You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Oleg Sidorov f94bac0643 chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3] ... Backport of https://github.com/helm/helm/pull/6010 to dev-v3 (the description below is a copy-paste from the original v2 branch PR). As https://github.com/helm/helm/pull/6016 is now merged to dev-v3, the change is reasonably trivial. This change is an attempt to address the common problem of json number unmarshalling where any number is converted into a float64 and represented in a scientific notation on a marshall call. This behavior breaks things like: chart versions and image tags if not converted to yaml strings explicitly. An example of this behavior: k8s failure to fetch an image tagged with a big number like: $IMAGE:20190612073634 after a few steps of yaml re-rendering turns into: $IMAGE:2.0190612073634e+13. Example issue: #1707 This commit forces yaml parser to use JSON modifiers and explicitly enables interface{} unmarshalling instead of float64. The change introduced might be breaking so should be processed with an extra care. Due to the fact helm mostly dals with human-produced data (charts), we have a decent level of confidence this change looses no functionality helm users rely upon (the scientific notation). Relevant doc: https://golang.org/pkg/encoding/json/#Decoder.UseNumber Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com> Signed-off-by: Oleg Sidorov <me@whitebox.io>		7 years ago
..
action	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
chart	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
chartutil	chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3]	7 years ago
cli	feat(*): use vanity import helm.sh/helm	7 years ago
downloader	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
engine	Stop Lint from breaking when using required	7 years ago
getter	Add sub-command support to plugin downloader	7 years ago
helmpath	ref: remove pkg/helm, pkg/hapi, pkg/tiller	7 years ago
hooks	feat(*): use vanity import helm.sh/helm	7 years ago
ignore	feat(*): use vanity import helm.sh/helm	7 years ago
kube	feat(wait): Adds smarter waiting for DaemonSets and StatefulSets	7 years ago
lint	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
plugin	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
provenance	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
registry	Fix linter issuers	7 years ago
release	Add app version to history table	7 years ago
releasetesting	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
releaseutil	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
repo	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
resolver	fix(resolver): compare hash of lockfile against resolved dependencies	7 years ago
storage	feat(*): use vanity import helm.sh/helm	7 years ago
strvals	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
sympath	change copyright to "Copyright The Helm Authors"	7 years ago
tlsutil	change copyright to "Copyright The Helm Authors"	7 years ago
urlutil	ref(urlutil): remove stripPort	7 years ago
version	add go version to version cmd output of helm	7 years ago