You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Damien Nozay 9fa373e8be Make validation errors easier to fix ... Problem: the warnings don't give enough details about which values are problematic, only the name of the leaf key. This is all the more annoying when you have a chart depending on other charts. ``` mainchart | +- subchart1 +- subchart2 +- subchart3 ``` Here are some warnings I get before the change: ``` coalesce.go:199: warning: destination for credentials is a table. Ignoring non-table value coalesce.go:160: warning: skipped value for resources: Not a table. coalesce.go:160: warning: skipped value for googleSheetsServiceAccount: Not a table. coalesce.go:199: warning: destination for googleSheetsServiceAccount is a table. Ignoring non-table value coalesce.go:199: warning: destination for resources is a table. Ignoring non-table value [] coalesce.go:199: warning: destination for credentials is a table. Ignoring non-table value coalesce.go:199: warning: destination for credentials is a table. Ignoring non-table value coalesce.go:160: warning: skipped value for resources: Not a table. coalesce.go:160: warning: skipped value for googleSheetsServiceAccount: Not a table. ``` with fix: ``` coalesce.go:162: warning: skipped value for subchart1.resources: Not a table. coalesce.go:162: warning: skipped value for subchart2.googleSheetsServiceAccount: Not a table. coalesce.go:211: warning: destination for subchart3.aws.credentials is a table. Ignoring non-table value () coalesce.go:211: warning: destination for mainchart.subchart3.aws.credentials is a table. Ignoring non-table value () coalesce.go:211: warning: destination for mainchart.subchart2.googleSheetsServiceAccount is a table. Ignoring non-table value () coalesce.go:211: warning: destination for mainchart.subchart1.resources is a table. Ignoring non-table value ([]) coalesce.go:162: warning: skipped value for subchart1.resources: Not a table. coalesce.go:162: warning: skipped value for subchart2.googleSheetsServiceAccount: Not a table. coalesce.go:211: warning: destination for subchart3.aws.credentials is a table. Ignoring non-table value () ``` Signed-off-by: Damien Nozay <damiennozay+github@gmail.com> add tests Signed-off-by: Damien Nozay <damiennozay+github@gmail.com>		3 years ago
..
testdata	chore: Spelling (#9410)	4 years ago
capabilities.go	Fix capabilities changes leaking into other tests	4 years ago
capabilities_test.go	bump version to 3.7	3 years ago
chartfile.go	…
chartfile_test.go	…
coalesce.go	Make validation errors easier to fix	3 years ago
coalesce_test.go	Make validation errors easier to fix	3 years ago
compatible.go	…
compatible_test.go	…
create.go	feat: add networking.k8s.io/v1 support to ingress template	4 years ago
create_test.go	go fmt	4 years ago
dependencies.go	…
dependencies_test.go	chore: Spelling (#9410)	4 years ago
doc.go	…
errors.go	…
errors_test.go	…
expand.go	…
expand_test.go	…
jsonschema.go	…
jsonschema_test.go	…
save.go	…
save_test.go	chore: Spelling (#9410)	4 years ago
validate_name.go	Merge pull request #9416 from croomes/resource-name-validation	4 years ago
validate_name_test.go	refactor the release name validation to be consistent across Helm	4 years ago
values.go	…
values_test.go	…