mirror of https://github.com/helm/helm
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
110 lines
3.1 KiB
110 lines
3.1 KiB
/*
|
|
Copyright The Helm Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package lint
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"helm.sh/helm/v3/pkg/lint/support"
|
|
)
|
|
|
|
var values map[string]interface{}
|
|
|
|
const namespace = "testNamespace"
|
|
const strict = false
|
|
|
|
const badChartDir = "rules/testdata/badchartfile"
|
|
const badValuesFileDir = "rules/testdata/badvaluesfile"
|
|
const badYamlFileDir = "rules/testdata/albatross"
|
|
const goodChartDir = "rules/testdata/goodone"
|
|
|
|
func TestBadChart(t *testing.T) {
|
|
m := All(badChartDir, values, namespace, strict).Messages
|
|
if len(m) != 8 {
|
|
t.Errorf("Number of errors %v", len(m))
|
|
t.Errorf("All didn't fail with expected errors, got %#v", m)
|
|
}
|
|
// There should be one INFO, 2 WARNINGs and one ERROR messages, check for them
|
|
var i, w, e, e2, e3, e4, e5, e6 bool
|
|
for _, msg := range m {
|
|
if msg.Severity == support.InfoSev {
|
|
if strings.Contains(msg.Err.Error(), "icon is recommended") {
|
|
i = true
|
|
}
|
|
}
|
|
if msg.Severity == support.WarningSev {
|
|
if strings.Contains(msg.Err.Error(), "directory not found") {
|
|
w = true
|
|
}
|
|
}
|
|
if msg.Severity == support.ErrorSev {
|
|
if strings.Contains(msg.Err.Error(), "version '0.0.0.0' is not a valid SemVer") {
|
|
e = true
|
|
}
|
|
if strings.Contains(msg.Err.Error(), "name is required") {
|
|
e2 = true
|
|
}
|
|
if strings.Contains(msg.Err.Error(), "directory name (badchartfile) and chart name () must be the same") {
|
|
e3 = true
|
|
}
|
|
|
|
if strings.Contains(msg.Err.Error(), "apiVersion is required. The value must be either \"v1\" or \"v2\"") {
|
|
e4 = true
|
|
}
|
|
|
|
if strings.Contains(msg.Err.Error(), "chart type is not valid in apiVersion") {
|
|
e5 = true
|
|
}
|
|
|
|
if strings.Contains(msg.Err.Error(), "dependencies are not valid in the Chart file with apiVersion") {
|
|
e6 = true
|
|
}
|
|
}
|
|
}
|
|
if !e || !e2 || !e3 || !e4 || !e5 || !e6 || !w || !i {
|
|
t.Errorf("Didn't find all the expected errors, got %#v", m)
|
|
}
|
|
}
|
|
|
|
func TestInvalidYaml(t *testing.T) {
|
|
m := All(badYamlFileDir, values, namespace, strict).Messages
|
|
if len(m) != 1 {
|
|
t.Fatalf("All didn't fail with expected errors, got %#v", m)
|
|
}
|
|
if !strings.Contains(m[0].Err.Error(), "deliberateSyntaxError") {
|
|
t.Errorf("All didn't have the error for deliberateSyntaxError")
|
|
}
|
|
}
|
|
|
|
func TestBadValues(t *testing.T) {
|
|
m := All(badValuesFileDir, values, namespace, strict).Messages
|
|
if len(m) < 1 {
|
|
t.Fatalf("All didn't fail with expected errors, got %#v", m)
|
|
}
|
|
if !strings.Contains(m[0].Err.Error(), "cannot unmarshal") {
|
|
t.Errorf("All didn't have the error for invalid key format: %s", m[0].Err)
|
|
}
|
|
}
|
|
|
|
func TestGoodChart(t *testing.T) {
|
|
m := All(goodChartDir, values, namespace, strict).Messages
|
|
if len(m) != 0 {
|
|
t.Errorf("All failed but shouldn't have: %#v", m)
|
|
}
|
|
}
|