|
|
/*
|
|
|
Copyright The Helm Authors.
|
|
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
you may not use this file except in compliance with the License.
|
|
|
You may obtain a copy of the License at
|
|
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
See the License for the specific language governing permissions and
|
|
|
limitations under the License.
|
|
|
*/
|
|
|
|
|
|
package main
|
|
|
|
|
|
import (
|
|
|
"fmt"
|
|
|
"os"
|
|
|
"path/filepath"
|
|
|
"reflect"
|
|
|
"strings"
|
|
|
"testing"
|
|
|
|
|
|
"helm.sh/helm/v3/pkg/chart"
|
|
|
"helm.sh/helm/v3/pkg/chart/loader"
|
|
|
"helm.sh/helm/v3/pkg/chartutil"
|
|
|
"helm.sh/helm/v3/pkg/release"
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
)
|
|
|
|
|
|
func TestUpgradeCmd(t *testing.T) {
|
|
|
|
|
|
tmpChart := t.TempDir()
|
|
|
cfile := &chart.Chart{
|
|
|
Metadata: &chart.Metadata{
|
|
|
APIVersion: chart.APIVersionV1,
|
|
|
Name: "testUpgradeChart",
|
|
|
Description: "A Helm chart for Kubernetes",
|
|
|
Version: "0.1.0",
|
|
|
},
|
|
|
}
|
|
|
chartPath := filepath.Join(tmpChart, cfile.Metadata.Name)
|
|
|
if err := chartutil.SaveDir(cfile, tmpChart); err != nil {
|
|
|
t.Fatalf("Error creating chart for upgrade: %v", err)
|
|
|
}
|
|
|
ch, err := loader.Load(chartPath)
|
|
|
if err != nil {
|
|
|
t.Fatalf("Error loading chart: %v", err)
|
|
|
}
|
|
|
_ = release.Mock(&release.MockReleaseOptions{
|
|
|
Name: "funny-bunny",
|
|
|
Chart: ch,
|
|
|
})
|
|
|
|
|
|
// update chart version
|
|
|
cfile.Metadata.Version = "0.1.2"
|
|
|
|
|
|
if err := chartutil.SaveDir(cfile, tmpChart); err != nil {
|
|
|
t.Fatalf("Error creating chart: %v", err)
|
|
|
}
|
|
|
ch, err = loader.Load(chartPath)
|
|
|
if err != nil {
|
|
|
t.Fatalf("Error loading updated chart: %v", err)
|
|
|
}
|
|
|
|
|
|
// update chart version again
|
|
|
cfile.Metadata.Version = "0.1.3"
|
|
|
|
|
|
if err := chartutil.SaveDir(cfile, tmpChart); err != nil {
|
|
|
t.Fatalf("Error creating chart: %v", err)
|
|
|
}
|
|
|
var ch2 *chart.Chart
|
|
|
ch2, err = loader.Load(chartPath)
|
|
|
if err != nil {
|
|
|
t.Fatalf("Error loading updated chart: %v", err)
|
|
|
}
|
|
|
|
|
|
missingDepsPath := "testdata/testcharts/chart-missing-deps"
|
|
|
badDepsPath := "testdata/testcharts/chart-bad-requirements"
|
|
|
presentDepsPath := "testdata/testcharts/chart-with-subchart-update"
|
|
|
|
|
|
relWithStatusMock := func(n string, v int, ch *chart.Chart, status release.Status) *release.Release {
|
|
|
return release.Mock(&release.MockReleaseOptions{Name: n, Version: v, Chart: ch, Status: status})
|
|
|
}
|
|
|
|
|
|
relMock := func(n string, v int, ch *chart.Chart) *release.Release {
|
|
|
return release.Mock(&release.MockReleaseOptions{Name: n, Version: v, Chart: ch})
|
|
|
}
|
|
|
|
|
|
tests := []cmdTestCase{
|
|
|
{
|
|
|
name: "upgrade a release",
|
|
|
cmd: fmt.Sprintf("upgrade funny-bunny '%s'", chartPath),
|
|
|
golden: "output/upgrade.txt",
|
|
|
rels: []*release.Release{relMock("funny-bunny", 2, ch)},
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a release with timeout",
|
|
|
cmd: fmt.Sprintf("upgrade funny-bunny --timeout 120s '%s'", chartPath),
|
|
|
golden: "output/upgrade-with-timeout.txt",
|
|
|
rels: []*release.Release{relMock("funny-bunny", 3, ch2)},
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a release with --reset-values",
|
|
|
cmd: fmt.Sprintf("upgrade funny-bunny --reset-values '%s'", chartPath),
|
|
|
golden: "output/upgrade-with-reset-values.txt",
|
|
|
rels: []*release.Release{relMock("funny-bunny", 4, ch2)},
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a release with --reuse-values",
|
|
|
cmd: fmt.Sprintf("upgrade funny-bunny --reuse-values '%s'", chartPath),
|
|
|
golden: "output/upgrade-with-reset-values2.txt",
|
|
|
rels: []*release.Release{relMock("funny-bunny", 5, ch2)},
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a release with --take-ownership",
|
|
|
cmd: fmt.Sprintf("upgrade funny-bunny '%s' --take-ownership", chartPath),
|
|
|
golden: "output/upgrade-and-take-ownership.txt",
|
|
|
rels: []*release.Release{relMock("funny-bunny", 2, ch)},
|
|
|
},
|
|
|
{
|
|
|
name: "install a release with 'upgrade --install'",
|
|
|
cmd: fmt.Sprintf("upgrade zany-bunny -i '%s'", chartPath),
|
|
|
golden: "output/upgrade-with-install.txt",
|
|
|
rels: []*release.Release{relMock("zany-bunny", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
name: "install a release with 'upgrade --install' and timeout",
|
|
|
cmd: fmt.Sprintf("upgrade crazy-bunny -i --timeout 120s '%s'", chartPath),
|
|
|
golden: "output/upgrade-with-install-timeout.txt",
|
|
|
rels: []*release.Release{relMock("crazy-bunny", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a release with wait",
|
|
|
cmd: fmt.Sprintf("upgrade crazy-bunny --wait '%s'", chartPath),
|
|
|
golden: "output/upgrade-with-wait.txt",
|
|
|
rels: []*release.Release{relMock("crazy-bunny", 2, ch2)},
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a release with wait-for-jobs",
|
|
|
cmd: fmt.Sprintf("upgrade crazy-bunny --wait --wait-for-jobs '%s'", chartPath),
|
|
|
golden: "output/upgrade-with-wait-for-jobs.txt",
|
|
|
rels: []*release.Release{relMock("crazy-bunny", 2, ch2)},
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a release with missing dependencies",
|
|
|
cmd: fmt.Sprintf("upgrade bonkers-bunny %s", missingDepsPath),
|
|
|
golden: "output/upgrade-with-missing-dependencies.txt",
|
|
|
wantError: true,
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a release with bad dependencies",
|
|
|
cmd: fmt.Sprintf("upgrade bonkers-bunny '%s'", badDepsPath),
|
|
|
golden: "output/upgrade-with-bad-dependencies.txt",
|
|
|
wantError: true,
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a release with resolving missing dependencies",
|
|
|
cmd: fmt.Sprintf("upgrade --dependency-update funny-bunny %s", presentDepsPath),
|
|
|
golden: "output/upgrade-with-dependency-update.txt",
|
|
|
rels: []*release.Release{relMock("funny-bunny", 2, ch2)},
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a non-existent release",
|
|
|
cmd: fmt.Sprintf("upgrade funny-bunny '%s'", chartPath),
|
|
|
golden: "output/upgrade-with-bad-or-missing-existing-release.txt",
|
|
|
wantError: true,
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a failed release",
|
|
|
cmd: fmt.Sprintf("upgrade funny-bunny '%s'", chartPath),
|
|
|
golden: "output/upgrade.txt",
|
|
|
rels: []*release.Release{relWithStatusMock("funny-bunny", 2, ch, release.StatusFailed)},
|
|
|
},
|
|
|
{
|
|
|
name: "upgrade a pending install release",
|
|
|
cmd: fmt.Sprintf("upgrade funny-bunny '%s'", chartPath),
|
|
|
golden: "output/upgrade-with-pending-install.txt",
|
|
|
wantError: true,
|
|
|
rels: []*release.Release{relWithStatusMock("funny-bunny", 2, ch, release.StatusPendingInstall)},
|
|
|
},
|
|
|
{
|
|
|
name: "install a previously uninstalled release with '--keep-history' using 'upgrade --install'",
|
|
|
cmd: fmt.Sprintf("upgrade funny-bunny -i '%s'", chartPath),
|
|
|
golden: "output/upgrade-uninstalled-with-keep-history.txt",
|
|
|
rels: []*release.Release{relWithStatusMock("funny-bunny", 2, ch, release.StatusUninstalled)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade` on a chart that doesn't have notes or subcharts should print the upgrade command's
|
|
|
// output without notes.
|
|
|
name: "helm upgrade on chart without notes or subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default", emptyChart),
|
|
|
golden: "output/upgrade-without-notes-or-subcharts.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade --dry-run` on a chart that doesn't have notes or subcharts should print upgrade
|
|
|
// command's dry-run output without notes.
|
|
|
name: "helm upgrade --dry-run on chart without notes or subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default --dry-run", emptyChart),
|
|
|
golden: "output/upgrade-without-notes-or-subcharts-with-flag-dry-run-enabled.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade --render-subchart-notes` on a chart that doesn't have notes or subcharts should
|
|
|
// print the upgrade command's output without any notes.
|
|
|
name: "helm upgrade --render-subchart-notes on chart without notes or subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default --render-subchart-notes", emptyChart),
|
|
|
golden: "output/upgrade-without-notes-or-subcharts.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade --dry-run --render-subchart-notes` on a chart that doesn't have notes or subcharts
|
|
|
// should print the upgrade command's dry-run output without any notes.
|
|
|
name: "helm upgrade --dry-run --render-subchart-notes on chart without notes or subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default --dry-run --render-subchart-notes", emptyChart),
|
|
|
golden: "output/upgrade-without-notes-or-subcharts-with-flag-dry-run-enabled.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade` on a chart that has notes but no subcharts should print the upgrade command's
|
|
|
// output with (current chart's) notes.
|
|
|
name: "helm upgrade on chart with notes without subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default", chartWithNotes),
|
|
|
golden: "output/upgrade-with-notes.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade --dry-run` on a chart that has notes but no subcharts should print the upgrade
|
|
|
// command's dry-run output with (current chart's) notes. Note: The notes in dry-run output include the
|
|
|
// source filename and separator "---".
|
|
|
name: "helm upgrade --dry-run on chart with notes without subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default --dry-run", chartWithNotes),
|
|
|
golden: "output/upgrade-with-notes-with-flag-dry-run-enabled.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade --render-subchart-notes` on a chart that has notes but no subcharts should print
|
|
|
// the upgrade command's output with (current chart's) notes, i.e., no subchart's notes as no subchart.
|
|
|
name: "helm upgrade --render-subchart-notes on chart with notes without subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default --render-subchart-notes", chartWithNotes),
|
|
|
golden: "output/upgrade-with-notes.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade --dry-run --render-subchart-notes` on a chart that has notes but no subcharts
|
|
|
// should print the upgrade command's dry-run output (current chart's) notes, i.e., no subchart's notes as
|
|
|
// no subchart. Note: The notes in dry-run output include the source filename and separator "---".
|
|
|
name: "helm upgrade --dry-run --render-subchart-notes on chart with notes without subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default --dry-run --render-subchart-notes",
|
|
|
chartWithNotes),
|
|
|
golden: "output/upgrade-with-notes-with-flag-dry-run-enabled.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade` on a chart that has notes and 2 levels of subcharts should print upgrade command's
|
|
|
// output with just root chart's notes, i.e., without subchart's notes.
|
|
|
name: "helm upgrade on chart with notes and subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default", chartWithNotesAnd2LevelsOfSubCharts),
|
|
|
golden: "output/upgrade-with-notes-and-subcharts.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade --dry-run` on a chart that has notes and 2 levels of subcharts should print the
|
|
|
// upgrade command's dry-run output with just the root chart's notes, i.e., without subcharts' notes. Note:
|
|
|
// The notes in dry-run output include the source filename and separator "---".
|
|
|
name: "helm upgrade --dry-run on chart with notes and subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default --dry-run",
|
|
|
chartWithNotesAnd2LevelsOfSubCharts),
|
|
|
golden: "output/upgrade-with-notes-and-subcharts-with-flag-dry-run-enabled.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade --render-subchart-notes` on a chart that has notes and 2 levels of subcharts should
|
|
|
// print the upgrade command's output with both the root chart and the subcharts' notes.
|
|
|
name: "helm upgrade --render-subchart-notes on chart with notes and subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default --render-subchart-notes",
|
|
|
chartWithNotesAnd2LevelsOfSubCharts),
|
|
|
golden: "output/upgrade-with-notes-and-subcharts-with-flag-render-subchart-notes-enabled.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
{
|
|
|
// Running `helm upgrade --dry-run --render-subchart-notes` on a chart that has notes and 2 levels of
|
|
|
// subcharts should print the upgrade command's dry-run output with both the root chart and the subcharts'
|
|
|
// notes. Note: The notes in dry-run output include the source filename and separator "---".
|
|
|
name: "helm upgrade --dry-run --render-subchart-notes on chart with notes and subcharts",
|
|
|
cmd: fmt.Sprintf("upgrade luffy '%s' --namespace default --dry-run --render-subchart-notes",
|
|
|
chartWithNotesAnd2LevelsOfSubCharts),
|
|
|
golden: "output/" +
|
|
|
"upgrade-with-notes-and-subcharts-with-both-flags-dry-run-and-render-subchart-notes-enabled.txt",
|
|
|
rels: []*release.Release{relMock("luffy", 1, ch)},
|
|
|
},
|
|
|
}
|
|
|
runTestCmd(t, tests)
|
|
|
}
|
|
|
|
|
|
// TestUpgradeHelpOutput tests the `helm upgrade --help` command's output text. This is required because the
|
|
|
// --render-subchart-notes flag's description is different for the template command from that of install/upgrade
|
|
|
// commands.
|
|
|
func TestUpgradeHelpOutput(t *testing.T) {
|
|
|
const (
|
|
|
outputFilePath = "testdata/output/upgrade-help.txt"
|
|
|
testNamespace = "test-namespace"
|
|
|
repositoryCache = "test-repository-cache-dir"
|
|
|
repositoryConfig = "test-repository-config.yaml"
|
|
|
registryConfig = "test-registry-config.json"
|
|
|
gnupgHome = "test-gpg"
|
|
|
commandText = "upgrade --help"
|
|
|
)
|
|
|
|
|
|
// Reset the envs and the configs at the end of this test so that the updates wouldn’t affect other tests.
|
|
|
defer resetEnv()()
|
|
|
|
|
|
// Read the expected output file.
|
|
|
expectedOutput, err := os.ReadFile(outputFilePath)
|
|
|
assert.NoError(t, err, "unexpected error while reading expected output's file %q", outputFilePath)
|
|
|
|
|
|
// Set the configs that might otherwise change based on the local environment if not explicitly set. Note: These
|
|
|
// configs are not related to the current test.
|
|
|
settings.RepositoryCache = repositoryCache
|
|
|
settings.RepositoryConfig = repositoryConfig
|
|
|
settings.RegistryConfig = registryConfig
|
|
|
settings.SetNamespace(testNamespace)
|
|
|
t.Setenv("GNUPGHOME", gnupgHome)
|
|
|
|
|
|
// Run the `helm upgrade --help` command and compare the help text.
|
|
|
_, actualOutput, err := executeActionCommandC(storageFixture(), commandText)
|
|
|
assert.NoError(t, err, "unexpected error running command %q", commandText)
|
|
|
assert.Equal(t, string(expectedOutput), actualOutput, "mismatch of output")
|
|
|
}
|
|
|
|
|
|
func TestUpgradeWithValue(t *testing.T) {
|
|
|
releaseName := "funny-bunny-v2"
|
|
|
relMock, ch, chartPath := prepareMockRelease(releaseName, t)
|
|
|
|
|
|
defer resetEnv()()
|
|
|
|
|
|
store := storageFixture()
|
|
|
|
|
|
store.Create(relMock(releaseName, 3, ch))
|
|
|
|
|
|
cmd := fmt.Sprintf("upgrade %s --set favoriteDrink=tea '%s'", releaseName, chartPath)
|
|
|
_, _, err := executeActionCommandC(store, cmd)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
updatedRel, err := store.Get(releaseName, 4)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
if !strings.Contains(updatedRel.Manifest, "drink: tea") {
|
|
|
t.Errorf("The value is not set correctly. manifest: %s", updatedRel.Manifest)
|
|
|
}
|
|
|
|
|
|
}
|
|
|
|
|
|
func TestUpgradeWithStringValue(t *testing.T) {
|
|
|
releaseName := "funny-bunny-v3"
|
|
|
relMock, ch, chartPath := prepareMockRelease(releaseName, t)
|
|
|
|
|
|
defer resetEnv()()
|
|
|
|
|
|
store := storageFixture()
|
|
|
|
|
|
store.Create(relMock(releaseName, 3, ch))
|
|
|
|
|
|
cmd := fmt.Sprintf("upgrade %s --set-string favoriteDrink=coffee '%s'", releaseName, chartPath)
|
|
|
_, _, err := executeActionCommandC(store, cmd)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
updatedRel, err := store.Get(releaseName, 4)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
if !strings.Contains(updatedRel.Manifest, "drink: coffee") {
|
|
|
t.Errorf("The value is not set correctly. manifest: %s", updatedRel.Manifest)
|
|
|
}
|
|
|
|
|
|
}
|
|
|
|
|
|
func TestUpgradeInstallWithSubchartNotes(t *testing.T) {
|
|
|
|
|
|
releaseName := "wacky-bunny-v1"
|
|
|
relMock, ch, _ := prepareMockRelease(releaseName, t)
|
|
|
|
|
|
defer resetEnv()()
|
|
|
|
|
|
store := storageFixture()
|
|
|
|
|
|
store.Create(relMock(releaseName, 1, ch))
|
|
|
|
|
|
cmd := fmt.Sprintf("upgrade %s -i --render-subchart-notes '%s'", releaseName, "testdata/testcharts/chart-with-subchart-notes")
|
|
|
_, _, err := executeActionCommandC(store, cmd)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
upgradedRel, err := store.Get(releaseName, 2)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
if !strings.Contains(upgradedRel.Info.Notes, "PARENT NOTES") {
|
|
|
t.Errorf("The parent notes are not set correctly. NOTES: %s", upgradedRel.Info.Notes)
|
|
|
}
|
|
|
|
|
|
if !strings.Contains(upgradedRel.Info.Notes, "SUBCHART NOTES") {
|
|
|
t.Errorf("The subchart notes are not set correctly. NOTES: %s", upgradedRel.Info.Notes)
|
|
|
}
|
|
|
|
|
|
}
|
|
|
|
|
|
func TestUpgradeWithValuesFile(t *testing.T) {
|
|
|
|
|
|
releaseName := "funny-bunny-v4"
|
|
|
relMock, ch, chartPath := prepareMockRelease(releaseName, t)
|
|
|
|
|
|
defer resetEnv()()
|
|
|
|
|
|
store := storageFixture()
|
|
|
|
|
|
store.Create(relMock(releaseName, 3, ch))
|
|
|
|
|
|
cmd := fmt.Sprintf("upgrade %s --values testdata/testcharts/upgradetest/values.yaml '%s'", releaseName, chartPath)
|
|
|
_, _, err := executeActionCommandC(store, cmd)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
updatedRel, err := store.Get(releaseName, 4)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
if !strings.Contains(updatedRel.Manifest, "drink: beer") {
|
|
|
t.Errorf("The value is not set correctly. manifest: %s", updatedRel.Manifest)
|
|
|
}
|
|
|
|
|
|
}
|
|
|
|
|
|
func TestUpgradeWithValuesFromStdin(t *testing.T) {
|
|
|
|
|
|
releaseName := "funny-bunny-v5"
|
|
|
relMock, ch, chartPath := prepareMockRelease(releaseName, t)
|
|
|
|
|
|
defer resetEnv()()
|
|
|
|
|
|
store := storageFixture()
|
|
|
|
|
|
store.Create(relMock(releaseName, 3, ch))
|
|
|
|
|
|
in, err := os.Open("testdata/testcharts/upgradetest/values.yaml")
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
cmd := fmt.Sprintf("upgrade %s --values - '%s'", releaseName, chartPath)
|
|
|
_, _, err = executeActionCommandStdinC(store, in, cmd)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
updatedRel, err := store.Get(releaseName, 4)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
if !strings.Contains(updatedRel.Manifest, "drink: beer") {
|
|
|
t.Errorf("The value is not set correctly. manifest: %s", updatedRel.Manifest)
|
|
|
}
|
|
|
}
|
|
|
|
|
|
func TestUpgradeInstallWithValuesFromStdin(t *testing.T) {
|
|
|
|
|
|
releaseName := "funny-bunny-v6"
|
|
|
_, _, chartPath := prepareMockRelease(releaseName, t)
|
|
|
|
|
|
defer resetEnv()()
|
|
|
|
|
|
store := storageFixture()
|
|
|
|
|
|
in, err := os.Open("testdata/testcharts/upgradetest/values.yaml")
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
cmd := fmt.Sprintf("upgrade %s -f - --install '%s'", releaseName, chartPath)
|
|
|
_, _, err = executeActionCommandStdinC(store, in, cmd)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
updatedRel, err := store.Get(releaseName, 1)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
if !strings.Contains(updatedRel.Manifest, "drink: beer") {
|
|
|
t.Errorf("The value is not set correctly. manifest: %s", updatedRel.Manifest)
|
|
|
}
|
|
|
|
|
|
}
|
|
|
|
|
|
func prepareMockRelease(releaseName string, t *testing.T) (func(n string, v int, ch *chart.Chart) *release.Release, *chart.Chart, string) {
|
|
|
tmpChart := t.TempDir()
|
|
|
configmapData, err := os.ReadFile("testdata/testcharts/upgradetest/templates/configmap.yaml")
|
|
|
if err != nil {
|
|
|
t.Fatalf("Error loading template yaml %v", err)
|
|
|
}
|
|
|
cfile := &chart.Chart{
|
|
|
Metadata: &chart.Metadata{
|
|
|
APIVersion: chart.APIVersionV1,
|
|
|
Name: "testUpgradeChart",
|
|
|
Description: "A Helm chart for Kubernetes",
|
|
|
Version: "0.1.0",
|
|
|
},
|
|
|
Templates: []*chart.File{{Name: "templates/configmap.yaml", Data: configmapData}},
|
|
|
}
|
|
|
chartPath := filepath.Join(tmpChart, cfile.Metadata.Name)
|
|
|
if err := chartutil.SaveDir(cfile, tmpChart); err != nil {
|
|
|
t.Fatalf("Error creating chart for upgrade: %v", err)
|
|
|
}
|
|
|
ch, err := loader.Load(chartPath)
|
|
|
if err != nil {
|
|
|
t.Fatalf("Error loading chart: %v", err)
|
|
|
}
|
|
|
_ = release.Mock(&release.MockReleaseOptions{
|
|
|
Name: releaseName,
|
|
|
Chart: ch,
|
|
|
})
|
|
|
|
|
|
relMock := func(n string, v int, ch *chart.Chart) *release.Release {
|
|
|
return release.Mock(&release.MockReleaseOptions{Name: n, Version: v, Chart: ch})
|
|
|
}
|
|
|
|
|
|
return relMock, ch, chartPath
|
|
|
}
|
|
|
|
|
|
func TestUpgradeOutputCompletion(t *testing.T) {
|
|
|
outputFlagCompletionTest(t, "upgrade")
|
|
|
}
|
|
|
|
|
|
func TestUpgradeVersionCompletion(t *testing.T) {
|
|
|
repoFile := "testdata/helmhome/helm/repositories.yaml"
|
|
|
repoCache := "testdata/helmhome/helm/repository"
|
|
|
|
|
|
repoSetup := fmt.Sprintf("--repository-config %s --repository-cache %s", repoFile, repoCache)
|
|
|
|
|
|
tests := []cmdTestCase{{
|
|
|
name: "completion for upgrade version flag",
|
|
|
cmd: fmt.Sprintf("%s __complete upgrade releasename testing/alpine --version ''", repoSetup),
|
|
|
golden: "output/version-comp.txt",
|
|
|
}, {
|
|
|
name: "completion for upgrade version flag, no filter",
|
|
|
cmd: fmt.Sprintf("%s __complete upgrade releasename testing/alpine --version 0.3", repoSetup),
|
|
|
golden: "output/version-comp.txt",
|
|
|
}, {
|
|
|
name: "completion for upgrade version flag too few args",
|
|
|
cmd: fmt.Sprintf("%s __complete upgrade releasename --version ''", repoSetup),
|
|
|
golden: "output/version-invalid-comp.txt",
|
|
|
}, {
|
|
|
name: "completion for upgrade version flag too many args",
|
|
|
cmd: fmt.Sprintf("%s __complete upgrade releasename testing/alpine badarg --version ''", repoSetup),
|
|
|
golden: "output/version-invalid-comp.txt",
|
|
|
}, {
|
|
|
name: "completion for upgrade version flag invalid chart",
|
|
|
cmd: fmt.Sprintf("%s __complete upgrade releasename invalid/invalid --version ''", repoSetup),
|
|
|
golden: "output/version-invalid-comp.txt",
|
|
|
}}
|
|
|
runTestCmd(t, tests)
|
|
|
}
|
|
|
|
|
|
func TestUpgradeFileCompletion(t *testing.T) {
|
|
|
checkFileCompletion(t, "upgrade", false)
|
|
|
checkFileCompletion(t, "upgrade myrelease", true)
|
|
|
checkFileCompletion(t, "upgrade myrelease repo/chart", false)
|
|
|
}
|
|
|
|
|
|
func TestUpgradeInstallWithLabels(t *testing.T) {
|
|
|
releaseName := "funny-bunny-labels"
|
|
|
_, _, chartPath := prepareMockRelease(releaseName, t)
|
|
|
|
|
|
defer resetEnv()()
|
|
|
|
|
|
store := storageFixture()
|
|
|
|
|
|
expectedLabels := map[string]string{
|
|
|
"key1": "val1",
|
|
|
"key2": "val2",
|
|
|
}
|
|
|
cmd := fmt.Sprintf("upgrade %s --install --labels key1=val1,key2=val2 '%s'", releaseName, chartPath)
|
|
|
_, _, err := executeActionCommandC(store, cmd)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
updatedRel, err := store.Get(releaseName, 1)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
if !reflect.DeepEqual(updatedRel.Labels, expectedLabels) {
|
|
|
t.Errorf("Expected {%v}, got {%v}", expectedLabels, updatedRel.Labels)
|
|
|
}
|
|
|
}
|
|
|
|
|
|
func prepareMockReleaseWithSecret(releaseName string, t *testing.T) (func(n string, v int, ch *chart.Chart) *release.Release, *chart.Chart, string) {
|
|
|
tmpChart := t.TempDir()
|
|
|
configmapData, err := os.ReadFile("testdata/testcharts/chart-with-secret/templates/configmap.yaml")
|
|
|
if err != nil {
|
|
|
t.Fatalf("Error loading template yaml %v", err)
|
|
|
}
|
|
|
secretData, err := os.ReadFile("testdata/testcharts/chart-with-secret/templates/secret.yaml")
|
|
|
if err != nil {
|
|
|
t.Fatalf("Error loading template yaml %v", err)
|
|
|
}
|
|
|
cfile := &chart.Chart{
|
|
|
Metadata: &chart.Metadata{
|
|
|
APIVersion: chart.APIVersionV1,
|
|
|
Name: "testUpgradeChart",
|
|
|
Description: "A Helm chart for Kubernetes",
|
|
|
Version: "0.1.0",
|
|
|
},
|
|
|
Templates: []*chart.File{{Name: "templates/configmap.yaml", Data: configmapData}, {Name: "templates/secret.yaml", Data: secretData}},
|
|
|
}
|
|
|
chartPath := filepath.Join(tmpChart, cfile.Metadata.Name)
|
|
|
if err := chartutil.SaveDir(cfile, tmpChart); err != nil {
|
|
|
t.Fatalf("Error creating chart for upgrade: %v", err)
|
|
|
}
|
|
|
ch, err := loader.Load(chartPath)
|
|
|
if err != nil {
|
|
|
t.Fatalf("Error loading chart: %v", err)
|
|
|
}
|
|
|
_ = release.Mock(&release.MockReleaseOptions{
|
|
|
Name: releaseName,
|
|
|
Chart: ch,
|
|
|
})
|
|
|
|
|
|
relMock := func(n string, v int, ch *chart.Chart) *release.Release {
|
|
|
return release.Mock(&release.MockReleaseOptions{Name: n, Version: v, Chart: ch})
|
|
|
}
|
|
|
|
|
|
return relMock, ch, chartPath
|
|
|
}
|
|
|
|
|
|
func TestUpgradeWithDryRun(t *testing.T) {
|
|
|
releaseName := "funny-bunny-labels"
|
|
|
_, _, chartPath := prepareMockReleaseWithSecret(releaseName, t)
|
|
|
|
|
|
defer resetEnv()()
|
|
|
|
|
|
store := storageFixture()
|
|
|
|
|
|
// First install a release into the store so that future --dry-run attempts
|
|
|
// have it available.
|
|
|
cmd := fmt.Sprintf("upgrade %s --install '%s'", releaseName, chartPath)
|
|
|
_, _, err := executeActionCommandC(store, cmd)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
_, err = store.Get(releaseName, 1)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
cmd = fmt.Sprintf("upgrade %s --dry-run '%s'", releaseName, chartPath)
|
|
|
_, out, err := executeActionCommandC(store, cmd)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
// No second release should be stored because this is a dry run.
|
|
|
_, err = store.Get(releaseName, 2)
|
|
|
if err == nil {
|
|
|
t.Error("expected error as there should be no new release but got none")
|
|
|
}
|
|
|
|
|
|
if !strings.Contains(out, "kind: Secret") {
|
|
|
t.Error("expected secret in output from --dry-run but found none")
|
|
|
}
|
|
|
|
|
|
// Ensure the secret is not in the output
|
|
|
cmd = fmt.Sprintf("upgrade %s --dry-run --hide-secret '%s'", releaseName, chartPath)
|
|
|
_, out, err = executeActionCommandC(store, cmd)
|
|
|
if err != nil {
|
|
|
t.Errorf("unexpected error, got '%v'", err)
|
|
|
}
|
|
|
|
|
|
// No second release should be stored because this is a dry run.
|
|
|
_, err = store.Get(releaseName, 2)
|
|
|
if err == nil {
|
|
|
t.Error("expected error as there should be no new release but got none")
|
|
|
}
|
|
|
|
|
|
if strings.Contains(out, "kind: Secret") {
|
|
|
t.Error("expected no secret in output from --dry-run --hide-secret but found one")
|
|
|
}
|
|
|
|
|
|
// Ensure there is an error when --hide-secret used without dry-run
|
|
|
cmd = fmt.Sprintf("upgrade %s --hide-secret '%s'", releaseName, chartPath)
|
|
|
_, _, err = executeActionCommandC(store, cmd)
|
|
|
if err == nil {
|
|
|
t.Error("expected error when --hide-secret used without --dry-run")
|
|
|
}
|
|
|
}
|
