mirror of https://github.com/helm/helm
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
470 lines
15 KiB
470 lines
15 KiB
/*
|
|
Copyright The Helm Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package storage // import "helm.sh/helm/v3/pkg/storage"
|
|
|
|
import (
|
|
"fmt"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/pkg/errors"
|
|
|
|
rspb "helm.sh/helm/v3/pkg/release"
|
|
"helm.sh/helm/v3/pkg/storage/driver"
|
|
)
|
|
|
|
func TestStorageCreate(t *testing.T) {
|
|
// initialize storage
|
|
storage := Init(driver.NewMemory())
|
|
|
|
// create fake release
|
|
rls := ReleaseTestData{
|
|
Name: "angry-beaver",
|
|
Version: 1,
|
|
}.ToRelease()
|
|
|
|
assertErrNil(t.Fatal, storage.Create(rls), "StoreRelease")
|
|
|
|
// fetch the release
|
|
res, err := storage.Get(rls.Name, rls.Version)
|
|
assertErrNil(t.Fatal, err, "QueryRelease")
|
|
|
|
// verify the fetched and created release are the same
|
|
if !reflect.DeepEqual(rls, res) {
|
|
t.Fatalf("Expected %v, got %v", rls, res)
|
|
}
|
|
}
|
|
|
|
func TestStorageUpdate(t *testing.T) {
|
|
// initialize storage
|
|
storage := Init(driver.NewMemory())
|
|
|
|
// create fake release
|
|
rls := ReleaseTestData{
|
|
Name: "angry-beaver",
|
|
Version: 1,
|
|
Status: rspb.StatusDeployed,
|
|
}.ToRelease()
|
|
|
|
assertErrNil(t.Fatal, storage.Create(rls), "StoreRelease")
|
|
|
|
// modify the release
|
|
rls.Info.Status = rspb.StatusUninstalled
|
|
assertErrNil(t.Fatal, storage.Update(rls), "UpdateRelease")
|
|
|
|
// retrieve the updated release
|
|
res, err := storage.Get(rls.Name, rls.Version)
|
|
assertErrNil(t.Fatal, err, "QueryRelease")
|
|
|
|
// verify updated and fetched releases are the same.
|
|
if !reflect.DeepEqual(rls, res) {
|
|
t.Fatalf("Expected %v, got %v", rls, res)
|
|
}
|
|
}
|
|
|
|
func TestStorageDelete(t *testing.T) {
|
|
// initialize storage
|
|
storage := Init(driver.NewMemory())
|
|
|
|
// create fake release
|
|
rls := ReleaseTestData{
|
|
Name: "angry-beaver",
|
|
Version: 1,
|
|
}.ToRelease()
|
|
rls2 := ReleaseTestData{
|
|
Name: "angry-beaver",
|
|
Version: 2,
|
|
}.ToRelease()
|
|
|
|
assertErrNil(t.Fatal, storage.Create(rls), "StoreRelease")
|
|
assertErrNil(t.Fatal, storage.Create(rls2), "StoreRelease")
|
|
|
|
// delete the release
|
|
res, err := storage.Delete(rls.Name, rls.Version)
|
|
assertErrNil(t.Fatal, err, "DeleteRelease")
|
|
|
|
// verify updated and fetched releases are the same.
|
|
if !reflect.DeepEqual(rls, res) {
|
|
t.Fatalf("Expected %v, got %v", rls, res)
|
|
}
|
|
|
|
hist, err := storage.History(rls.Name)
|
|
if err != nil {
|
|
t.Errorf("unexpected error: %s", err)
|
|
}
|
|
|
|
// We have now deleted one of the two records.
|
|
if len(hist) != 1 {
|
|
t.Errorf("expected 1 record for deleted release version, got %d", len(hist))
|
|
}
|
|
|
|
if hist[0].Version != 2 {
|
|
t.Errorf("Expected version to be 2, got %d", hist[0].Version)
|
|
}
|
|
}
|
|
|
|
func TestStorageList(t *testing.T) {
|
|
// initialize storage
|
|
storage := Init(driver.NewMemory())
|
|
|
|
// setup storage with test releases
|
|
setup := func() {
|
|
// release records
|
|
rls0 := ReleaseTestData{Name: "happy-catdog", Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls1 := ReleaseTestData{Name: "livid-human", Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls2 := ReleaseTestData{Name: "relaxed-cat", Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls3 := ReleaseTestData{Name: "hungry-hippo", Status: rspb.StatusDeployed}.ToRelease()
|
|
rls4 := ReleaseTestData{Name: "angry-beaver", Status: rspb.StatusDeployed}.ToRelease()
|
|
rls5 := ReleaseTestData{Name: "opulent-frog", Status: rspb.StatusUninstalled}.ToRelease()
|
|
rls6 := ReleaseTestData{Name: "happy-liger", Status: rspb.StatusUninstalled}.ToRelease()
|
|
|
|
// create the release records in the storage
|
|
assertErrNil(t.Fatal, storage.Create(rls0), "Storing release 'rls0'")
|
|
assertErrNil(t.Fatal, storage.Create(rls1), "Storing release 'rls1'")
|
|
assertErrNil(t.Fatal, storage.Create(rls2), "Storing release 'rls2'")
|
|
assertErrNil(t.Fatal, storage.Create(rls3), "Storing release 'rls3'")
|
|
assertErrNil(t.Fatal, storage.Create(rls4), "Storing release 'rls4'")
|
|
assertErrNil(t.Fatal, storage.Create(rls5), "Storing release 'rls5'")
|
|
assertErrNil(t.Fatal, storage.Create(rls6), "Storing release 'rls6'")
|
|
}
|
|
|
|
var listTests = []struct {
|
|
Description string
|
|
NumExpected int
|
|
ListFunc func() ([]*rspb.Release, error)
|
|
}{
|
|
{"ListDeployed", 2, storage.ListDeployed},
|
|
{"ListReleases", 7, storage.ListReleases},
|
|
{"ListUninstalled", 2, storage.ListUninstalled},
|
|
}
|
|
|
|
setup()
|
|
|
|
for _, tt := range listTests {
|
|
list, err := tt.ListFunc()
|
|
assertErrNil(t.Fatal, err, tt.Description)
|
|
// verify the count of releases returned
|
|
if len(list) != tt.NumExpected {
|
|
t.Errorf("ListReleases(%s): expected %d, actual %d",
|
|
tt.Description,
|
|
tt.NumExpected,
|
|
len(list))
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestStorageDeployed(t *testing.T) {
|
|
storage := Init(driver.NewMemory())
|
|
|
|
const name = "angry-bird"
|
|
const vers = 4
|
|
|
|
// setup storage with test releases
|
|
setup := func() {
|
|
// release records
|
|
rls0 := ReleaseTestData{Name: name, Version: 1, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls1 := ReleaseTestData{Name: name, Version: 2, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls2 := ReleaseTestData{Name: name, Version: 3, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls3 := ReleaseTestData{Name: name, Version: 4, Status: rspb.StatusDeployed}.ToRelease()
|
|
|
|
// create the release records in the storage
|
|
assertErrNil(t.Fatal, storage.Create(rls0), "Storing release 'angry-bird' (v1)")
|
|
assertErrNil(t.Fatal, storage.Create(rls1), "Storing release 'angry-bird' (v2)")
|
|
assertErrNil(t.Fatal, storage.Create(rls2), "Storing release 'angry-bird' (v3)")
|
|
assertErrNil(t.Fatal, storage.Create(rls3), "Storing release 'angry-bird' (v4)")
|
|
}
|
|
|
|
setup()
|
|
|
|
rls, err := storage.Last(name)
|
|
if err != nil {
|
|
t.Fatalf("Failed to query for deployed release: %s\n", err)
|
|
}
|
|
|
|
switch {
|
|
case rls == nil:
|
|
t.Fatalf("Release is nil")
|
|
case rls.Name != name:
|
|
t.Fatalf("Expected release name %q, actual %q\n", name, rls.Name)
|
|
case rls.Version != vers:
|
|
t.Fatalf("Expected release version %d, actual %d\n", vers, rls.Version)
|
|
case rls.Info.Status != rspb.StatusDeployed:
|
|
t.Fatalf("Expected release status 'DEPLOYED', actual %s\n", rls.Info.Status.String())
|
|
}
|
|
}
|
|
|
|
func TestStorageDeployedWithCorruption(t *testing.T) {
|
|
storage := Init(driver.NewMemory())
|
|
|
|
const name = "angry-bird"
|
|
const vers = int(4)
|
|
|
|
// setup storage with test releases
|
|
setup := func() {
|
|
// release records (notice odd order and corruption)
|
|
rls0 := ReleaseTestData{Name: name, Version: 1, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls1 := ReleaseTestData{Name: name, Version: 4, Status: rspb.StatusDeployed}.ToRelease()
|
|
rls2 := ReleaseTestData{Name: name, Version: 3, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls3 := ReleaseTestData{Name: name, Version: 2, Status: rspb.StatusDeployed}.ToRelease()
|
|
|
|
// create the release records in the storage
|
|
assertErrNil(t.Fatal, storage.Create(rls0), "Storing release 'angry-bird' (v1)")
|
|
assertErrNil(t.Fatal, storage.Create(rls1), "Storing release 'angry-bird' (v2)")
|
|
assertErrNil(t.Fatal, storage.Create(rls2), "Storing release 'angry-bird' (v3)")
|
|
assertErrNil(t.Fatal, storage.Create(rls3), "Storing release 'angry-bird' (v4)")
|
|
}
|
|
|
|
setup()
|
|
|
|
rls, err := storage.Deployed(name)
|
|
if err != nil {
|
|
t.Fatalf("Failed to query for deployed release: %s\n", err)
|
|
}
|
|
|
|
switch {
|
|
case rls == nil:
|
|
t.Fatalf("Release is nil")
|
|
case rls.Name != name:
|
|
t.Fatalf("Expected release name %q, actual %q\n", name, rls.Name)
|
|
case rls.Version != vers:
|
|
t.Fatalf("Expected release version %d, actual %d\n", vers, rls.Version)
|
|
case rls.Info.Status != rspb.StatusDeployed:
|
|
t.Fatalf("Expected release status 'DEPLOYED', actual %s\n", rls.Info.Status.String())
|
|
}
|
|
}
|
|
|
|
func TestStorageHistory(t *testing.T) {
|
|
storage := Init(driver.NewMemory())
|
|
|
|
const name = "angry-bird"
|
|
|
|
// setup storage with test releases
|
|
setup := func() {
|
|
// release records
|
|
rls0 := ReleaseTestData{Name: name, Version: 1, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls1 := ReleaseTestData{Name: name, Version: 2, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls2 := ReleaseTestData{Name: name, Version: 3, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls3 := ReleaseTestData{Name: name, Version: 4, Status: rspb.StatusDeployed}.ToRelease()
|
|
|
|
// create the release records in the storage
|
|
assertErrNil(t.Fatal, storage.Create(rls0), "Storing release 'angry-bird' (v1)")
|
|
assertErrNil(t.Fatal, storage.Create(rls1), "Storing release 'angry-bird' (v2)")
|
|
assertErrNil(t.Fatal, storage.Create(rls2), "Storing release 'angry-bird' (v3)")
|
|
assertErrNil(t.Fatal, storage.Create(rls3), "Storing release 'angry-bird' (v4)")
|
|
}
|
|
|
|
setup()
|
|
|
|
h, err := storage.History(name)
|
|
if err != nil {
|
|
t.Fatalf("Failed to query for release history (%q): %s\n", name, err)
|
|
}
|
|
if len(h) != 4 {
|
|
t.Fatalf("Release history (%q) is empty\n", name)
|
|
}
|
|
}
|
|
|
|
func TestStorageRemoveLeastRecentWithError(t *testing.T) {
|
|
storage := Init(driver.NewMemory())
|
|
storage.Log = t.Logf
|
|
|
|
storage.MaxHistory = 1
|
|
|
|
const name = "angry-bird"
|
|
|
|
// setup storage with test releases
|
|
setup := func() {
|
|
// release records
|
|
rls1 := ReleaseTestData{Name: name, Version: 1, Status: rspb.StatusSuperseded}.ToRelease()
|
|
|
|
// create the release records in the storage
|
|
assertErrNil(t.Fatal, storage.Driver.Create(makeKey(rls1.Name, rls1.Version), rls1), "Storing release 'angry-bird' (v1)")
|
|
}
|
|
setup()
|
|
|
|
rls2 := ReleaseTestData{Name: name, Version: 2, Status: rspb.StatusSuperseded}.ToRelease()
|
|
wantErr := driver.ErrNoDeployedReleases
|
|
gotErr := storage.Create(rls2)
|
|
if !errors.Is(gotErr, wantErr) {
|
|
t.Fatalf("Storing release 'angry-bird' (v2) should return the error %#v, but returned %#v", wantErr, gotErr)
|
|
}
|
|
}
|
|
|
|
func TestStorageRemoveLeastRecent(t *testing.T) {
|
|
storage := Init(driver.NewMemory())
|
|
storage.Log = t.Logf
|
|
|
|
// Make sure that specifying this at the outset doesn't cause any bugs.
|
|
storage.MaxHistory = 10
|
|
|
|
const name = "angry-bird"
|
|
|
|
// setup storage with test releases
|
|
setup := func() {
|
|
// release records
|
|
rls0 := ReleaseTestData{Name: name, Version: 1, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls1 := ReleaseTestData{Name: name, Version: 2, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls2 := ReleaseTestData{Name: name, Version: 3, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls3 := ReleaseTestData{Name: name, Version: 4, Status: rspb.StatusDeployed}.ToRelease()
|
|
|
|
// create the release records in the storage
|
|
assertErrNil(t.Fatal, storage.Create(rls0), "Storing release 'angry-bird' (v1)")
|
|
assertErrNil(t.Fatal, storage.Create(rls1), "Storing release 'angry-bird' (v2)")
|
|
assertErrNil(t.Fatal, storage.Create(rls2), "Storing release 'angry-bird' (v3)")
|
|
assertErrNil(t.Fatal, storage.Create(rls3), "Storing release 'angry-bird' (v4)")
|
|
}
|
|
setup()
|
|
|
|
// Because we have not set a limit, we expect 4.
|
|
expect := 4
|
|
if hist, err := storage.History(name); err != nil {
|
|
t.Fatal(err)
|
|
} else if len(hist) != expect {
|
|
t.Fatalf("expected %d items in history, got %d", expect, len(hist))
|
|
}
|
|
|
|
storage.MaxHistory = 3
|
|
rls5 := ReleaseTestData{Name: name, Version: 5, Status: rspb.StatusDeployed}.ToRelease()
|
|
assertErrNil(t.Fatal, storage.Create(rls5), "Storing release 'angry-bird' (v5)")
|
|
|
|
// On inserting the 5th record, we expect two records to be pruned from history.
|
|
hist, err := storage.History(name)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
} else if len(hist) != storage.MaxHistory {
|
|
for _, item := range hist {
|
|
t.Logf("%s %v", item.Name, item.Version)
|
|
}
|
|
t.Fatalf("expected %d items in history, got %d", storage.MaxHistory, len(hist))
|
|
}
|
|
|
|
// We expect the existing records to be 3, 4, and 5.
|
|
for i, item := range hist {
|
|
v := item.Version
|
|
if expect := i + 3; v != expect {
|
|
t.Errorf("Expected release %d, got %d", expect, v)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestStorageDoNotDeleteDeployed(t *testing.T) {
|
|
storage := Init(driver.NewMemory())
|
|
storage.Log = t.Logf
|
|
storage.MaxHistory = 3
|
|
|
|
const name = "angry-bird"
|
|
|
|
// setup storage with test releases
|
|
setup := func() {
|
|
// release records
|
|
rls0 := ReleaseTestData{Name: name, Version: 1, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls1 := ReleaseTestData{Name: name, Version: 2, Status: rspb.StatusDeployed}.ToRelease()
|
|
rls2 := ReleaseTestData{Name: name, Version: 3, Status: rspb.StatusFailed}.ToRelease()
|
|
rls3 := ReleaseTestData{Name: name, Version: 4, Status: rspb.StatusFailed}.ToRelease()
|
|
|
|
// create the release records in the storage
|
|
assertErrNil(t.Fatal, storage.Create(rls0), "Storing release 'angry-bird' (v1)")
|
|
assertErrNil(t.Fatal, storage.Create(rls1), "Storing release 'angry-bird' (v2)")
|
|
assertErrNil(t.Fatal, storage.Create(rls2), "Storing release 'angry-bird' (v3)")
|
|
assertErrNil(t.Fatal, storage.Create(rls3), "Storing release 'angry-bird' (v4)")
|
|
}
|
|
setup()
|
|
|
|
rls5 := ReleaseTestData{Name: name, Version: 5, Status: rspb.StatusFailed}.ToRelease()
|
|
assertErrNil(t.Fatal, storage.Create(rls5), "Storing release 'angry-bird' (v5)")
|
|
|
|
// On inserting the 5th record, we expect a total of 3 releases, but we expect version 2
|
|
// (the only deployed release), to still exist
|
|
hist, err := storage.History(name)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
} else if len(hist) != storage.MaxHistory {
|
|
for _, item := range hist {
|
|
t.Logf("%s %v", item.Name, item.Version)
|
|
}
|
|
t.Fatalf("expected %d items in history, got %d", storage.MaxHistory, len(hist))
|
|
}
|
|
|
|
expectedVersions := map[int]bool{
|
|
2: true,
|
|
4: true,
|
|
5: true,
|
|
}
|
|
|
|
for _, item := range hist {
|
|
if !expectedVersions[item.Version] {
|
|
t.Errorf("Release version %d, found when not expected", item.Version)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestStorageLast(t *testing.T) {
|
|
storage := Init(driver.NewMemory())
|
|
|
|
const name = "angry-bird"
|
|
|
|
// Set up storage with test releases.
|
|
setup := func() {
|
|
// release records
|
|
rls0 := ReleaseTestData{Name: name, Version: 1, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls1 := ReleaseTestData{Name: name, Version: 2, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls2 := ReleaseTestData{Name: name, Version: 3, Status: rspb.StatusSuperseded}.ToRelease()
|
|
rls3 := ReleaseTestData{Name: name, Version: 4, Status: rspb.StatusFailed}.ToRelease()
|
|
|
|
// create the release records in the storage
|
|
assertErrNil(t.Fatal, storage.Create(rls0), "Storing release 'angry-bird' (v1)")
|
|
assertErrNil(t.Fatal, storage.Create(rls1), "Storing release 'angry-bird' (v2)")
|
|
assertErrNil(t.Fatal, storage.Create(rls2), "Storing release 'angry-bird' (v3)")
|
|
assertErrNil(t.Fatal, storage.Create(rls3), "Storing release 'angry-bird' (v4)")
|
|
}
|
|
|
|
setup()
|
|
|
|
h, err := storage.Last(name)
|
|
if err != nil {
|
|
t.Fatalf("Failed to query for release history (%q): %s\n", name, err)
|
|
}
|
|
|
|
if h.Version != 4 {
|
|
t.Errorf("Expected revision 4, got %d", h.Version)
|
|
}
|
|
}
|
|
|
|
type ReleaseTestData struct {
|
|
Name string
|
|
Version int
|
|
Manifest string
|
|
Namespace string
|
|
Status rspb.Status
|
|
}
|
|
|
|
func (test ReleaseTestData) ToRelease() *rspb.Release {
|
|
return &rspb.Release{
|
|
Name: test.Name,
|
|
Version: test.Version,
|
|
Manifest: test.Manifest,
|
|
Namespace: test.Namespace,
|
|
Info: &rspb.Info{Status: test.Status},
|
|
}
|
|
}
|
|
|
|
func assertErrNil(eh func(args ...interface{}), err error, message string) {
|
|
if err != nil {
|
|
eh(fmt.Sprintf("%s: %q", message, err))
|
|
}
|
|
}
|