You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Oleg Sidorov f94bac0643 chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3] ... Backport of https://github.com/helm/helm/pull/6010 to dev-v3 (the description below is a copy-paste from the original v2 branch PR). As https://github.com/helm/helm/pull/6016 is now merged to dev-v3, the change is reasonably trivial. This change is an attempt to address the common problem of json number unmarshalling where any number is converted into a float64 and represented in a scientific notation on a marshall call. This behavior breaks things like: chart versions and image tags if not converted to yaml strings explicitly. An example of this behavior: k8s failure to fetch an image tagged with a big number like: $IMAGE:20190612073634 after a few steps of yaml re-rendering turns into: $IMAGE:2.0190612073634e+13. Example issue: #1707 This commit forces yaml parser to use JSON modifiers and explicitly enables interface{} unmarshalling instead of float64. The change introduced might be breaking so should be processed with an extra care. Due to the fact helm mostly dals with human-produced data (charts), we have a decent level of confidence this change looses no functionality helm users rely upon (the scientific notation). Relevant doc: https://golang.org/pkg/encoding/json/#Decoder.UseNumber Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com> Signed-off-by: Oleg Sidorov <me@whitebox.io>		5 years ago
..
albatross	ref(pkg/chart): add validation method to chart	6 years ago
dependent-chart-alias	Updating to the k8s label convention	6 years ago
dependent-chart-helmignore	Updating to the k8s label convention	6 years ago
dependent-chart-no-requirements-yaml	Updating to the k8s label convention	6 years ago
dependent-chart-with-all-in-requirements-yaml	Updating to the k8s label convention	6 years ago
dependent-chart-with-mixed-requirements-yaml	Updating to the k8s label convention	6 years ago
frobnitz	Updating to the k8s label convention	6 years ago
frobnitz_backslash	Updating to the k8s label convention	6 years ago
joonix	fix appveyor builds (#4934)	6 years ago
mariner	ref(pkg/chart): add validation method to chart	6 years ago
moby	ref(pkg/chart): add validation method to chart	6 years ago
subpop	Merge pull request #5601 from adamreese/v3/capabilities	6 years ago
chartfiletest.yaml	feat(2450): add annotations to chart metadata (#2671)	7 years ago
coleridge.yaml	chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3]	5 years ago
frobnitz-1.2.3.tgz	ref(pkg/chart): add validation method to chart	6 years ago
frobnitz_backslash-1.2.3.tgz	ref(pkg/chart): add validation method to chart	6 years ago
genfrob.sh	ref(pkg/chart): add validation method to chart	6 years ago
test-values-negative.yaml	Feat/schema validation (#5350)	6 years ago
test-values.schema.json	Feat/schema validation (#5350)	6 years ago
test-values.yaml	Feat/schema validation (#5350)	6 years ago