You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Oleg Sidorov f94bac0643 chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3] ... Backport of https://github.com/helm/helm/pull/6010 to dev-v3 (the description below is a copy-paste from the original v2 branch PR). As https://github.com/helm/helm/pull/6016 is now merged to dev-v3, the change is reasonably trivial. This change is an attempt to address the common problem of json number unmarshalling where any number is converted into a float64 and represented in a scientific notation on a marshall call. This behavior breaks things like: chart versions and image tags if not converted to yaml strings explicitly. An example of this behavior: k8s failure to fetch an image tagged with a big number like: $IMAGE:20190612073634 after a few steps of yaml re-rendering turns into: $IMAGE:2.0190612073634e+13. Example issue: #1707 This commit forces yaml parser to use JSON modifiers and explicitly enables interface{} unmarshalling instead of float64. The change introduced might be breaking so should be processed with an extra care. Due to the fact helm mostly dals with human-produced data (charts), we have a decent level of confidence this change looses no functionality helm users rely upon (the scientific notation). Relevant doc: https://golang.org/pkg/encoding/json/#Decoder.UseNumber Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com> Signed-off-by: Oleg Sidorov <me@whitebox.io>		7 years ago
..
testdata	chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3]	7 years ago
capabilities.go	…
capabilities_test.go	…
chartfile.go	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
chartfile_test.go	…
coalesce.go	ref(pkg/chartutil): break up chartutil into logical files	7 years ago
coalesce_test.go	ref(pkg/chartutil): break up chartutil into logical files	7 years ago
create.go	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
create_test.go	…
dependencies.go	…
dependencies_test.go	…
doc.go	…
errors.go	ref(pkg/chartutil): break up chartutil into logical files	7 years ago
expand.go	…
jsonschema.go	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
jsonschema_test.go	ref(pkg/chartutil): break up chartutil into logical files	7 years ago
save.go	Replaced ghodss/yaml with sigs.k8s.io/yaml	7 years ago
save_test.go	…
values.go	chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3]	7 years ago
values_test.go	chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3]	7 years ago