You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Marc Khouzam 3e1ca6fe6e fix(completion): --flag=val breaks zsh completion ... This is a bug I ran into when working on Helm completion. I was surprised that it didn't happen when I was using kubectl, so I investigated and found a PR that fixed this bug in kubectl: https://github.com/kubernetes/kubernetes/pull/48553 I duplicated the code in this commit which: Removes __helm_declare, which is safe to do since `declare -F` is already replaced to `whence -w` by __helm_convert_bash_to_zsh(). The problem was that calling "declare" from inside a function scopes the declaration to that function only. So "declare" should not be called through __helm_declare() but instead directly. To reproduce: 1- setup helm completion in zsh 2- helm --kubeconfig=$HOME/.kube/config statu<TAB> you will get the error: __helm_handle_flag:27: bad math expression: operand expected at end of string Co-authored-by: Kazuki Suda <kazuki.suda@gmail.com> Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>		7 years ago
..
helm	fix(completion): --flag=val breaks zsh completion	7 years ago
rudder	Fix `no RESOURCE with the name NAME found`	7 years ago
tiller	refactor: using tiller probe port constant	7 years ago