helm/pkg at 1c8d1e375fe1823cdb7adfc47fc3014ddc59730e - helm

History

Rostyslav Polishchuk 1c8d1e375f fix: chart icon presence test The `TestValidateChartIconPresence` test fails when run after `TestValidateChartIconURL` as they both are using a global variable `badChart.Icon` ``` : go test -v -test.shuffle 1 -run '^(TestValidateChartIconPresence\|TestValidateChartIconURL)$' ./pkg/lint/rules/ -test.shuffle 1 === RUN TestValidateChartIconURL --- PASS: TestValidateChartIconURL (0.00s) === RUN TestValidateChartIconPresence chartfile_test.go:171: validateChartIconPresence to return a linter error, got no error --- FAIL: TestValidateChartIconPresence (0.00s) FAIL FAIL helm.sh/helm/v4/pkg/lint/rules 0.051s FAIL : go test -v -test.shuffle 2 -run '^(TestValidateChartIconPresence\|TestValidateChartIconURL)$' ./pkg/lint/rules/ -test.shuffle 2 === RUN TestValidateChartIconPresence --- PASS: TestValidateChartIconPresence (0.00s) === RUN TestValidateChartIconURL --- PASS: TestValidateChartIconURL (0.00s) PASS ok helm.sh/helm/v4/pkg/lint/rules 0.050s ``` This commit: 1. Remove dependency on global variable 2. Explicitly set the state of the test object. Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>		1 year ago
..
action	Merge pull request #30737 from rpolishchuk/investigation-pr-30610	1 year ago
chart/v2	Merge pull request #30708 from benoittgt/migrate-kube-pkg-to-slog	1 year ago
cli	Use the logger with proper handling of dynamic debug on 2 locations	1 year ago
cmd	Removing the alpine test chart	1 year ago
downloader	…
engine	Merge pull request #30708 from benoittgt/migrate-kube-pkg-to-slog	1 year ago
gates	…
getter	…
helmpath	…
ignore	…
kube	Fix nil pointer dereference in ready test	1 year ago
lint	fix: chart icon presence test	1 year ago
plugin	…
postrender	…
provenance	…
pusher	…
registry	…
release	fix: correct webhook order to match Kubernetes admission flow	1 year ago
repo	…
storage	Call slog directly instead of using a wrapper	1 year ago
strvals	…
time	…
uploader	…