/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package tiller import ( "reflect" "testing" "github.com/ghodss/yaml" "k8s.io/helm/pkg/chartutil" "k8s.io/helm/pkg/proto/hapi/release" util "k8s.io/helm/pkg/releaseutil" ) func TestSortManifests(t *testing.T) { data := []struct { name []string path string kind []string hooks map[string][]release.Hook_Event manifest string }{ { name: []string{"first"}, path: "one", kind: []string{"Job"}, hooks: map[string][]release.Hook_Event{"first": {release.Hook_PRE_INSTALL}}, manifest: `apiVersion: v1 kind: Job metadata: name: first labels: doesnot: matter annotations: "helm.sh/hook": pre-install `, }, { name: []string{"second"}, path: "two", kind: []string{"ReplicaSet"}, hooks: map[string][]release.Hook_Event{"second": {release.Hook_POST_INSTALL}}, manifest: `kind: ReplicaSet apiVersion: v1beta1 metadata: name: second annotations: "helm.sh/hook": post-install `, }, { name: []string{"third"}, path: "three", kind: []string{"ReplicaSet"}, hooks: map[string][]release.Hook_Event{"third": nil}, manifest: `kind: ReplicaSet apiVersion: v1beta1 metadata: name: third annotations: "helm.sh/hook": no-such-hook `, }, { name: []string{"fourth"}, path: "four", kind: []string{"Pod"}, hooks: map[string][]release.Hook_Event{"fourth": nil}, manifest: `kind: Pod apiVersion: v1 metadata: name: fourth annotations: nothing: here`, }, { name: []string{"fifth"}, path: "five", kind: []string{"ReplicaSet"}, hooks: map[string][]release.Hook_Event{"fifth": {release.Hook_POST_DELETE, release.Hook_POST_INSTALL}}, manifest: `kind: ReplicaSet apiVersion: v1beta1 metadata: name: fifth annotations: "helm.sh/hook": post-delete, post-install `, }, { // Regression test: files with an underscore in the base name should be skipped. name: []string{"sixth"}, path: "six/_six", kind: []string{"ReplicaSet"}, hooks: map[string][]release.Hook_Event{"sixth": nil}, manifest: `invalid manifest`, // This will fail if partial is not skipped. }, { // Regression test: files with no content should be skipped. name: []string{"seventh"}, path: "seven", kind: []string{"ReplicaSet"}, hooks: map[string][]release.Hook_Event{"seventh": nil}, manifest: "", }, { name: []string{"eighth", "example-test"}, path: "eight", kind: []string{"ConfigMap", "Pod"}, hooks: map[string][]release.Hook_Event{"eighth": nil, "example-test": {release.Hook_RELEASE_TEST_SUCCESS}}, manifest: `kind: ConfigMap apiVersion: v1 metadata: name: eighth data: name: value --- apiVersion: v1 kind: Pod metadata: name: example-test annotations: "helm.sh/hook": test-success `, }, { name: []string{"ninth"}, path: "nine", kind: []string{"CustomResourceDefinition"}, hooks: map[string][]release.Hook_Event{"ninth": {release.Hook_CRD_INSTALL}}, manifest: `apiVersion: apiextensions.k8s.io/v1beta1 kind: CustomResourceDefinition metadata: name: ninth labels: doesnot: matter annotations: "helm.sh/hook": crd-install `, }, } manifests := make(map[string]string, len(data)) for _, o := range data { manifests[o.path] = o.manifest } hs, generic, err := sortManifests(manifests, chartutil.NewVersionSet("v1", "v1beta1"), InstallOrder) if err != nil { t.Fatalf("Unexpected error: %s", err) } // This test will fail if 'six' or 'seven' was added. // changed to account for CustomResourceDefinition with crd-install hook being added to generic list of manifests if len(generic) != 3 { t.Errorf("Expected 3 generic manifests, got %d", len(generic)) } // changed to account for 5 hooks now that there is a crd-install hook added as member 9 of the data list. It was 4 before. if len(hs) != 5 { t.Errorf("Expected 5 hooks, got %d", len(hs)) } for _, out := range hs { t.Logf("Checking name %s path %s and kind %s", out.Name, out.Path, out.Kind) found := false for _, expect := range data { if out.Path == expect.path { found = true nameFound := false for _, expectedName := range expect.name { if out.Name == expectedName { nameFound = true } } if !nameFound { t.Errorf("Got unexpected name %s", out.Name) } kindFound := false for _, expectedKind := range expect.kind { if out.Kind == expectedKind { kindFound = true } } if !kindFound { t.Errorf("Got unexpected kind %s", out.Kind) } expectedHooks := expect.hooks[out.Name] if !reflect.DeepEqual(expectedHooks, out.Events) { t.Errorf("expected events: %v but got: %v", expectedHooks, out.Events) } } } if !found { t.Errorf("Result not found: %v", out) } } // Verify the sort order sorted := []Manifest{} for _, s := range data { manifests := util.SplitManifests(s.manifest) for _, m := range manifests { var sh util.SimpleHead err := yaml.Unmarshal([]byte(m), &sh) if err != nil { // This is expected for manifests that are corrupt or empty. t.Log(err) continue } name := sh.Metadata.Name //only keep track of non-hook manifests, that are not CustomResourceDefinitions with crd-install if err == nil && (s.hooks[name] == nil || s.hooks[name][0] == release.Hook_CRD_INSTALL) { another := Manifest{ Content: m, Name: name, Head: &sh, } sorted = append(sorted, another) } } } sorted = sortByKind(sorted, InstallOrder) for i, m := range generic { if m.Content != sorted[i].Content { t.Errorf("Expected %q, got %q", m.Content, sorted[i].Content) } } } func TestVersionSet(t *testing.T) { vs := chartutil.NewVersionSet("v1", "v1beta1", "extensions/alpha5", "batch/v1") if l := len(vs); l != 4 { t.Errorf("Expected 4, got %d", l) } if !vs.Has("extensions/alpha5") { t.Error("No match for alpha5") } if vs.Has("nosuch/extension") { t.Error("Found nonexistent extension") } }