Matheus Pimenta
c94d381b03
chore(defaults): server-side apply SDK defaults should always match the CLI defaults
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
(cherry picked from commit c1cc625323 )
2 weeks ago
Matheus Pimenta
b868e6a7cc
fix: insert newline after doc separators glued to content by template trimming
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
(cherry picked from commit af94abf976 )
2 weeks ago
Manuel Alonso
c15e7114dc
fix(install): check nil for restClientGetter and fix tests
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 9817a68618 )
2 weeks ago
Manuel Alonso
df82e68ce1
chore(refactor): better testing and functionality for installing crd
...
Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>
(cherry picked from commit 6501ef490a )
2 weeks ago
Manuel Alonso
4b896ca82f
fix(test): fix tests and check nil for restclient
...
Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>
(cherry picked from commit 0f949a92c1 )
2 weeks ago
Manuel Alonso
6017d2b470
fix(install): add more tests and check nil file data
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 00f0a48a7d )
2 weeks ago
Manuel Alonso
f451967ab5
fix(test): no check empty resources
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 0357e8d0f7 )
2 weeks ago
Manuel Alonso
fdadff59eb
fix(install): check lenght and file nil, add tests
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 52235cc0bf )
2 weeks ago
Manuel Alonso
10d6067265
fix(action): crd resources can be empty
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 268593bf2e )
2 weeks ago
Mujib Ahasan
0fec40f9b6
fix: casing issue fixed
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 170911459b )
2 weeks ago
Mujib Ahasan
263749874c
fix: error handled correctly
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 94860626ce )
2 weeks ago
Mujib Ahasan
961d7d7cd6
fix: doc string added
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 12e8b715aa )
2 weeks ago
Mujib Ahasan
29e45067f3
update: test coverage added for helper function validateNameAndGenerateName
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 115409976b )
2 weeks ago
Mujib Ahasan
d55b0b9022
update: helper function added for the business logic
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 522d2fe615 )
2 weeks ago
Mujib Ahasan
c1c090e8ce
generateName is also considered in logic
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 6769fb6fb6 )
2 weeks ago
Mujib Ahasan
5e093136f4
update: business logic respected for skipping object missing name
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit b357bcae86 )
2 weeks ago
Matheus Pimenta
59ece92bed
pkg/kube: introduce support for custom kstatus readers
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 months ago
Evans Mungai
e751a70e84
fix(release): fix test compilation error
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 months ago
Evans Mungai
05f25a3834
Merge pull request #31579 from benoittgt/delete-hook-after-log-retrieval
...
fix: Delay test hook deletion until after logs are retrieved with `helm test release --logs`
2 months ago
George Jenkins
fa41d60d73
Merge pull request #31239 from StephanieHhnbrg/test-actions-pkg
...
Add tests to action package to improve coverage
3 months ago
Terry Howe
5d2ab10caa
Merge pull request #12564 from hiddeco/supersede-on-uninstall
...
fix(uninstall): supersede deployed releases
3 months ago
Terry Howe
2597088a20
Merge pull request #31586 from calvinbui/main
...
fix: use length check for MetaDependencies instead of nil comparison
3 months ago
Robert Sirchia
4cf7d8d025
Merge pull request #31641 from wangjingcun/main
...
chore: fix some comments to improve readability
3 months ago
Terry Howe
d28853e206
Merge pull request #31624 from atombrella/feature/sloglint
...
Enable the `sloglint` linter
3 months ago
wangjingcun
858cf31583
chore: fix some comments to improve readability
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
3 months ago
Mads Jensen
a18e59e465
Enable the sloglint linter
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
3 months ago
George Jenkins
3165e5463a
Merge pull request #31528 from benoittgt/31423-git-version
...
fix: preserve vendor suffixes in KubeVersion.GitVersion
3 months ago
Stephanie Hohenberg
a109ac2f06
fixes comment in install.go
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
4 months ago
Stephanie Hohenberg
2f598ffc85
fixes tests after merge
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
4 months ago
Stephanie Hohenberg
bb9356e182
fixes lint issue
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
4 months ago
Stephanie Hohenberg
8cf4ad73c3
updates tests after rebase from master
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
4 months ago
Stephanie Hohenberg
31131cff9b
Add tests to action package to improve coverage
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
4 months ago
George Jenkins
dfa1e3c3c5
Merge pull request #31562 from atombrella/feature/modernize
...
Use modernize to use newer Golang features.
4 months ago
Benoit Tigeot
45c5f3aaca
Deal with golint warning with private executeShutdownFunc
...
```
Error: pkg/action/release_testing.go:60:57: unexported-return: exported method Run returns unexported type action.executeShutdownFunc, which can be annoying to use (revive)
func (r *ReleaseTesting) Run(name string) (ri.Releaser, executeShutdownFunc, error) {
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Calvin Bui
b33d4ae0c0
Use length check for MetaDependencies instead of nil comparison
...
Signed-off-by: Calvin Bui <3604363+calvinbui@users.noreply.github.com>
4 months ago
Benoit Tigeot
70fc5f97e2
Code review
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Michelle Fernandez Bieber
6bb5bcc212
Update pkg/action/hooks.go
...
Co-authored-by: Marco Lecheler <marco@task.media>
Signed-off-by: Michelle Fernandez Bieber <37021266+mfbieber@users.noreply.github.com>
4 months ago
Michelle Fernandez Bieber
d9301441f4
added check for nil shutdown
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
4 months ago
Michelle Fernandez Bieber
7a61ebf013
cleaned up empty line
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
4 months ago
Michelle Fernandez Bieber
10714772be
updated comment and made defer of shutdown function return errors as before and not the possible shutdown error
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
4 months ago
Michelle Fernandez Bieber
7a557580e1
added shutdown hook that is executed after the logs have been retrieved
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
4 months ago
Mads Jensen
6cceead399
Use modernize to use newer Golang features.
...
The rangeint suggestion is faster.
The maps.Copy and slices.Contains are just syntatic sugar.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
4 months ago
Matt Farina
61d289c119
Merge pull request #31518 from gjenkins8/gjenkins/fix_update_create
...
fix: Use server-side apply for object create during update
4 months ago
Matt Farina
698fcd2290
Merge pull request #31515 from gjenkins8/gjenkins/copy_adopted
...
fix: Copy adopted resource info
4 months ago
Benoit Tigeot
ce273eea48
fix: preserve vendor suffixes in KubeVersion.GitVersion
...
Helm 3.19.0 introduced a regression where vendor-specific suffixes
(e.g., -gke.1245000, -eks-4096722, +) are stripped from
.Capabilities.KubeVersion.GitVersion, breaking charts that detect
managed Kubernetes platforms.
The root cause was using k8sversion.ParseGeneric().String() which
intentionally discards vendor suffixes. The fix stores both the full
version (with vendor suffix) and a normalized version. String() returns
the normalized version for constraint checking (e.g., ">= 1.21.0"),
while Version/GitVersion preserve the full string for template access.
Fixes #31423
Related to #31063 , #31078
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
George Jenkins
18616e6ce9
fix: Use server-side apply for object create during update
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
George Jenkins
855ebb6884
Copy adopted resource info
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
promalert
d8c4040336
refactor: use strings.Builder to improve performance
...
Signed-off-by: promalert <promalert@outlook.com>
4 months ago
Scott Rigby
0ee89d2d4e
Merge pull request #31418 from tisonkun/typo
...
chore: fix typo of public field
4 months ago
Hidde Beydals
d158708fbf
fix(rollback): `errors.Is` instead of string comp
...
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
4 months ago