Travis Leeden
7cb43e0c58
Restored --atomic flag on install command
...
Signed-off-by: Travis Leeden <travis.leeden@octopus.com>
(cherry picked from commit 16573f87f5 )
2 weeks ago
Matheus Pimenta
b868e6a7cc
fix: insert newline after doc separators glued to content by template trimming
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
(cherry picked from commit af94abf976 )
2 weeks ago
rohansood10
dbfbea91e3
fix: correct import comment in statuswait.go from v3 to v4
...
The import comment in pkg/kube/statuswait.go still referenced
helm.sh/helm/v3/pkg/kube while all other files in the package
correctly reference helm.sh/helm/v4/pkg/kube. This mismatch
causes downstream processing errors (e.g. kythe) when vendoring
Helm.
Fixes #31846
Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
(cherry picked from commit c59c140ce0 )
2 weeks ago
Pedro Tôrres
4967ead762
add image index test
...
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
(cherry picked from commit e8f386b5aa )
2 weeks ago
Pedro Tôrres
2fe6b106e6
fix pulling charts from OCI indices
...
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
(cherry picked from commit d983696e35 )
2 weeks ago
Evans Mungai
e3e2d01ef4
fix: handle OCI digest algorithm prefix in chart downloader ( #31601 )
...
* fix: strip digest algorithm prefix before hex decoding
OCI references with tag+digest (e.g., chart:1.0@sha256:abc...) failed with "invalid byte" error because the sha256: prefix was passed to hex.DecodeString().
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add cmd test for OCI references with tag+digest
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Move oci registry push result to a struct
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Review comments from PR review
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Fix failing test
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
---------
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
(cherry picked from commit ee018608f6 )
2 weeks ago
Manuel Alonso
c15e7114dc
fix(install): check nil for restClientGetter and fix tests
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 9817a68618 )
2 weeks ago
Manuel Alonso
df82e68ce1
chore(refactor): better testing and functionality for installing crd
...
Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>
(cherry picked from commit 6501ef490a )
2 weeks ago
Manuel Alonso
4b896ca82f
fix(test): fix tests and check nil for restclient
...
Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>
(cherry picked from commit 0f949a92c1 )
2 weeks ago
Manuel Alonso
6017d2b470
fix(install): add more tests and check nil file data
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 00f0a48a7d )
2 weeks ago
Manuel Alonso
f451967ab5
fix(test): no check empty resources
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 0357e8d0f7 )
2 weeks ago
Manuel Alonso
fdadff59eb
fix(install): check lenght and file nil, add tests
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 52235cc0bf )
2 weeks ago
Manuel Alonso
10d6067265
fix(action): crd resources can be empty
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 268593bf2e )
2 weeks ago
Mujib Ahasan
0fec40f9b6
fix: casing issue fixed
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 170911459b )
2 weeks ago
Mujib Ahasan
263749874c
fix: error handled correctly
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 94860626ce )
2 weeks ago
Mujib Ahasan
961d7d7cd6
fix: doc string added
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 12e8b715aa )
2 weeks ago
Mujib Ahasan
29e45067f3
update: test coverage added for helper function validateNameAndGenerateName
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 115409976b )
2 weeks ago
Mujib Ahasan
d55b0b9022
update: helper function added for the business logic
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 522d2fe615 )
2 weeks ago
Mujib Ahasan
c1c090e8ce
generateName is also considered in logic
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 6769fb6fb6 )
2 weeks ago
Mujib Ahasan
5e093136f4
update: business logic respected for skipping object missing name
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit b357bcae86 )
2 weeks ago
Mujib Ahasan
f289d1605c
fixed: --dry-run=server now respect generateName
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 2820ebe8c9 )
2 weeks ago
Orgad Shaneh
bfac7393e4
fix(downloader): safely handle concurrent file writes on Windows
...
When multiple processes try to download the same chart version
concurrently (e.g., via Terraform), they can race to write the
destination file. On Windows, this results in 'Access Denied'
errors because the file cannot be renamed while another process
has a handle to the destination.
This commit introduces 'PlatformAtomicWriteFile' to the fileutil
package. On Unix-like systems, it simply delegates to AtomicWriteFile,
maintaining existing behavior. On Windows, it coordinates writes using
a lock file (.lock). It acquires the lock, then performs the atomic
write.
Crucially, this implementation ensures that existing files are
overwritten (rather than skipped). This ensures that if a chart is
republished with the same version, the local cache is correctly updated,
preventing stale data issues.
Fixes #31633
Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
(cherry picked from commit 76eb37c01a )
2 weeks ago
Matheus Pimenta
5caf0044d4
feat(kstatus): fine-grained context options for waiting
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 months ago
Matheus Pimenta
2519a88b0b
bugfix(kstatus): do not wait forever on failed resources
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 months ago
Matheus Pimenta
b2c487c436
Revert "Consider GroupVersionKind when matching resources"
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 months ago
Evans Mungai
f46f1ce55d
Update pkg/kube/statuswait.go
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 months ago
Matheus Pimenta
59ece92bed
pkg/kube: introduce support for custom kstatus readers
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 months ago
Evans Mungai
e751a70e84
fix(release): fix test compilation error
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 months ago
Evans Mungai
2e2cb05855
Merge pull request #31427 from tisonkun/resolve-todo
...
Check plugin name is not used
2 months ago
Evans Mungai
05f25a3834
Merge pull request #31579 from benoittgt/delete-hook-after-log-retrieval
...
fix: Delay test hook deletion until after logs are retrieved with `helm test release --logs`
2 months ago
Terry Howe
429ce93848
Merge pull request #31613 from aslafy-z/feat/getter-env
...
fix(getter): pass settings environment variables
2 months ago
Terry Howe
08f17fc947
Merge pull request #31683 from majiayu000/fix-13198---api-versions-is-undocumented-1230-2329
...
fix: `--api-versions` is undocumented
3 months ago
George Jenkins
fa41d60d73
Merge pull request #31239 from StephanieHhnbrg/test-actions-pkg
...
Add tests to action package to improve coverage
3 months ago
Mads Jensen
2d6d9c09c4
Replace reflect.Ptr with reflect.Pointer
...
The reflect package has a go:fix annotation for Ptr = Pointer.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
3 months ago
majiayu000
c7cc77b68d
Add documentation for --api-versions flag in template command
...
The --api-versions flag was undocumented in the template command's
help text. This adds usage documentation and examples showing both
comma-separated and multiple flag usage patterns.
Fixes #13198
Signed-off-by: majiayu000 <1835304752@qq.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: majiayu000 <1835304752@qq.com>
3 months ago
Matt Farina
fe1c749183
Fixing failing tests for cli-tools update
...
Tests were failing for cli-utils watcher because upstream k8s made
changes that impacted cli-utils. In k8s WatchListClient is now
enabled by default. Fake clients used for testing don't know this
semantic. cli-utils leverages reflection in k8s to handle this.
The Helm tests didn't handle this well.
The tests are updated to use PrependReactor and PrependWatchReactor
in the same way that cli-utils does for testing. This works without
wrapping the client.
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 months ago
George Jenkins
118d90e810
Merge pull request #31677 from gjenkins8/gjenkins/new_client_set
...
chore: Replace deprecated `NewSimpleClientset`
3 months ago
George Jenkins
a15db7f087
Replace deprecated `NewSimpleClientset`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
Terry Howe
8802d959cb
Merge pull request #31104 from LinPr/fix
...
fix: assign KUBECONFIG environment variable value to env.Kubeconfig
3 months ago
George Jenkins
f05c21b6b6
Merge pull request #31296 from gjenkins8/gjenkins/runtime_kube_version
...
build: set kube version via `debug.BuildInfo`
3 months ago
George Jenkins
24e8297343
Merge pull request #31610 from mohsenmottaghi/fix-helm-4-watch-strategy
...
fix: use namespace-scoped watching to avoid cluster-wide LIST permiss…
3 months ago
Brenden Ehlers
1c119bcaa6
fix: add default casess to switch statements
...
Signed-off-by: Brenden Ehlers <brenden@theehlers.org>
3 months ago
Branch Vincent
c6d9a5bdc2
build: set kube version via `debug.BuildInfo`
...
Signed-off-by: Branch Vincent <branchevincent@gmail.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
Matt Farina
2108bc5070
Merge pull request #31448 from laervn/feat/add-no-headers-option
...
feat(repo): add --no-headers option to 'helm repo list'
3 months ago
Deepak Chethan
55a4aed67f
doc: update based on review suggestion
...
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Deepak Chethan <deepakchethan@outlook.com>
3 months ago
Mohsen Mottaghi
d6b35cedeb
test(statuswait): fix Copilot code review suggestion for goroutine in tests
...
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
3 months ago
Mohsen Mottaghi
a1543d5947
test(statuswait): add more tests suggested by Copilot code review
...
add missing coverage for the positive case where cluster-scoped resources (like ClusterRole or Namespace) should work correctly
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
3 months ago
Mohsen Mottaghi
dd44f4ecd0
test(statuswait): add some tests for statuswait
...
Adding some tests for multi namespace deployment, simulate restrcited rbac access and mixed namespace scope and cluster scope resources
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
3 months ago
Mohsen Mottaghi
3dd54ed0b6
fix: use namespace-scoped watching to avoid cluster-wide LIST permissions
...
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
3 months ago
Deepak
f92ae18977
fix(doc): Update default wait strategy
...
fixes : #31652
Default wait strategy is hookOnly, so updated the docs to reflect the same
Signed-off-by: Deepak Chethan <deepakchethan@outlook.com>
3 months ago