Benoit Tigeot
b2380720eb
Migrate to pure slog without a custom wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
947658a96e
Explain why we ignore the timestamp
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
3db7ebc591
Fix missing logger to SQL in test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
15de13f9d2
Fix linting issue and temporary removing logging in test acion
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
b42767be40
Migrate more code to log adapter
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
83cdffe4ae
Migrate to a dedicated internal package for slog adapter + migrate more
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
fae2345edf
Demonstrate the impact of having Logger defined in kube package
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
ede73860c1
Fix call to kube log
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
3a22df9731
Deal with linting errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
394ba2d55e
Properly use DefaultLogger
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
eb2dfe7dbf
Some interesting rephrasing by Terry Howe
...
See: https://github.com/helm/helm/pull/30698#discussion_r2012394228
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
227d270788
Extra comment + Default logger fallback
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
b642bca8f6
Provide an adapter to easily pass a slog.Default()
...
```
helmClient.Log = NewSlogAdapter(slog.Default())
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
d6d7cff417
Try to make log more common and more easily grepable
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
8d30464f2c
Do no mask warning alerts
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
dfaf249221
Remove unreachable error
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
f4631bf3d8
Migrate kube package to slog
...
As for helm v4. We want to migrate logs to slog.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Patrick Seidensal
e55707b09d
Fix --take-ownership
...
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.
This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.
By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.
Fixes #30622
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 months ago
Scott Rigby
af4f7370cb
Merge pull request #13119 from idsulik/update-charts-data-race-fix
6 months ago
George Jenkins
be2b84685a
cleanup: Remove Helm v2 template lint rules
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
Suleiman Dibirov
000c098a41
fix(concurrency): add mutex to protect repoFailList and out in updateCharts
...
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
6 months ago
Scott Rigby
985f5af538
Merge pull request #13604 from AustinAbro321/refactor-wait
...
Introduce kstatus watcher
6 months ago
Scott Rigby
122e7b441a
Merge pull request #13458 from thudi/main
...
#13449 Resolves: Replacing NewSimpleClientSet to NewClientSet due to deprecation
6 months ago
dongjiang
fcc9468b60
fix comments
...
Signed-off-by: dongjiang <dongjiang1989@126.com>
6 months ago
Austin Abro
21ee721242
go fmt
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Austin Abro
8efd428e5d
switch back to k8s rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Austin Abro
83266254f0
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Austin Abro
386523bdbc
update to get waiter instead of set
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Robert Sirchia
0199b748aa
Merge pull request #30696 from benoittgt/report-time-waited-v4
...
Inform about time spent waiting resources to be ready in slog format
6 months ago
Wahab Ali
ec31aab851
Use NewTLSConfig instead of the outdated NewClientTLS func
...
Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
6 months ago
Wahab Ali
e7895245f0
Fix lint errors
...
Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
6 months ago
Wahab Ali
3ca2558f04
Do not explicitly set SNI in HTTPGetter
...
Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
6 months ago
Benoit Tigeot
4f4c858f9c
Ignore unused parameter
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Matt Farina
2e6437beb5
Merge pull request #30684 from twz123/remove-clientoptresolver
...
Remove ClientOptResolver from OCI Client
6 months ago
Matt Farina
ab9f0c80b5
Merge pull request #30603 from robertsirc/converting-to-slog
...
converting inline log to slog
6 months ago
Robert Sirchia
a5ec16357d
Merge pull request #30688 from helm/dependabot/github_actions/main/actions/setup-go-5.4.0
...
build(deps): bump actions/setup-go from 5.3.0 to 5.4.0
6 months ago
Robert Sirchia
c5991028e0
fixing matts changes
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
6 months ago
Matt Farina
65706a4984
Merge pull request #30699 from mattfarina/error-on-failed-repo-up
...
Error when failed repo update.
6 months ago
Matt Farina
e4e602e13c
Error when failed repo update.
...
In Helm v3 we did not change exit codes for existing commands to
maintain compat. A flag was introduced so a failure would result
in a non-0 exit code. A note was left to make this the default
in Helm v4. That's what this change does.
Closes #10016
Signed-off-by: Matt Farina <matt.farina@suse.com>
6 months ago
Benoit Tigeot
94cb21c7c4
Follow convention for error with slog.Any()
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
e3e84b6dfe
"beginning wait" is dedicated to be display as debug log
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
0e4d185370
Inform about time spent waiting resources to be ready in slog format
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Robert Sirchia
7000db1ec0
Merge pull request #30687 from helm/dependabot/github_actions/main/actions/upload-artifact-4.6.2
...
build(deps): bump actions/upload-artifact from 4.6.1 to 4.6.2
6 months ago
Matt Farina
e1972f62e8
Merge pull request #30693 from linghuying/main
...
chore: make function comment match function name
6 months ago
Austin Abro
d78b7e401a
go mod tidy
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
linghuying
fc476f7235
chore: make function comment match function name
...
Signed-off-by: linghuying <1599935829@qq.com>
6 months ago
dependabot[bot]
f95410f66c
build(deps): bump actions/setup-go from 5.3.0 to 5.4.0
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](f111f3307d...0aaccfd150
)
---
updated-dependencies:
- dependency-name: actions/setup-go
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
6 months ago
dependabot[bot]
a45cf1bab9
build(deps): bump actions/upload-artifact from 4.6.1 to 4.6.2
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.6.1 to 4.6.2.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](4cec3d8aa0...ea165f8d65
)
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
6 months ago
Matt Farina
b304ee495d
Merge pull request #30681 from helm/dependabot/github_actions/main/golangci/golangci-lint-action-6.5.2
...
build(deps): bump golangci/golangci-lint-action from 6.5.1 to 6.5.2
6 months ago
Tom Wieczorek
835ff78f48
Remove ClientOptResolver from OCI Client
...
This option was kept to avoid compile-time incompatibilities in Helm v3
when upgrading to ORAS v2. Let's remove it for Helm v4.
This allows Helm to drop the containerd dependency entirely.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
6 months ago