93137abbb4
Merge pull request #7410 from tiendc/unit_test_releaseutil
...
Add unit test for Reverse() in pkg/releaseutil/sorter.go
6 years ago
9d20e44ad1
Add unit test for lint/values.go
...
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
6 years ago
26830942d2
Fix a bug in Delete() in storage/driver/cfgmaps.go ( #7367 )
6 years ago
06bc18c624
Fix a bug in storage/driver/secrets.go Delete() ( #7348 )
...
* Fix a bug in storage/driver/secrets.go
6 years ago
3cc5811de5
Merge pull request #7744 from hickeyma/port-devel-show
...
fix(show): Port --devel flag for show command
6 years ago
22b7562c62
fix(cli): Make upgrade check if cluster reachable
...
The 'helm upgrade' command was not checking if the cluster was reachable.
Also, 'helm upgrade --install' first checks if the release exists
already. If that check fails there is no point in continuing the
upgrade. This optimization avoids a second timeout of 30 seconds when
trying to do the upgrade.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
6 years ago
2dfb20f332
Merge pull request #7751 from mattfarina/fix-7748
...
Fixing issue where archives created on windows have broken paths
6 years ago
9496a7474b
Add tests
...
Signed-off-by: Jacob LeGrone <git@jacob.work>
6 years ago
8d1de39fe3
Add more detail to error messages and support a non-force mode in metadata visitor
...
Signed-off-by: Jacob LeGrone <git@jacob.work>
6 years ago
28b085bed5
Fixing issue where archives created on windows have broken paths
...
When archives are created on windows the path spearator in the
archive file is \\. This causes issues when the file is unpacked.
For example, on Linux the files are unpacked in a flat structure
and \ is part of the file name. This causes comp issues. In Helm
v2 the path was set as / when the archive was written. This works
on both Windows and POSIX systems.
The fix being implemented is to use the ToSlash function to ensure
/ is used as the separator.
Fixes #7748
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago
66292e5e24
Merge pull request #7164 from jmcelwain/master
...
fix(install): use ca file for install (#7140 )
6 years ago
bf5c0ae7f4
fix(install): correct append tls config.
...
Signed-off-by: James McElwain <jmcelwain@gmail.com>
6 years ago
a6994f6659
Port --devel flag from v2 to v3
...
Helm v2 PR #5141
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
d829343c15
Use Create method if no resources need to be adopted
...
Signed-off-by: Jacob LeGrone <git@jacob.work>
6 years ago
3d288b9823
Merge pull request #7661 from akash-gautam/fix/issue-7452
...
fix(helm): add --skip-crds flag to 'helm upgrade'
6 years ago
eaebce6738
Merge pull request #7651 from sshukun/fix-v1-dep
...
Fix dep build to be compatiable with Helm 2 when requirements use repo alias
6 years ago
b864fcd0f4
Make the charts cache safe in presence of several Helm instances
...
If several instances of Helm are run at the same moment and try to download the
same chart, some of them might see an empty or incomplete file in cache. Prevent
that by saving the dowloaded file atomically.
Closes #7600
Signed-off-by: Mikhail Gusarov <misha@ridge.co>
6 years ago
16024dc19a
fix: add new static linter and fix issues it found ( #7655 )
...
* fix: add new static linter and fix issues it found
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* fixed two additional linter errors.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
6 years ago
dc26128fb4
Add --insecure-skip-tls-verify for repositories ( #7254 )
...
* added --insecure-skip-tls-verify for chart repos
Signed-off-by: Matthias Riegler <me@xvzf.tech>
* fixed not passing the insecureSkipTLSverify option
Signed-off-by: Matthias Riegler <me@xvzf.tech>
* fixed testcase
Signed-off-by: Matthias Riegler <me@xvzf.tech>
* pass proxy when using insecureSkipVerify
Signed-off-by: Matthias Riegler <me@xvzf.tech>
* Add testcases for insecureSkipVerifyTLS
Signed-off-by: Matthias Riegler <me@xvzf.tech>
* added missing err check
Signed-off-by: Matthias Riegler <me@xvzf.tech>
* panic after json marshal fails
Signed-off-by: Matthias Riegler <me@xvzf.tech>
6 years ago
b1959a309e
Merge pull request #7674 from sshukun/package-lock-file
...
Save Chart.lock to helm package tar
6 years ago
ead3429408
Merge pull request #7713 from q384566678/add-secrets-test
...
pkg/storage: add unit test
6 years ago
6bed5949cb
Merge pull request #7714 from donggangcj/respect-resource-policy-on-upgrade
...
fix(helm): respect resource policy on ungrade
6 years ago
1940f500fd
Merge pull request #7721 from bacongobbler/fix-7230
...
ref(environment): use string checking instead
6 years ago
e0d11be6db
Merge pull request #7707 from mattfarina/add-verify-out-to-command
...
Add verification output to the verify command
6 years ago
faf5cfb2cb
Merge pull request #7189 from pmacik/fix-os.Stat
...
Repair unit tests failing on Linux caused by using the os.Stat
6 years ago
14f6d1ea97
ref(environment): use string checking instead
...
It is more idiomatic to compare the string against the empty string than to check the string's length.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
3dbc4dd53b
Merge pull request #7230 from waveywaves/update/token
...
feat(cli) Pass token via cli
6 years ago
13ffa52a59
Merge pull request #7706 from mattfarina/fix-7624
...
Fixes verification output on pull command
6 years ago
a992464fa2
Save Chart.lock to helm package tar
...
Signed-off-by: Song Shukun <song.shukun@fujitsu.com>
6 years ago
9d7907342d
Merge pull request #7514 from fhopfensperger/fix-7497
...
fixed dependencies processing in case of helm install or upgrade for …
6 years ago
69d9722eda
test(helm): fix client update error
...
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
6 years ago
c45869c4ad
fix(helm): polish goimport
...
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
6 years ago
f5da6bd3d6
add unit test for RecordsReplace
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
6 years ago
9744e9f619
fix(helm): respect resource policy on ungrade
...
Don't delete a resource on upgrade if it is annotated with
helm.io/resource-policy=keep. This can cause data loss for users
if the annotation is ignored(e.g. for a PVC)
Close #7677
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
6 years ago
ae508ebd1c
add unit test for ConfigMapDelete
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
6 years ago
95d7f36d41
add unit test for SecretDelete
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
6 years ago
af35d61a98
Add verification output to the verify command
...
This complements the verification output fixed in #7706 . On verify
there should be some detail about the verification rather than
no information.
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago
a3f92f65e2
Fixes verification output on pull command
...
When using the --verify flag on the pull command the output was
an internal Go object rather than useful detail. This is a bug.
The output new displays who signed the chart along with the
hash.
Fixes #7624
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago
1ab52fa79c
fix(helm): stdin values for helm upgrade --install
...
Signed-off-by: Matt Morrissette <yinzara@gmail.com>
6 years ago
13e2dcfde5
Fix dep build to be compatiable with Helm 2 when requirements use repo alias
...
Signed-off-by: Song Shukun <song.shukun@fujitsu.com>
6 years ago
ec2e77cded
Merge pull request #7648 from bacongobbler/fix-6794
...
feat(install): introduce --create-namespace
6 years ago
7fd30581b6
Merge pull request #7665 from TomasKohout/master
...
Printing name of chart that do not have requested import value.
6 years ago
b4f716413c
Printing name of chart that do not have requested import value.
...
Signed-off-by: Tomas Kohout <tomas.kohout@leveris.com>
6 years ago
f1f661d4ca
pkg/storage/records: add unit test for Exists
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
6 years ago
c96aff6a43
pkg/storage/records: add unit test for Index
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
6 years ago
6b1eebd23a
pkg/storage/records: add unit test for Get
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
6 years ago
e92a258a9d
fix(helm): add --skipCRDs flag to 'helm upgrade'
...
When 'helm upgrade --install' is run, this will allow to skip installing CRDs
Closes #7452
Signed-off-by: akash-gautam <gautam.akash04@gmail.com>
6 years ago
7f3339cb4e
feat(tests): Allow to provision memory driver
...
The memory driver is used for go tests. It can also be used from the
command-line by setting the environment variable HELM_DRIVER=memory.
In the latter case however, there was no way to pre-provision some
releases.
This commit introduces the HELM_MEMORY_DRIVER_DATA variable which
can be used to provide a colon-separated list of yaml files specifying
releases to provision automatically.
For example:
HELM_DRIVER=memory \
HELM_MEMORY_DRIVER_DATA=./testdata/releases.yaml \
helm list --all-namespaces
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
6 years ago
271cb2268b
Alternative: annotation-only solution
...
Signed-off-by: Jacob LeGrone <git@jacob.work>
6 years ago
a29365b3c6
Adopt resources into release with correct instance and managed-by labels
...
Signed-off-by: Jacob LeGrone <git@jacob.work>
6 years ago
64ce6e6a74
Merge pull request #7591 from ylvmw/master
...
IsReachable() needs to give detailed error message.
6 years ago
694cf61aac
feat(install): introduce --create-namespace
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
09f49458b0
Merge pull request #7608 from q384566678/add-gate-test
...
pkg/gates: add unit test for String
6 years ago
1ff7202a98
Fix output of list action when it is failed
...
Signed-off-by: Song Shukun <song.shukun@fujitsu.com>
6 years ago
4bd3b8fc06
Pass the apiserver address/port via cli, introduce HELM_KUBEAPISERVER envvar
...
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
6 years ago
eda60a59b6
pkg/helmpath: fix unit test for Windows
...
Signed-off-by: Song Shukun <song.shukun@fujitsu.com>
6 years ago
512e1b8bc9
Merge pull request #7401 from hiddeco/non-global-scheme-convert
...
fix(kube): use non global Scheme to convert
6 years ago
2cd3d12acd
Merge pull request #7530 from plenus-cloud/fix-7513
...
fix(helm): Don't wait for service to be ready when external IP are set
6 years ago
e9f40ed7a5
fix golint failure in pkg/action
...
Signed-off-by: Song Shukun <song.shukun@fujitsu.com>
6 years ago
0c9e99dce5
Merge pull request #7365 from fenggw-fnst/mybranch
...
Add corresponding unit test to the function in parser.go
6 years ago
03b04639f3
pkg/gates: add unit test for String
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
6 years ago
7b9dc71c25
Fix render error not being propogated
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
722042e852
Merge pull request #7570 from Maronee/upgradeOpenApiValidation
...
feat(upgrade): introduce --disable-openapi-validation:
6 years ago
54ca879095
IsReachable() needs to give detailed error message.
...
Signed-off-by: ylvmw <yngliu@vmware.com>
6 years ago
561971c381
feat(upgrade): introduce --disable-openapi-validation:
...
This is a copy of the --disable-openapi-validation flag from the install command as introduced by Matthew Fisher.
See commit 67e57a5fbb
6 years ago
afdfb75234
Pass kube user token via cli, introduce HELM_KUBETOKEN envvar
...
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
6 years ago
e41184a585
fix(kube): generate k8s native scheme only once
...
Signed-off-by: Hidde Beydals <hello@hidde.co>
6 years ago
b55224ebb9
fix(kube): use non global Scheme to convert
...
But instead use a newly initialized Scheme with only Kubernetes native
resources added. This ensures the 3-way-merge patch strategy is not
accidentally chosen for custom resources due to them being added
to the global Scheme by e.g. versioned clients while using Helm as a
package, and not a self-contained binary.
Signed-off-by: Hidde Beydals <hello@hidde.co>
6 years ago
5e638e3587
Revert "Do not delete templated CRDs"
...
This reverts commit 9711d1c6bf#7505 .
Signed-off-by: Benn Linger <benn@bennlinger.com>
6 years ago
af0007c908
fix(helm): improved logs
...
Signed-off-by: Federico Bevione <f.bevione@cognitio.it>
6 years ago
206d4a9053
add test for template recursion
...
Signed-off-by: Daniel Cheng <dcheng@us.ibm.com>
6 years ago
8528548441
fix recursion count in templates
...
Signed-off-by: Daniel Cheng <dcheng@us.ibm.com>
6 years ago
077503f175
fix(helm): Reworded logs for clarity
...
Signed-off-by: Federico Bevione <f.bevione@cognitio.it>
6 years ago
cf7a02fac7
chore(*): Removes support for searching the plugin dir
...
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
6 years ago
7a3049a418
chore(postrender): Adds unit tests for exec post renderer
...
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
6 years ago
08fc12a8c3
Adds post-render support
...
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
6 years ago
8e1fc4bc6f
fix(memory_test): rebase master
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
e24b21a3dc
Merge pull request #7543 from mattfarina/issue-7536
...
Fixes issue where non-CRDs are read in from the crd directory
6 years ago
b0a187756c
Merge pull request #7288 from mnkyl/lint-subcharts
...
feat(cmd/lint): added flag to lint dependent charts
6 years ago
be7de1c376
fix(cmd): Specify namespace for template command
...
The template command uses the memory driver. This driver now supports
namespaces, so the template code-path now specifies the namespace as
required by the memory driver.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
6 years ago
e6d2d10bad
fix(tests): Add namespace support to memory driver
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
6 years ago
98962dce3f
Merge pull request #7349 from tiendc/unit_test_memory_list
...
Add unit test for List() of pkg/storage/driver/memory.go
6 years ago
ed80cf4548
Fixes issue where non-CRDs are read in from the crd directory
...
For example, a readme markdown is read in and parsed
Closes #7536
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago
0dadbdc309
Merge pull request #7373 from Sh4d1/bypass_ns
...
add option to bypass kubeconfig namespace
6 years ago
c825a01435
Merge pull request #7440 from mtougeron/helm-template-write-crd-to-spec-file
...
Render the CRDs to output-dir files
6 years ago
671ceb5514
ref(kind_sorter): use an in-place sort for sortManifestsByKind, reduce code duplication
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
3582b03a91
Merge pull request #7542 from mattfarina/issue-7532
...
Fixes issue where <CHARTNAME> is left in starter values file
6 years ago
43e6285995
Fix engine.newFiles doc comment
...
Signed-off-by: Jon Huhn <huhnjon@gmail.com>
6 years ago
1bd819a7b2
Fixes issue where <CHARTNAME> is left in starter values file
...
This is a leftover bug from #7201 .
Closes #7532
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago
438eaec971
fix(helm): Don't wait for service to be ready when external IP are set
...
Resolves #7513
As the externalIPs are not managed by k8s (according to the doc: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.17/#servicespec-v1-core ) helm should not wait for services which set al least one externalIPs.
Signed-off-by: Federico Bevione <f.bevione@cognitio.it>
6 years ago
5ec70ab27f
fix(chart): lock digest differs when dependency build with Helm 2 and then Helm 3 ( #7261 )
...
* Fix issue with apiVersion v1 lock digest
When apiVersion v1 chart dependencies are built with Helm 2
and then built with Helm 3, the lock digests differ. To avoid
this issue, a depdendency update is forced.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Check against Helm v2 hash
Handle scenario where dependency hash was generated by Helm v2
but need to do a dependency build with Helm v3.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Add unit test
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Refactor unit test
Refactor unit test to use an existing chart as dependency
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Update after review
Comments:
- https://github.com/helm/helm/pull/7261#discussion_r373827088
- https://github.com/helm/helm/pull/7261#discussion_r373827250
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
e78402d559
fix conflicts
...
Signed-off-by: Mike Tougeron <tougeron@adobe.com>
6 years ago
7ce29e12fa
ref(go.mod): oras v0.8.1 ( #6862 )
...
* ref(go.mod): oras v0.8.1
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* update various module versions
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* upgrade oras v0.8.1
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* upgrade to oras 0.8.1 release
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* lock to oras release (0.8.1)
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
6 years ago
3ff3dabd9e
Merge pull request #6819 from bacongobbler/disable-openapi-validation
...
feat(install): introduce --disable-openapi-validation
6 years ago
084ab20f67
feat(template): Allow template output to use release name ( #7503 )
...
* Allow template output to use release name
helm template output command uses the chart name only when writing
templates to disk. This changes will also use the release name
to avoid colloiding the path when output nore than one release
of smae chart.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Update after review
Comment:
- https://github.com/helm/helm/pull/7503/files#r374130090
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
d03db32c25
fixed dependencies processing in case of helm install or upgrade for disabled/enabled sub charts
...
Signed-off-by: Florian Hopfensperger <f.hopfensperger@gmail.com>
6 years ago
df20164cd2
Fix tests on arm64 and ppc64le ( #7500 )
...
Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
6 years ago
5c7bf8e015
Merge pull request #7474 from bacongobbler/fix-7473
...
fix(lookup_func): do not return error when object is not found
6 years ago
1b1d6bba9c
fix(lookup_func): do not return error when object is not found
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
d70b50b3a1
Fix typo
...
Signed-off-by: Jon Huhn <huhnjon@gmail.com>
6 years ago
Martin Hickey
Kim Bao Long
tiendc
Marc Khouzam
Matt Farina
Jacob LeGrone
James McElwain
Mikhail Gusarov
Matt Butcher
Matthias Riegler
Matthew Fisher
Song Shukun
Dong Gang
Zhou Hao
Matt Morrissette
Tomáš Kohout
akash-gautam
Vibhav Bobade
Taylor Thomas
ylvmw
Sebastian Voinea
Hidde Beydals
Benn Linger
Federico Bevione
Daniel Cheng
Jon Huhn
Mike Tougeron
Josh Dolitsky
Florian Hopfensperger
Yaakov Selkowitz