Brandt Keller
f6f8700a53
fix(client): skipnode utilization for PreCopy
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
(cherry picked from commit a18a52e898
)
4 months ago
Brandt Keller
4da701593f
fix(client): layers now returns manifest - remove duplicate from descriptors
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
(cherry picked from commit b07ab77da3
)
4 months ago
Brandt Keller
1a8507fd5a
fix(client): return nil on non-allowed media types
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
(cherry picked from commit c225c124ac
)
4 months ago
Benoit Tigeot
015531ca4f
Prevent fetching newReference again as we have in calling method
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit c33215d765
)
4 months ago
Benoit Tigeot
9db1a120f9
Prevent failure when resolving version tags in oras memory store
...
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.
I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.
Close : #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit f552b67230
)
4 months ago
Benoit Tigeot
e8bfa0eed6
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
(cherry picked from commit dce60adb51
)
4 months ago
Benoit Tigeot
24b44902a2
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
(cherry picked from commit cda0865d64
)
4 months ago
Benoit Tigeot
7e8f53421a
Wait for Helm v4 before raising when platformCommand and Command are set
...
same for `PlatformHooks` and `hooks`.
When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.
See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270
Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit 5d9d9a0fb8
)
4 months ago
Scott Rigby
ea04cea48b
Fix 3.18.0 regression: registry login with scheme
...
Helm 3.18.0 released an upgrade of ORAS from v1 to v2.
ORAS v2 correctly does not accept http/https scheme for registry login, while
ORAS v1 previously did. Even if v1 should not have, we want to preserve
backwards compatibility for Helm 3 users who pass the scheme.
This will be removed in Helm 4, where registry login will not accept http/https
scheme.
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
(cherry picked from commit c0f3ace52d
)
4 months ago
Matt Farina
bec66098fd
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
...
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit c5249c1f8d
)
4 months ago
Robert Sirchia
d8edc2aebc
bump version to v3.18.0
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
5 months ago
Terry Howe
cdd7c105a6
docs: Note about http fallback for OCI registries
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
Scott Rigby
e4bc4a31b9
Merge pull request #30768 from banjoh/em/fix-take-ownership
...
v3 backport - fix --take-ownership
5 months ago
Benoit Tigeot
087fa18276
Bump toml
...
Looking at the [toml diff](https://github.com/BurntSushi/toml/compare/v1.4.0...v1.5.0 ). I think it's safe to change the test here.
For main: https://github.com/helm/helm/pull/30775
Closes: https://github.com/helm/helm/pull/30683
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Evans Mungai
0906fe7f6b
Add install test for TakeOwnership flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Patrick Seidensal
4ee3a19e9a
Fix --take-ownership
...
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.
This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.
By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.
Fixes #30622
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 months ago
Matt Farina
3ce10e4f81
Unarchiving fix
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 7cc4dcf94ee410c8e0d64f3e726dda199c24ccb2)
6 months ago
Benoit Tigeot
422c58e4a2
Fix typo
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
5e7f12d4c3
Report as debug log, the time spent waiting for resources
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Terry Howe
1435ec7c77
Update pkg/registry/fallback.go
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Terry Howe
674e882c88
automatic fallback to http
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Terry Howe
c188441757
chore(oci): upgrade to ORAS v2
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Scott Rigby
bcb83e465f
Fix cherry-pick helm.sh/helm/v4 -> helm.sh/helm/v3
...
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Chris Berry
2aa90b8f26
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
5739197faa
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
b8e13878fc
Add HookOutputFunc and generic yaml unmarshaller
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Scott Rigby
97b0e11871
clarify fix error message
...
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
2f79afb0a3
fix err check
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
c77f4ec6c4
remove comments about previous functionality
...
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
3cd6afe845
add short circuit return
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Chris Berry
5367001f4f
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
3c445158d8
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
4cb639ed4e
Fix lint
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris
20f859c9ff
Tidy up imports
...
Signed-off-by: Chris <bez625@gmail.com>
7 months ago
Chris Berry
ca90972b3d
Add hook annotations to output pod logs to client on success and fail
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Matt Farina
e2c7986f30
Merge pull request #13534 from althmoha/dev-v3-12987
...
fix (helm) : toToml` renders int as float [ backport to v3 ]
8 months ago
George Jenkins
80f87ab636
Merge pull request #13654 from ryanhockstad/subchart-null
...
[backport] bugfix: Override subcharts with null values
8 months ago
Matt Farina
9aff8bdaa0
Merge pull request #13644 from mattfarina/backport-13583
...
fix: check group for resource info match (v3 backport)
8 months ago
George Jenkins
6ed9d2f2d5
Merge pull request #13592 from stevehipwell/add-plugin-platform-hooks-v3
...
feat: Add multi-platform plugin hook support [v3 backport]
8 months ago
Jiasheng Zhu
2ebce786ba
fix: check group for resource info match
...
Closes : #13582
Signed-off-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com>
(cherry picked from commit f5d488122b
)
8 months ago
Ryan Hockstad
326c1e3f67
add test for nullifying nested global value
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
8 months ago
Matt Farina
fba9d08dce
Ensuring the file paths are clean prior to passing to securejoin
...
securejoin v0.4.0 made a possibly breaking change. Only clean paths
are safe to pass to SecureJoin or they could return an error or
have the wrong path. The details are in the release notes for v0.4.0.
This change ensures the paths are clean prior to passing to SecureJoin.
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 35a9ead998
)
8 months ago
Matt Farina
d6db69ed66
bump version to v3.17.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 301108edc7
)
9 months ago
Ryan Hockstad
ef2eb55283
Add test case for removing an entire object
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
9 months ago
Scott Rigby
60fcce18d1
Tests for bugfix: Override subcharts with null values #12879
...
- Add consistency for null test in given values, parent chart, subchart, and
sub-sub-chart
- Remove bar null test to keep consistent with boat=null at top level
Signed-off-by: Scott Rigby <scott@r6by.com>
9 months ago
Andrew Block
83dddb1839
feat: Added multi-platform plugin hook support to v3
...
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
9 months ago
Terry Howe
949b2e6040
fix: make ORAS reference private
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit d2b94f6200
)
9 months ago
Terry Howe
aba95b9cb4
fix: issue with helm template and oci chart
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit aca7e8d775
)
9 months ago
Terry Howe
c3e5217d85
feat: allow installation by OCI digest
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit ad9fb68fa3
)
9 months ago
Matt Farina
9ade3b502a
Merge pull request #13574 from gjenkins8/v3_13343
...
Add annotations and dependencies to get metadata output [v3 backport]
9 months ago