This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Closes#30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit c5249c1f8d)
Multiple changes were made to pass linting. Some Go built-in names
are being used for variables (e.g., min). This happens in the Go
source itself including the Go standard library and is not always
a bad practice.
To handle allowing some built-in names to be used the linter config
is updated to allow (via opt-in) some names to pass. This allows us
to still check for re-use of Go built-in names and opt-in to any
new uses.
There were also several cases where a value was checked for nil
before checking its length when this is already handled by len()
or the types default value. These were cleaned up.
The license validation was updated because it was checking everything
in the .git directory including all remote content that was local.
The previous vendor directory was from a time prior to Go modules
when Helm handled dependencies differently. It was no longer needed.
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 5727f56a96)
The output of helm get metadata includes a subset of the fields contained in
the chart.Metadata struct. This change adds the values of the annotations field
and the dependencies field to the output.
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
When #13531 was merged in the tests were not passing. This is because
it took into account #13444 but that had not been backported to v3.
Tests had not been automatically run on dev-v3 but that was fixed
via #13563.
Signed-off-by: Matt Farina <matt.farina@suse.com>
The `TakeOwnership` setting was added to the install and upgrade actions in
https://github.com/helm/helm/pull/12876
This PR allows setting this option on install and upgrade via the CLI
using a --take-ownership flag
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
In the event some malformed folders/files make its way into the
`charts/` directory meant for subcharts, it is possible one may see an
error message like the below:
```
Error: error unpacking foo in app: Chart.yaml file is missing
```
This error is not very descriptive, as it doesn't reference where on
disk `Chart.yaml` is missing. In the event this happens, this error is
being updated to include that `Chart.yaml` is missing for the `foo`
subchart.
Without this updated error messaging, one would need to look into Helm's
codebase to troubleshoot what exactly is wrong.
Signed-off-by: Taylor Jasko <taylor@taylorjasko.com>
The result is that when doing shell completion (bash and zsh only),
instead of getting no suggestions for commands that take no more
arguments, the user will instead be shown an informative message:
$ helm list <TAB>
This command does not take any more arguments (but may accept flags).
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
Matt Farina
Robert Sirchia
Rongrong Liu
Terry Howe
Scott Rigby
Chris Berry
Evans Mungai
Matt Farina
George Jenkins
Andrew Block
Niladri Halder
Althaf M
Mayank Shah
Taylor Jasko
myeunee
Yarden Shoham
Nathan Baulch
Giulio
Marc Khouzam