Matthew Fisher
37f7cc0851
Merge pull request #4917 from derkoe/dev-v3-fix-requirement-condition
...
fix(pkg/chartutil): conditions for alias and umrella charts (#3734 )
6 years ago
Bhavesh Sethi
0c43fc9175
go formatted - (gofmt)
...
Signed-off-by: Bhavesh Sethi <bhaveshsethi1611@gmail.com>
6 years ago
Bhavesh Sethi
951a5d1b9c
update test files to account for added field
...
Signed-off-by: Bhavesh Sethi <bhaveshsethi1611@gmail.com>
6 years ago
Bhavesh Sethi
40962b1be7
add appVersion field to output
...
Signed-off-by: Bhavesh Sethi <bhaveshsethi1611@gmail.com>
6 years ago
Taylor Thomas
0ca3840714
Merge pull request #6444 from mumoshu/fix-no-hooks-flag
...
fix(v3): `helm template` output should include hooks by default
6 years ago
Martin Hickey
26dacf84aa
feat(cmd): Port child NOTES.txt rendering to Helm 3 ( #6512 )
...
* Port Helm 2 PR 4088 to Helm 3
Not a direct port as is but refactored for Helm 3.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Update unit test to test string retunred for different order
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Martin Hickey
db15a6f898
Create charts directory for scaffold chart ( #6516 )
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Yusuke Kuoka
5c18e1b89f
fix(helm3): `helm template` output should include hooks by default
...
This fixes `helm template [--no-hooks]` to work like proposed in #6443
Manually tested with running `helm template` against `stable/mysql` chart with helm 2, helm 3.0.0-beta.3, and helm 3 after this fix.
The manual test report follows. Assume `helmv3` is 3.0.0-beta.3 and `helmv3-nohooksfix` is the binary build from this PR.
```
$ helmv3 fetch stable/mysql
$ helmv3 template mysql-1.3.1.tgz > helm-template-mysql-helm-3.yaml
$ helmv3-nohooksfix template mysql-1.3.1.tgz > helm-template-mysql-helm-3-with-fix.yaml
$ helmv3-nohooksfix template --no-hooks mysql-1.3.1.tgz > helm-template-mysql-helm-3-with-fix-nohooks-enabled.yaml
```
The example below shows that this fix changes `helm template` to output hooks by default:
```
$ diff --unified helm-template-mysql-helm-3{,-with-fix}.yaml
--- helm-template-mysql-helm-3.yaml 2019-09-17 22:21:38.000000000 +0900
+++ helm-template-mysql-helm-3-with-fix.yaml 2019-09-17 22:21:53.000000000 +0900
@@ -13,10 +13,10 @@
type: Opaque
data:
- mysql-root-password: "VGtybWh5N3JnWA=="
+ mysql-root-password: "aGpHN2VEbnhvVA=="
- mysql-password: "OTNQSXdNVURBYw=="
+ mysql-password: "UmpwQkVuMHpoQQ=="
---
# Source: mysql/templates/tests/test-configmap.yaml
apiVersion: v1
@@ -167,3 +167,48 @@
claimName: RELEASE-NAME-mysql
# - name: extras
# emptyDir: {}
+---
+# Source: mysql/templates/tests/test.yaml
+apiVersion: v1
+kind: Pod
+metadata:
+ name: RELEASE-NAME-mysql-test
+ namespace: default
+ labels:
+ app: RELEASE-NAME-mysql
+ chart: "mysql-1.3.1"
+ heritage: "Helm"
+ release: "RELEASE-NAME"
+ annotations:
+ "helm.sh/hook": test-success
+spec:
+ initContainers:
+ - name: test-framework
+ image: "dduportal/bats:0.4.0"
+ command:
+ - "bash"
+ - "-c"
+ - |
+ set -ex
+ # copy bats to tools dir
+ cp -R /usr/local/libexec/ /tools/bats/
+ volumeMounts:
+ - mountPath: /tools
+ name: tools
+ containers:
+ - name: RELEASE-NAME-test
+ image: "mysql:5.7.14"
+ command: ["/tools/bats/bats", "-t", "/tests/run.sh"]
+ volumeMounts:
+ - mountPath: /tests
+ name: tests
+ readOnly: true
+ - mountPath: /tools
+ name: tools
+ volumes:
+ - name: tests
+ configMap:
+ name: RELEASE-NAME-mysql-test
+ - name: tools
+ emptyDir: {}
+ restartPolicy: Never
```
The example below shows that `helm template --no-hooks` can be used for excluding hooks:
```
$ diff --unified helm-template-mysql-helm-3{,-with-fix-nohooks-enabled}.yaml
--- helm-template-mysql-helm-3.yaml 2019-09-17 22:21:38.000000000 +0900
+++ helm-template-mysql-helm-3-with-fix-nohooks-enabled.yaml 2019-09-17 22:22:03.000000000 +0900
@@ -13,10 +13,10 @@
type: Opaque
data:
- mysql-root-password: "VGtybWh5N3JnWA=="
+ mysql-root-password: "Zk1LYUd6OWgzaQ=="
- mysql-password: "OTNQSXdNVURBYw=="
+ mysql-password: "OTZPZU9hdlFORg=="
---
# Source: mysql/templates/tests/test-configmap.yaml
apiVersion: v1
```
Fixes #6443
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
6 years ago
Taylor Thomas
3fa4465eec
Merge pull request #6502 from VilledeMontreal/feat-v3/compRenamedBin
...
v3: Support auto-complete of a renamed helm binary
6 years ago
Marc Khouzam
c225b60307
Avoid string concatenation
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
6 years ago
Taylor Thomas
15d277360e
Merge pull request #6504 from thomastaylor312/feat/output
...
feat(*): Ports all output functionality from v2
6 years ago
Martin Hickey
caa26c4bb2
Change release storage name to use helm storage type as prefix ( #6500 )
...
* Change release storage name to prefix helm storage type
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Add comments about the Kubernetes storage object type field content
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Adam Reese
fef60966f6
Merge pull request #6400 from adamreese/ref/envvars
...
ref(pkg/cli): refactor environment variable setup
6 years ago
Taylor Thomas
eac6a60001
feat(*): Ports all output functionality from v2
...
As part of this port, I removed some now superfluous code from the `action` package.
This is technically a breaking change, but since the package was introduced in v3, it
is highly unlikely anyone is using it and we are still within the beta window.
Also closes #6437
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
6 years ago
Adam Reese
d3805a1d54
ref(pkg/cli): refactor environment variable setup
...
This change sets proper defaults based on environment variables for
global settings and plugin environments.
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Taylor Thomas
85572df378
Merge pull request #6494 from thomastaylor312/feat/set_file
...
feat(*): Ports `--set-file` flag to v3
6 years ago
Matthew Fisher
7928803ace
Merge pull request #6492 from bacongobbler/port-5678
...
fix(cmd): lock repository file during `helm repo add`
6 years ago
Matthew Fisher
3fa07d572f
fix(cmd): lock repository file during `helm repo add`
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Marc Khouzam
b3857b5d80
feat(comp): auto-complete of a renamed helm binary
...
If a user renames the helm binary, the shell needs to be told that this
new name corresponds to the helm completion function. For example if
the user decides to rename the helm v3 binary to 'helm3', then the
following command extra command would need be run by the user:
complete -o default -F __start_helm helm3.
This commit automates this by adding this extra command to the generated
shell completion script by looking at what binary was used to call the
helm completion command. For example, if the user renames the binary
to helm3 and then calls
helm3 completion bash
the completion script will include a hook for the binary 'helm3' to
the completion script.
A binary rename is one of the two options recommended when users need to
run both helm2 and helm3.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
6 years ago
Marc Khouzam
681eab83f9
feat(comp): have zsh completion generation re-use bash code
...
This allows that any addition to the bash completion logic be
automatically added to the zsh logic.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
6 years ago
Matthew Fisher
261e5b00ac
Merge pull request #6491 from bacongobbler/port-5700
...
fix(action): typo
6 years ago
Matthew Fisher
7817fe2a2f
Merge pull request #6493 from bacongobbler/port-5496
...
feat(cmd): implement `helm get --template`
6 years ago
Matthew Fisher
e7f81f204a
Merge pull request #6495 from bacongobbler/port-5192
...
ref(CONTRIBUTING): port over changes from Helm 2
6 years ago
Taylor Thomas
1b9cc69da5
Merge pull request #6496 from thomastaylor312/fix/digest_err
...
fix(provenance): Ports error check for `Digest` to v3
6 years ago
Taylor Thomas
9b87721c1f
fix(provenance): Ports error check for `Digest` to v3
...
This is a port of #5672
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
6 years ago
Matthew Fisher
56f27547c4
ref(CONTRIBUTING): port over changes from Helm 2
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Taylor Thomas
7599c5d489
feat(*): Ports `--set-file` flag to v3
...
I made a few modifications from the original code to fit in with the new
code layout and to clarify a few things. This is a port of #3758
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
6 years ago
Matthew Fisher
05d93b2c7a
feat(cmd): implement `helm get --template`
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Matthew Fisher
faa9048580
Merge pull request #6486 from bacongobbler/fix-6452
...
fix(action): invalidate discovery client cache on startup
6 years ago
Matthew Fisher
9742c8c5a2
fix(action): typo
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Taylor Thomas
6419ff6961
Merge pull request #6480 from thomastaylor312/feat/cleanup_on_fail
...
feat(*): Ports `--cleanup-on-fail` to v3
6 years ago
Matthew Fisher
1b0b843d6a
fix(action): invalidate discovery client cache on startup
...
we want to force a cache invalidation to ensure that the Capabilities object always has the latest information from the server (Kubernetes server version, available API versions, etc). `kubectl version` forces a cache invalidation every time it's invoked, so this seems like a safe change that is identical to kubectl's behaviour.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Matthew Fisher
3e891dbde9
Merge pull request #6425 from AndiDog/helm-template-no-reachability-check
...
Fix reachability check which must be disabled for `helm template` (unless `--validate` is specified)
6 years ago
Matt Farina
22a84078f5
Merge pull request #6472 from VilledeMontreal/feat-v3/dynCompDifferentHelm
...
v3: Dynamic completion to handle env with both helm2 and helm3
6 years ago
Marc Khouzam
2db09189f4
Simplify logic
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
6 years ago
Marc Khouzam
d50e2a3134
Merge branch 'dev-v3' into feat-v3/dynCompDifferentHelm
6 years ago
Matthew Fisher
64521d00da
Merge pull request #6479 from bacongobbler/fix-6356
...
fix(list): scrub list returned from .List()
6 years ago
Taylor Thomas
17854e83af
feat(*): Ports `--cleanup-on-fail` to v3
...
This ports the functionality of cleanup on fail to v3 as introduced in #4871 . This has been tested manually
and would be a good candidate for a new acceptance test.
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
6 years ago
Matthew Fisher
4971ed5077
fix(list): scrub list returned from .List()
...
This way only the latest release is displayed with `helm list`.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Taylor Thomas
d95a6246a4
Merge pull request #6430 from karuppiah7890/fix-install-storing-computed-values
...
fix install storing computed values in release instead of user supplied values
6 years ago
Matt Farina
4ee8db2208
Merge pull request #6470 from VilledeMontreal/fix/dynCompStderr
...
v3: fix(completion): Redirect stderr must be before pipes
6 years ago
Marc Khouzam
a46694c8d6
Dynamic completion to use same binary as main call
...
The binary of Helm to use for dynamic completion should be the same
as the actual Helm binary being used. For example, if PATH points
to a version of helm v2, but the user calls bin/helm to use a local
v3 version, then dynamic completion should also use bin/helm.
If not, in this example, the dynamic completion will use the
information returned by helm v2.
This improvement is particularly useful for users that will run both
helm v2 and helm v3 at the same time.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
6 years ago
Marc Khouzam
e0a119c662
fix(completion): Redirect stderr must be before pipes
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
6 years ago
Matt Farina
e38b414bc8
Merge pull request #6408 from VilledeMontreal/feat-v3/dynCompGlobalFlags
...
feat-v3(cli): Dynamic completion for global flags
6 years ago
Taylor Thomas
249221191e
Merge pull request #6463 from thomastaylor312/chore/deprecate_recreate_pods
...
chore(cmd): Deprecates --recreate-pods flag
6 years ago
Taylor Thomas
45e27d4571
chore(cmd): Deprecates --recreate-pods flag
...
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
6 years ago
Matt Farina
9a592e5379
Merge pull request #6448 from oneilcin/fix-ingress-extensions
...
handle ingress apiVersion change for kubernete versions
6 years ago
Cindy O'Neill
41e9359716
handle ingress apiVersion change for kubernete versions
...
Signed-off-by: Cindy O'Neill <cubiedoo2@gmail.com>
6 years ago
Matt Farina
68baa494b1
Merge pull request #6455 from mattfarina/update-v3-contributing
...
Moving from CLA to DCO in contribution guide
6 years ago
Matt Farina
4eae3bb3fc
Moving from CLA to DCO in contribution guide
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago