Turns out that removing the quotes from the associate array
'aliashash' is still required, but because it is needed for
completion of alias commands. For example
helm dep <TAB>
does not complete as expected (as if it was 'helm dependency')
if the quotes are not removed.
This is because although bash ignores quotes when using
associative arrays, zsh does not. So when looking for an alias
aliashash[dep]
will not match the entry
aliashash["dep"]
in zsh but will for bash. Therefore, removing the quotes fixes
things.
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
This reverts commit d2ab3f5062.
The reverted commit turned out to be a workaroud another problem.
The real fix is submitted in PR #5680
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
This will enable the detection of specific objects including CRDs
that may vary widely between kubernetes clusters
Signed-off-by: Matt Farina <matt@mattfarina.com>
Built-in function 'tuple' is implemented in Sprig as 'list'.
(see 2625cd487a/functions.go (L237) )
Replace documentation references to 'tuple' with 'list' so there
is no need to explain what a tuple is.
Signed-off-by: Daniel Badea <daniel.badea@windriver.com>
Built-in objects listed in the previous sections are: Release, Values, Chart, Files, Capabilities and Template. Text here refers to four built-in objects.
Signed-off-by: Daniel Badea <daniel.badea@windriver.com>
- Add ability to test for nested non-existent keys
- Add test cases for nested null values
- Minimalist fix for nested null key test cases
- Add missing metadata to integration test
Signed-off-by: Adam Eijdenberg <adam.eijdenberg@digital.gov.au>
Signed-off-by: Andreu Gallofre <andreugallofre@gmail.com>
Change the label sizing in CONTRIBUTING.md
Change the label size and merging conditions to match the actual labels
and conditions used
Signed-off-by: Andreu Gallofre <andreugallofre@gmail.com>
Add requested changes
Add missing dot, removes duplicated information and change requirements
for merging size/L
Signed-off-by: Andreu Gallofre <andreugallofre@gmail.com>
PR #5072 followed by #5406 tweaked the handling of the associative
array 'aliashash' when in zsh. However, upon further investigation
the root of the problem was the 'aliashash' was not being declared
properly as it was declared within a method and therefore not
accessible to the rest of the completion script.
The previous commit of this PR makes the necessary change to properly
declare 'aliashash' which makes the previous tweak unecessary. This
commit removes the tweak.
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
Patrik Fuhrmann
Martin Hickey
Deepak Sattiraju
Matt Farina
Marc Khouzam
Matthew Fisher
Xiang Dai
Ace Eldeib
Tim Schrumpf
Daniel Badea
Alex Khaerov
Scott Rigby
Adam Eijdenberg
Justin Scott
Andreu Gallofre
Tariq Ibrahim
Per Hermansson
dev-chulbuji
Morten Torkildsen
ialidzhikov