This is the fix for only one particular, but important case.
The case when a new resource has been added to the chart and
there is an error in the chart, which leads to release failure.
In this case after first failed release upgrade new resource will be
created in the cluster. On the next release upgrade there will be the error:
`no RESOURCE with the name NAME found` for this newly created resource
from the previous release upgrade.
The root of this problem is in the side effect of the first release process,
Release invariant says: if resouce exists in the kubernetes cluster, then
it should exist in the release storage. But this invariant has been broken
by helm itself -- because helm created new resources as side effect and not
adopted them into release storage.
To maintain release invariant for such case during release upgrade operation
all newly *successfully* created resources will be deleted in the case
of an error in the subsequent resources update.
This behaviour will be enabled only when `--cleanup-on-fail` option used
for `helm upgrade` or `helm rollback`.
Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
When checking version and desired version is not set, we follow
redirected URL of github latest release to get the latest tag instead of
trying to get the tag value from html content.
Closes#5480
Signed-off-by: Arief Hidayat <mr.arief.hidayat@gmail.com>
Github recently changed the output of the releases page.
grepping for the exact <a> tag fixes the issue where the wrong tag was being filtered.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
There was a typo in a tiller error with "released named" message, I've changed it to "a release named". Also fix a unit-test for it.
Signed-off-by: Mikhail Kirpichev <mkirpic@gmail.com>
In the quickstart guide, --max-history is recommended as parameter for helm init. The actual name of the parameter is --history-max.
Signed-off-by: Jens Frank <jf@mormo.org>
Normally zsh arrays start at index 1 but when emulating other shells
this may change. During completion, we run the command
emulate -L sh
which affects the indexing of zsh arrays to make it start at 0.
Consequently, when replacing FUNCNAME by funcstack, we should not
change the index.
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
Cobra provides some out-of-the-box debugging for bash completion.
To use it, one must set the variable BASH_COMP_DEBUG_FILE to
some file where the debug output will be written. Many of the
debug printouts indicate the current method name; they do so
by using bash's ${FUNCNAME[0]} variable. This variable is
different in zsh. To obtain the current method name in zsh
we must use ${funcstack[1]}.
This commit adds the proper sed modification to convert from
bash to zsh.
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
Update to the latest Sprig version, which is a reversion of some of
the functions added in 2.18.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
Matthew Fisher
Xiangxuan Liu
Mike Eves
Pavel Eremeev
ialidzhikov
Devin Burnette
Fernando Barbosa
Timofey Kirillov
Arief Hidayat
tariqibrahim
Mikhail Kirpichev
tariqibrahim
robertavram
Adam Reese
Jens Frank
Marc Khouzam
Luis Davim
Joe Lanford
Matt Butcher
Martin Hickey
Patrick Decat
Marc Khouzam
anton
Jacob LeGrone