Neven Miculinic
4827ca1f16
Fix install memory/goroutine leak
...
Signed-off-by: Neven Miculinic <neven.miculinic@gmail.com>
(cherry picked from commit 5059ae843e
)
3 years ago
David Peraza
9661e39dce
Moving uploader and pusher out of action into pkg
...
Signed-off-by: David Peraza <dperaza@redhat.com>
3 years ago
David Peraza
7cab1a09e3
Move all the remainder module out of experimental.
...
All the experimental modules were moved to pkg/action
Signed-off-by: David Peraza <dperaza@redhat.com>
3 years ago
Thomas Runyon
353d74e967
refactor internal/experimental/registry to pkg/registry
...
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
3 years ago
Matt Farina
548ec55cf9
Fix panic with OCI for install, upgrade, and show
...
When range support for OCI went in via #10527 it created a situation
where some lookups for a chart could cause a panic. This change
makes sure the registry client is available to lookup OCI charts
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Andrew Block
1a9cb93551
Handling name of OCI file
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Scott Rigby
4d50526a2b
Move OCI tag semver range logic from OCIGetter to ChartDownloader
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Andrew Block
4f62d3dc1b
Started work on 'helm pull'
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
df98e18eb7
Working oci code without providing versions
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
mengjiao.liu
160da867d0
validate release name during install
...
Signed-off-by: mengjiao.liu <mengjiao.liu@daocloud.io>
3 years ago
Jerome Küttner
9a492f8240
Channel should remain open if there is still a routine that wants to write into it
...
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 years ago
Jerome Küttner
ad3d2cc8ef
Fix memory leak in upgrade action
...
fixes helm/helm#10439
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 years ago
Matthew Fisher
a8d33e7df4
Merge pull request #9918 from cndoit18/fix-issue-9915
...
fix(install): fix 9915
3 years ago
Timofey Kirillov
7f68bfa1fa
fix: added resource info into the validation error
...
Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
3 years ago
Guangwen Feng
9b7a45a384
Fix a golint issue caused by typo
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
3 years ago
Alexey Igrychev
5753f61ae3
docs: fix typo Charts.yaml
...
Signed-off-by: Alexey Igrychev <alexey.igrychev@flant.com>
3 years ago
cndoit18
da15d96a68
fix(install): if subcharts are disabled, the CRD for subcharts should not be installed
...
Signed-off-by: cndoit18 <cndoit18@outlook.com>
3 years ago
Matt Farina
accf82ba1c
Merge pull request #9180 from Moser-ss/feature-handle-SIGINT
...
Handle SIGTERMs during helm upgrade and helm install
3 years ago
Matt Farina
2062a59566
Merge pull request #9702 from mikeshng/uninstall-wait
...
feat: add optional boolean '--wait' flag to 'uninstall' command.
3 years ago
Josh Dolitsky
caa97158d0
Revert moving registry actions back to pkg/
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago
Josh Dolitsky
77750962d5
Move registry actions back to pkg/
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago
Mike Ng
75fe8883cc
Rename newly introduced interface to InterfaceExt
...
Signed-off-by: Mike Ng <ming@redhat.com>
3 years ago
Mike Ng
d51a61f9ab
Introduce a new interface for WaitForDelete() to avoid breaking backwards compatibility
...
Signed-off-by: Mike Ng <ming@redhat.com>
3 years ago
Josh Dolitsky
0121f6a328
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago
Mike Ng
655bdcd2fd
feat: add optional boolean '--wait' flag to 'uninstall' command.
...
If set, 'uninstall' command will wait until all the resources are deleted before returning.
It will wait for as long as --timeout
closes #2378
Signed-off-by: Mike Ng <ming@redhat.com>
3 years ago
Matt Farina
0ff53945bf
Fixing issue where helm show all fails to show crds when no readme
...
Closes #10058
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Matt Farina
9443a7ead4
Merge pull request #10033 from avorima/show-crds-command
...
Implement show crds subcommand
3 years ago
John Howard
82a2abf512
Update oras-go to v0.4.0
...
Signed-off-by: John Howard <howardjohn@google.com>
3 years ago
Mario Valderrama
fae7853c2a
Implement show crds subcommand
...
This subcommand will display manifests under `crds/` if some exist.
This also changes the behaviour of `show all` to include CRDs.
Signed-off-by: Mario Valderrama <woldy401@gmail.com>
3 years ago
Stephane Moser
c62ce12bed
Refactor SIGTERM logic
...
Use context to handle SIGTERM in the cmd/helm instead of pkg/action
Signed-off-by: Stephane Moser <moser.sts@gmail.com>
3 years ago
Nicolas De Loof
663c569887
Migrate to oras-go library
...
see https://github.com/deislabs/oras/pull/265
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
3 years ago
Stephane Moser
7bfb2a3602
Improve tests
...
Rename the package time
Redesgin the logic to make a FakeKubeClient wait for a ammount time.
Remove unneed logic in the PrintingKubeClient
Signed-off-by: Stephane Moser <moser.sts@gmail.com>
3 years ago
Stephane Moser
2164e3f26c
Rename time dependecy
...
Signed-off-by: Stephane Moser <moser.sts@gmail.com>
3 years ago
Josh Dolitsky
d296ddf026
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago
Kally Fox
f9b1445b63
refactor: use os instead of ioutil's ReadDir
...
Signed-off-by: Kally Fox <kallydev@gmail.com>
3 years ago
Stephane Moser
c6c4157c43
Move locks from global var to the structs
...
Signed-off-by: Stephane Moser <moser.sts@gmail.com>
3 years ago
Stephane Moser
660183d659
Add test for atomic upgrade and install when it is interrupted
...
Add tests when the install release is Interrupted and the flag Wait or Atomic is set
Signed-off-by: Stephane Moser <moser.sts@gmail.com>
3 years ago
Stephane Moser
2fa339b25d
Add test for Upgrade Release Interrupted
...
Implement timer in the fake.go and printer.go to simulate the wait period
Add test Upgrade Release when it is interruped with SIGINT
Signed-off-by: Stephane Moser <moser.sts@gmail.com>
3 years ago
Stephane Moser
3434053d38
Hande SIGINT in install command
...
Replicate the same logic in that was implementd in the upgrade action to handle SIGINT
Rename mutexes to isolate the variables
Signed-off-by: Stephane Moser <moser.sts@gmail.com>
3 years ago
Stephane Moser
d7833eb2b0
Refactor logic
...
Use mutex to lock the action to report the upstream function
Wrap logic to report to upstream function in the function reportToPerformUpgrade
Signed-off-by: Stephane Moser <moser.sts@gmail.com>
3 years ago
Stephane Moser
027cea48bf
Handle SIGTERM
...
Change the logic to release Upgrade to handle SIGTERMs
Extract logic to 2 goroutine so it is possible to handle SIGTERMS and the release flow
Fix go style
Signed-off-by: Stephane Moser <moser.sts@gmail.com>
3 years ago
Josh Dolitsky
230e37ca52
remove hardcoded oci strings, add constant/util
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago
Josh Dolitsky
3e17c1a7ef
remove action errors assuming CLI
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago
Josh Dolitsky
eba63beab1
move experimental actions to new internal package
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago
Josh Dolitsky
24a216d3b2
move pkg/uploader, pkg/pusher to internal
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago
Josh Dolitsky
cd27cf660f
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago
Matt Farina
17ed9c4cd3
tweak basic handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Josh Dolitsky
4e7a01fa7a
Merge branch 'main' of github.com:helm/helm into hip-6
3 years ago
Martin Hickey
281380f31c
Merge pull request #9659 from mladedav/feature/upgrade-dep-up
...
Feature/upgrade dep up
3 years ago
Josh Dolitsky
00985cad6b
Implement changes proposed in HIP 6
...
For more information, please see the following URL:
https://github.com/helm/community/blob/main/hips/hip-0006.md
Note: OCI support remains experimental, and you are still
required to set HELM_EXPERIMENTAL_OCI=1 in your environment.
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago