Joe Lanford
98d98369ed
Add ReadyChecker to decouple ready check logic from --wait
...
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
3 years ago
James McElwain
54410194a6
closes #9312
...
Because backOffLimit can be 0, a zero value for pod status failed will
always cause the condition to return true.
Signed-off-by: James McElwain <jmcelwain@gmail.com>
4 years ago
Matt Farina
f5ef87b96e
Merge pull request #8363 from zh168654/master
...
helm upgrade with --wait support jobs in manifest to be completed
4 years ago
Jon Huhn
5d08a0d00e
Fix typo
...
Signed-off-by: Jon Huhn <huhnjon@gmail.com>
4 years ago
zh168654
bfc575dec2
add waitwithjobs instead of changing wait api
...
Signed-off-by: zh168654 <zhangye.168@163.com>
4 years ago
zh168654
957d2a2bf9
add wait-for-jobs flag
...
Signed-off-by: zh168654 <zhangye.168@163.com>
4 years ago
zhangye15
bd03e1b5c7
fix style conformance
...
Signed-off-by: zhangye15 <zhangye15@baidu.com>
4 years ago
zhangye15
c96dc48f21
fix test-style error
...
Signed-off-by: zhangye15 <zhangye15@baidu.com>
4 years ago
zh168654
8d498d58e7
add test cases
...
Signed-off-by: zh168654 <zhangye.168@163.com>
4 years ago
zh168654
5825112a8b
helm upgrade with --wait support jobs in manifest to be completed
...
Signed-off-by: zh168654 <zhangye15@baidu.com>
4 years ago
Janario Oliveira
cf3870a57f
Adjusted import
...
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
4 years ago
Janario Oliveira
10a29d1662
Reuse kube-client
...
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
4 years ago
Matt Farina
b7c38c879a
Adding support for k8s 1.19
...
Closes #8806
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Li Zhijian
4258e8664e
Use T.cleanup() to cleanup cmdtest_temp file
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Tariq Ibrahim
b07b2589fb
optimise if condition in service ready logic
...
Signed-off-by: Tariq Ibrahim <tariq181290@gmail.com>
4 years ago
Rajat Jindal
4faeedd98b
fix watch error due to elb/proxy timeout
...
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
4 years ago
Hidde Beydals
8217aba4a6
fix(kube): use logger instead of fmt.Printf
...
Signed-off-by: Hidde Beydals <hello@hidde.co>
4 years ago
Matt Farina
dbd001e532
Removing tiller language
...
Since Tiller is no longer part of Helm v3, internal documentation
language about Tiller can be removed
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
小明同学
decab8ea2e
fix: upgrade using --force shoud not run patch logic ( #8000 )
...
fix helm/helm#7999
Signed-off-by: Liu Ming <hit_oak_tree@126.com>
4 years ago
Liu Ming
ff3ed53b7c
polish to keep the same log style
...
Signed-off-by: Liu Ming <hit_oak_tree@126.com>
4 years ago
Adam Reese
d5d96ed3cf
Merge pull request #7929 from adamreese/fix/upgrade-results
...
fix(pkg/kube): continue deleting objects when one fails
4 years ago
Adam Reese
4a0dfbe53b
fix(pkg/cli): ensure correct configuration from kubeconfig file
...
Bind Helm flags to Kubernetes configuration loader to get a merged
config with kubeconfig.
Fixes : #7539
Signed-off-by: Adam Reese <adam@reese.io>
4 years ago
Adam Reese
bdf6f48704
fix(pkg/kube): continue deleting objects when one fails
...
* Continue deleting objects when one fails to minimize the risk of an
upgrade ending in an unrecoverable state
* Exclude failed deleted object from the returned result set
Signed-off-by: Adam Reese <adam@reese.io>
4 years ago
Adam Reese
c2da4fd53d
ref(*): kubernetes v1.18 ( #7831 )
...
Upgrade Kubernetes libraries to v0.18.0
Add new lazy load KubernetesClientSet to avoid missing kubeconfig error
In kubernetes v1.18 kubeconfig validation was added. Minikube and Kind
both remove kubeconfig when stopping clusters. This causes and error
when running any helm commands because we initialize the client before
executing the command.
Signed-off-by: Adam Reese <adam@reese.io>
4 years ago
lnattrass
c12a9aee02
fix(helm): Data race in kube/client Delete func. ( #7820 )
...
helm uninstall has a data race in its Delete function.
This resolves it using a mutex.
Signed-off-by: Liam Nattrass <liam.d.nattrass+git@gmail.com>
4 years ago
Dong Gang
69d9722eda
test(helm): fix client update error
...
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
5 years ago
Dong Gang
c45869c4ad
fix(helm): polish goimport
...
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
5 years ago
Dong Gang
9744e9f619
fix(helm): respect resource policy on ungrade
...
Don't delete a resource on upgrade if it is annotated with
helm.io/resource-policy=keep. This can cause data loss for users
if the annotation is ignored(e.g. for a PVC)
Close #7677
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
5 years ago
Matthew Fisher
64ce6e6a74
Merge pull request #7591 from ylvmw/master
...
IsReachable() needs to give detailed error message.
5 years ago
Taylor Thomas
512e1b8bc9
Merge pull request #7401 from hiddeco/non-global-scheme-convert
...
fix(kube): use non global Scheme to convert
5 years ago
Taylor Thomas
2cd3d12acd
Merge pull request #7530 from plenus-cloud/fix-7513
...
fix(helm): Don't wait for service to be ready when external IP are set
5 years ago
ylvmw
54ca879095
IsReachable() needs to give detailed error message.
...
Signed-off-by: ylvmw <yngliu@vmware.com>
5 years ago
Hidde Beydals
e41184a585
fix(kube): generate k8s native scheme only once
...
Signed-off-by: Hidde Beydals <hello@hidde.co>
5 years ago
Hidde Beydals
b55224ebb9
fix(kube): use non global Scheme to convert
...
But instead use a newly initialized Scheme with only Kubernetes native
resources added. This ensures the 3-way-merge patch strategy is not
accidentally chosen for custom resources due to them being added
to the global Scheme by e.g. versioned clients while using Helm as a
package, and not a self-contained binary.
Signed-off-by: Hidde Beydals <hello@hidde.co>
5 years ago
Benn Linger
5e638e3587
Revert "Do not delete templated CRDs"
...
This reverts commit 9711d1c6bf
. Resolves issue #7505 .
Signed-off-by: Benn Linger <benn@bennlinger.com>
5 years ago
Federico Bevione
af0007c908
fix(helm): improved logs
...
Signed-off-by: Federico Bevione <f.bevione@cognitio.it>
5 years ago
Federico Bevione
077503f175
fix(helm): Reworded logs for clarity
...
Signed-off-by: Federico Bevione <f.bevione@cognitio.it>
5 years ago
Matthew Fisher
0dadbdc309
Merge pull request #7373 from Sh4d1/bypass_ns
...
add option to bypass kubeconfig namespace
5 years ago
Federico Bevione
438eaec971
fix(helm): Don't wait for service to be ready when external IP are set
...
Resolves #7513
As the externalIPs are not managed by k8s (according to the doc: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.17/#servicespec-v1-core ) helm should not wait for services which set al least one externalIPs.
Signed-off-by: Federico Bevione <f.bevione@cognitio.it>
5 years ago
Taylor Thomas
c8c0000725
Merge pull request #7409 from akazemis/11414-fix-the-helm-upgrade-force-log-issue
...
log.Printf replaced to fix the helm upgrade log issue
5 years ago
Jakub Bielecki
8fe2097ffe
fix(kube) only add to scheme.Scheme once
...
Closes #6566
Signed-off-by: Jakub Bielecki <jakub.bielecki@codilime.com>
5 years ago
Ahmad Kazemi
9143223932
unnecessary import removed
...
Signed-off-by: Ahmad Kazemi <ahmad.kazemi@recordpoint.com>
unnecessary import removed
5 years ago
Ahmad Kazemi
d4c37d33d1
Signed-off-by: Ahmad Kazemi <ahmad.kazemi@recordpoint.com>
...
log.Printf replaced to fix the log issue.
5 years ago
Guangwen Feng
0cdbbf287f
Fix typo in comment for func IsReachable
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
5 years ago
Patrik Cyvoct
ff0e008558
add option to bypass kubeconfig namespace
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
5 years ago
Taylor Thomas
f35719a62a
Merge pull request #7320 from PhilGrayson/issue-7279
...
Do not delete templated CRDs
5 years ago
Matthew Fisher
9e4d42e18c
Merge pull request #7245 from waveywaves/fix/crd-install-api-extensions
...
fix(kube/client) crd install with apiextensions.k8s.io/v1
5 years ago
Phil Grayson
600970459e
Do not delete templated CRDs
...
Fixes issue #7279 .
Prevent the deletion of CRDs that were defined in the `templates/`
directory. This makes CRD deletion behaviour consistent with Helm
documentation:
> CRDs are never deleted. Deleting a CRD automatically deletes all of the
> CRD’s contents across all namespaces in the cluster. Consequently, Helm
> will not delete CRDs.
Previous the documentation only applied to CRDs that were defined in the
`crds/` directory. It did not consider that Charts could have CRDs in the
`templates/` directory (for example charts that were written before the
`crds/` directory feature or if the Chart author needed templated CRDs).
Signed-off-by: Phil Grayson <phil@philgrayson.com>
5 years ago
Guangwen Feng
cedd480199
Add corresponding unit test to the function in resource.go.
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
5 years ago
Adrian Gonzalez-Martin
afa612df9d
Add back fix for CRD patch creation
...
Signed-off-by: Adrian Gonzalez-Martin <agm@seldon.io>
5 years ago