Martin Hickey
9c97dc8fa2
Merge pull request #8933 from wawa0210/fix-helm-package-escape-invalid-version
...
Fix invalid semver version number of the helm package command will escape
4 years ago
knrt10
0490c288f5
completion: move to native zshCompletion
...
Cobra https://github.com/spf13/cobra/releases/tag/v1.1.1 fixed the issue
which did not need zshCompletion to be changed to bash.
closes : #8893
Signed-off-by: knrt10 <tripathi.kautilya@gmail.com>
4 years ago
Aayush Joglekar
babc8c9a70
Add remaining tests in TestDependentChartAliases
...
Signed-off-by: Aayush Joglekar <aayushjog@gmail.com>
4 years ago
Bridget Kromhout
86af591e00
Clarifies action needed to list new stable repo
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
4 years ago
Martin Hickey
9aa0fbee6c
Merge pull request #8879 from hickeyma/fix/incorrect-lint-msg
...
fix(lint): Lint error message for valid names
4 years ago
wawa0210
2c19838295
Fix that the invalid version number of the helm package command will escape
...
Signed-off-by: wawa0210 <xiaozhang0210@hotmail.com>
4 years ago
Bridget Kromhout
84b02bbee3
Updating descriptions
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
4 years ago
Ma Xinjian
24107e6afe
Add support to judge whether desired version is available or not
...
Now no matter what desired version provides, always give info "Helm ${TAG} is available.
Changing from version ${version}". It's obviously wrong.
This patch check whether desired version is actually available or not
by compare desired vesion with all available version in
https://github.com/helm/helm/releases
Signed-off-by: Ma Xinjian <maxj.fnst@cn.fujitsu.com>
4 years ago
Matt Farina
43b0ef5f20
Merge pull request #8855 from janario/fix/reusabe-kube-client
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
af2d3021f4
Merge pull request #8952 from mattfarina/fix-8940
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
c0d3877231
Merge pull request #8915 from zheng1/master
...
Bugfix: panic when chart contains requirements.lock
4 years ago
Zhengyi Lai
9cc00eea24
Add test case for LoadFiles
...
Signed-off-by: Zhengyi Lai <zheng1@yunify.com>
4 years ago
Matt Farina
882db2543c
Fixes Error: could not find protocol handler for
...
A previous update to automate finding charts in repos when update
was run did not take into account the case for no repo being
specified. This fixes that situation.
Closes #8940
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Lehel Gyuro
27807e1bb5
[ #7696 ] Avoid crash in chart loader on unexpected file sequence
...
Make sure, that chart metadata is initialized by the time the processing
of the chart is started.
Signed-off-by: Lehel Gyuro <lehel@freemail.hu>
4 years ago
wawa0210
da6b240fe7
helm search supports semver pre version numbers starting with 0
...
Signed-off-by: wawa0210 <xiaozhang0210@hotmail.com>
4 years ago
Christophe VILA
8a4c0bc7b1
added test for https://github.com/helm/helm/pull/8913 related to https://github.com/helm/helm/issues/8621
...
Signed-off-by: Christophe VILA <christophe.vila@thalesgroup.com>
4 years ago
Christophe VILA
e0a1bc8ea8
Merge remote-tracking branch 'origin/master' into fork-lint-bug
4 years ago
Lehel Gyuro
8abb44f218
[ #7696 ] Avoid crash in chart loader on unexpected file sequence
...
Make sure, that chart metadata is initialized by the time the processing
of the chart is started.
Signed-off-by: Lehel Gyuro <lehel@freemail.hu>
4 years ago
Marc Khouzam
82f739072c
feat(test): Adapt completion tests to Cobra 1.1
...
Cobra 1.1 trims completions so we need to remove extra spaces from
the tests.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
4 years ago
dependabot[bot]
713ec751a3
Bump github.com/spf13/cobra from 1.0.0 to 1.1.1
...
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra ) from 1.0.0 to 1.1.1.
- [Release notes](https://github.com/spf13/cobra/releases )
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md )
- [Commits](https://github.com/spf13/cobra/compare/v1.0.0...v1.1.1 )
Signed-off-by: dependabot[bot] <support@github.com>
4 years ago
Matthew Fisher
11077a4991
Merge pull request #8929 from bacongobbler/fix-8416
...
fix(test): display error message
4 years ago
Martin Hickey
b83632e757
Update err message to use the regex pattern directly
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
4 years ago
Martin Hickey
5785dd6d49
Fix the lint error message for valid names
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
4 years ago
Christophe VILA
f736af95eb
do not check YAML if nothing was parsed
...
Signed-off-by: Christophe VILA <christophe.vila@thalesgroup.com>
4 years ago
Matthew Fisher
38c964ae81
fix(test): display error message
...
This fixes the error output to display the error's default value (the error message) rather than
Go's internal representation of its value.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matt Farina
e72e2935dd
Merge pull request #8923 from mattfarina/bump-version-3.4
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
ce4fa95868
bump version to v3.4.0
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 7090a89efc
)
4 years ago
Matt Farina
75b7aeaeeb
Merge pull request #7024 from jan25/issue-6972
...
v3: Prettify Updated time in helm list
4 years ago
Matt Butcher
fe2d7f7792
this rewrites a whole bunch of old repo URLs to the new repo URL ( #8902 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
af01394e9f
warn and block old repo URLs ( #8903 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
5f3e560029
improved user-facing error messages to explain the underlying problem ( #8731 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matthew Fisher
e1d4c67437
Merge pull request #8891 from bridgetkromhout/meeting-details
...
Linking the README to a more complete list of meeting details in the community repo
4 years ago
Matthew Fisher
1a3c019c73
Merge pull request #8887 from bacongobbler/fix-8848
...
add authentication to CircleCI jobs
4 years ago
Bridget Kromhout
0f55fb5316
Linking to a more complete list of meeting details.
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
4 years ago
Matthew Fisher
360212393b
add authentication to CircleCI jobs
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
yxxhero
09af5447d9
Add --skip-refresh option in helm dep build
...
Signed-off-by: yxxhero <aiopsclub@163.com>
4 years ago
Martin Hickey
8667aa4f98
Merge pull request #8874 from consideRatio/pr/helm-create-template-indentation
...
helm create: make generated YAML indentation more consistent
4 years ago
Matthew Fisher
e73af10d0b
Merge pull request #8696 from f0rmiga/patch-1
...
fix: boilerplate template indentation
4 years ago
Erik Sundell
1d9767fea2
helm create: make generated YAML indentation more consistent
...
Signed-off-by: Erik Sundell <erik@sundellopensource.se>
4 years ago
Janario Oliveira
cf3870a57f
Adjusted import
...
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
4 years ago
Janario Oliveira
10a29d1662
Reuse kube-client
...
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
4 years ago
Matt Farina
fc9b46067f
Merge pull request #8828 from zhijianli88/pipe-stderr
...
TestCheckPerms: utilize pipe to read stderr
4 years ago
Matt Farina
54ea21d245
Merge pull request #8830 from zhijianli88/GOBIN
...
Makefile: check and use GOBIN environment variable first
4 years ago
Matt Farina
6297c021cb
Merge pull request #8795 from mattfarina/feat-8767
...
Adding annotation to index.yaml file
4 years ago
Li Zhijian
e97975d7ad
Makefile: check and use GOBIN environment variable first
...
'go get' will install binaries into GOBIN when it's set which is not
always same with GOPATH/bin
this commit can fix below errors:
~/workspace/k8s/helm$ go env | grep -e GOPATH -e GOBIN -e GOROO
GOBIN="/home/lizj/go/bin"
GOPATH="/home/lizj/gosrc"
GOROOT="/home/lizj/go"
~/workspace/k8s/helm$ make build-cross
(cd /; GO111MODULE=on go get -u github.com/mitchellh/gox)
go: github.com/mitchellh/gox upgrade => v1.0.1
go: github.com/hashicorp/go-version upgrade => v1.2.1
GO111MODULE=on CGO_ENABLED=0 /home/lizj/gosrc/bin/gox -parallel=3 -output="_dist/{{.OS}}-{{.Arch}}/helm" -osarch='darwin/amd64 linux/amd64 linux/386 linux/arm linux/arm64 linux/ppc64le linux/s390x windows/amd64' -tags '' -ldflags '-w -s -X helm.sh/helm/v3/internal/version.metadata=unreleased -X helm.sh/helm/v3/internal/version.gitCommit=59c77716ad61331da28c37e9430d5f6a3ab23fed -X helm.sh/helm/v3/internal/version.gitTreeState=dirty -extldflags "-static"' ./cmd/helm
bash: /home/lizj/gosrc/bin/gox: No such file or directory
Makefile:146: recipe for target 'build-cross' failed
make: *** [build-cross] Error 127
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
59c77716ad
TestCheckPerms: utilize pipe to read stderr
...
Refer to the stderr manpage:
$ man 3 stderr
*Note that mixing use of FILEs and raw file descriptors can produce unexpected results and should generally be avoided.*
And actually, we noticed that the warning() will output the message to
stdout instead of stderr sometimes.
lizj@FNSTPC:~/workspace/k8s/helm$ while true; do timeout 1m go test -count=1 -run TestCheckPerms ./cmd/helm -v 2>/dev/null; done
=== RUN TestCheckPerms
--- PASS: TestCheckPerms (0.00s)
PASS
ok helm.sh/helm/v3/cmd/helm 0.028s
=== RUN TestCheckPerms
--- PASS: TestCheckPerms (0.00s)
PASS
ok helm.sh/helm/v3/cmd/helm 0.027s
=== RUN TestCheckPerms
--- PASS: TestCheckPerms (0.00s)
PASS
ok helm.sh/helm/v3/cmd/helm 0.028s
=== RUN TestCheckPerms
--- PASS: TestCheckPerms (0.00s)
PASS
ok helm.sh/helm/v3/cmd/helm 0.029s
=== RUN TestCheckPerms
--- PASS: TestCheckPerms (0.00s)
PASS
ok helm.sh/helm/v3/cmd/helm 0.029s
=== RUN TestCheckPerms
--- PASS: TestCheckPerms (0.00s)
PASS
ok helm.sh/helm/v3/cmd/helm 0.028s
=== RUN TestCheckPerms
--- PASS: TestCheckPerms (0.00s)
PASS
ok helm.sh/helm/v3/cmd/helm 0.030s
=== RUN TestCheckPerms
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /tmp/helmtest093620773/testconfig
=== RUN TestCheckPerms
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /tmp/helmtest083469215/testconfig
=== RUN TestCheckPerms
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /tmp/helmtest101343249/testconfig
=== RUN TestCheckPerms
--- PASS: TestCheckPerms (0.00s)
PASS
ok helm.sh/helm/v3/cmd/helm 0.032s
=== RUN TestCheckPerms
--- PASS: TestCheckPerms (0.00s)
PASS
ok helm.sh/helm/v3/cmd/helm 0.040s
=== RUN TestCheckPerms
--- PASS: TestCheckPerms (0.00s)
PASS
ok helm.sh/helm/v3/cmd/helm 0.031s
=== RUN TestCheckPerms
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /tmp/helmtest706352639/testconfig
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
4 years ago
Matt Farina
e17500018e
Merge pull request #8824 from helm/dependabot/go_modules/github.com/sirupsen/logrus-1.7.0
...
Bump github.com/sirupsen/logrus from 1.6.0 to 1.7.0
4 years ago
Matt Farina
bea377bbd0
Merge pull request #8825 from helm/dependabot/go_modules/github.com/DATA-DOG/go-sqlmock-1.5.0
...
Bump github.com/DATA-DOG/go-sqlmock from 1.4.1 to 1.5.0
4 years ago
dependabot[bot]
b08c7d2429
Bump github.com/DATA-DOG/go-sqlmock from 1.4.1 to 1.5.0
...
Bumps [github.com/DATA-DOG/go-sqlmock](https://github.com/DATA-DOG/go-sqlmock ) from 1.4.1 to 1.5.0.
- [Release notes](https://github.com/DATA-DOG/go-sqlmock/releases )
- [Commits](https://github.com/DATA-DOG/go-sqlmock/compare/v1.4.1...v1.5.0 )
Signed-off-by: dependabot[bot] <support@github.com>
4 years ago
dependabot[bot]
2bc79d3294
Bump github.com/sirupsen/logrus from 1.6.0 to 1.7.0
...
Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus ) from 1.6.0 to 1.7.0.
- [Release notes](https://github.com/sirupsen/logrus/releases )
- [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sirupsen/logrus/compare/v1.6.0...v1.7.0 )
Signed-off-by: dependabot[bot] <support@github.com>
4 years ago