14 Commits (e62dddcfb6cede175366548ea9badbf3bd37133d)

Author	SHA1	Message	Date
Morten Torkildsen	82d01cb312	fix(helm): Merge nested values correctly on upgrade (#4806) ... Upgrading a release and override existing values doesn't work as expected for nested values. Maps should be merged recursively, but currently maps are treated just like values and replaced at the top level. If the existing values are: ```yaml resources: requests: cpu: 400m something: else ``` and an update is done with ```--set=resources.requests.cpu=500m```, it currently ends up as ```yaml resources: requests: cpu: 500m ``` but it should have been ```yaml resources: requests: cpu: 500m something: else ``` This PR updates the way override values are merged into the existing set of values to merge rather than replace maps. Closes: #4792 Signed-off-by: Morten Torkildsen <mortent@google.com>	6 years ago
Matt Rasmus	0522b34e05	test(tiller): cover crash fixed by #4630 (#4853) ... While investigating a tiller crash on v2.10.0 (see recent comments in #3125), I pulled down the code and wrote a test replicating the crash I was experiencing. I then realized that the crash had been fixed, and was able to locate the fix in #4630 after running a quck bisect. Since there don't appear to be any tests that cover this crash, and I had written one myself, I figured I might as well put up a PR for it. Here's what the test failure on v2.10.0 looks like: ``` -- FAIL: TestUpdateReleasePendingInstall_Force (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x1d128d8] goroutine 235 [running]: testing.tRunner.func1(0xc420493c20) /usr/local/Cellar/go/1.10/libexec/src/testing/testing.go:742 +0x29d panic(0x1eb8d80, 0x2a12db0) /usr/local/Cellar/go/1.10/libexec/src/runtime/panic.go:505 +0x229 k8s.io/helm/pkg/tiller.(*ReleaseServer).performUpdateForce(0xc4208210b0, 0xc4202c6dc0, 0x0, 0x0, 0x2174220) /Users/mattrasmus/go/src/k8s.io/helm/pkg/tiller/release_update.go:166 +0x188 k8s.io/helm/pkg/tiller.(*ReleaseServer).UpdateRelease(0xc4208210b0, 0x2191780, 0xc420820f30, 0xc4202c6dc0, 0x29aeb90, 0x38, 0x2d2) /Users/mattrasmus/go/src/k8s.io/helm/pkg/tiller/release_update.go:43 +0x245 k8s.io/helm/pkg/tiller.TestUpdateReleasePendingInstall_Force(0xc420493c20) /Users/mattrasmus/go/src/k8s.io/helm/pkg/tiller/release_update_test.go:549 +0x120 testing.tRunner(0xc420493c20, 0x20e5c70) /usr/local/Cellar/go/1.10/libexec/src/testing/testing.go:777 +0xd0 created by testing.(*T).Run /usr/local/Cellar/go/1.10/libexec/src/testing/testing.go:824 +0x2e0 FAIL k8s.io/helm/pkg/tiller 0.118s ``` Signed-off-by: Matt Rasmus <mrasmus@betterworks.com>	6 years ago
Matthew Fisher	941b1f4d68	fix(release_server): handle the case when requested values is empty (#4604) ... Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>	6 years ago
Michelle Noorali	2d82b88282	Merge pull request #4364 from michelleN/fix-4337 ... fix(release_server): fix how we merge values	6 years ago
Michelle Noorali	3e0de0dae9	fix(release_server): fix how we merge values ... resolves #4337 Merging maps inside of strings gets a bit tricky. When two strings consisting of "{}" were being added together, this resulted in "{}\n{}" instead of "{}" which is what we wanted. This led to YAML parsing errors and showed up when the `--reuse-values` flag was used when no overrides via `--set` were provided during install and/or upgrade.	6 years ago
Matthew Fisher	2d77db11fa	change copyright to "Copyright The Helm Authors"	7 years ago
Arash Deshmeh	a32868e48b	added ability to handle custom release descriptions to tiller ... Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>	7 years ago
Michelle Noorali	e02802ba95	ref(pkg/tiller): clarify reuseValues comment	7 years ago
Michelle Noorali	9266731dc4	fix(pkg/tiller): reuseValues combines all prev val ... Resolves #3655 We were seeing that when running helm upgrade with the reuse-values flag enabled that you could end up in the position where overrides a.k.a computed values from previous revisions were not being saved on the updated revision. This left us in a weird position where some computed values would disappear mysteriously in the abyss. That happened because computed values from previous revisions weren't merged with the new computed values every time the reuse-values flag was used. This PR merges computed values from the previous revisions so you don't end up in that kind of conundrum.	7 years ago
Matthew Fisher	13730b0dab	replace FAILED deployments with `helm upgrade --install --force` ... When using `helm upgrade --install`, if the first release fails, Helm will respond with an error saying that it cannot upgrade from an unknown state. With this feature, `helm upgrade --install --force` automates the same process as `helm delete && helm install --replace`. It will mark the previous release as DELETED, delete any existing resources inside Kubernetes, then replace it as if it was a fresh install. It will then mark the FAILED release as SUPERSEDED.	7 years ago
Adam Reese	82ef751414	fix(tiller): upgrade last deployed release ... Fixes #2437 Two bugs were causing this behavior - Tiller was marking the previous release superseded when an upgrade failed. - Upgrade was diffing against failed releases	7 years ago
Maxim Ivanov	ff5acc9bd8	Make Memory driver to store copy of releases to stop hiding storage errors during tests	7 years ago
Adam Reese	eccb041c0f	ref(tiller): cleanup goimports	8 years ago
fibonacci1729	22db973932	ref(tiller): refactor tests into logical files ... TestListReleasesByStatus -> tiller/release_list_test.go TestListReleasesFilter -> tiller/release_list_test.go TestListReleasesSort -> tiller/release_list_test.go TestListReleases -> tiller/release_list_test.go TestUpdateRelease_ResetReuseValues -> tiller/release_update_test.go TestUpdateRelease_ResetValues -> tiller/release_update_test.go TestUpdateRelease_ReuseValues -> tiller/release_update_test.go TestUpdateReleaseNoChanges -> tiller/release_update_test.go TestUpdateReleaseFailure -> tiller/release_update_test.go TestUpdateReleaseNoHooks -> tiller/release_update_test.go TestUpdateRelease -> tiller/release_update_test.go TestRollbackReleaesFailure -> tiller/release_rollback_test.go	8 years ago