Matt Farina
37de51428c
Merge pull request #31376 from benoittgt/accept-yaml-yml
...
Do not ignore *.yml file on linting while accepting *.yaml
4 months ago
Robert Sirchia
3924cf3781
Merge pull request #31362 from fabiocarneiro/patch-1
...
Clarify the intent of the resource instructions
4 months ago
Andreas Sommer
b05411506a
Improve error message when plugin source cannot be determined or a non-directory is passed
...
Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
4 months ago
wyrapeseed
b9eadd3186
chore: fix some comment format
...
Signed-off-by: wyrapeseed <wyrapeseed@outlook.com>
4 months ago
Terry Howe
ffb3940011
rename interface{} to any
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Benoit Tigeot
06188f9dfe
Add test for isYamlFileExtension functions
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Matt Farina
f80cbe43d0
Moved release objects to enable versioning
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 months ago
Benoit Tigeot
4a944230ea
Do not ignore *.yml file on linting while accepting *.yaml
...
From : https://github.com/helm/helm/pull/30712/files#r2417446037
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
reddaisyy
e69a12dad3
refactor: use reflect.TypeFor
...
Signed-off-by: reddaisyy <reddaisy@outlook.jp>
4 months ago
Robert Sirchia
600eb487f1
Merge pull request #31349 from TerryHowe/fix-shuffle-lint-test
...
fix: flakey lint test on shuffle
4 months ago
Fábio Carneiro
1477d3793f
Clarify the intent of the resource instructions
...
Signed-off-by: Fábio Carneiro <fahecs@gmail.com>
4 months ago
George Jenkins
b97452d0e7
feat: `helm version` print Kubernetes (client-go) version
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
George Jenkins
a7a6a5e3b0
Merge pull request #31312 from gjenkins8/gjenkins/rm_plugin_schema_settings
...
Remove unused 'Settings' from plugin schema
4 months ago
Terry Howe
ee322a9671
fix: flakey lint test on shuffle
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Terry Howe
bee9c1a108
chore: replace github.com/mitchellh/copystructure
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
George Jenkins
93c02523bb
Merge pull request #31249 from banjoh/em/additional-logging
...
chore: add additional logging to plugin installer
4 months ago
George Jenkins
900cf2a93d
Merge pull request #31320 from kosiew/sign-31181
...
provenance: allow RSA signing when ed25519 keys are present (switch to ProtonMail/go-crypto)
4 months ago
juejinyuxitu
69dbd6115e
chore: fix some typos in comment
...
Signed-off-by: juejinyuxitu <juejinyuxitu@outlook.com>
4 months ago
Siew Kam Onn
7c9176ae35
Update dependencies and refactor crypto imports to use ProtonMail's go-crypto package
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
4 months ago
George Jenkins
6bc6231bcc
Remove unused 'Settings' from plugin schema
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Matt Farina
d2236e95ed
Merge pull request #31303 from mattfarina/unified-loader
...
Update the action interfaces for chart apiversions
5 months ago
Matt Farina
8dc7c57f50
Update the action interfaces for chart apiversions
...
This change is about handling the interfaces to public functions for
different chart apiVersions. The internals are still focused on v2.
This enables v3 to be layered in layer.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
zyfy29
b24bfe4168
Merge branch 'main' into delete-unused-var
...
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
5 months ago
Matt Farina
0befdb90a1
Merge pull request #31287 from miledxz/fileutil-tests-improvements
...
improve fileutil test coverage
5 months ago
Mile Druzijanic
934b4550d9
improve fileutil test coverage
...
Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com>
5 months ago
Tom Wieczorek
6181e0a873
Make test scripts run without /bin/bash
...
The test scripts hardcoded #!/bin/bash while they are not really
requiring bash. Use the more portable #!/usr/bin/env sh instead, so that
they use the default shell.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
5 months ago
yajianggroup
cfaf30083a
refactor: use strings.CutPrefix
...
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
5 months ago
Benoit Tigeot
072e2a689a
Extend --skip-schema-validation for lint command
...
When --skip-schema-validation is enabled, the lint command will now skip
JSON schema validation for values.yaml files, allowing charts with schema
validation errors to pass linting when the flag is used.
This addresses the gap where --skip-schema-validation only applied to
templates but not to values files, providing complete schema validation
bypass when needed.
Fixes : #13413
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Evans Mungai
3d23230ef8
chore: add additional logging to plugin installer
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Kamil Swiechowski
cd76ae1c93
feat:strict compliance with semverv2 for chart/v3/linter
...
Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>
5 months ago
Matt Farina
618b14a772
Merge pull request #31225 from mattfarina/move-lint-to-chart
...
Move lint pkg to be part of each chart version
5 months ago
George Jenkins
a8151ef4fe
Cleanup plugin config
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Scott Rigby
ed6cab39c6
Merge pull request #31219 from gjenkins8/gjenkins/plugin-integration/rm_setup_plugin_env
5 months ago
Matt Farina
9dcc49cbd5
Move lint pkg to be part of each chart version
...
Linting is specific to the chart versions. A v2 and v3 chart will
lint differently.
To accomplish this, packages like engine need to be able to handle
different chart versions. This was accomplished by some changes:
1. The introduction of a Charter interface for charts
2. The ChartAccessor which is able to accept a chart and then
provide access to its data via an interface. There is an
interface, factory, and implementation for each version of
chart.
3. Common packages were moved to a common and util packages.
Due to some package loops, there are 2 packages which may
get some consolidation in the future.
The new interfaces provide the foundation to move the actions
and cmd packages to be able to handle multiple apiVersions of
charts.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Matt Farina
52267ee74b
Move repo package to versioned directory
...
The repo package is internally versioned at v1. Repos were designed
to be versioned. This change moves it to a versioned directory the
same way other packages are now being handled.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
George Jenkins
5926ec83dd
Remove SetupPluginEnv
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
George Jenkins
665c5a1fc9
Merge pull request #31224 from gjenkins8/gjenkins/postrenderer_plugin_message_value
...
fix: Adjust PostRenderer plugin output to value
5 months ago
George Jenkins
d99d732542
fix: Adjust PostRenderer plugin output to value
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
George Jenkins
c35755a197
Remove legacy Command/Hooks from v1 Subprocess ( #23 )
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Scott Rigby
591d863df5
Move Postrenderer to a plugin type
...
Fix/add back postrenderer args unit tests
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
e814ff3c38
Remove unnecessary file i/o operations from signing and verifying
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
9ea35da0d0
[HIP-0026] Plugin packaging, signing, and verification ( #31176 )
...
* Plugin packaging, signing and verification
Signed-off-by: Scott Rigby <scott@r6by.com>
* wrap keyring read error with more explicit message
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* skip unnecessary check
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Change behavior for installing plugin with missing .prov file (now warns and continues instead of failing)
Signed-off-by: Scott Rigby <scott@r6by.com>
* Add comprehensive plugin verification tests
- Test missing .prov files (warns but continues)
- Test invalid .prov file formats (fails verification)
- Test hash mismatches in .prov files (fails verification)
- Test .prov file access errors (fails appropriately)
- Test directory plugins don't support verification
- Test installation without verification enabled (succeeds)
- Test with valid .prov files (fails on empty keyring as expected)
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
zyfy29
8068578266
chore: delete unused var in installer.go
...
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
5 months ago
George Jenkins
2658a00863
fix output message value
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
George Jenkins
e5b612626e
fixup slog tmpDirInner
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
George Jenkins
b6545e903a
code review + bug fixes
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
George Jenkins
c8e51b40c2
Plugin extism/v1 runtime
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Matt Farina
4ae80c0399
Merge pull request #31191 from TerryHowe/stderr-logging
...
fix: send logging to stderr
5 months ago
Terry Howe
389646ffd1
fix: send logging to stderr
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
Scott Rigby
3d30112468
Fix LocalInstaller Path() to strip version from tarball filenames
...
Override Path() method to use existing stripPluginName function for archives
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
16924a51db
Fix: Removed unsafe umask manipulation in tests
...
Problem: Tests used syscall.Umask(0000) which could leave your shell creating
files with 777 permissions if interrupted.
Solution: Instead of changing umask, tests now detect the current umask and
calculate expected permissions after it's applied.
Result: Same test coverage, but safe from system-wide side effects.
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
5c663db853
Plugin tarball installer support for HTTP (fix) and local (feat)
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
d19130f69e
Fix file handle management in tar extractors
...
Use defer outFile.Close() to avoid multiple close calls and ensure proper resource cleanup
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
fd41fdd9c9
New registry plugin func GetPluginName. Re-use regsitry.reference
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
7d22bb25fa
Plugin OCI installer
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
a7578fec74
Plugin types and plugin apiVersion v1
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
6 months ago
Scott Rigby
be74ab72a0
[HIP-0026] Plugin runtime interface ( #31145 )
...
* Runtime abstraction to encapsulate subprocess code and enable future runtimes
Also fix race condition in TestPrepareCommandExtraArgs by replacing the shared variable modification with a local copy
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Remove commented out code
Co-authored-by: Joe Julian <me@joejulian.name>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Check test failure string
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Co-authored-by: Joe Julian <me@joejulian.name>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
6 months ago
Matt Farina
0f1b410f14
Merge pull request #31165 from mattfarina/content-cache
...
Initial addition of content based cache
6 months ago
Matt Farina
fea6d8eb04
Updating to tested content cache
...
A few things are added here:
1. The cache is made to be more generic as a content based cache.
It could be used for other things such as plugins
2. Flags were added to specify the content cache locaiton rather
than rely on the repository cache. Keeping the 2 the same
hid bugs and errors.
3. Tests were added and updated to ensure the cache is used and
tested
Signed-off-by: Matt Farina <matt.farina@suse.com>
6 months ago
George Jenkins
4596c0e062
Merge pull request #31142 from helm/gjenkins/main/mv_plugin_internal
...
[HIP-0026] Move pkg/plugin -> internal/plugin
6 months ago
George Jenkins
a1c84f9a4c
Move pkg/plugin -> internal/plugin
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
joemicky
fab70472af
refactor: replace []byte(fmt.Sprintf) with fmt.Appendf
...
Signed-off-by: joemicky <joemickychang@outlook.com>
6 months ago
Robert Sirchia
d7d072b7f6
Merge commit from fork
...
Advisory fix 1
6 months ago
George Jenkins
18b7d45999
Merge pull request #31034 from Mazafard/feat/color-output-and-test-fixes
...
Feat: Add color output functionality and tests for release statuses
6 months ago
Matt Farina
0c64ad1c97
fix Chart.yaml handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
6 months ago
Matt Farina
70257f5cd6
Initial addition of v3 charts
...
This change adds v3 charts. The code for the chart, including a
loader, is present. It is based on v2 charts as a starting point.
Note, this change does not make the charts available for use with
Helm CLI commands or the action package. That will be in follow-up
changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
6 months ago
Mohammadreza Asadollahifard
ba8f70ae0b
refactor: move color package to internal/cli/output
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
8 months ago
Matthieu MOREL
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
9 months ago
Matthieu MOREL
77a267dacf
chore: enable usestdlibvars linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
9 months ago
Matthieu MOREL
15b83a9959
fix: dep fs errors
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
9 months ago
Matt Farina
ed356cfca8
Fixing windows build
...
The package github.com/pkg/errors was removed via the pull request #13460 .
This change did not correctly handle the case in the windows code and CI
did not exercise this to find the error.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
10 months ago
Benoit Tigeot
1654664b78
could use strings.ReplaceAll instead
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
b2ac216763
func cleanUpDir is unused
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
a23b96276a
var mu is unused (unused)
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
7fe554e7a8
Fix naked return errors
...
> xinternal/third_party/dep/fs/fs.go:175:3: naked return in func `copyFile` with 59 lines of code (nakedret)
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
e7eedae97c
Use the logger with proper handling of dynamic debug on 2 locations
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
cbaac7652d
Call slog directly instead of using a wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
83a5a14826
Properly discard by default logs
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
b2380720eb
Migrate to pure slog without a custom wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
947658a96e
Explain why we ignore the timestamp
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
15de13f9d2
Fix linting issue and temporary removing logging in test acion
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
83cdffe4ae
Migrate to a dedicated internal package for slog adapter + migrate more
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Austin Abro
8efd428e5d
switch back to k8s rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
83266254f0
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
600947b32e
client->restmapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
ddc7baaaca
copyright things
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
3a296aacad
rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
24dc643822
restmapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
8d964588cd
Update internal/statusreaders/job_status_reader.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
11 months ago
Austin Abro
5ecca2ed14
Apply suggestions from code review
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
11 months ago
Robert Sirchia
848c134e0c
fixing error messages
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
11 months ago
Robert Sirchia
1ad79a2bb7
converting inline log to slog
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
11 months ago
Austin Abro
09faaac273
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Matt Farina
61d3eca55c
Move pkg/chart to pkg/chart/v2 to prepare for v3 charts
...
This change moves the code, updates the import locations, and
adds a doc.go file to document what the v2 package is for.
This is part of HIP 20 for v3 charts
Signed-off-by: Matt Farina <matt.farina@suse.com>
11 months ago
Austin Abro
f866409c50
move statusreaders to it's own package
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
12 months ago
George Jenkins
3253059438
Merge pull request #13535 from helm/refactor_tlsutil
...
refactor: tlsutil use options pattern
1 year ago
George Jenkins
415c7e10fd
Merge pull request #13516 from TerryHowe/new-lint
...
chore: fix problems with latest lint
1 year ago
Matt Farina
27bcda42dd
Updating the internal version to v4
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago