Kévin Dunglas
9aa773042d
create: include the namespace in NOTES.txt for LoadBalancer status ( #5055 )
...
Signed-off-by: Kévin Dunglas <dunglas@gmail.com>
6 years ago
įoнииγ įoнииγ
03718ee93d
Added extra padding to resources template ( #4981 )
...
This is probably a silly PR. However, each time I create a new chart
via `helm create`, the instructions to uncomment the resource limits
require adding a couple extra spaces back to the YAML.
This PR simply brings the spacing in-line with the rest of the generated
template.
Signed-off-by: John Dewey <john@dewey.ws>
6 years ago
Martin Hickey
58be8e461c
Update messaging in value parsing to improve traceability ( #4974 )
...
Closes #4736
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Matthew Fisher
97465abda0
fix(windows): fix unit tests on Windows ( #4897 )
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Morten Torkildsen
82d01cb312
fix(helm): Merge nested values correctly on upgrade ( #4806 )
...
Upgrading a release and override existing values doesn't work as expected for nested values. Maps should be merged recursively, but currently maps are treated just like values and replaced at the top level.
If the existing values are:
```yaml
resources:
requests:
cpu: 400m
something: else
```
and an update is done with ```--set=resources.requests.cpu=500m```, it currently ends up as
```yaml
resources:
requests:
cpu: 500m
```
but it should have been
```yaml
resources:
requests:
cpu: 500m
something: else
```
This PR updates the way override values are merged into the existing set of values to merge rather than replace maps.
Closes : #4792
Signed-off-by: Morten Torkildsen <mortent@google.com>
6 years ago
Erik Sundell
eb96576b8d
Reform indentation practices using nindent ( #4562 )
...
The essence of this commit is to help people get started with a better
indentation practice than this:
```yaml
spec:
labels:
{{ toYaml .Values.labels | indent 4 }}
```
The previous indentation practice is harder to read. Instead this commit
introduces an indentation practice using `nindent` like this:
```yaml
spec:
labels:
{{- toYaml .Values.labels | nindent 4 }}
```
Signed-off-by: Erik Sundell <erik.i.sundell@gmail.com>
6 years ago
Zachary Seguin
662fd4fcf6
Remove executable bits from chartutil generated files ( #4839 )
...
Signed-off-by: Zachary Seguin <zachary@zacharyseguin.ca>
6 years ago
Martin Hickey
f6efe2f0c1
Add test template example for helm create ( #4524 )
...
* Add test template example for helm create
As helm create ganerates an nginx chart, the example is based on
https://github.com/helm/helm/blob/master/docs/examples/nginx/templates/
service-test.yaml
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Update after review
- https://github.com/helm/helm/pull/4524#pullrequestreview-155183390
- https://github.com/helm/helm/pull/4524#pullrequestreview-155379922
- Fix where app.kubernetes.io/instance was incorrect in service selector
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Add doc update
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Update GO formatting
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Adam Reese
26c88ec815
Merge pull request #4703 from adshmh/4556-fix-paths-ingress-template
...
fix paths in the ingress template and values file written by helm create
6 years ago
Adam Reese
e83a54f7a0
Merge pull request #4742 from florianrusch/patch-1
...
Add the `.vscode` folder to the `.helmignore` file
6 years ago
Rijnard van Tonder
5267c0d44a
The nil check before the range loop is redundant
...
Signed-off-by: Rijnard van Tonder <hi.teresy@gmail.com>
6 years ago
Florian Rusch
6f12ab24a5
Add the .vscode folder to the .helmignore file
...
Signed-off-by: Florian Rusch <git@florianrusch.de>
6 years ago
adshmh
2ef61fdf5c
feat(helm): use apps/v1 as deployment apiVersion ( #4725 )
...
Use 'apps/v1' as the apiVersion field for the deployment.yaml written
by the 'helm create' command, rather than the deprecated 'apps/v1beta2'.
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
6 years ago
Arash Deshmeh
1a54463bdb
fix(helm): fix paths in the ingress template and values file written by helm create
...
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
6 years ago
Qiang Li
4dd9047586
fix(helm): fix selector typo in service template for 'helm create' ( #4663 )
...
changed instancelease to instance in service template
closes #4661
Signed-off-by: Qiang Li <liqiang@gmail.com>
6 years ago
Martin Hickey
7306b4c28e
Fix helm create note for k8 label convention changes
...
Update to note as per changes in Issue #4335 . Otherwise cannot
retrieve the pod with the label names.
6 years ago
Matt Farina
e328d00a2f
Updating to the k8s label convention
...
Closes #4335
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago
Matthew Fisher
9a788b7a48
Merge pull request #4161 from mattjmcnaughton/mattjmcnaughton/fix-wrong-timestamp-helm-package
...
Fix incorrect timestamp when helm package
6 years ago
Matthew Fisher
2d77db11fa
change copyright to "Copyright The Helm Authors"
6 years ago
Matthew Fisher
99f20d82bb
Merge pull request #4093 from aidtechnology/issue_4092
...
Migrate 'template' to 'include' in 'helm create'
7 years ago
mattjmcnaughton
96a85a06ed
Fix incorrect timestamp when helm package
...
The files contained in the `tar` file from `helm package` did not have
the correct timestamp. This lack of timestamp occurred because we were
not writing any time to the tar header file.
7 years ago
Matthew Fisher
3771ef8635
Merge pull request #3984 from muehlburger/dev
...
Fix filenames in tarball created on windows
7 years ago
Johnny Bergström
43b19dccbe
Add helm template --is-upgrade
...
Useful for toggling .Release.IsInstall / .Release.IsUpgrade which
in turn may cause templates to render differently.
7 years ago
Alejandro Vicente Grabovetsky
4fbc733ade
Migrate 'template' to 'include' in 'helm create' to conform to Helm best practices
...
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
7 years ago
AdamDang
89c29f3ff1
Update capabilities.go
7 years ago
AdamDang
51f92b4787
Typo fix: mach->match
...
mach->match
7 years ago
Herbert Mühlburger
a1b5b69248
Refactor to be more precise
7 years ago
Matthew Fisher
f7f686f7d0
Revert "toYaml - Fix #3470 and #3410's trailing \n issues"
7 years ago
Herbert Mühlburger
dcdeefbd63
#3763 replace backslash with forward slash
7 years ago
Julien Bordellier
cf3ded91f2
Add quoting support in ingress to allow wildcard domain
7 years ago
Matthew Fisher
d502f7c8a8
Merge pull request #3950 from BarryWilliams/issue3747
...
Add comments to fix linter issues
7 years ago
BarryWilliams
718578036d
Changed whitespacing in comments
7 years ago
Matthew Fisher
f201db3fc2
Merge pull request #3692 from aleerizw/fix-sigsegv-create
...
Fixed SIGSEGV when running helm create with -p and no values.yaml file
7 years ago
Justin Scott
ad714fe704
Merge pull request #3323 from jascott1/2620_importvals_warning_fix
...
fix(helm): fix importValues warnings from disabled charts
7 years ago
Nikhil Manchanda
30f236b75c
Merge pull request #3877 from chancez/enhance_helm_template_handling
...
Update helm template -x to support children chart manifests in more cases
7 years ago
Chance Zibolski
d7e7170993
Add working template to mariner chart for use in testing subcharts
7 years ago
Matthew Fisher
6f02d9e412
Merge pull request #3837 from consideRatio/toYaml-pr
...
toYaml - Fix #3470 and #3410's trailing \n issues
7 years ago
Steffen Windoffer
8bd42d2645
remove unused servicePort from default ingress template
7 years ago
Erik Sundell
05a1f7f46c
Updated tests for PR #3837
7 years ago
Erik Sundell
35132d141c
toYaml - Fixes #3410 - trailing \n issue
...
`toYaml` utilized by `.Files` was introducing a new line. It is an issue since the new line is part of a functions output, it can't be whitespace chomped away so it would require a `trimSuffix "\n"` pipe. This commit trims one trailing `\n` from the toYaml output.
7 years ago
Zack Williams
1d3ae54185
Fix #3822
7 years ago
adshmh
1a55161a53
Fix several golint warnings ( #3756 )
...
* fix(helm): fix golint warning due to ApiVersionV1 constant name
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
* fix(helm): fix golint warning due to ResolveChartVersionAndGetRepo comment
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
* fix(helm): fix golint warnings on HttpGetter type and SetCredentials method missing a comment
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
* fix(helm):fix golint warning due to comment on FindChartInAuthRepoURL function
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
* fix(helm): fix golint warning due to RepoFile type name
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
* fix(helm): fix golint warning due to ParseString comment
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
7 years ago
cameronconradt
6a59683c01
Update files.go
...
Should suppress the warnings about the naming of these two functions. Added TODO
7 years ago
Ali Rizwan
99da9fb548
Fixed SIGSEGV when running helm create with -p and no values.yaml file
7 years ago
Matthew Fisher
b5af54d44c
Merge pull request #3567 from jumal/master
...
Create missing directories when saving files in chartutil.SaveDir
7 years ago
Matthew Fisher
86ae040bfa
Merge pull request #3491 from oilbeater/fix-defer-in-loop
...
defer in loop may cause resource leak
7 years ago
Jean-Philippe Courson
5b77335415
Create missing directories when saving files in chartutil.SaveDir
7 years ago
Thibaut Rousseau
a59d212512
docs: Fix FromJson comment
7 years ago
oilbeater
757db3a062
defer in loop may cause resource leak
7 years ago
Matthew Fisher
14c7be1f92
Merge pull request #3288 from bradbeam/starter
...
feat Making starter templates more versatile
7 years ago
Matt Farina
c359ea66ed
Merge pull request #3350 from mattfarina/fix/3349
...
fix(capabilities): Adding GitVersion to default set
7 years ago
Matt Farina
d5a865b5f4
fix(capabilities): Adding GitVersion to default set
...
Prior to this, using the semver template functions with the full
version, which is represented in the GitVersion, was not possible
for helm template and lint commands because the property was not
populated by default. This update adds default handling.
Closes #3349
7 years ago
Reinhard Nägele
f47e1619b0
Update initial chart experience
...
* Add template for chart name
* Use named ports and simplify service configuration
* Add affinity
* Add tolerations
* Use 'with' statements where possible
* Enhance ingress
* Add fullnameOverride to fullname template
7 years ago
Justin Scott
fbe80437a4
fix(helm): fix importValues warnings from disabled charts
...
ImportValues incorrectly processes charts that should be disabled. This
patch excludes those charts.
Closes #2620
7 years ago
Matthew Fisher
e1027fae73
refactor symWalk() into pkg/sympath ( #3199 )
...
* refactor symWalk() into pkg/sympath
* add Go copyright
* remove dead code
7 years ago
Adam Reese
a31e3b8fe1
ref(*): kubernetes v1.9 support ( #3234 )
7 years ago
Brad Beam
8e0eface2c
Making starter templates more versatile
...
This adds support for changing '<CHARTNAME>'
occurances in starter chart to the destination
chart name
7 years ago
Nauris Sadovskis
bd8178d50b
Fix package url
7 years ago
Matthew Fisher
7c79d1c765
Merge pull request #3193 from burdiyan/master
...
ref(helm): improve fullname template in starter chart
7 years ago
Johnny Bergström
7cc610960f
Walk symbolic link directories
...
Continue walking symlinks to be able to use them
for sub-charts. Useful when not specifying requirements
but still want to share charts locally.
7 years ago
Alexandr Burdiyan
f432e07126
ref(helm): improve fullname template in starter chart
...
Closes #1186
7 years ago
Johnny Bergström
d762a42168
Fix helmignore for .* ( #3114 )
...
When the first rule matching entry for top level dir
will be empty string, the .* rule will match.
Skip this entry as it's not needed for processing.
7 years ago
Maxime Guyot
c864ba179e
Add fullnameOverride
7 years ago
Dhilip
67af4998de
helm create all defined template names should be namespaced … ( #2845 )
...
* helm create all defined template names should be namespaced https://docs.helm.sh/chart_best_practices/#names-of-defined-templates
* Update Doc
* Update example
7 years ago
Matthew Fisher
e3e1116eaa
Merge pull request #2857 from llsheldon/fix-dependency-alias
...
fix(helm):Fix dependency aliaes not working
7 years ago
Matthew Fisher
f278675f98
remove references to facebookgo/symwalk
7 years ago
Matthew Fisher
211f5f6f33
Revert "fix(helm): resolve symlinks when loading chart"
...
This reverts commit edd4e56112
.
7 years ago
Matthew Fisher
cf3fc21e81
Merge pull request #2898 from zlabjp/kube-version
...
feat(helm): add --kube-version flag to helm template
7 years ago
carlory
ad2d8e434a
fix fromjson comment
7 years ago
carlory
b9d3974df0
fix func comment
7 years ago
Kazuki Suda
fa3ee5aecf
feat(helm): add --kube-version flag to helm template
...
This commit adds --kube-version flag to helm template. It allows you to
override the Kubernetes version used as Capabilities.KubeVersion.Major/Minor (e.g. 1.7).
7 years ago
Kazuki Suda
3508cebbf6
Use the same defaults as done in helm lint for Capabilities
7 years ago
Michelle Noorali
84bb77f183
Merge pull request #1997 from AmandaCameron/issue/1401
...
Take a crack at Issue #1401
7 years ago
Amanda Cameron
415e52bf55
Add support for sub-directory scanning as in issue #1401
7 years ago
llsheldon
0440b54bbf
fix(helm):Fix dependency aliaes not working
...
The alias functionality only works when a hardcoded version
is used. Any use of semver logic causes unexpected behavior.
I use version.IsCompatibleRange to check the dependency version.
Closes #2794
7 years ago
Adnan Abdulhussein
8fd8a7c324
fix(create): port-forward should use internal port
...
cc @james-w
7 years ago
Justin Scott
4a02a71f1e
WIP feat(helm): add `template` command
...
This adds the functionality from the helm-template plugin to allow the
rendering of templates without Tiller.
Closes #2755
7 years ago
Kira
4c1a47480e
feat(2450): add annotations to chart metadata ( #2671 )
...
* feat(2450): add options to chart metadata
7 years ago
Maxime Guyot
bbf2d6b7e8
Fix the default NOTES.txt
7 years ago
Miouge1
6cfed9d635
Updating default values.yaml comments
...
Following the instructions to simply uncomment the following lines results in a invalid yaml output
7 years ago
Steven E. Harris
e8d80729ac
Merge pull request #2703 from rbwsam/ref/simplify_error
...
ref(pkg/chartutil): replace use of 'fmt.Efforf'
7 years ago
Sam Leavens
098df8b186
ref(pkg/chartutil): improve comment spacing
...
Reduce comment spacing to single tab.
7 years ago
Sam Leavens
f7ca52dfc8
ref(pkg/chartutil): improve comment for PathValue
...
Make comment for PathValue more explanatory.
7 years ago
Sam Leavens
cf09e344d1
fix(pkg/chartutil): Fix test, improve message
...
Fix inverted equaility check and update error message.
7 years ago
Sam Leavens
8df52b6501
ref(pkg/chartutil): move comment
...
Move comment out of test. Move ref location in test.
7 years ago
Sam Leavens
3ee70291c8
ref(pkg/chartutil): Capitalize YAML
...
Capitalize "yaml" in error message. Remove empty var from test error message.
7 years ago
Sam Leavens
51b59497ee
ref(pkg/chartutil): decrease map lookups
...
Decrease map lookups in `chartutil.coalesceValues` and move comment to unit
test.
Closes #2663
7 years ago
Sam Leavens
9b8928edf4
ref(pkg/chartutil): replace use of 'fmt.Efforf'
...
'fmt.Errorf' is unnecessary when checking for 0 length path in Values.PathValue
due to the lack of formatting. Add test covering changes.
7 years ago
Scott Rigby
6dc31f8e96
Test that the coalesced key is properly removed for all YAML null syntax options, but not for empty string
7 years ago
Scott Rigby
645f01eb22
New Helm functionality to delete a coalesced YAML key when the value is nil.
...
- Note that this covers all YAML null syntax options:
ref: http://yaml.org/type/null.html
- Note that we do a nil comparison because the encoding/yaml package parses
YAML properly and any variation of null, Null, NULL, or ~ is converted to nil
by the time we get here.
7 years ago
Matt Butcher
883da97396
Merge pull request #2607 from sushilkm/issues/2599
...
Adds charts in "charts\" directory to dependencies
7 years ago
Ilya Semenov
13b15f5662
Remove service.type mention from ingress docs
7 years ago
Justin Scott
af4c243ee3
Correct punctuation and capitalization for user facing strings.
8 years ago
Sushil Kumar
82da721c0a
Added tests for different combinations of subcharts & requirements.yaml
...
Added more tests to test following comibnations of subcharts and requirements.yaml
- [ ] subcharts not specified in requirements.yaml
- [ ] some subcharts specified in requirements.yaml while others should be picked directly from "charts\"
- [ ] all subcharts specified in requirements.yaml without alias
- [ ] subcharts specified in requirements.yaml with alias is already tested
8 years ago
Sushil Kumar
7ce5c7925b
Adds charts in "charts\" directory to dependencies
...
Dependencies should be processed even if they are not added to requirements.yaml
Fixes https://github.com/kubernetes/helm/issues/2599
8 years ago
Sushil Kumar
bfd74c35e9
Added omitempty to Requirements struct
...
This was needed to get correct sha for requirements.yaml and requirements.lock
Fixes https://github.com/kubernetes/helm/issues/2598
8 years ago
Reinhard Nägele
76e6e15a0c
Add comment on resources
8 years ago
Reinhard Nägele
51923e54b1
Improve 'helm create'
8 years ago
Taylor Thomas
e3250e3319
Merge pull request #2534 from sushilkm/issues/2508
...
First alias would be dependency rename
8 years ago
Sushil Kumar
716be14ad3
Updated code to read requirements.yaml as per following structure
...
```
- name: <dependency-chart-name>
alias: <alias-name-to-be-used>
version: <dependency-chart-version>
repository: <dependency-chart-version>
```
8 years ago