Scott Rigby
0ee89d2d4e
Merge pull request #31418 from tisonkun/typo
...
chore: fix typo of public field
9 months ago
Benoit Tigeot
02312a1cf2
Update pkg/cmd/flags.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
277c140c87
Error strategy list match help
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
5f6fa437b2
Prevent surprising failure with SDK when timeout is not set
...
While testing SDK features for v4. I was surprised with the error:
"reporter failed to start: event funnel closed: context deadline exceeded"
This occurs when no timeout is set:
```
upgradeClient := action.NewUpgrade(actionConfig)
upgradeClient.WaitStrategy = kube.StatusWatcherStrategy
// When Timeout is zero, the status wait uses a context with zero timeout which
// immediately expires causing "context deadline exceeded" errors.
upgradeClient.Timeout = 2 * time.Minute
```
With this patch it will work without specifying.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
52a282832f
Do not change the default waiting strategy when --wait is not set
...
It is too much a breaking change for a new RC of beta V4.
See comment: https://github.com/helm/helm/pull/31421#discussion_r2465121438
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
11128659aa
Provide more help for SDK user when setting up WaitStrategy
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
8535e9f4ab
Avoid confusion between `--wait` (watcher) and no --wait (hookOnly)
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
1836f37f4d
The default is not HookOnlyStrategy but WaitStrategy
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
a5e110fccd
Make wait strategy selection more obvious
...
It is not clear enough that you need to set --wait=false for a hook only
strategy.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
e8b0cff45a
Update pkg/cmd/flags.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
95e1ee1089
Increase documentation of --wait flag
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
5cbd9b3035
While testing SDK features for v4. I was surprised with the error:
...
> "reporter failed to start: event funnel closed: context deadline exceeded"
It happens when you forget to set a minimal timeout:
```go
upgradeClient := action.NewUpgrade(actionConfig)
upgradeClient.WaitStrategy = kube.StatusWatcherStrategy
// When Timeout is zero, the status wait uses a context with zero timeout which
// immediately expires causing "context deadline exceeded" errors.
upgradeClient.Timeout = 2 * time.Minute
```
Also maybe it might be worth documenting this more clearly. Initial [PR](https://github.com/helm/helm/pull/13604 ) say:
> I have not written any docs, I assume that can be done when we are closer to Helm 4, a lot of it is covered by linking to - https://github.com/kubernetes-sigs/cli-utils/blob/master/pkg/kstatus/README.md
Related:
- https://github.com/helm/helm/pull/31411#issuecomment-3443925663
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Terry Howe
d93ef03ee4
fix: do not run release workflow on forks
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
George Jenkins
f352ced42b
Merge pull request #31468 from yardenshoham/issue-31456
...
Rename copilot-instructions.md to AGENTS.md
9 months ago
saimanojk1
6de83c5f60
Convert pkg/cmd/load_plugins.go to slog
...
Signed-off-by: saimanojk1 <saimanojk1@hotmail.com>
9 months ago
Yarden Shoham
caff03fb4e
Rename copilot-instructions.md to AGENTS.md
...
As of https://github.blog/changelog/2025-08-28-copilot-coding-agent-now-supports-agents-md-custom-instructions/ , AGENTS.md is supported.
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
9 months ago
George Jenkins
cdb48b88fb
Merge pull request #31240 from benoittgt/fix-31170-URN
...
jsonschema: warn and ignore unresolved URN $ref to match v3.18.4
9 months ago
tison
4576a81a00
for remaining local variable case inconsistency
...
Signed-off-by: tison <wander4096@gmail.com>
9 months ago
Benoit Tigeot
ed6cf0e8a1
Properly test error messages on pull command's test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Matt Farina
0f5eda74c1
Adding a LoadArchive to common loader
...
LoadArchive is in the individual loaders for the chart versions.
It is used by SDK users to load a stream rather than a file on
the filesystem. Adding to support SDK users like Flux.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
George Jenkins
384a3f0ff8
Merge pull request #31385 from porridge/test-unknown-policy
...
test: protect unknown hook delete policies
9 months ago
Robert Sirchia
5c2d99fd0d
Merge pull request #31452 from helm/dependabot/go_modules/main/sigs.k8s.io/controller-runtime-0.22.4
...
chore(deps): bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4
9 months ago
Robert Sirchia
fdaf26c53f
Merge pull request #31453 from helm/dependabot/go_modules/main/github.com/cyphar/filepath-securejoin-0.6.0
...
chore(deps): bump github.com/cyphar/filepath-securejoin from 0.5.0 to 0.6.0
9 months ago
tison
90d01915f9
for all other similar cases
...
Signed-off-by: tison <wander4096@gmail.com>
9 months ago
dependabot[bot]
21af58b822
chore(deps): bump github.com/cyphar/filepath-securejoin
...
Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin ) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases )
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md )
- [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.5.0...v0.6.0 )
---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
dependency-version: 0.6.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
9 months ago
dependabot[bot]
60aaa8a288
chore(deps): bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4
...
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime ) from 0.22.3 to 0.22.4.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases )
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md )
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.22.3...v0.22.4 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
dependency-version: 0.22.4
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
9 months ago
Scott Rigby
99cd196435
Merge pull request #31435 from matheuscscp/cancel-health-checks
...
Introduce a context for canceling wait operations
9 months ago
Matheus Pimenta
efc1702657
Introduce a context for canceling wait operations
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
9 months ago
George Jenkins
bdc459d73c
Merge pull request #31389 from TerryHowe/chore-more-registry-clean-up
...
chore: fix pkg/registry warnings to reduce noise
10 months ago
George Jenkins
841d8d7e76
Merge pull request #31364 from helm/dependabot/github_actions/main/github/codeql-action-4
...
chore(deps): bump github/codeql-action from 3 to 4
10 months ago
Benoit Tigeot
97b7a1c9ae
Merge branch 'main' into fix-31170-URN
...
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Matt Farina
9bed143103
Merge pull request #31323 from mattfarina/reproducible-chart-builds
...
Reproducible chart archive builds
10 months ago
Matt Farina
8834d90c60
Merge pull request #31440 from mattfarina/bump-go-1.25
...
Updating Go and golangci-lint versions
10 months ago
Matt Farina
15300549f0
When time not available, using time.Now
...
Note, when time is not available, the builds are not reproducible.
This problem would only happen when an SDK user is using parts of
the API to build their own tooling. Helm will consistently inject
the dates through the higher level APIs.
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
Matt Farina
c6334c2ac5
Updating Go and golangci-lint versions
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
Matt Farina
ca8eae9361
Reproducible chart archive builds
...
Building the same chart into an archive multiple times will have
the same sha256 hash.
Perviously, the time in the headers for a file was time.Now() which
changed each time. The time is now collected from the operating
system when the file is loaded and this time is used.
Fixes : #3612
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
Scott Rigby
f4c5220d99
Merge pull request #31411 from banjoh/em/reinstate-logger-param
...
feat: reinstate logger parameter to actions package
10 months ago
tison
0d6de28bf4
chore: fix typo of public field
...
Signed-off-by: tison <wander4096@gmail.com>
10 months ago
Evans Mungai
2ddeb50fa6
Set default logger in Configuration constructor
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
a94878fb89
Fix failing test
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
28bc76c364
Add tests for logging LogHolder
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
a112bf5aa6
Remove non-reachable code
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Matt Farina
1da2b0a6d4
Merge pull request #31204 from benoittgt/fix-31202
...
Avoid panic in helm.sh/helm/v3/pkg/chartutil.ValidateAgainstSchema
10 months ago
Robert Sirchia
25ad74f5a7
Merge pull request #31337 from rachelvweber/rawo/fixingWaitStrategy
...
Fixing rollback and uninstall client WaitStrategy
10 months ago
Evans Mungai
aed687eaa1
Add config options to NewConfiguration()
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
e63b4d92cb
Update internal/logging/logging.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
99fe9b3b9b
Update logging to use a param for the logger
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
d67b17b6ec
Minor name change
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
b6eca1c0f1
Refactor logging functionality to use slog.Handler
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
5ab4ca5490
Embed logging functionality to DRY code
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago