Kay Yan
141f2dd501
Fix typo
...
Unset the env var before func return in Unit Test
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
3 years ago
Matt Farina
5c698e9fa7
Updating Kubernetes packages to those from 1.23.1
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
3 years ago
Matt Farina
ca4e926009
Merge pull request #10470 from bridgetkromhout/prydonius-emeritus
...
Moving prydonius to emeritus
3 years ago
Neven Miculinic
5059ae843e
Fix install memory/goroutine leak
...
Signed-off-by: Neven Miculinic <neven.miculinic@gmail.com>
3 years ago
Bridget Kromhout
ad1110eaba
Moving prydonius to emeritus
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
3 years ago
root
679e14cd21
add legal name check
...
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
3 years ago
Andrew Block
797a8cd524
Honor --dependency-update flag in upgrade command
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Simon Alling
dd5db7bc40
Remove AssertGoldenBytes test helper
...
The test suite is thereby simplified somewhat.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
3 years ago
Simon Alling
0f15b01dfb
Remove runTestActionCmd and use runTestCmd instead
...
`runTestCmd` is identical to `runTestActionCmd` except that it
* runs the command multiple times if the `repeat` property is greater
than zero,
* calls its storage `storage` instead of `store`,
* fails if the `Create` method returns an error, and
* logs a "running cmd" message.
This is most easily demonstrated by copying the functions to their own
files and diffing the files with this command:
git diff --no-index --ignore-space-change --color-words=. runTestActionCmd.go runTestCmd.go
Also, `runTestCmd` is used 32 times; `runTestActionCmd` only 1.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
3 years ago
Matt Farina
8ca401398d
Merge pull request #10440 from jkmw/fix/10439
...
Fix memory leak in upgrade action
3 years ago
Jerome Küttner
9a492f8240
Channel should remain open if there is still a routine that wants to write into it
...
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 years ago
Jerome Küttner
ad3d2cc8ef
Fix memory leak in upgrade action
...
fixes helm/helm#10439
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 years ago
Matt Farina
0e6e936ab8
Merge pull request #10410 from helm/dependabot/go_modules/github.com/Masterminds/squirrel-1.5.2
...
chore(deps): bump github.com/Masterminds/squirrel from 1.5.1 to 1.5.2
3 years ago
Matthew Fisher
03d9e7ca62
Merge pull request #10425 from bridgetkromhout/CustomResourceDefinition-typo-fix
...
Bringing over an edit from the helm-www repo
3 years ago
Bridget Kromhout
21e1cd6027
Bringing over an edit from the helm-www repo
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
3 years ago
David Xia
13d86143f8
docs: Clarify use of --set-file
...
and fix non-idiomatic English.
replaces https://github.com/helm/helm-www/pull/1239
Signed-off-by: David Xia <dxia@spotify.com>
3 years ago
cndoit18
94dc605968
fix(rollback): fix helm rollback doesn't have meta.helm.sh annotations
...
Signed-off-by: cndoit18 <cndoit18@outlook.com>
3 years ago
dependabot[bot]
a840fb0940
chore(deps): bump github.com/Masterminds/squirrel from 1.5.1 to 1.5.2
...
Bumps [github.com/Masterminds/squirrel](https://github.com/Masterminds/squirrel ) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/Masterminds/squirrel/releases )
- [Commits](https://github.com/Masterminds/squirrel/compare/v1.5.1...v1.5.2 )
---
updated-dependencies:
- dependency-name: github.com/Masterminds/squirrel
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
Ashley Davis
0ab44aef70
add more error checks during the signing process
...
Before this change, several of the potential errors during the process
of signing a package were skipped.
Crucially, `Close()`ing the ReadCloser from the gpg clearsigner is the call
which actually does the signing, and so has several points of failure
which are ignored; for example, if there's a problem with the format of
the key.
Also changes the error from messageBlock() to be propagated rather than
being swallowed, and adds a test for the case where a signer fails to
sign.
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
3 years ago
Matthew Fisher
5d47255a3d
Merge pull request #10230 from yxxhero/fix_sdk_namespace_issue
...
add SetNamespace method for EnvSettings, in order to set namespace in helm sdk
3 years ago
Matthew Fisher
67f92d63fa
Merge pull request #9640 from wangchenglong01/wangchl01
...
Add error check to avoid panic
3 years ago
Matthew Fisher
c6961a9a78
Merge pull request #9794 from j6s/task/missing-dependency-message
...
Add hint to missing dependency message
3 years ago
Matthew Fisher
a8d33e7df4
Merge pull request #9918 from cndoit18/fix-issue-9915
...
fix(install): fix 9915
3 years ago
Matthew Fisher
de8034c097
Merge pull request #10390 from helm/dependabot/go_modules/github.com/mattn/go-shellwords-1.0.12
...
chore(deps): bump github.com/mattn/go-shellwords from 1.0.11 to 1.0.12
3 years ago
Matthew Fisher
ad71cc1ab7
Merge pull request #10387 from bhavin192/sts-ready-fix
...
fix(pkg/kube): statefulSetReady: handle partition cases correctly
3 years ago
dependabot[bot]
664d5e63e3
chore(deps): bump github.com/mattn/go-shellwords from 1.0.11 to 1.0.12
...
Bumps [github.com/mattn/go-shellwords](https://github.com/mattn/go-shellwords ) from 1.0.11 to 1.0.12.
- [Release notes](https://github.com/mattn/go-shellwords/releases )
- [Commits](https://github.com/mattn/go-shellwords/compare/v1.0.11...v1.0.12 )
---
updated-dependencies:
- dependency-name: github.com/mattn/go-shellwords
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
Bhavin Gandhi
c3310bb724
fix(pkg/kube): statefulSetReady: handle partition cases correctly
...
The partition value can be greater than number of replicas, in that
case no pods are rolled out. The expectedReplicas becomes a negative
number.
https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#partitions
In the cases where the update does not change anything in the pod
template, the updatedReplicas value from StatefulSet status remains
unchanged. Such updates can still set some partition value, and
UpdatedReplicas is always greater than expectedReplicas. Basically,
the StatefulSet is ready / rolled-out.
In both the above scenarios, providing `--wait` flag causes it to
timeout waiting indefinitely. Because updatedReplicas can never be
negative, or be equal to the expectedReplicas for the second case.
This commit handles both the scenarios by checking if UpdatedReplicas
is smaller than expectedReplicas. If it is, then the StatefulSet is
not ready yet.
Based on the code from kubectl rollout:
a450ebd59c/pkg/polymorphichelpers/rollout_status.go (L138-L141)
Closes #8674
Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
3 years ago
Martin Hickey
e03d20d8f4
Merge pull request #10401 from indreias/indreias-patch-1
...
Add support for installing on Windows via Cygwin
3 years ago
Tyler Auerbeck
4bf99e54eb
Update HELM_PLUGIN_SELF -> HELM_PLUGIN_DIR ( #10380 )
...
* Update HELM_PLUGIN_SELF -> HELM_PLUGIN_DIR
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
* Trigger Build
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
Co-authored-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
3 years ago
Ioan Indreias
799339316f
Add support for installing on Windows via Cygwin
...
Signed-off-by: Ioan Indreias <indreias@gmail.com>
3 years ago
Matt Farina
98c4ccf29b
Merge pull request #10341 from helm/dependabot/go_modules/github.com/Masterminds/squirrel-1.5.1
...
chore(deps): bump github.com/Masterminds/squirrel from 1.5.0 to 1.5.1
3 years ago
Matt Farina
0199f84014
Merge pull request #10342 from helm/dependabot/go_modules/github.com/gofrs/flock-0.8.1
...
chore(deps): bump github.com/gofrs/flock from 0.8.0 to 0.8.1
3 years ago
Matt Farina
eb276db17f
Merge pull request #10385 from mattfarina/k8s-1.22.4
...
Updating to Kubernetes 1.22.4 packages
3 years ago
Matt Farina
c2da47e22b
Updating to Kubernetes 1.22.4 packages
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Matt Farina
39471bcffd
Merge pull request #9705 from helm/dependabot/go_modules/github.com/mitchellh/copystructure-1.2.0
...
chore(deps): Bump github.com/mitchellh/copystructure from 1.1.1 to 1.2.0
3 years ago
dependabot[bot]
6a1daecd0c
chore(deps): bump github.com/Masterminds/squirrel from 1.5.0 to 1.5.1
...
Bumps [github.com/Masterminds/squirrel](https://github.com/Masterminds/squirrel ) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/Masterminds/squirrel/releases )
- [Commits](https://github.com/Masterminds/squirrel/compare/v1.5.0...v1.5.1 )
---
updated-dependencies:
- dependency-name: github.com/Masterminds/squirrel
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
dependabot[bot]
6d96e5e4d6
chore(deps): Bump github.com/mitchellh/copystructure from 1.1.1 to 1.2.0
...
Bumps [github.com/mitchellh/copystructure](https://github.com/mitchellh/copystructure ) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/mitchellh/copystructure/releases )
- [Commits](https://github.com/mitchellh/copystructure/compare/v1.1.1...v1.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
Josh Dolitsky
dd0177aed7
Merge pull request #10377 from bloodorangeio/oras-1.0.0
...
Upgrade to oras-go v1.0.0
3 years ago
Matt Farina
5f74c0e17f
Merge pull request #10370 from mattfarina/fix-10367
...
Fix specifying of Kubernetes version from build scripts
3 years ago
Josh Dolitsky
b66c468812
Upgrade to oras-go v1.0.0
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
3 years ago
Matthew Fisher
f7e56a27fc
Merge pull request #10372 from zonggen/add-zonggen-to-triage-maintainers-list
...
OWNERS: add zonggen to triage maintainers list
3 years ago
Allen Bai
08eb75b3cd
OWNERS: add zonggen to triage maintainers list
...
Ref: https://lists.cncf.io/g/cncf-helm/message/401
Signed-off-by: Allen Bai <abai@redhat.com>
3 years ago
Matt Farina
7838fb769d
Fix specifying of Kubernetes version from build scripts
...
This bug came about because of three issues that this change
corrects:
- The CI scripts run on a pull request did not test building
Helm. This means that a failure to set a variable using LDFLAGS
had no opportunity to be caught.
- #8608 provided a means to match the k8s version used in linting
and chartutil with the version of the package we pull in. With
one problem. It attempts to set a const as if it were a string.
This is ignored and everyone missed it.
- #10325 moved those constants to vars so it could be set. This
looked good and passed tests but missed that you can't set an
int as if it were a string. See first bullet.
This change fixes this by moved the internal representation to
be a string. These are internal variables not exposed in the public
API which makes this change non-breaking to the API.
Closes #10367
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
dependabot[bot]
46a643fff4
chore(deps): bump github.com/gofrs/flock from 0.8.0 to 0.8.1
...
Bumps [github.com/gofrs/flock](https://github.com/gofrs/flock ) from 0.8.0 to 0.8.1.
- [Release notes](https://github.com/gofrs/flock/releases )
- [Commits](https://github.com/gofrs/flock/compare/v0.8.0...v0.8.1 )
---
updated-dependencies:
- dependency-name: github.com/gofrs/flock
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
Matthew Fisher
d31261f47c
Merge pull request #10362 from helm/dependabot/go_modules/github.com/docker/docker-20.10.11incompatible
...
chore(deps): bump github.com/docker/docker from 20.10.9+incompatible to 20.10.11+incompatible
3 years ago
dependabot[bot]
7293ac2388
chore(deps): bump github.com/docker/docker
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 20.10.9+incompatible to 20.10.11+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/docker/docker/compare/v20.10.9...v20.10.11 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
Martin Hickey
f86694232b
Merge pull request #10351 from helm/dependabot/go_modules/github.com/lib/pq-1.10.4
...
chore(deps): bump github.com/lib/pq from 1.10.3 to 1.10.4
3 years ago
dependabot[bot]
fdb97665e4
chore(deps): bump github.com/lib/pq from 1.10.3 to 1.10.4
...
Bumps [github.com/lib/pq](https://github.com/lib/pq ) from 1.10.3 to 1.10.4.
- [Release notes](https://github.com/lib/pq/releases )
- [Commits](https://github.com/lib/pq/compare/v1.10.3...v1.10.4 )
---
updated-dependencies:
- dependency-name: github.com/lib/pq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
Matt Farina
6809070032
Merge pull request #10325 from sboschman/lint-with-ldflags
...
allow ldflags to overwrite k8s version
3 years ago
Josh Dolitsky
a63489ad28
Merge pull request #10294 from joshrwolf/oras-0.5
...
upgrade oras to 0.5.0, refactor client oci logic to use new oras.Copy()
3 years ago