Zach Burgess
cc85352a0e
Use `assert.Len` instead of `assert.Lenf`
...
The default message from testify is descriptive enough.
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
c59a097209
Remove duplicate test case from crds_test.go
...
The "good" test case for CRDs is done in `TestGoodChart` in lint_test.go.
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
bf9084a16a
Rename `validateCrdApiVersion` to `validateCrdAPIVersion`
...
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
357957b0d3
Use testify and add a CRD to the `goodone` test case.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
dadaff716a
Merge branch 'helm:main' into crds_lint
6 months ago
George Jenkins
bbea98ed6b
Merge pull request #30898 from fidelity-contributions/fix-issue-13198
...
Fix issue 13198
6 months ago
George Jenkins
edd0dabe02
Merge pull request #31021 from zachburg/test_temp_dir
...
Update tests in create_test.go and package_test.go to work in a temp directory
6 months ago
Matt Farina
e8be2e540d
Merge pull request #31023 from gjenkins8/gjenkins/rm_recreate_pods
...
Remove deprecated '--create-pods' flag
6 months ago
George Jenkins
a3bcc5b184
fix: 'TestRunLinterRule' stateful test
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
George Jenkins
5283915c57
Remove deprecated '--create-pods' flag
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
Zach Burgess
eaf40b4b4f
Call `ensure.HelmHome()` in package_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Matt Farina
9517cfc5ce
Merge pull request #31009 from tpresa/test-coverage-pusher
...
test: increase test coverage for pkg/pusher
6 months ago
Zach Burgess
c48a3435f5
Remove unnecessary calls for changing directory to `helmpath.CachePath`.
...
This was only set on some tests in create_test.go and isn't
affecting the test.
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
3b26ddc22b
Update tests in create_test.go and package_test.go to work in a temp dir.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
a99c3700f0
Return early if the `/crds` directory does not exist.
...
Don't silently discard the error from `os.Stat`.
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
562ff982cb
Early return if the `/crds` directory does not exist and don't silently discard the error from `os.Stat`.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
d6ddd8e661
Document that attempting to parse YAML checks that the CRD is not a
...
template
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
e4c88faeff
Update test assertions
...
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
bc35ea5ad7
Fix comment in pkg/lint/rules/testdata/invalidcrdsdir/values.yaml
...
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Zach Burgess
21b9aa3d94
Lint the `crds/` directory.
...
This checks that the `crds/` dir only contains YAML files that define
K8s resources with `kind: CustomResourceDefinition`.
Checking that the YAML files are not templates will be done in a
separate commit.
Signed-off-by: Zach Burgess <zachburg@google.com>
6 months ago
Thiago Presa
afd63fed77
test: increase test coverage for pkg/pusher
...
Signed-off-by: Thiago Presa <thiago.addevico@gmail.com>
6 months ago
Matt Farina
f0cf9c28f0
Move logging setup to be configurable
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
6 months ago
curlwget
bfc1af68fb
chore: fix function in comment
...
Signed-off-by: curlwget <curlwget@icloud.com>
6 months ago
George Jenkins
a2a0935cba
Merge pull request #30900 from unguiculus/issue-12952
...
Add timeout flag to repo add and update commands
6 months ago
Robert Sirchia
ba0fbdeb57
Merge pull request #30979 from TerryHowe/oras-v2-login-for-v4
...
fix: OAuth username password login for v4
6 months ago
Terry Howe
df482346db
fix: lint test SetEnv errors
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Terry Howe
47980159b3
fix: user username password for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
manslaughter03
bc44614a78
fix: wrap run release test error in case GetPodLogs failed.
...
Signed-off-by: manslaughter03 <manslaughter03@gmail.com>
7 months ago
Terry Howe
744c6b5a97
fix: kube client create mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Ashmit Bhardwaj
e060fbe185
updated docs
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
7 months ago
Ashmit Bhardwaj
0389407cbc
removed unnecessary binary file
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
7 months ago
Ashmit Bhardwaj
b305a501e8
added documentation and test cases for api-versions flag
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
7 months ago
Terry Howe
93ec064640
fix: repo update cmd mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
acceptacross
9623fb80f1
chore: fix some function names in comment
...
Signed-off-by: acceptacross <csqcqs@gmail.com>
7 months ago
Matt Farina
7031000b7d
Merge pull request #30955 from carloslima/fix-test-deleting-local-directories
...
Fix tests deleting XDG_DATA_HOME
7 months ago
Scott Rigby
069b525332
Merge pull request #13586 from jessesimpson36/cleaner-stacktraces
...
fix: add formatting for errors to make multiline stacktraces in helm templates
7 months ago
Carlos Lima
f8204031f1
Fix tests deleting XDG_DATA_HOME
...
That includes ~/.local/share/keyrings which was the most immediatelly
visible effect.
Signed-off-by: Carlos Lima <carlos@cpan.org>
7 months ago
Robert Sirchia
c0aa690c90
Merge pull request #30909 from jinjiadu/main
...
refactor: replace HasPrefix+TrimPrefix with CutPrefix
7 months ago
Scott Rigby
e2630d1aba
Merge pull request #30939 from TerryHowe/action-hooks-delete-policy-mutex
...
fix: action hooks delete policy mutex
7 months ago
Scott Rigby
de745ea34b
Merge pull request #12581 from Nordix/considerAllGroupVersionKind
...
Consider full GroupVersionKind when matching resources
7 months ago
Scott Rigby
e8c1acf228
Merge pull request #30809 from mmorel-35/usetesting
...
chore: enable usetesting linter
7 months ago
Scott Rigby
4023c3b5ff
Merge pull request #30917 from TerryHowe/oci-transport-debugging
...
fix: add debug logging to oci transport
7 months ago
Terry Howe
a8cbf3aa51
fix: action hooks delete policy mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
Terry Howe
6ab7aa3612
fix: legacy docker support broken for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Terry Howe
5fe7a87138
fix: add debug logging to oci transport
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
7 months ago
Benoit Tigeot
6df8eb3b3b
Fix flaky TestFindChartURL due to non-deterministic map iteration
...
The test was failing intermittently because Go's map iteration order
is randomized (see `range repos` in `findChartUrl`).
When looking up the `baz` chart with repository URL http://example.com/helm ,
two repositories match due to trailing slash equivalence:
- testing-relative (URL: http://example.com/helm ) - contains baz chart GOOD
- testing-relative-trailing-slash (URL: http://example.com/helm/ ) - does not contain baz chart.. NOT GOOD
The urlutil.Equal() function treats these URLs as equivalent, but
depending on which repository the random map iterator encounters
first, the test would either pass or fail with "entry not found".
So I changed the third test case from baz to foo chart, since foo exists
in both matching repositories. This eliminates the race condition while
preserving all test expectations and logic.
`findChartURL()` iterates over a map without deterministic
ordering, causing the first-match-wins behavior to be non-deterministic
when multiple repositories match the same URL pattern.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
7 months ago
Scott Rigby
d4e58c54ba
Merge pull request #30928 from TerryHowe/fix-plugin-install-no-internet
...
fix: plugin installer test with no Internet
7 months ago
Terry Howe
cc39d2428f
fix: plugin installer test with no Internet
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Benoit Tigeot
b2fd91b8d0
Adapt error of invalid json schema with the new expected output
...
Closes: https://github.com/helm/helm/pull/30907
To be able to upgrade to v6.0.2 for jsonschema lib we need to upgrade
this test.
I am wondering if it's related to this commit:
86cca28795
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
7 months ago