This update moves to ubuntu jammy. The name moves off of debian
version names because jammy is based on bookworm and azure cli
does not have debian package support with bookworm
This is an update to the previous update for this because the
CircleCI environment is ubuntu 20.04 but the container this is
running is has 22.04 as the ubuntu version. Updating the in
container to 22.04 (jammy).
Signed-off-by: Matt Farina <matt.farina@suse.com>
CircleCI is now using Ubuntu 20.04 for the Go 1.18 image. The
azure CLI is expecting a version older than that. This change
updates.
Note, we have been using the debian name for the repo rather than
the ubuntu name. bullseye maps to Ubuntu 20.04 through 21.10.
Signed-off-by: Matt Farina <matt.farina@suse.com>
golint which is used as one of the sublinters in golangci-lint is deprecated.
It is replaced with revive which is a drop-in replacement.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Co-authored-by: Martin Mulholland <mmulholl@redhat.com>
This bug came about because of three issues that this change
corrects:
- The CI scripts run on a pull request did not test building
Helm. This means that a failure to set a variable using LDFLAGS
had no opportunity to be caught.
- #8608 provided a means to match the k8s version used in linting
and chartutil with the version of the package we pull in. With
one problem. It attempts to set a const as if it were a string.
This is ignored and everyone missed it.
- #10325 moved those constants to vars so it could be set. This
looked good and passed tests but missed that you can't set an
int as if it were a string. See first bullet.
This change fixes this by moved the internal representation to
be a string. These are internal variables not exposed in the public
API which makes this change non-breaking to the API.
Closes#10367
Signed-off-by: Matt Farina <matt.farina@suse.com>
Since we've moved to Go 1.14, golangci-lint has been silently failing.
This commit updates to a compatible version.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
* Removed the parallelism as it was running the same tests 3 times
* Removed caching as the time to cache/restore is about the same
as without caching
Signed-off-by: Matt Farina <matt@mattfarina.com>
While we still don't want to upload to GCS/GCR, we also don't want the CI run to fail because we are just skipping the step. This is most usually seen in the `release-X.Y` branches cut every minor release.
This commit does a few things:
* It moves the information being cached to be the glide cache.
This will make the glide install process faster.
* The cache is restored from prior to installing the dependencies.