c59f26a659
implement host validation for login to check for URL schemes and paths. Halt the execution if any is found with a dedicated error message.
...
Signed-off-by: Yannick Alexander <yannick@alexanderdev.io>
4 months ago
85bf56ea82
docs(registry): fix incorrect and improve clarity of comments in client.go
...
- Fixed incorrect comment in ClientOptPlainHTTP
- Improved clarity of LoginOptPlainText comment
- Enhanced Login function documentation
- Improved wording for ClientOptHTTPClient
No functional changes.
Signed-off-by: Debasish Mohanty <139056705+Debasish-87@users.noreply.github.com>
5 months ago
8e44f8e3fe
Merge pull request #31957 from Mentigen/add-mustToToml
...
feat(engine): add mustToToml template function
5 months ago
c1a5a6e260
docs(engine): fix misleading toTOML doc comment
...
The toTOML doc comment said "returns empty string on marshal error"
but the implementation actually returns err.Error(). Fix the comment
to match the real behavior. Also mention mustToToml as the strict
alternative.
Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>
5 months ago
b075f7a35d
feat(engine): add mustToToml template function
...
Add `mustToToml` that panics on marshal error, consistent with
`mustToYaml` and `mustToJson`. This makes it possible for chart authors
to get a hard failure when TOML serialization fails, rather than having
to inspect the output manually.
`toToml` behavior is unchanged in this commit.
Closes #31430
Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>
5 months ago
7edfff33eb
chore: fix unnecessary-format issues from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
42f78ba60e
Merge pull request #31872 from mmorel-35/perfsprint-pkg-6-5f845e3
...
chore(pkg): fix perfsprint linter issues part 6
5 months ago
e3b4808450
Merge pull request #31874 from mmorel-35/perfsprint-pkg-4-fb6db58
...
chore(pkg): fix perfsprint linter issues part 4
5 months ago
610547b570
Merge pull request #31873 from mmorel-35/perfsprint-pkg-5-3294250
...
chore(pkg): fix perfsprint linter issues part 5
5 months ago
d3df72e560
Merge pull request #31932 from TerryHowe/fix/remove-legacy-import-comments-test-files
...
pkg/kube: remove legacy import comments from test files
5 months ago
e64d628a13
fix(kube): remove legacy import comments from test files
...
Remove pre-Go modules import path comments from pkg/kube test files
(ready_test.go, resource_test.go, statuswait_test.go) for consistency
with the rest of the package.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
d7cdc9e8fb
pkg/kube: remove legacy import comments
...
Import path comments (e.g. `// import "helm.sh/helm/v4/pkg/kube"`) are
a pre-Go modules convention no longer needed in module-aware builds.
Some files in pkg/kube had these comments while others did not, causing
inconsistency that triggered downstream Kythe indexing errors.
Remove the import comments from all affected files to make the package
declaration consistent across the directory.
Fixes #31846
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
5 months ago
259f181808
chore: fix some minor issues in the comments
...
Signed-off-by: tsinglua <tsinglua@outlook.com>
5 months ago
3e7b38fd04
Merge pull request #31868 from matheuscscp/fix-31867
...
fix: insert newline after doc separators glued to content by template trimming
5 months ago
af94abf976
fix: insert newline after doc separators glued to content by template trimming
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
5 months ago
e31a078e6e
chore: enable modernize linter ( #31860 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
16573f87f5
Restored --atomic flag on install command
...
Signed-off-by: Travis Leeden <travis.leeden@octopus.com>
5 months ago
df8e0301ed
Merge pull request #31878 from mmorel-35/perfsprint-pkg-3-39f7a9f
...
chore(pkg): fix perfsprint linter issues part 3
5 months ago
4f9f18c453
Merge pull request #31875 from mmorel-35/perfsprint-pkg-2-0e1acbc
...
chore(pkg): fix perfsprint linter issues part 2
5 months ago
c4392033cc
Merge pull request #31853 from atombrella/feature/fmt_unneeded
...
Replace non-format use of t.Fatalf with t.Fatal
5 months ago
58f066b9a5
Merge pull request #31879 from mmorel-35/perfsprint-pkg-7-a389500
...
chore(pkg): fix perfsprint linter issues part 7
5 months ago
5d40f17011
Update pkg/cmd/status.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
dc0e3f10c3
chore(pkg): fix perfsprint linter issues part 6
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
e3c74fd9fa
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
1d2d63cc43
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
63f03c0f5c
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
c25c988cfb
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/registry
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
0fecfd04c2
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
6c2cb2f547
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
36cb3a2fe9
Replace unneeded use of t.Fatalf with t.Fatal
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
5 months ago
5b6c6bbfc7
fix: enable nolinlint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
d275b925c4
Merge pull request #31852 from rohansood10/fix/31846-import-comment
...
fix: correct import comment in statuswait.go from v3 to v4
6 months ago
be7cdb69e5
Merge pull request #31806 from mmorel-35/errorlint-pkg-4-15f432a
...
fix(pkg): errorlint linter
6 months ago
3dfc4f3cf6
Merge pull request #31858 from helm/gjenkins/go_fix
...
chore: `go fix` fixes
6 months ago
3ad9ccdb19
Merge pull request #31563 from Mujib-Ahasan/dry-run-fix
...
fix: --dry-run=server now respect generateName
6 months ago
b667317422
fixup `strings.Cut` variables
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
92b64e87ad
chore: fixes
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
c59c140ce0
fix: correct import comment in statuswait.go from v3 to v4
...
The import comment in pkg/kube/statuswait.go still referenced
helm.sh/helm/v3/pkg/kube while all other files in the package
correctly reference helm.sh/helm/v4/pkg/kube. This mismatch
causes downstream processing errors (e.g. kythe) when vendoring
Helm.
Fixes #31846
Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
6 months ago
ee018608f6
fix: handle OCI digest algorithm prefix in chart downloader ( #31601 )
...
* fix: strip digest algorithm prefix before hex decoding
OCI references with tag+digest (e.g., chart:1.0@sha256:abc...) failed with "invalid byte" error because the sha256: prefix was passed to hex.DecodeString().
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add cmd test for OCI references with tag+digest
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Move oci registry push result to a struct
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Review comments from PR review
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Fix failing test
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
---------
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
b26ec6b09e
Merge pull request #31566 from TerryHowe/fix-test-concurrency-download-index
...
fix: test concurrency download index
6 months ago
794372e317
Merge pull request #31816 from mmorel-35/errorlint-pkg-7-6d6a660
...
fix(pkg): errorlint linter
6 months ago
4a91f3ad5c
feat(release): add internal/release/v2 package for chart v3 support ( #31709 )
...
Introduce release/v2 that mirrors pkg/release/v1 but uses *v3.Chart
from internal/chart/v3. The code is structurally identical to v1 with
only import paths changed to reference internal/chart/v3 instead of
pkg/chart/v2.
- Add internal/release/v2 with Release, Info, Hook types
- Add internal/release/v2/util with filter, sorter, manifest utilities
- Update pkg/release/common.go with v2Accessor and v2HookAccessor
- Copy all test files from pkg/release/v1 and add a v2 test in common_test.go
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
b6fbb68c2b
Merge pull request #31776 from t0rr3sp3dr0/pedrotorres/fix-oci-index-pull
...
fix regression when pulling charts from OCI indices
6 months ago
947b429cdd
Merge pull request #31801 from mmorel-35/modernize-pkg-4-062b248
...
chore(pkg): fix modernize linter
6 months ago
78f5af72be
Merge pull request #31802 from mmorel-35/modernize-pkg-5-a3c8fdb
...
chore(pkg): fix modernize linter
6 months ago
70899a6b3f
Merge pull request #31578 from manute/main
...
fix(action): crd resources can be empty
6 months ago
14e0b8f970
Merge pull request #31128 from orgads/win-parallel
...
fix(downloader): prevent concurrent file access errors on Windows
6 months ago
56d0d9374a
Merge pull request #31810 from mmorel-35/errorlint-pkg-5-dda0145
...
fix(pkg): errorlint linter
6 months ago
7f9703fe22
Merge pull request #31811 from mmorel-35/errorlint-pkg-3-39f7a9f
...
fix(pkg): errorlint linter
6 months ago
259f76a849
fix(pkg): errorlint linter
...
errorlint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Yannick Alexander
Debasish Mohanty
Terry Howe
Ilya Kiselev
Matthieu MOREL
George Jenkins
abhay1999
tsinglua
Matheus Pimenta
Travis Leeden
Mads Jensen
rohansood10
Evans Mungai
Matt Farina
Joe Julian