Scott Rigby
bd754a054c
Bring exact version check logic from IndexFile.Get into registry tag check
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Andrew Block
291c17fcc5
Enabled auth and support http registries for OCI
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Scott Rigby
4c8a3faaa2
Fix import
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
b6bf3905f3
Implement reusable GetTagMatchingVersionOrConstraint
...
Largely borrowed from (IndexFile).Get. However there is not currently a nice
way to make this code also usable to the repo package, as IndexFile depends on
a list of index Entries containing a nexted version.
We could refactor this later to somehow use the same shared function, but for
now keeping separate.
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Andrew Block
df98e18eb7
Working oci code without providing versions
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
0fae7f5008
Updated tag resolver logic
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
9a7c362dd1
Initial tag listing support
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Allen Bai
e3897ad6b1
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
...
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.
Ref:
- https://github.com/helm/helm/pull/10536#issuecomment-1010144075
- https://github.com/oras-project/oras-go/pull/92
Signed-off-by: Allen Bai <abai@redhat.com>
4 years ago
Allen Bai
e08a9270be
HELM_REGISTRY_CONFIG: change default file of registry config to config.json
...
Changes default registry config file from `registry.json` to
`config.json`. This aligns with the `config.json` that is widely used in docker.
Closes: https://github.com/helm/helm/issues/10156
Related: https://github.com/helm/helm/issues/10122
Signed-off-by: Allen Bai <abai@redhat.com>
4 years ago
Josh Wolf
fed0d31bf5
ensure consistency in registry client Push/Pull function signatures. ensure message is only printed when tags contain a replaced character
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
4 years ago
Scott Rigby
157ac85ab7
Fix typo. Thanks buildbot. Also comments at 80 chars
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Josh Wolf
fb0eeebf66
add oci reference validation and tag scoped (+) replacement to registry client Push/Pull
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
4 years ago
Scott Rigby
8424bc2b60
Update registry underscore message with semver note for extra clarity
...
Add newline to registry underscore message
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
4aacbc44e0
Move plus/underscore change to inside Client. Compare original ref for strict mode
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Josh Wolf
fae5009382
ensure error is correctly handled when generating chart's oci manifest
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
4 years ago
Josh Wolf
d2d8e52401
modify oci chart push/pull manifest test values to represent new order sorted by oras
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
4 years ago
Josh Wolf
7cec93d9fb
upgrade oras to 0.5.0, refactor client oci logic to use new oras.Copy()
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
4 years ago
Matt Farina
81f0df0ea6
Merge pull request #10182 from spectrocloud/oci-allow-any-media-type
...
changes to support any mediatype for layers on download
4 years ago
Kai Takac
52cbc2f49c
Fix default registry config path of oci protocol provider
...
Signed-off-by: Kai Takac <kai.takac@gmail.com>
4 years ago
LochanRn
9e29f1619b
changes to support any mediatype for layers on download
...
Signed-off-by: LochanRn <rajanaga_ra@srmuniv.edu.in>
4 years ago
Josh Dolitsky
0121f6a328
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
John Howard
82a2abf512
Update oras-go to v0.4.0
...
Signed-off-by: John Howard <howardjohn@google.com>
4 years ago
Josh Dolitsky
82cdb0b793
modify registry test to only listen on loopback
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Matthew Fisher
4801818f7c
Switch to distribution v3
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Nicolas De Loof
663c569887
Migrate to oras-go library
...
see https://github.com/deislabs/oras/pull/265
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
4 years ago
Josh Dolitsky
8202ccd699
Remove LoginResult/LogoutResult types
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
230e37ca52
remove hardcoded oci strings, add constant/util
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
bfa5036a1a
consolidate registry source files
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
faf7fc5efd
use version.GetUserAgent
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
8f60ee76a5
resolve golint errors
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
4073e4d118
inline data fetching for pull result
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
dd7bc40bc4
one-line JSON unmarshall
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
817ac8ff9f
do not wrap single imports/vars
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
f7247c40ee
Upgrade to oras-go v0.4.0
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
00985cad6b
Implement changes proposed in HIP 6
...
For more information, please see the following URL:
https://github.com/helm/community/blob/main/hips/hip-0006.md
Note: OCI support remains experimental, and you are still
required to set HELM_EXPERIMENTAL_OCI=1 in your environment.
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
cndoit18
a79cad5539
support max-col-width parameters
...
support commands:
- helm chart list
- helm dependency list
Signed-off-by: cndoit18 <cndoit18@outlook.com>
4 years ago
Peter Engelbert
3028c55858
Clean up imports and add doc comments
...
Additionally, revert `NewPull()` to its existing signature.
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
5 years ago
Peter Engelbert
3ad08f3ea9
Implement `helm pull` for OCI registries
...
* Implement `helm dep update` for oci dependencies
* New unit tests
* Remove `helm chart pull` command
* New `helm pull` does not depend on registry cache
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
5 years ago
bellkeyang
fbc32aea3d
bufix: fix validateNumColons docs
...
Signed-off-by: bellkeyang <bellkeyang@tencent.com>
5 years ago
Peter Engelbert
7e9a83184c
Determine chart digest by manifest ( #8249 )
...
Currently, whenever the chart is printed, the digest of the .tar.gz
content layer is printed as the digest. The manifest digest is important
for OCI purposes, particularly in pushing to a registry.
Resolves #8248 .
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
5 years ago
Guangwen Feng
7ec501155d
Fix golint issue
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
5 years ago
Matthew Fisher
65ee1e0bc1
Merge pull request #7356 from EItanya/helm-7351
...
--registry-config flag is not honored
5 years ago
Matthew Fisher
47feb20042
Merge pull request #8220 from bloodorangeio/fix-helm-chart-list-crash-bug
...
Fix crashing `helm chart list` with large list
5 years ago
Adam Reese
a01adcebfd
Merge pull request #8089 from junaid18183/master
...
Fixes repo parsing
5 years ago
Peter Engelbert
f11e74ee57
Add unit test for man-in-the-middle attack on pull
...
Add a unit test that proves the digest of the received content being
checked. The check should ensure that the digest of the received content
is identical to the digest provided by the manifest in the layers[0]
descriptor. This check is currently implemented in containerd, so the
unit test ensures security in the case a breaking change is made in
containerd.
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
5 years ago
Peter Engelbert
a0fd1d81f0
Fix crashing `helm chart list` with large list
...
With a large list of charts, `helm chart list` will crash with the
following message:
```
$ helm chart list --debug
Error: open
/home/me/.cache/helm/registry/cache/blobs/sha256/109971e44d63f7fd11fff60d19db41c2429a136943be2e3f8fd3e4c165156536:
too many open files
helm.go:75: [debug] open
/home/me/.cache/helm/registry/cache/blobs/sha256/109971e44d63f7fd11fff60d19db41c2429a136943be2e3f8fd3e4c165156536:
too many open files
```
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
5 years ago
Juned Memon
95e9e18ab5
Removed scheme
...
Signed-off-by: Juned Memon <junaid18183@gmail.com>
5 years ago
Juned Memon
8cb9ab7095
Fixes repo parsing
...
Signed-off-by: Juned Memon <junaid18183@gmail.com>
5 years ago
Juned Memon
b473f8adec
Fixes repo parsing
...
Signed-off-by: Juned Memon <junaid18183@gmail.com>
5 years ago
EItanya
872d9bcb0e
Merge branch 'master' of github.com:helm/helm into helm-7351
6 years ago