Matthieu MOREL
33c2839569
chore(pkg): refactor: convert tests to testify assert/require part 19
...
refactor: convert tests to testify assert/require in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
George Jenkins
440cc223c5
Merge pull request #32405 from mmorel-35/testifylint-manual-assert-internal-1
...
chore(internal): refactor: convert tests to testify assert/require part 1
2 months ago
George Jenkins
715888a5eb
Merge pull request #32410 from mmorel-35/testifylint-manual-assert-internal-6
...
chore(internal): refactor: convert tests to testify assert/require part 6
2 months ago
George Jenkins
e126cd327a
Merge pull request #32409 from mmorel-35/testifylint-manual-assert-internal-5
...
chore(internal): refactor: convert tests to testify assert/require part 5
2 months ago
George Jenkins
c9d9428e78
Merge pull request #32415 from mmorel-35/testifylint-manual-assert-pkg-1
...
chore(pkg): refactor: convert tests to testify assert/require part 1
2 months ago
Matthieu MOREL
0b1aa55cbb
chore(pkg): refactor: convert tests to testify assert/require part 22
...
#### Description
refactor: convert tests to testify assert/require in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
a934b827fa
chore(pkg): refactor: convert tests to testify assert/require part 21
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
1d4665e54c
chore(pkg): refactor: convert tests to testify assert/require part 20
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
fb8a62bf13
chore(pkg): refactor: convert tests to testify assert/require part 18
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
0fa9f7d427
chore(pkg): refactor: convert tests to testify assert/require part 16
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
4073566e28
chore(pkg): refactor: convert tests to testify assert/require part 17
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
71733656a5
chore(pkg): refactor: convert tests to testify assert/require part 15
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
dc66ee7be7
chore(pkg): refactor: convert tests to testify assert/require part 14
...
refactor: convert tests to testify assert/require in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
aae82bf97a
chore(pkg): refactor: convert tests to testify assert/require part 13
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
a3fa28ae22
chore(pkg): refactor: convert tests to testify assert/require part 12
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
dc3e3a5e7e
chore(pkg): refactor: convert tests to testify assert/require part 11
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
2f5a33fb77
chore(pkg): refactor: convert tests to testify assert/require part 10
...
#### Description
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
13d1edc5f3
chore(pkg): refactor: convert tests to testify assert/require part 9
...
refactor: convert tests to testify assert/require in pkg/chart/common/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
e5f0e07b96
chore(pkg): refactor: convert tests to testify assert/require part 8
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
ca1767b813
chore(pkg): refactor: convert tests to testify assert/require part 7
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
0daa77fa9b
chore(pkg): refactor: convert tests to testify assert/require part 2
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Terry Howe
3f1f55c4c8
Merge pull request #32420 from mmorel-35/testifylint-manual-assert-pkg-6
...
chore(pkg): refactor: convert tests to testify assert/require part 6
2 months ago
Terry Howe
90669b3a78
Merge pull request #32419 from mmorel-35/testifylint-manual-assert-pkg-5
...
chore(pkg): refactor: convert tests to testify assert/require part 5
2 months ago
Terry Howe
b100b44bef
Merge pull request #32418 from mmorel-35/testifylint-manual-assert-pkg-4
...
chore(pkg): refactor: convert tests to testify assert/require part 4
2 months ago
Matthieu MOREL
d4ec8e9b87
chore(pkg): refactor: convert tests to testify assert/require part 1
...
refactor: convert tests to testify assert/require in pkg/engine
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
0844b3b8b5
chore(pkg): refactor: convert tests to testify assert/require part 6
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
3ff05c835e
chore(pkg): refactor: convert tests to testify assert/require part 5
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
658a8fac15
chore(pkg): refactor: convert tests to testify assert/require part 4
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
df2d013517
chore(pkg): refactor: convert tests to testify assert/require part 3
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
dependabot[bot]
8c7f3a14d2
chore(deps): bump actions/checkout from 7.0.0 to 7.0.1 ( #32411 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 7.0.0 to 7.0.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](9c091bb21b...3d3c42e5aa )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 7.0.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 months ago
Matthieu MOREL
6c45810119
chore(internal): refactor: convert tests to testify assert/require part 4 ( #32408 )
...
refactor: convert tests to testify assert/require in internal/chart/v3/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
668e7e580a
chore(internal): refactor: convert tests to testify assert/require part 3
...
refactor: convert tests to testify assert/require in internal
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
f1d5979e7d
chore(internal): refactor: convert tests to testify assert/require part 5
...
refactor: convert tests to testify assert/require in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
f3402c1cd6
chore(internal): refactor: convert tests to testify assert/require part 6
...
refactor: convert tests to testify assert/require in internal/plugin
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
ba31ca0c0b
chore(internal): refactor: convert tests to testify assert/require part 1
...
refactor: convert tests to testify assert/require in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
615a299876
chore(internal): refactor: convert tests to testify assert/require part 2
...
#### Description
refactor: convert tests to testify assert/require in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Gates Wang
0604d8fb1e
fix: pass registry client to downloader.Manager in upgrade
...
`helm upgrade --dependency-update` built its downloader.Manager without a
RegistryClient, unlike the identical literals in install, dependency update,
and dependency build. Resolving an OCI chart dependency whose version is a
range then dereferenced a nil *registry.Client in registry.(*Client).Tags,
panicking the process. Pass the registry client already constructed for the
command, matching install.
Add a regression test that runs `upgrade --dependency-update` against a chart
with an unresolved OCI dependency and asserts the command returns an error
instead of panicking.
Signed-off-by: Gates Wang <9372086+SetagGnaw@users.noreply.github.com>
2 months ago
George Jenkins
06978bd8c5
Merge pull request #32371 from benoittgt/ci/tag-v4
...
ci: auto-label PRs targeting main with v4.x
2 months ago
George Jenkins
ccb8f595ab
Merge pull request #32374 from helm/dependabot/github_actions/main/github/codeql-action/autobuild-4.37.1
...
chore(deps): bump github/codeql-action (init, autobuild, analyze) to 4.37.1
2 months ago
Zhaofeng Miao
3bcf965f99
perf: enable concurrent status computation to prevent multi-minute delays ( #32043 )
...
* fix: enable concurrent status computation to prevent multi-minute delays
Set StatusComputeWorkers=8 on DefaultStatusWatcher for Wait,
WaitWithJobs, and WatchUntilReady. This opts in to the async status
computation added in fluxcd/cli-utils#20 , preventing the informer
notification pipeline from being blocked by slow API calls when many
resources are updated simultaneously.
Without this, status computation for resources like Deployments (which
require additional LIST ReplicaSets/Pods calls) runs serially inside
the informer, causing growing delays of 1-3+ minutes when upgrading
many resources at once (e.g., ~20 Deployments via Helm).
Signed-off-by: maplemiao <maplemiao@tencent.com>
* refactor(kube): expose StatusComputeWorkers as a WaitOption
Replace the package-level DefaultStatusComputeWorkers variable with a
WithStatusComputeWorkers WaitOption threaded through waitOptions into
the statusWaiter. This removes global mutable state from pkg/kube and
lets callers opt in explicitly.
SDK consumers (e.g. helm-controller) inherit the zero value, which
preserves the upstream cli-utils synchronous behavior and avoids an
unexpected fan-out of status-compute goroutines when many releases
reconcile concurrently. The Helm CLI continues to enable 8 workers by
default via a shared pkg/cmd/flags.go helper, so install/upgrade/
rollback/uninstall/test users still get the fix for multi-minute
informer stalls out of the box.
Signed-off-by: maplemiao <maplemiao@tencent.com>
* refactor(kube): clamp negative StatusComputeWorkers values to zero
Address review feedback: when a caller passes a negative value to
WithStatusComputeWorkers, coerce it to zero rather than propagating
it to the underlying cli-utils watcher, where the behavior is
undefined. Zero is the safe default and matches the SDK opt-in
contract.
Signed-off-by: maplemiao <maplemiao@tencent.com>
---------
Signed-off-by: maplemiao <maplemiao@tencent.com>
Signed-off-by: Maple Miao <maplemiao@yunzhanghu.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2 months ago
Abhay Chaurasiya
82be04d7f2
remove legacy import comments from remaining packages ( #31933 )
...
Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`)
are obsolete since Go 1.11 where go.mod is the authoritative module path.
These stale comments cause issues with downstream tooling such as Kythe.
Removes the legacy import comments from 64 files across 20 packages:
- cmd/helm
- internal/chart/v3/lint and sub-packages
- internal/plugin and sub-packages
- internal/release/v2/util
- pkg/chart/v2/lint and sub-packages
- pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance
- pkg/registry
- pkg/release/v1/util
- pkg/repo/v1
- pkg/storage and pkg/storage/driver
Follows up on #31931 and #31932 which addressed pkg/kube.
Fixes #31846
Signed-off-by: abhay1999 <abhay.chaurasiya@example.com>
Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
2 months ago
Terry Howe
c2fda5ac58
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 months ago
Matthieu MOREL
a2b1a60d51
fix: enhance error handling and improve test assertions ( #32352 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Solomon Wakhungu
5a30c7ae85
fix(scripts): add cache-busting to get-helm-3 version check
...
The get-helm-3 script queries get.helm.sh/helm3-latest-version to
determine the latest release. The CDN serving this file has no
Cache-Control header, so edge servers can serve stale cached
responses for hours after a new release.
This causes non-deterministic behavior: machines running get-helm-3
at the same time can install different versions depending on which
CDN edge node they hit.
Fix: Append a timestamp query string (?ts=1783837438) to bust CDN
caches, and add Cache-Control: no-cache header to both curl and wget
requests.
Fixes #32329
Signed-off-by: Solomon Wakhungu <65043605+1solomonwakhungu@users.noreply.github.com>
2 months ago
Terry Howe
0563162dd9
chore(deps): bump github/codeql-action init and analyze to 4.37.1
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 months ago
dependabot[bot]
06b95860dc
chore(deps): bump github/codeql-action/upload-sarif ( #32378 )
...
Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ) from 4.37.0 to 4.37.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](99df26d4f1...7188fc3636 )
---
updated-dependencies:
- dependency-name: github/codeql-action/upload-sarif
dependency-version: 4.37.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 months ago
dependabot[bot]
a494169853
chore(deps): bump actions/setup-go from 6.5.0 to 7.0.0 ( #32376 )
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 6.5.0 to 7.0.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](924ae3a1cd...b7ad1dad31 )
---
updated-dependencies:
- dependency-name: actions/setup-go
dependency-version: 7.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 months ago
George Jenkins
d817c54d51
Merge pull request #32372 from gjenkins8/gjenkins/gitignore_ai_vendor_paths
2 months ago
dependabot[bot]
eeb37edfea
chore(deps): bump github/codeql-action/autobuild from 4.37.0 to 4.37.1
...
Bumps [github/codeql-action/autobuild](https://github.com/github/codeql-action ) from 4.37.0 to 4.37.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](99df26d4f1...7188fc3636 )
---
updated-dependencies:
- dependency-name: github/codeql-action/autobuild
dependency-version: 4.37.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 months ago
George Jenkins
8cd3a48c34
chore: Add AI Vendor specific paths to `.gitignore`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 months ago