12 Commits (a9ed6057ba4366647609c13b2c6deda8b610484f)

Author	SHA1	Message	Date
Damien Nozay	9fa373e8be	Make validation errors easier to fix ... Problem: the warnings don't give enough details about which values are problematic, only the name of the leaf key. This is all the more annoying when you have a chart depending on other charts. ``` mainchart | +- subchart1 +- subchart2 +- subchart3 ``` Here are some warnings I get before the change: ``` coalesce.go:199: warning: destination for credentials is a table. Ignoring non-table value coalesce.go:160: warning: skipped value for resources: Not a table. coalesce.go:160: warning: skipped value for googleSheetsServiceAccount: Not a table. coalesce.go:199: warning: destination for googleSheetsServiceAccount is a table. Ignoring non-table value coalesce.go:199: warning: destination for resources is a table. Ignoring non-table value [] coalesce.go:199: warning: destination for credentials is a table. Ignoring non-table value coalesce.go:199: warning: destination for credentials is a table. Ignoring non-table value coalesce.go:160: warning: skipped value for resources: Not a table. coalesce.go:160: warning: skipped value for googleSheetsServiceAccount: Not a table. ``` with fix: ``` coalesce.go:162: warning: skipped value for subchart1.resources: Not a table. coalesce.go:162: warning: skipped value for subchart2.googleSheetsServiceAccount: Not a table. coalesce.go:211: warning: destination for subchart3.aws.credentials is a table. Ignoring non-table value () coalesce.go:211: warning: destination for mainchart.subchart3.aws.credentials is a table. Ignoring non-table value () coalesce.go:211: warning: destination for mainchart.subchart2.googleSheetsServiceAccount is a table. Ignoring non-table value () coalesce.go:211: warning: destination for mainchart.subchart1.resources is a table. Ignoring non-table value ([]) coalesce.go:162: warning: skipped value for subchart1.resources: Not a table. coalesce.go:162: warning: skipped value for subchart2.googleSheetsServiceAccount: Not a table. coalesce.go:211: warning: destination for subchart3.aws.credentials is a table. Ignoring non-table value () ``` Signed-off-by: Damien Nozay <damiennozay+github@gmail.com> add tests Signed-off-by: Damien Nozay <damiennozay+github@gmail.com>	3 years ago
Bernd Gutjahr	5cf9735a9d	improved coalesce readability by getting rid of continue statements ... Signed-off-by: Bernd Gutjahr <bernd.gutjahr@microfocus.com>	3 years ago
Giacomo Margaria	3b68afc1c8	Fix coalesce globals to prevent subchart globals to leak upstream ... Signed-off-by: Giacomo Margaria <giacomo.margaria@gmail.com>	4 years ago
Marc Khouzam	bed1a42a39	fix(pkg/chartutil): Remove warning for nils ... Nil tables should not be reported as non-tables. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>	4 years ago
David Pait	6aefbdcf38	Helm upgrades with --reuse-values and nil user values -- with tests (#7959) ... * return the new values if modifications dont yet exist Signed-off-by: David Pait <DP19@users.noreply.github.com> * fix tests Signed-off-by: David Pait <DP19@users.noreply.github.com> * removed outter if statement as its not needed now Signed-off-by: David Pait <DP19@users.noreply.github.com>	5 years ago
Matt Butcher	853ba2de16	fix: removed inaccurate comment (#7937) ... Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>	5 years ago
uzxmx	a34f311539	Fix nested null value overrides (#7743) ... * Fix nested null value overrides Signed-off-by: Mingxiang Xue <mingxiangxue@gmail.com> * Fix subchart value deletion Signed-off-by: Mingxiang Xue <mingxiangxue@gmail.com>	5 years ago
Taylor Thomas	a758490f4d	fix(chartutil): Uses copystructure for deep copy to avoid using gob ... We already had the copystructure library in our dependencies transitively through sprig. This solves a gob encoding bug that was causing issues with chart testing Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>	5 years ago
Karuppiah Natarajan	dfed8ab5e3	fix install storing computed values in release ... this was partially fixed in #6430 but the fix only worked for values without nesting. this PR fixes it. this is done by doing a deep copy of values rather than a top level keys copy. deep copy ensures values are not mutated during coalesce() execution which leads to bugs like #6659 the deep copy code has been copied from: https://gist.github.com/soroushjp/0ec92102641ddfc3ad5515ca76405f4d which is in turn inspired by this stackoverflow answer: http://stackoverflow.com/a/28579297/1366283 Signed-off-by: Karuppiah Natarajan <karuppiah7890@gmail.com>	5 years ago
Matt Farina	9bc7934f35	Updating the module for v3 as the major version ... Signed-off-by: Matt Farina <matt@mattfarina.com>	5 years ago
Karuppiah Natarajan	25324ca8db	fix install storing computed values in release instead of user supplied values ... Signed-off-by: Karuppiah Natarajan <karuppiah7890@gmail.com>	5 years ago
Adam Reese	b49db9e6e6	ref(pkg/chartutil): break up chartutil into logical files ... Signed-off-by: Adam Reese <adam@reese.io>	6 years ago