Fred Heinecke
30ce031d77
Merge branch 'main' into feat/add-toyamlpretty-1
2 months ago
Joe Julian
1c73ea44ad
Merge remote-tracking branch 'upstream/main' into feat/toml-parsing
...
Signed-off-by: Joe Julian <me@joejulian.name>
2 months ago
fheinecke
e502486109
Merge branch 'main' into feat/add-toyamlpretty-1
...
Signed-off-by: fheinecke <23390735+fheinecke@users.noreply.github.com>
6 months ago
Robert Sirchia
d58d7b3762
Fixing all the linting errors
...
Cleaned up all the linting errors we are getting.
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
8 months ago
Matt Farina
7fd08041b1
Merge pull request #12617 from porridge/dynamic-client
...
feature(pkg/engine): introduce RenderWithClientProvider
10 months ago
Andrew Block
77d54d7dbe
Merge pull request #11351 from greed42/fast-tpl
...
Speed up `tpl`
10 months ago
Marcin Owsiany
a997de1f11
tests(pkg/engine): test RenderWithClientProvider
...
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
11 months ago
Marcin Owsiany
bfec4ec926
feature(pkg/engine): introduce RenderWithClientProvider
...
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
11 months ago
Fred Heinecke
73f1dcc1d9
Added `toYamlPretty` template function
...
Signed-off-by: Fred Heinecke <fred.heinecke@goteleport.com>
11 months ago
Joe Julian
c42fdd1e0b
Merge remote-tracking branch 'upstream/main' into fix3
1 year ago
Graham Reed
b261a1b1be
Test update for "Allow a nested `tpl` invocation access to `defines` in a containing one"
...
Signed-off-by: Graham Reed <greed@7deadly.org>
1 year ago
Graham Reed
36d417de3b
Test update for "Speed up `tpl`"
...
Signed-off-by: Graham Reed <greed@7deadly.org>
1 year ago
Graham Reed
97dbb96f5a
Merge remote-tracking branch 'origin/main' into fast-tpl
...
Signed-off-by: Graham Reed <greed@7deadly.org>
1 year ago
Joe Julian
ca61c326c2
Merge pull request #11758 from joejulian/remove_blank_list_item_from_files_lines
...
strip trailing newline from Files.Lines
1 year ago
Joe Julian
ec1d0d8671
Merge pull request #11456 from greed42/tpl-tests
...
Backfill tests for the `tpl` function
1 year ago
Graham Reed
95905f19dd
Work around template.Clone omitting options
...
Signed-off-by: Graham Reed <greed@7deadly.org>
2 years ago
Graham Reed
f235f0f285
Check that missing keys are still handled in tpl
...
Signed-off-by: Graham Reed <greed@7deadly.org>
2 years ago
Dominik Müller
266ab5af05
test(pkg/engine): add tests for TOML parsing
...
Signed-off-by: Dominik Müller <mail@dominikm.de>
2 years ago
Dominik Müller
f550eda6e9
feat(pkg/engine): add TOML parsing functionality
...
Allows to use `fromToml` in templates similar to `fromJson` or `fromYaml`.
Closes #12024
Signed-off-by: Dominik Müller <mail@dominikm.de>
2 years ago
Joe Julian
b3707e666b
strip trailing newline from Files.Lines
...
Signed-off-by: Joe Julian <me@joejulian.name>
2 years ago
Matt Farina
50c22ed7f9
Bump the Go version
...
Needed to gofmt source to meet changes in style
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
AdamKorcz
2a9594c0fe
pkg/engine: fix nil-dereference
...
Signed-off-by: AdamKorcz <adam@adalogics.com>
2 years ago
Matt Farina
863bc74e5a
Update to func handling
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
2 years ago
Graham Reed
9fe912f3c5
Check redefinition of define and include in tpl
...
Signed-off-by: Graham Reed <greed@7deadly.org>
2 years ago
Graham Reed
ebf5e1e2af
Check that `.Template` is passed through `tpl`
...
Signed-off-by: Graham Reed <greed@7deadly.org>
2 years ago
Graham Reed
0a6e7d95ab
Make sure empty `tpl` values render empty.
...
Signed-off-by: Graham Reed <greed@7deadly.org>
2 years ago
Graham Reed
d1e9a242a7
Pick the test improvement out of PR#8371
...
<https://github.com/helm/helm/pull/8371 >
This covers:
- `tpl` text can `include` a `define` provided in a partial file
- `tpl` text can `include` a `define` provided in its text
- `tpl` text can be loaded via `.Files.Get`
Signed-off-by: Graham Reed <greed@7deadly.org>
2 years ago
Graham Reed
a7d3fd6c09
Allow a nested `tpl` invocation access to `defines` in a containing one
...
Signed-off-by: Graham Reed <greed@7deadly.org>
2 years ago
Graham Reed
e2a7c7998a
Remove the 'reference templates' concept
...
As we're using `t.Clone()` we already get the right 'references'.
Signed-off-by: Graham Reed <greed@7deadly.org>
2 years ago
cui fliter
09d3f31358
fix a few function names on comments
...
Signed-off-by: cui fliter <imcusg@gmail.com>
2 years ago
Graham Reed
db4f330122
Speed up `tpl`
...
- Use a clone of the current Template instead of re-creating everything from scratch
- Needs to inject `include` so any defines in the tpl text can be seen.
Signed-off-by: Graham Reed <greed@7deadly.org>
2 years ago
Matthew Fisher
aa6e82bac8
fix: use `go install` instead of `go get`
...
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
2 years ago
Matt Farina
f895948ae2
Fixing issue with non-existant .Template when using tpl function
...
This is a regression accidently introduced in #9957 .
A delete call had been used on the Template key of vals. This caused
a condition where Template was not available when rendering via tpl.
The delete happened after ExecuteTemplate so the issue is surpsising.
It may possibly be a race condition. Existing tests did not catch it.
I tried to create a test that directly tested the issue and was
unable to replicate the error seen with real charts. This leads me
to believe it is a race condition in the underlying Go template
package.
The delete call was not there before #9957 . It should be safe to
remove and keep that information.
Closes #10082
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Matt Farina
ac80a5eec9
Merge branch 'main' into feat/subcharts-scope
3 years ago
Matt Farina
2de6f9d424
Merge pull request #9993 from Ka0o0/make-isroot-available-to-template
...
Make Chart's IsRoot available to templates
3 years ago
Kai Takac
8fcaf7b85c
Add Chart IsRoot test
...
Signed-off-by: Kai Takac <kai.takac@gmail.com>
3 years ago
Kai Takac
06ae6f933a
Make Chart's IsRoot available to templates
...
Signed-off-by: Kai Takac <kai.takac@gmail.com>
3 years ago
Cory Snider
79df3926f6
fix(engine): parse fail messages with newlines
...
The templating engine handles errors originating from the `required` and
`fail` template functions specially, cleaning up the error messages to
be more presentable to users. Go's text/template package unfortunately
does not make this straightforward to implement. Despite
template.ExecError implementing Unwrap, the error value returned from
the template function cannot be retrieved using errors.As. The wrapped
error in ExecError is a pre-formatted error string with the template
function's error string interpolated in with the original error value
erased. Helm works around this limitation by delimiting the
template-supplied message and extracting the message out of the
ExecError string with a regex.
Fix the parsing of `required` and `fail` error messages containing
newlines by setting the regex flag to make `.` match newline characters.
Signed-off-by: Cory Snider <csnider@mirantis.com>
3 years ago
Valentin Flaux
3daaea0a1c
feat(pkg/engine): expose subcharts scope in parent
...
Expose the scope (.Values, .Charts, .Releases etc.) of subcharts to the parent scope.
Signed-off-by: Valentin Flaux <vflaux@oui.sncf>
3 years ago
Martin Hickey
dffc2a30c7
Merge pull request #9035 from wizbit/fail-message
...
Fail message is now the same as the required message.
4 years ago
Martin Hickey
699ea6dcef
Merge pull request #9066 from scaat/fix-specification
...
[FIX]Unified go specification
4 years ago
Josh Soref
2bf8fdf45d
chore: Spelling ( #9410 )
...
* spelling: annotate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: asserts
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: behavior
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: binary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: contain
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: copied
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dependency
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: depending
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: deprecated
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: doesn't
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: donot
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: github
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: inputting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: iteration
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: jabberwocky
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: kubernetes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: length
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mismatch
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multiple
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: nonexistent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: outputs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: panicking
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: plugins
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: parsing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: porthos
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: regular
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: resource
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repositories
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: something
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: strict
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: string
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unknown
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
4 years ago
Marcus Speight
7a663a56c2
Fixed Test
...
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
Signed-off-by: Marcus Speight <marcus@pmconnect.co.uk>
4 years ago
Marcus Speight
8aa42824f9
Added test for lint mode
...
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
4 years ago
Scaat Feng
1852694a65
[FIX]comment should start with whitespace
...
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
4 years ago
Marcus Speight
7a0739a863
Fail message is now the same as the required message.
...
Fixed #8973 Helm function 'fail' should not fail when doing 'helm lint'
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
4 years ago
Paul Brousseau
3192408415
Fixing typo in engine comments
...
Signed-off-by: Paul Brousseau <object88@gmail.com>
4 years ago
Matt Farina
dbd001e532
Removing tiller language
...
Since Tiller is no longer part of Helm v3, internal documentation
language about Tiller can be removed
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
Matt Butcher
bb47286f09
fix linting error with lookup function ( #7969 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
5 years ago
Andre Sencioles
d0726e07ab
Parse reference templates in predictable order ( #7702 )
...
* Parse reference templates in predictable order
Fix issue #7701
Signed-off-by: Andre Sencioles <asenci@gmail.com>
* Add test case for issue #7701 regression
Signed-off-by: Andre Sencioles <asenci@gmail.com>
* gofmt
Signed-off-by: Andre Sencioles <asenci@gmail.com>
5 years ago