George Jenkins
9c373bf4fc
Merge pull request #32327 from fluxcd/fix-32326
...
Fix vanishing empty lines
3 weeks ago
Lohit Kolluri
ad93b7df63
feat: honor SOURCE_DATE_EPOCH for chart archives ( #32162 )
...
* feat: honor SOURCE_DATE_EPOCH for chart archives
Add StampModTimes() on Chart struct to recursively set ModTime on
all chart file entries. CLI reads SOURCE_DATE_EPOCH env var and wires
through all 5 commands: package, install, upgrade, dep build, dep update.
Removes unused v3 duplicate source_date_epoch.go (YAGNI).
Inlines env var parsing to CLI layer from chart util.
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
* docs: document SOURCE_DATE_EPOCH in environment variables help
Add a short entry for $SOURCE_DATE_EPOCH to the env var table shown
in 'helm help'. The variable is honored by 'helm package', 'install',
'upgrade', 'dep build', and 'dep update' to produce reproducible chart
archives. Full documentation belongs in helm-www.
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
* fix: adapt SourceDateEpoch to upstream refactored dep check
Upstream/main restructured the dependency error handling in install.go
and upgrade.go from a nested-if block (if DependencyUpdate) to an
early-return pattern (if !DependencyUpdate). Adapt the feature's
Manager construction to match the new code structure.
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
---------
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
3 weeks ago
Matthieu MOREL
a02a5713de
chore: fix elseif and ifElseChain issues from gocritic ( #32289 )
...
* chore: fix elseif and ifElseChain issues from gocritic
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
* test: enhance assertions in OCIInstaller and list tests using testify
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
George Jenkins
7a7b328ba5
Merge pull request #32319 from mmorel-35/revive
...
feat(linters): add new revive rules for better code quality
3 weeks ago
Matheus Pimenta
bfebbb7c1a
Fix vanishing empty lines
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 weeks ago
Matthieu MOREL
16787d65f5
feat(linters): add new revive rules for better code quality
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
Matthieu MOREL
9662fdd73b
refactor: enable several checks from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
Terry Howe
d262c7ca79
Merge pull request #32296 from mmorel-35/gocritic-singleCaseSwitch
...
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
4 weeks ago
Matthieu MOREL
96b315f188
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
Matthieu MOREL
c1569ea83f
Update pkg/cmd/history_test.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
Matthieu MOREL
f34ad6c337
chore: fix several checks issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
Matthieu MOREL
07259ecc86
chore: fix several checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
Matthieu MOREL
34cfdfdbe5
chore: enable contextcheck, fatcontext and noctx linters
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Terry Howe
a092a1bd09
Merge pull request #31859 from biagiopietro/feature/rollback-revision-history
...
feat(history): add rollback revision column to helm history output
2 months ago
s3onghyun
dd442c0cc7
docs: fix typo in helm version command description
...
Signed-off-by: s3onghyun <s3onghyun.hong@gmail.com>
2 months ago
Jeaeun Kim
9c1d5a3b24
chore: rename savedErr to clear its specific purpose
...
Signed-off-by: Jeaeun Kim <me@kyoku.dev>
2 months ago
Jeaeun Kim
99baa2edd4
chore: fix lint
...
Signed-off-by: Jeaeun Kim <me@kyoku.dev>
2 months ago
Jeaeun Kim
ea847fef95
chore: store err separately for clarity
...
Signed-off-by: Jeaeun Kim <me@kyoku.dev>
2 months ago
Jeaeun Kim
2014946e55
chore: Improve error reporting for `helm template --debug` with `--show-only`
...
Signed-off-by: Jeaeun Kim <me@kyoku.dev>
2 months ago
Terry Howe
b3fbf8d0f7
Merge pull request #30808 from mmorel-35/errorlint
...
chore: enable errorlint
2 months ago
Terry Howe
c2f1b238a1
fix: route registry client output to stdout instead of stderr ( #32056 )
...
Commands like 'helm registry login', 'helm push', and 'helm pull' were
writing success messages ("Login Succeeded", "Pushed:", "Pulled:",
"Digest:") to stderr instead of stdout. The root cause was that
newDefaultRegistryClient and newRegistryClientWithTLS hard-coded
os.Stderr as the registry client writer, ignoring the out io.Writer
that main() passes as os.Stdout.
Thread out io.Writer through newRegistryClient, newDefaultRegistryClient,
and newRegistryClientWithTLS, and update all call sites in pkg/cmd.
Fixes #13464
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 months ago
MrJack
1b360574a9
Merge branch 'helm:main' into feature/rollback-revision-history
2 months ago
Terry Howe
59b57c5c31
Merge pull request #31885 from mmorel-35/whitespace
...
chore: fix whitespace linter
2 months ago
Evans Mungai
d374e823b2
Merge pull request #32086 from mmorel-35/error-is-as
...
testifylint: enable error-is-as and error-nil rules
2 months ago
MrJack
d097d882d4
Renamed flag from show-rollback to show-rollback-revision
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
3 months ago
MrJack
291a1a3b26
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
box4wangjing
432fc8a217
refactor: use slices.Backward to simplify the code
...
Signed-off-by: box4wangjing <box4wangjing@outlook.com>
3 months ago
MrJack
38336f84ec
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
George Jenkins
19b3656306
Bump to version v4.2 ( #32102 )
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
MrJack
dc04059ea3
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
Matthieu MOREL
f8ba28bb17
testifylint: enable error-is-as and error-nil rules
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Terry Howe
fbc2791886
Merge pull request #32078 from matheuscscp/go-1.26-k8s-1.36-cli-utils-1.1
...
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
3 months ago
Terry Howe
2fb101a20b
Merge pull request #31755 from scottrigby/template-cmd-deprecate-notes-flags
...
fix(template): deprecate unused --hide-notes and --render-subchart-notes flags
3 months ago
Matheus Pimenta
a4a9cc7a31
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
MrJack
3838d2d2dd
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
Terry Howe
83a4611908
Merge pull request #12932 from AndiDog/error-message
...
Make error message instructional for the case of lock file being out of date
4 months ago
Matheus Pimenta
265c5eb530
fix(templating): SplitManifests must preserve line endings for downstream YAML parsers ( #31952 )
...
* fix(templating): SplitManifests must preserve line endings for downstream YAML parsers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comment about skipping empty docs
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Port fix to release v2
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comments
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
4 months ago
Johannes Lohmer
00638773d1
fix(values): do not copy chart-default nils into coalesced values
...
Only user-supplied nils should survive coalescing. Chart-default nils
defaults, not just user overrides. This caused:
- %!s(<nil>) in templates using Bitnami common.secrets.key (#31919 )
- pluck fallbacks returning nil instead of falling through to globals
(#31971 )
Fixes #31919
Fixes #31971
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
4 months ago
MrJack
41ba370236
Merge branch 'helm:main' into feature/rollback-revision-history
4 months ago
George Jenkins
586eb57338
fix: Plugin missing provenance bypass
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
George Jenkins
f8afb35f4e
Merge commit from fork
...
fix: Plugin version path traversal
4 months ago
MrJack
42db90d9e8
Merge branch 'helm:main' into feature/rollback-revision-history
4 months ago
Matthieu MOREL
7edfff33eb
chore: fix unnecessary-format issues from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
Matthieu MOREL
af31a67924
chore: enable errorlint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Matthieu MOREL
1e0f702f00
chore: fix whitespace linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
George Jenkins
42f78ba60e
Merge pull request #31872 from mmorel-35/perfsprint-pkg-6-5f845e3
...
chore(pkg): fix perfsprint linter issues part 6
5 months ago
George Jenkins
e3b4808450
Merge pull request #31874 from mmorel-35/perfsprint-pkg-4-fb6db58
...
chore(pkg): fix perfsprint linter issues part 4
5 months ago
George Jenkins
610547b570
Merge pull request #31873 from mmorel-35/perfsprint-pkg-5-3294250
...
chore(pkg): fix perfsprint linter issues part 5
5 months ago
George Jenkins
47a084091e
ignore error plugin loads (cli, getter)
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
George Jenkins
36dcc27ca3
fix: Plugin version path traversal
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago