Matt Farina
8e6a5149d2
validation fix
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
Eng Zer Jun
2ceebffc77
test: replace `ensure.TempDir` with `t.TempDir`
...
This commit replaces `ensure.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ensure.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
1 year ago
wujunwei
878e962b23
fix: failed testcase on windows
...
Signed-off-by: wujunwei <wjw3323@live.com>
2 years ago
Eng Zer Jun
2e3e22a003
test: use `T.TempDir` to create temporary test directory
...
The directory created by `T.TempDir` is automatically removed when the
test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
3 years ago
Josh Soref
2bf8fdf45d
chore: Spelling ( #9410 )
...
* spelling: annotate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: asserts
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: behavior
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: binary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: contain
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: copied
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dependency
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: depending
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: deprecated
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: doesn't
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: donot
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: github
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: inputting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: iteration
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: jabberwocky
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: kubernetes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: length
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mismatch
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multiple
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: nonexistent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: outputs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: panicking
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: plugins
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: parsing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: porthos
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: regular
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: resource
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repositories
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: something
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: strict
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: string
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unknown
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
4 years ago
Adam Reese
657ce552cb
fix(*): Validate metadata semver and printable characters
...
ref: https://github.com/helm/helm/security/advisories/GHSA-c38g-469g-cmgx
* Skip invalid chart versions when reading the repository index file or
when programmatically adding a chart version.
* Adds semver validation and strips non-printable characters and
normalizes spaces for string fields in Metadata.Validate()
* Fixes a unit test that was pulling a remote repo. Now uses a local
repo.
* Fixes ignored error in repo update command
Signed-off-by: Adam Reese <adam@reese.io>
4 years ago
Matt Butcher
2750e4d781
Lint dependencies ( #7970 )
...
* feat: add dependency tests
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* replaced on-disk fixtures with in-memory fixtures
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Song Shukun
a992464fa2
Save Chart.lock to helm package tar
...
Signed-off-by: Song Shukun <song.shukun@fujitsu.com>
5 years ago
Romain Grenet
8cb3c02c47
Port PR #4161 Fix incorrect timestamp when helm package to Helmv3
...
Lint CRLF
Signed-off-by: Romain Grenet <romain.grenet@gmail.com>
5 years ago
Simon Alling
2a462aef2d
fix(pkg/chartutil): add tests according to feedback
...
The seemingly redundant `return filename, err` line is related to how
the name `err` is used throughout the function: there is a "global" (to
the function) `err` variable, as well as several locally block-scoped
ones. It took me hours to understand why my code did not work without
that line, but I decided not to clean up the `err` code in this commit.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
5 years ago
wxdao
c00890cae1
Fix Save misbehavior on nonexistent directory ( #6360 )
...
Signed-off-by: wxdao <waxiadao@gmail.com>
5 years ago
Matt Farina
9bc7934f35
Updating the module for v3 as the major version
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
Simon Alling
43bb10cd24
ref(pkg/chartutil): Dry up file and path names ( #6554 )
...
Signed-off-by: Simon Alling <alling.simon@gmail.com>
5 years ago
Josh Dolitsky
cc5dece910
fix(chartutil): Ensure nested template dir on save ( #6177 )
...
If a templates/ dir of a chart contained a subdirectory,
for example "templates/tests/test-db.yaml", an error was
being thrown on export due to missing the "templates/test"
directory prior to saving the template file itself.
Fixes #5757
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
5 years ago
Adam Reese
45f63628e1
ref(pkg/chart): remove unused chart.RawValues
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
e458a67f0c
ref(pkg/chart): add validation method to chart
...
Consolidate validation of Chart.yaml.
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
895e9192d4
feat(*): use vanity import helm.sh/helm
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
516c53dae6
ref(chart): use map for chart.Values
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
4f26b658d8
change copyright to "Copyright The Helm Authors"
6 years ago
Adam Reese
f012940d9c
ref(*): refactor chart/chartutil
...
ref(chartutil): move chart loading out of chartutil into new package
add chart loader interface to allow lazy loading
feat(chart): create chart accessors
ref(*): cleanup requirements
ref(tiller): remove optional template engines
ref(tiller): simplify sorting releases and hooks
ref(*): code simplification
ref(hapi): move chart package out of hapi
ref(chart): add requirements and lock to Chart struct
6 years ago
Adam Reese
4c95185164
ref(*): replace chart.config with []byte
7 years ago
Adam Reese
36536d77ba
ref(*): remove protobuf any type
7 years ago
Adam Reese
6345f04190
ref(hapi): convert protobuf to go types
7 years ago
Jean-Philippe Courson
5b77335415
Create missing directories when saving files in chartutil.SaveDir
7 years ago
Matt Butcher
784a339627
feat(helm): support 'helm create --pack=mypack'
...
This adds support for packs, pre-configured chart patterns that can be
used to quickly create a custom layout for your new chart.
8 years ago
Matt Butcher
e757b24aed
fix(*): add license header
9 years ago
Adam Reese
818c878700
chore(*): use k8s.io as the import path
9 years ago
Matt Butcher
15a1cb4816
feat(chartutil): add Save function
...
This replicates the previous Save function, which can save an
in-memory Chart proto to a tgz.
9 years ago