msb-public/helm - helm - 马士兵教育代码仓库

Author SHA1 Message Date

Author	SHA1	Message	Date
Oleg Sidorov	44a81f63f7	Revert "chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3]" This reverts commit `f94bac0643`. Due to a major numeric regression detected in dev-v2 reported in #6708, we believe the master branch (former dev-v3) is also impacted by this change and will expose the same set of problems. In order to not jeopardize the stability of helm3 this commit is reverted in favor of a better fix in the future. Signed-off-by: Oleg Sidorov <me@whitebox.io>	5 years ago
Oleg Sidorov	f94bac0643	chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3] Backport of https://github.com/helm/helm/pull/6010 to dev-v3 (the description below is a copy-paste from the original v2 branch PR). As https://github.com/helm/helm/pull/6016 is now merged to dev-v3, the change is reasonably trivial. This change is an attempt to address the common problem of json number unmarshalling where any number is converted into a float64 and represented in a scientific notation on a marshall call. This behavior breaks things like: chart versions and image tags if not converted to yaml strings explicitly. An example of this behavior: k8s failure to fetch an image tagged with a big number like: $IMAGE:20190612073634 after a few steps of yaml re-rendering turns into: $IMAGE:2.0190612073634e+13. Example issue: #1707 This commit forces yaml parser to use JSON modifiers and explicitly enables interface{} unmarshalling instead of float64. The change introduced might be breaking so should be processed with an extra care. Due to the fact helm mostly dals with human-produced data (charts), we have a decent level of confidence this change looses no functionality helm users rely upon (the scientific notation). Relevant doc: https://golang.org/pkg/encoding/json/#Decoder.UseNumber Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com> Signed-off-by: Oleg Sidorov <me@whitebox.io>	5 years ago
Matt Butcher	7aa4ffa4d4	feat(chartutil): switch TOML to YAML	8 years ago

Oleg Sidorov

Revert "chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3]"

This reverts commit f94bac0643.

Due to a major numeric regression detected in dev-v2 reported in #6708,
we believe the master branch (former dev-v3) is also impacted by this
change and will expose the same set of problems. In order to not
jeopardize the stability of helm3 this commit is reverted in favor of a
better fix in the future.

Signed-off-by: Oleg Sidorov <me@whitebox.io>

Oleg Sidorov

f94bac0643

chartutil.ReadValues is forced to unmarshal numbers into json.Number refs #1707 [dev-v3]

Backport of https://github.com/helm/helm/pull/6010 to dev-v3 (the
description below is a copy-paste from the original v2 branch PR).
As https://github.com/helm/helm/pull/6016 is now merged to dev-v3, the
change is reasonably trivial.

This change is an attempt to address the common problem of json number
unmarshalling where any number is converted into a float64 and
represented in a scientific notation on a marshall call. This behavior
breaks things like: chart versions and image tags if not converted to
yaml strings explicitly.

An example of this behavior: k8s failure to fetch an image tagged with a
big number like: $IMAGE:20190612073634 after a few steps of yaml
re-rendering turns into: $IMAGE:2.0190612073634e+13.

Example issue: #1707

This commit forces yaml parser to use JSON modifiers and explicitly
enables interface{} unmarshalling instead of float64. The change
introduced might be breaking so should be processed with an extra care.

Due to the fact helm mostly dals with human-produced data (charts), we
have a decent level of confidence this change looses no functionality
helm users rely upon (the scientific notation).

Relevant doc: https://golang.org/pkg/encoding/json/#Decoder.UseNumber

Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com>
Signed-off-by: Oleg Sidorov <me@whitebox.io>

Matt Butcher

7aa4ffa4d4

feat(chartutil): switch TOML to YAML

3 Commits (98962dce3f13d20155a3a8ed35d5b839a844ae7e)