reddaisyy
1c67fbf108
refactor: use strings.builder
...
Signed-off-by: reddaisyy <reddaisy@outlook.jp>
4 months ago
Artem Vdovin
ae4af69b9d
fix test
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
4 months ago
Artem Vdovin
aaaa457f04
Merge branch 'main' into bug/index-concurrency
4 months ago
Terry Howe
b2870379c8
Update pkg/engine/engine.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Terry Howe
91a65234ac
Update pkg/engine/engine.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Terry Howe
9112687a7e
Update pkg/engine/engine.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Tom Wieczorek
6181e0a873
Make test scripts run without /bin/bash
...
The test scripts hardcoded #!/bin/bash while they are not really
requiring bash. Use the more portable #!/usr/bin/env sh instead, so that
they use the default shell.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
4 months ago
bennsimon
db50c37eda
remove metadata output on helm template
...
Signed-off-by: bennsimon <bennsimonotieno@gmail.com>
4 months ago
Robert Sirchia
5534c01cdb
Merge pull request #31277 from benoittgt/31234-fix
...
Fix deprecation warning for spf13/pflag from 1.0.7 to 1.0.10
5 months ago
Evan Anderson
20f4e1f12d
Use filepath.Path when handling directory names
...
Signed-off-by: Evan Anderson <evan.k.anderson@gmail.com>
5 months ago
Benoit Tigeot
99e5fce71a
Fix deprecation warning for spf13/pflag from 1.0.7 to 1.0.10
...
Close : #31231
```
Error: cmd/helm/root.go:165:2: SA1019: flags.ParseErrorsWhitelist is deprecated: use [FlagSet.ParseErrorsAllowlist] instead. This field will be removed in a future release. (staticcheck)
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Matt Farina
1a06fe9901
Merge pull request #31275 from benoittgt/13414-v2
...
Extend --skip-schema-validation for lint command
5 months ago
Benoit Tigeot
072e2a689a
Extend --skip-schema-validation for lint command
...
When --skip-schema-validation is enabled, the lint command will now skip
JSON schema validation for values.yaml files, allowing charts with schema
validation errors to pass linting when the flag is used.
This addresses the gap where --skip-schema-validation only applied to
templates but not to values files, providing complete schema validation
bypass when needed.
Fixes : #13413
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Scott Rigby
315b13334c
Merge pull request #31258 from StephanieHhnbrg/test-unreachable-client
...
Refactor unreachableKubeClient for testing into failingKubeClient
5 months ago
Stephanie Hohenberg
e19d9fb6ee
Refactor unreachableKubeClient for testing into failingKubeClient
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
5 months ago
Benoit Tigeot
939fff9cb9
Avoid "panic: interface conversion: interface {} is nil"
...
Closes : #31202
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Jesse Simpson
712cde4624
test: passes now
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
b060911075
refactor: break out into functions and draft tests
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Benoit Tigeot
9e2d4680e1
Warn when we fallback to a different version on `helm pull`
...
Close: https://github.com/helm/helm/issues/31253
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Kamil Swiechowski
a645dfb7f8
fix:semverv2 lint test error message
...
Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>
5 months ago
Scott Rigby
78cf5470d1
Merge pull request #31199 from TerryHowe/fix-flaky-registry-data-race
...
fix: flaky registry data race on mockdns close
5 months ago
Scott Rigby
8602422b7a
Merge pull request #31064 from kamilswiec/main
...
lint: throw warning when chart version is not semverv2
5 months ago
Scott Rigby
50358d7ffd
Merge pull request #31200 from TerryHowe/fix-install-tests
...
fix: installer action goroutine count
5 months ago
Benoit Tigeot
8025a397e6
Ignore duplicated URN in logs
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
03bb62f63d
jsonschema: warn and ignore unresolved URN $ref to match v3.18.4
...
- v3.18.5 switched jsonschema and began resolving external $ref
at compile-time, exposing missing urn handling
(“no URLLoader registered for urn:…”).
- Add urn scheme loader and pluggable URNResolver. If unresolved, log
a warning and return a permissive true schema (back-compat).
- Apply to pkg/chart/v2 and internal/chart/v3 validators. Not sure about
that
Note: external URNs need AddResource/Resolver (the CLI uses --map for
this). Warning may appear twice since both validators run.
Another strategy could be to add the option to import more "external
schema" explicitly but it is another PR. Something similar to `--map`
from jsonschema package
(santhosh-tekuri/jsonschema@ed65924).
Close : #31170
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Matt Farina
fc22b6df31
Merge pull request #31222 from benoittgt/30987-ghcr-io
...
Prevent failing `helm push` on ghcr.io using standard GET auth token flow
5 months ago
Robert Sirchia
191154640f
Merge pull request #31197 from tzchenxixi/main
...
chore: fix function name
5 months ago
Kamil Swiechowski
38d1a7376f
fix: throw warning when chart version is not semverv2
...
Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>
5 months ago
Matt Farina
618b14a772
Merge pull request #31225 from mattfarina/move-lint-to-chart
...
Move lint pkg to be part of each chart version
5 months ago
George Jenkins
a8151ef4fe
Cleanup plugin config
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Scott Rigby
ed6cab39c6
Merge pull request #31219 from gjenkins8/gjenkins/plugin-integration/rm_setup_plugin_env
5 months ago
Matt Farina
9dcc49cbd5
Move lint pkg to be part of each chart version
...
Linting is specific to the chart versions. A v2 and v3 chart will
lint differently.
To accomplish this, packages like engine need to be able to handle
different chart versions. This was accomplished by some changes:
1. The introduction of a Charter interface for charts
2. The ChartAccessor which is able to accept a chart and then
provide access to its data via an interface. There is an
interface, factory, and implementation for each version of
chart.
3. Common packages were moved to a common and util packages.
Due to some package loops, there are 2 packages which may
get some consolidation in the future.
The new interfaces provide the foundation to move the actions
and cmd packages to be able to handle multiple apiVersions of
charts.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Matt Farina
52267ee74b
Move repo package to versioned directory
...
The repo package is internally versioned at v1. Repos were designed
to be versioned. This change moves it to a versioned directory the
same way other packages are now being handled.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Matt Farina
6f957f4922
Move the release util to the versioned directory
...
The release util package is directly related to the v1 of
releases and uses the v1 of releases.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
George Jenkins
5926ec83dd
Remove SetupPluginEnv
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
George Jenkins
665c5a1fc9
Merge pull request #31224 from gjenkins8/gjenkins/postrenderer_plugin_message_value
...
fix: Adjust PostRenderer plugin output to value
5 months ago
George Jenkins
d99d732542
fix: Adjust PostRenderer plugin output to value
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Benoit Tigeot
5595c0d005
Prevent failing helm push on ghcr.io using standard GET auth token flow
...
Fix GHCR auth by not forcing OAuth2 POST but also reset
ForceAttemptOAuth2 after login.
- Remove ForceAttemptOAuth2 in NewClient and only enable during Login
ping and always restore to false.
- Aligns with OCI Distribution auth (token via GET), avoiding GHCR 405
on POST /token.
- Some tests
Failures logs:
```sh
~/p/lifen/test/helm-f/quicktest ❯ ../../../helm/bin/helm push quicktest-0.1.0.tgz oci://ghcr.io/benoittgt/helm-charts --debug
level=DEBUG msg=HEAD id=0 url=https://ghcr.io/v2/benoittgt/helm-charts/quicktest/manifests/sha256:af359fd8fb968ec1097afbd6e8e1dac9ee130861082e54dc2340d0c019407873 header=" \"Accept\": \"application/vnd.docker.distribution.manifest.v2+json, application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.manifest.v1+json, application/vnd.oci.image.index.v1+json, application/vnd.oci.artifact.manifest.v1+json\"\n \"User-Agent\": \"Helm/4.0+unreleased\""
level=DEBUG msg=Resp id=0 status="401 Unauthorized" header=" \"Www-Authenticate\": \"Bearer realm=\\\"https://ghcr.io/token \\\",service=\\\"ghcr.io\\\",scope=\\\"repository:benoittgt/helm-charts/quicktest:pull\\\"\"\n \"Date\": \"Mon, 01 Sep 2025 13:56:35 GMT\"\n \"Content-Length\": \"73\"\n \"X-Github-Request-Id\": \"DC73:115F:2B40F2C:2BAB567:68B5A613\"\n \"Content-Type\": \"application/json\"" body=" Response body is empty"
level=DEBUG msg=POST id=1 url=https://ghcr.io/token header=" \"Content-Type\": \"application/x-www-form-urlencoded\"\n \"User-Agent\": \"Helm/4.0+unreleased\""
level=DEBUG msg=Resp id=1 status="405 Method Not Allowed" header=" \"Docker-Distribution-Api-Version\": \"registry/2.0\"\n \"Strict-Transport-Security\": \"max-age=63072000; includeSubDomains; preload\"\n \"Date\": \"Mon, 01 Sep 2025 13:56:35 GMT\"\n \"Content-Length\": \"78\"\n \"X-Github-Request-Id\": \"DC73:115F:2B40F75:2BAB5C2:68B5A613\"\n \"Content-Type\": \"application/json\"" body="{\"errors\":[{\"code\":\"UNSUPPORTED\",\"message\":\"The operation is unsupported.\"}]}\n"
Error: failed to perform "Exists" on destination: HEAD "https://ghcr.io/v2/benoittgt/helm-charts/quicktest/manifests/sha256:af359fd8fb968ec1097afbd6e8e1dac9ee130861082e54dc2340d0c019407873 ": POST "https://ghcr.io/token ": response status code 405: unsupported: The operation is unsupported.
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
tzchenxixi
89aca09e5e
chore: fix function name
...
Signed-off-by: tzchenxixi <tzchenxixi@icloud.com>
5 months ago
George Jenkins
c35755a197
Remove legacy Command/Hooks from v1 Subprocess ( #23 )
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Scott Rigby
591d863df5
Move Postrenderer to a plugin type
...
Fix/add back postrenderer args unit tests
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
e814ff3c38
Remove unnecessary file i/o operations from signing and verifying
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
9ea35da0d0
[HIP-0026] Plugin packaging, signing, and verification ( #31176 )
...
* Plugin packaging, signing and verification
Signed-off-by: Scott Rigby <scott@r6by.com>
* wrap keyring read error with more explicit message
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* skip unnecessary check
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Change behavior for installing plugin with missing .prov file (now warns and continues instead of failing)
Signed-off-by: Scott Rigby <scott@r6by.com>
* Add comprehensive plugin verification tests
- Test missing .prov files (warns but continues)
- Test invalid .prov file formats (fails verification)
- Test hash mismatches in .prov files (fails verification)
- Test .prov file access errors (fails appropriately)
- Test directory plugins don't support verification
- Test installation without verification enabled (succeeds)
- Test with valid .prov files (fails on empty keyring as expected)
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Terry Howe
b12cd28503
fix: installer action goroutine count
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
George Jenkins
892e86182f
Merge pull request #31194 from gjenkins8/gjenkins/plugin-integration/wasm_runtime
...
[HIP-0026] Plugin extism/v1 runtime
5 months ago
George Jenkins
80f659ce8b
Merge pull request #31178 from mattfarina/env-content-cache
...
Add content cache to helm env
5 months ago
zyfy29
8068578266
chore: delete unused var in installer.go
...
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
5 months ago
George Jenkins
2658a00863
fix output message value
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Terry Howe
ce97a2449e
fix: move mockdns to packge level
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
Terry Howe
6273f9b38e
fix: flaky registry data race on mockdns close
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
Terry Howe
284bd980b6
fix: replace pkg/engine regular expressions with parser
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
George Jenkins
b6545e903a
code review + bug fixes
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
George Jenkins
934f761e08
Merge pull request #30812 from gjenkins8/gjenkins/chartrelease_server_side_apply
...
HIP-0023: Helm support server-side apply
5 months ago
Scott Rigby
fd41fdd9c9
New registry plugin func GetPluginName. Re-use regsitry.reference
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
7d22bb25fa
Plugin OCI installer
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Matt Farina
533eddc57d
Add content cache to helm env
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Scott Rigby
a7578fec74
Plugin types and plugin apiVersion v1
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
be74ab72a0
[HIP-0026] Plugin runtime interface ( #31145 )
...
* Runtime abstraction to encapsulate subprocess code and enable future runtimes
Also fix race condition in TestPrepareCommandExtraArgs by replacing the shared variable modification with a local copy
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Remove commented out code
Co-authored-by: Joe Julian <me@joejulian.name>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Check test failure string
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Co-authored-by: Joe Julian <me@joejulian.name>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Matt Farina
0f1b410f14
Merge pull request #31165 from mattfarina/content-cache
...
Initial addition of content based cache
5 months ago
George Jenkins
a0d6b0d383
Merge pull request #13629 from gjenkins8/rename_atomic_rollbackonfailure
...
Rename 'atomic' -> 'rollback-on-failure'
5 months ago
Scott Rigby
29d12ba09e
Merge pull request #31156 from estroz/fix-resolve-client
...
fix: set repo authorizer in registry.Client.Resolve()
5 months ago
Robert Sirchia
fc5bd02a1b
Merge pull request #31175 from cuiweixie/atomic.Uint64
...
pkg/register: refactor to use atomic.Uint64
5 months ago
Matt Farina
fea6d8eb04
Updating to tested content cache
...
A few things are added here:
1. The cache is made to be more generic as a content based cache.
It could be used for other things such as plugins
2. Flags were added to specify the content cache locaiton rather
than rely on the repository cache. Keeping the 2 the same
hid bugs and errors.
3. Tests were added and updated to ensure the cache is used and
tested
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
George Jenkins
4596c0e062
Merge pull request #31142 from helm/gjenkins/main/mv_plugin_internal
...
[HIP-0026] Move pkg/plugin -> internal/plugin
5 months ago
cuiweixie
04cb1bad67
pkg/register: refactor to use atomic.Uint64
...
Signed-off-by: cuiweixie <cuiweixie@gmail.com>
5 months ago
George Jenkins
ebc874ef84
fix client-side to server-side field manager migration
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Robert Sirchia
30404b4173
Merge pull request #31138 from islewis/release-3.18
...
fix(helm-lint): Add HTTP/HTTPS URL support for json schema references
5 months ago
Isaiah Lewis
62e0c78ef8
fix(helm-lint): fmt
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
5 months ago
Matt Farina
6ac2c34689
Initial addition of content based cache
...
The previous cache was based on chart name and version. If 2 charts
with different content had the same name and version they would collide.
Helm did not trust the cache because of this and always downloaded
content. It was a short lived cache.
This commit introduces a content based cache which is based on the
content rather than file name. Charts with the same name but different
content are no longer an issue.
While the system assumes a file based interface, the cache system
is pluggable. In the future, it should return bytes for the content
instead of paths to it. That would requie a larger change for Helm 5
or later.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Matt Farina
3726d01c5c
Merge pull request #31132 from joemicky/main
...
refactor: replace []byte(fmt.Sprintf) with fmt.Appendf
5 months ago
Eric Stroczynski
e1e23d2af1
fix: set repo authorizer in registry.Client.Resolve()
...
Signed-off-by: Eric Stroczynski <estroczynski@nvidia.com>
5 months ago
George Jenkins
b4b2392f7e
mergefix
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Isaiah Lewis
fb12b44493
fix(helm-lint): Add TLSClientConfig
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
5 months ago
Matt Farina
de9ea4d1e3
Merge pull request #30992 from TerryHowe/force-oath-v4
...
fix: force bearer oauth for if registry requests bearer auth
5 months ago
George Jenkins
e2dcbe28bf
Helm client/SDK support server-side apply
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Evans Mungai
0943d032a7
Merge branch 'main' into em/fix-username-password
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
George Jenkins
a1c84f9a4c
Move pkg/plugin -> internal/plugin
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Terry Howe
1e22b2fe7c
fix: remove redundant error check
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
Isaiah Lewis
fa73b6743b
fix(helm-lint): Add HTTP/HTTPS URL support for json schema references
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
5 months ago
George Jenkins
36e52c828d
Merge pull request #31030 from gjenkins8/gjenkins/kubeclient_ssa
...
HIP-0023: Kube client support server-side apply
5 months ago
Robert Sirchia
47529bbffb
Merge pull request #31133 from joemicky/use_CutPrefix
...
refactor: replace HasPrefix+TrimPrefix with CutPrefix
5 months ago
joemicky
762ef3ee80
refactor: omit unnecessary reassignment
...
Signed-off-by: joemicky <joemickychang@outlook.com>
5 months ago
joemicky
a3d2da4d2e
refactor: replace HasPrefix+TrimPrefix with CutPrefix
...
Signed-off-by: joemicky <joemickychang@outlook.com>
5 months ago
joemicky
fab70472af
refactor: replace []byte(fmt.Sprintf) with fmt.Appendf
...
Signed-off-by: joemicky <joemickychang@outlook.com>
5 months ago
Joe Julian
e1b9173812
Merge pull request #12624 from papdaniel/main
...
show crds command output separated by document separator
5 months ago
George Jenkins
36532f36b1
Merge pull request #11700 from suzaku/use-sort-slice
...
Refactor, use sort.Slice to reduce boilerplate code
5 months ago
Joe Julian
4b493f036c
Merge remote-tracking branch 'upstream/main' into papdaniel/main
5 months ago
Joe Julian
6ecf033700
Merge pull request #13111 from rawtaz/style-cosmetics
...
style(pkg/chartutil): add missing dots and indentation to defaultValues
5 months ago
Joe Julian
3fe1cb6f02
Merge remote-tracking branch 'upstream/main' into style-cosmetics
5 months ago
Joe Julian
92bc614fbf
Merge remote-tracking branch 'upstream/main' into use-sort-slice
5 months ago
Scott Rigby
943ca1d0ca
Merge pull request #30891 from gjenkins8/gjenkins/port_plugin_warn
...
fix: Port pluginCommand & command warning
5 months ago
Robert Sirchia
d7d072b7f6
Merge commit from fork
...
Advisory fix 1
5 months ago
George Jenkins
ba53075a9d
Merge pull request #12968 from sjeandeaux/helm-uninstall-dry-run
...
helm uninstall dry run support `--ignore-not-found`
5 months ago
George Jenkins
b2dc411f9d
code review (error checks, collapse forceConflicts, UpdateApplyFunc)
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
George Jenkins
99dc23f00b
switch target<->original
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
George Jenkins
741facca43
Update pkg/kube/client_test.go
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
George Jenkins
45141451b4
Kube client support server-side apply
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
Matt Farina
8affd6178f
Merge pull request #31126 from paologallinaharbur/fix/leverageSameTLSconfig
...
fix(transport): leverage same tls config
6 months ago
Matt Farina
523d0b305e
Merge pull request #31076 from matheuscscp/registry-tls-memory
...
pkg/registry: Login option for passing TLS config in memory
6 months ago
Stephane Jeandeaux
44a594fef5
review
...
Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
6 months ago
Robert Sirchia
c5901abba6
Merge pull request #31050 from spreadshirt/fix-helm-pull-ud-check
...
Fix `helm pull` untar dir check with repo urls
6 months ago
Paolo Gallina
f3c9407052
fix(transport): leverage same tls config
...
Signed-off-by: Paolo Gallina <paologallina1992@gmail.com>
6 months ago
Stephane Jeandeaux
8434935a3d
fix fallthrough
...
Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
6 months ago
Stephane Jeandeaux
65209bed54
Update pkg/action/uninstall.go
...
Co-authored-by: Eddy Moulton <eddy@moulton.com.au>
Signed-off-by: Stephane Jeandeaux <sjeandeaux@users.noreply.github.com>
6 months ago
Stephane Jeandeaux
b3568a67a8
helm uninstall
...
The goal is to have the same behaviour with or without dry-run with --ignore-not-found
close #12970
Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
6 months ago
Joe Julian
ae0fe82bc3
Merge remote-tracking branch 'upstream/main' into get-values-test
6 months ago
Khwaja Faraz Ahmed
85164e5705
fix lint errors
...
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
6 months ago
Khwaja Faraz Ahmed
ded25c1908
Add tests for alias
...
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
6 months ago
Evans Mungai
97af5a5e85
Fix linter warning
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
Evans Mungai
5e86e43eda
Add tests for pull command using OCI registry
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
Evans Mungai
9e1cbbebcb
fix linting warning
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
Evans Mungai
5e6a411c1f
fix: use username and password if provided
...
Ref: #31114
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
Pavani Pogula
6597fecce3
test(pkg/kube/wait): Add unit tests for waitForPodSuccess, waitForJob and SelectorsForObject.
...
Signed-off-by: Pavani Pogula <pogulapavani@gmail.com>
6 months ago
Pavani Pogula
d4ed9210df
test(pkg/kube/roundtripper): Add unit tests for roundtripper.go
...
Signed-off-by: Pavani Pogula <pogulapavani@gmail.com>
6 months ago
Robert Sirchia
3c5d68d62e
Merge pull request #31109 from carlossg/panic3
...
fix: prevent panic when ChartDownloader.getOciURI
6 months ago
George Jenkins
18b7d45999
Merge pull request #31034 from Mazafard/feat/color-output-and-test-fixes
...
Feat: Add color output functionality and tests for release statuses
6 months ago
Robert Sirchia
9b217506bd
Merge pull request #31106 from irikeish/test/pkg_kube_client
...
test(pkg/kube): add test for Client.isReachable
6 months ago
George Jenkins
93106ba2b6
Merge pull request #30982 from gjenkins8/gjenkins/force_replace_flag
...
Rename 'force' to 'force-replace'
6 months ago
Carlos Sanchez
4e483d36bd
fix: prevent panic when ChartDownloader.getOciURI
...
needs to lookup tags because no version is provided
but no RegistryClient is provided
Signed-off-by: Carlos Sanchez <carlos@apache.org>
6 months ago
Robert Sirchia
6007d5773e
Merge pull request #31094 from mikelolasagasti/drop-freeport
...
chore(deps): remove phayes/freeport module
6 months ago
Atish Kumar
008bd7fc82
test(pkg/kube/client): add test for isReachable
...
Signed-off-by: Atish Kumar <allolro@gmail.com>
6 months ago
LinPr
b25fa862d5
fix: assign KUBECONFIG environment variable value to env.Kubeconfig
...
Signed-off-by: LinPr <314573849@qq.com>
6 months ago
Evans Mungai
85243914a4
feat: switch yaml library to go.yaml.in/yaml/v3
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
Matt Farina
69efc0d4fb
Handle messy index files
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
6 months ago
Matt Farina
0c64ad1c97
fix Chart.yaml handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
6 months ago
Mikel Olasagasti Uranga
7007d4d485
chore(deps): remove phayes/freeport module
...
Replaces the `phayes/freeport` module with the standard library's
`net.Listen("tcp", "127.0.0.1:0")` idiom. This removes an unnecessary
dependency and simplifies the codebase.
Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
6 months ago
Khwaja Faraz Ahmed
a37934a892
fix linting issue
...
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
6 months ago
Faraz Khawaja
2d2d4a868d
Fix struct declaration
...
Signed-off-by: Faraz Khawaja <khwajafarazahmed@yahoo.com>
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
6 months ago
Matheus Pimenta
802e09038c
pkg/registry: Login option for passing TLS config in memory
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
6 months ago
Robert Sirchia
a42b76421b
Merge pull request #31078 from 8tomat8/master
...
fix: k8s version parsing to match original
6 months ago
Mohammadreza Asadollahifard
0865d70304
refactor: change default color output setting to auto and remove ColorEnabled method
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
6 months ago
Mohammadreza Asadollahifard
4ef0f3d5e2
Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes
6 months ago
George Jenkins
f3065ff1ba
Remove plugin deprecated 'UseTunnelDeprecated'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
George Jenkins
08840f042c
Rename 'atomic' -> 'rollback-on-failure'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
Borys Hulii
9f6beaad48
fix: k8s version parsing to match original
...
Signed-off-by: Borys Hulii <borys.hulii@bitvavo.com>
6 months ago
Luna Stadler
1031b67fff
Fix `helm pull` untar dir check with repo urls
...
The existing check worked for `helm pull downloaded-repo/chart-name`,
but often does not work when using `--repo-url`, depending on the urls
used by the charts.
Signed-off-by: Luna Stadler <luc@spreadshirt.net>
6 months ago
Artem Vdovin
118d0eb697
add concurrency test on write & load index file
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
6 months ago
Faraz Khawaja
f75100266b
Resolve conflicts
6 months ago
George Jenkins
8face0e596
Merge pull request #31060 from yumeiyin/main
...
refactor: replace Split in loops with more efficient SplitSeq
6 months ago
Robert Sirchia
619035d789
Merge pull request #31057 from danilobuerger/db/thick-lark
...
Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme
6 months ago
Joe Julian
7f4eb407c6
add missing template directory to badcrdfile testdata
...
Signed-off-by: Joe Julian <me@joejulian.name>
6 months ago
Joe Julian
08909e030b
Merge pull request #31019 from zachburg/templates_lint
...
Return early when linting if the `templates/` directory does not exist
6 months ago
Joe Julian
1f3e4ad12a
Merge pull request #31011 from yalosev/feature/add-labels-to-metadata
...
feature: add labels to metadata
6 months ago
Joe Julian
cd5ae5b19e
Merge pull request #31015 from zachburg/crds_lint
...
Add linter support for the `crds/` directory
6 months ago
Terry Howe
250ce7b5dc
chore: improve OCI debug logging
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
6 months ago
Matt Farina
1a73633908
Merge pull request #31033 from navinag1989/test-cov-cli-options
...
test: increase test coverage for pkg/cli/options.go file
6 months ago
George Jenkins
74f2805f01
Rename 'force' to 'force-replace'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
yumeiyin
8c22fbfe4a
refactor: replace Split in loops with more efficient SplitSeq
...
Signed-off-by: yumeiyin <yin.yumei@qq.com>
6 months ago
Artem Vdovin
314bd19d11
update writing index files to writeAtomicFile
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
7 months ago
Danilo Bürger
055c4e2bec
Moved url comparison to own function
...
Signed-off-by: Danilo Bürger <info@danilobuerger.de>
7 months ago
Mohammadreza Asadollahifard
c1b3a83514
refactor: clean up color output imports in list, root, and status files
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Mohammadreza Asadollahifard
d28343550f
feat: make color output opt-in by default
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Mohammadreza Asadollahifard
ba8f70ae0b
refactor: move color package to internal/cli/output
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Mohammadreza Asadollahifard
b72db06c49
refactor: replace NoColor with ColorMode for improved color output control
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Mohammadreza Asadollahifard
96c54a2963
refactor color output functions to simplify noColor checks
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Mohammadreza Asadollahifard
b630ae30a5
Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes
7 months ago
Khwaja Faraz Ahmed
d50d22c970
Add test coverage for get_values/metadata.go
...
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
7 months ago
Danilo Bürger
8096f09370
Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme
...
Signed-off-by: Danilo Bürger <danilo.buerger@helsing.ai>
7 months ago
Scott Rigby
091f9a24fe
Merge pull request #13154 from carloslima/post-render-everything
...
Allow post-renderer to process hooks
7 months ago
Robert Sirchia
49e82c1fe9
Merge pull request #31042 from TerryHowe/fix-test-teardown-dns-data-race
...
fix: test teardown dns data race
7 months ago
jingchanglu
2da734d0b2
chore: fix typo in pkg/repo/chartrepo.go
...
Signed-off-by: jingchanglu <jingchanglu@outlook.com>
7 months ago
Terry Howe
82bc9adcc2
fix: test teardown dns data race
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Yuriy Losev
46b1a41631
Add release labels to the release Metadata
...
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
7 months ago
Robert Sirchia
4b8e61093d
Merge commit from fork
...
Updating link handling
7 months ago
naving1989
4310b2bc36
Fixed linting issues
...
Signed-off-by: naving1989 <navinag1989@gmail.com>
7 months ago
Zach Burgess
1002ec5ae9
Update tests in lint_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
35434947a3
Return a lint warning if `templates/` does not exist.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
b6e3301bef
Merge branch 'helm:main' into templates_lint
7 months ago
Zach Burgess
fe11438715
Raise error instead of warning if `crds/` is not a valid directory
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
eea2d4577b
Raise an error if the `templates/` dir is not valid and return early.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Mohammadreza Asadollahifard
1e00790b8c
refactor tests to use t.Setenv for NO_COLOR environment variable
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Mohammadreza Asadollahifard
c547d1f2ae
add color output functionality and tests for release statuses
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Zach Burgess
3a318c2fa3
Update crds.go after https://github.com/helm/helm/pull/31029
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
81af3c9570
Merge branch 'helm:main' into crds_lint
7 months ago
George Jenkins
d21a8a04cb
Merge pull request #31029 from gjenkins8/gjenkins/k8s_yaml_struct
...
chore(refactor): Privatize 'k8sYamlStruct'
7 months ago
Zach Burgess
cc85352a0e
Use `assert.Len` instead of `assert.Lenf`
...
The default message from testify is descriptive enough.
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
c59a097209
Remove duplicate test case from crds_test.go
...
The "good" test case for CRDs is done in `TestGoodChart` in lint_test.go.
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
naving1989
3b2f9e7d6f
test: increase test coverage for pkg/cli/options.go file
...
Signed-off-by: naving1989 <navinag1989@gmail.com>
7 months ago
Zach Burgess
bf9084a16a
Rename `validateCrdApiVersion` to `validateCrdAPIVersion`
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
357957b0d3
Use testify and add a CRD to the `goodone` test case.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
dadaff716a
Merge branch 'helm:main' into crds_lint
7 months ago
Zach Burgess
6e30619d8f
Merge branch 'helm:main' into templates_lint
7 months ago
Matt Farina
76fdba4c8c
Updating link handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
George Jenkins
bbea98ed6b
Merge pull request #30898 from fidelity-contributions/fix-issue-13198
...
Fix issue 13198
7 months ago
George Jenkins
4c674728d2
Privatize 'k8sYamlStruct'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
George Jenkins
edd0dabe02
Merge pull request #31021 from zachburg/test_temp_dir
...
Update tests in create_test.go and package_test.go to work in a temp directory
7 months ago
Matt Farina
e8be2e540d
Merge pull request #31023 from gjenkins8/gjenkins/rm_recreate_pods
...
Remove deprecated '--create-pods' flag
7 months ago
George Jenkins
a3bcc5b184
fix: 'TestRunLinterRule' stateful test
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
George Jenkins
5283915c57
Remove deprecated '--create-pods' flag
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
George Jenkins
de1bdf5820
switch to slog
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
George Jenkins
62ca98f521
fix up verbiage
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
George Jenkins
5f9cbe6f4a
fix: Port pluginCommand & command warning
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
Zach Burgess
eaf40b4b4f
Call `ensure.HelmHome()` in package_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Matt Farina
9517cfc5ce
Merge pull request #31009 from tpresa/test-coverage-pusher
...
test: increase test coverage for pkg/pusher
7 months ago
Zach Burgess
c48a3435f5
Remove unnecessary calls for changing directory to `helmpath.CachePath`.
...
This was only set on some tests in create_test.go and isn't
affecting the test.
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Carlos Lima
6991a0a531
Make annotateAndMerge deterministic
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
7 months ago
Carlos Lima
c01e76b5c3
review: change annotation name to postrenderer.helm.sh/postrender-filename
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
7 months ago
Carlos Lima
a1416cf225
review: style changes
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
7 months ago
Carlos Lima
859721bd77
review: rewrite error messages from the end-user perspective
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
7 months ago
Carlos Lima
b26b473bf6
review: make splitAndDeannotate private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
7 months ago
Carlos Lima
855b5a44b7
review: make annotateAndMerge private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
7 months ago
Carlos Lima
1d993f9e2d
review: make filenameAnnotation private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
7 months ago
Carlos Lima
e6362d74c8
Allow post-renderer to process hooks
...
This annotates and merges all manifests before sending to the
postrender, reversing the process and recovering the filenames
afterwards.
closes #7891
Signed-off-by: Carlos Lima <carlos@cpan.org>
7 months ago
Zach Burgess
3b26ddc22b
Update tests in create_test.go and package_test.go to work in a temp dir.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
b703d5b4bb
Return early when linting if the `templates/` dir does not exist
...
The `vaildateTemplatesDir` function would still return `nil` if the directory doesn't exist,
so the early return that was documented never occurs.
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
a99c3700f0
Return early if the `/crds` directory does not exist.
...
Don't silently discard the error from `os.Stat`.
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
562ff982cb
Early return if the `/crds` directory does not exist and don't silently discard the error from `os.Stat`.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
d6ddd8e661
Document that attempting to parse YAML checks that the CRD is not a
...
template
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
e4c88faeff
Update test assertions
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
bc35ea5ad7
Fix comment in pkg/lint/rules/testdata/invalidcrdsdir/values.yaml
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
21b9aa3d94
Lint the `crds/` directory.
...
This checks that the `crds/` dir only contains YAML files that define
K8s resources with `kind: CustomResourceDefinition`.
Checking that the YAML files are not templates will be done in a
separate commit.
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Thiago Presa
afd63fed77
test: increase test coverage for pkg/pusher
...
Signed-off-by: Thiago Presa <thiago.addevico@gmail.com>
7 months ago
Matt Farina
f0cf9c28f0
Move logging setup to be configurable
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
curlwget
bfc1af68fb
chore: fix function in comment
...
Signed-off-by: curlwget <curlwget@icloud.com>
7 months ago
George Jenkins
a2a0935cba
Merge pull request #30900 from unguiculus/issue-12952
...
Add timeout flag to repo add and update commands
7 months ago
Terry Howe
f55c462a79
fix: force bearer oauth for everything
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Robert Sirchia
ba0fbdeb57
Merge pull request #30979 from TerryHowe/oras-v2-login-for-v4
...
fix: OAuth username password login for v4
7 months ago
Artem Vdovin
351bb78ee5
fix index concurrency
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
7 months ago
Terry Howe
df482346db
fix: lint test SetEnv errors
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Terry Howe
47980159b3
fix: user username password for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
manslaughter03
bc44614a78
fix: wrap run release test error in case GetPodLogs failed.
...
Signed-off-by: manslaughter03 <manslaughter03@gmail.com>
8 months ago
Terry Howe
744c6b5a97
fix: kube client create mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
Ashmit Bhardwaj
e060fbe185
updated docs
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
8 months ago
Ashmit Bhardwaj
0389407cbc
removed unnecessary binary file
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
8 months ago
Ashmit Bhardwaj
b305a501e8
added documentation and test cases for api-versions flag
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
8 months ago
Terry Howe
93ec064640
fix: repo update cmd mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
acceptacross
9623fb80f1
chore: fix some function names in comment
...
Signed-off-by: acceptacross <csqcqs@gmail.com>
8 months ago
Matt Farina
7031000b7d
Merge pull request #30955 from carloslima/fix-test-deleting-local-directories
...
Fix tests deleting XDG_DATA_HOME
8 months ago
Scott Rigby
069b525332
Merge pull request #13586 from jessesimpson36/cleaner-stacktraces
...
fix: add formatting for errors to make multiline stacktraces in helm templates
8 months ago
Carlos Lima
f8204031f1
Fix tests deleting XDG_DATA_HOME
...
That includes ~/.local/share/keyrings which was the most immediatelly
visible effect.
Signed-off-by: Carlos Lima <carlos@cpan.org>
8 months ago
Robert Sirchia
c0aa690c90
Merge pull request #30909 from jinjiadu/main
...
refactor: replace HasPrefix+TrimPrefix with CutPrefix
8 months ago
Scott Rigby
e2630d1aba
Merge pull request #30939 from TerryHowe/action-hooks-delete-policy-mutex
...
fix: action hooks delete policy mutex
8 months ago
Scott Rigby
de745ea34b
Merge pull request #12581 from Nordix/considerAllGroupVersionKind
...
Consider full GroupVersionKind when matching resources
8 months ago
Scott Rigby
e8c1acf228
Merge pull request #30809 from mmorel-35/usetesting
...
chore: enable usetesting linter
8 months ago
Scott Rigby
4023c3b5ff
Merge pull request #30917 from TerryHowe/oci-transport-debugging
...
fix: add debug logging to oci transport
8 months ago
Terry Howe
a8cbf3aa51
fix: action hooks delete policy mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
8 months ago
Terry Howe
6ab7aa3612
fix: legacy docker support broken for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
Terry Howe
5fe7a87138
fix: add debug logging to oci transport
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
8 months ago
Benoit Tigeot
6df8eb3b3b
Fix flaky TestFindChartURL due to non-deterministic map iteration
...
The test was failing intermittently because Go's map iteration order
is randomized (see `range repos` in `findChartUrl`).
When looking up the `baz` chart with repository URL http://example.com/helm ,
two repositories match due to trailing slash equivalence:
- testing-relative (URL: http://example.com/helm ) - contains baz chart GOOD
- testing-relative-trailing-slash (URL: http://example.com/helm/ ) - does not contain baz chart.. NOT GOOD
The urlutil.Equal() function treats these URLs as equivalent, but
depending on which repository the random map iterator encounters
first, the test would either pass or fail with "entry not found".
So I changed the third test case from baz to foo chart, since foo exists
in both matching repositories. This eliminates the race condition while
preserving all test expectations and logic.
`findChartURL()` iterates over a map without deterministic
ordering, causing the first-match-wins behavior to be non-deterministic
when multiple repositories match the same URL pattern.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Scott Rigby
d4e58c54ba
Merge pull request #30928 from TerryHowe/fix-plugin-install-no-internet
...
fix: plugin installer test with no Internet
8 months ago
Terry Howe
cc39d2428f
fix: plugin installer test with no Internet
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
Benoit Tigeot
b2fd91b8d0
Adapt error of invalid json schema with the new expected output
...
Closes: https://github.com/helm/helm/pull/30907
To be able to upgrade to v6.0.2 for jsonschema lib we need to upgrade
this test.
I am wondering if it's related to this commit:
86cca28795
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Reinhard Nägele
d448cf1943
Add timeout flag to repo add and update flags
...
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
# Conflicts:
# pkg/cmd/repo_update.go
8 months ago
jinjiadu
6f8e9e09a4
refactor: replace HasPrefix+TrimPrefix with CutPrefix
...
Signed-off-by: jinjiadu <jinjiadu@aliyun.com>
8 months ago
Robert Sirchia
b7e127dd6b
amending missed line to delete
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
8 months ago
Robert Sirchia
937c533e37
forward porting 30902
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
8 months ago
Robert Sirchia
52dddba759
Merge pull request #30894 from benoittgt/fix-#30881-main
...
Prevent push cmd failure in 3.18 by handling version tag resolution in ORAS memory store
8 months ago
Robert Sirchia
83c26845ad
Merge pull request #30904 from benoittgt/document-ideal-registry-login-command
...
[Doc] Help users avoid specifying URL scheme and path with `helm registry`
8 months ago
Benoit Tigeot
f939f6145f
Prevent fetching newReference again as we have in calling method
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago