Matt Farina
069eec9e42
Updatin gthe apiVersion linting for Helm v3
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago
Matt Farina
29842e040f
Adding lint check for apiVersion which is a required field
...
Fixes #5727
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago
Matthew Fisher
5367c6c296
fix(loader): assume apiVersion is v1 when loading charts
...
In Helm 2, no chart validation was performed on v1 charts, so there are
a few charts out there that never added an apiVersion to the Chart.yaml.
To ensure those charts continue to work for Helm 3, we should assume
that charts loaded without an apiVersion set should be assumed as v1.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Josh Dolitsky
5f1128b5f7
pass debug option to registry client
...
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
6 years ago
Martin Hickey
22d0ba8b51
Print manifest output for dry-run option
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Adam Reese
8d1590016c
Merge pull request #5646 from adamreese/v3/kube-wait
...
ref(pkg/kube): extract wait logic from install/update
6 years ago
Adam Reese
b7a14de590
Merge pull request #5601 from adamreese/v3/capabilities
...
ref(pkg/chartutil): remove k8s version object dependency
6 years ago
Martin Hickey
ecf4eda6c5
Fix scaffold chart label in helper template
...
The 'app.kubernetes.io/version' label was not being rendered as
expected. It was appending onto the label before it and also
the next label label was appending onto it on the same line.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Adam Reese
b97f881be0
ref(*): use time.Duration for timeouts
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
097834de0a
ref(pkg/chartutil): remove k8s version object dependency
...
Flattens the `.Capabilities` built-in and removes useless kubernetes
runtime metadata.
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Matt Farina
2a06c2baba
Merge pull request #5684 from mattfarina/add-app-version
...
Add app version
6 years ago
Adam Reese
2dd4744d23
ref(pkg/kube): extract wait logic from install/update
...
This change adds a new method for waiting for kubernetes resources.
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
b8bced2649
fix(pkg/action): load clients after flags have been parsed ( #5681 )
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Matt Farina
250b63eced
Updating the labels for consistency
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago
Luis Davim
82ffe56ca6
Reduce template code duplication. Fixes #5372
...
Signed-off-by: Luis Davim <luis.davim@jet.com>
6 years ago
Luis Davim
4425f86865
Add app.kubernetes.io/version label
...
Signed-off-by: Luis Davim <luis.davim@jet.com>
6 years ago
Matt Farina
af7eab0325
Updating to the k8s label convention
...
Closes #4335
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 years ago
Martin Hickey
75624afb73
Merge pull request #5662 from hickeyma/fix-scaffold-chart-image
...
fix(chartutil): Scaffold chart fails to deploy pod
6 years ago
Josh Dolitsky
a12a396aab
Helm 3: registry login/logout ( #5597 )
...
* login/logout placeholders
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* use latest oras
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* use docker auth system
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* working login+push
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* working on tests
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* fix typo in htpasswd
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* rename credsfile to config.json
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* add flags for username/password
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* disable logout test broken on linux
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* upgrade to oras 0.4.0
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* re-enable logout test
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* panic for uncaught errors
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* move login/logout to new registry subcommand
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
6 years ago
Martin Hickey
f12c2a3111
Change the nginx app version to a set tag
...
Want to avoid moving tags like using 'stable'. Therefore,
specify the specifc nginx version/tag.
Update from comment review:
- https://github.com/helm/helm/pull/5662#discussion_r280122531
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Martin Hickey
0b809dd078
Validate library chart files after chart loaded
...
Validate the library chart files after the chart and
its depoendencies have been loaded. This is an update
following review comment:
- https://github.com/helm/helm/pull/5441#pullrequestreview-231339425
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Martin Hickey
86c5e52ac4
Fix the image field for the scaffold chart application
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Martin Hickey
b74fee715e
Add capability for application charts to be used as library charts
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Matthew Fisher
b1ae1acc8b
Merge pull request #5283 from bacongobbler/purge-by-default
...
ref(uninstall): purge release history by default
6 years ago
Martin Hickey
1915358a21
Merge pull request #5538 from hickeyma/add-app-version
...
feat(*): Add app version to history table
6 years ago
Ian Howell
ffff0e8c33
Feat/schema validation ( #5350 )
...
* Add the Schema type and a function to read it
* Added a function to read a schema from a file
* Check that values.yaml matches schema
This commit uses the gojsonschema package to validate a values.yaml file
against a corresponding values.schema.yaml file.
* Add functionality to generate a schema from a values.yaml
* Add Schema to Chart and loader
* Clean up implementation in chartutil
* Add tests for helm install with schema
* Add schema validation to helm lint
* Clean up "matchSchema"
* Modify error output
* Add documentation
* Fix a linter issue
* Fix a test that broke during a rebase
* Clean up documentation
* Specify JSONSchema spec
Since JSONSchema is still in a draft state as of this commit, we need to
specify a particular version of the JSONSchema spec
* Switch to using builtin functionality for file extensions
* Switch to using a third-party library for JSON conversion
* Use the constants from the gojsonschema package
* Updates to unit tests
* Minor change to avoid string cast
* Remove JSON Schema generation
* Change Schema type from map[string]interface{} to []byte
* Convert all Schema YAML to JSON
* Fix some tests that were broken by a rebase
* Fix up YAML/JSON conversions
* This checks subcharts for schema validation
The final coalesced values for a given chart will be validated against
that chart's schema, as well as any dependent subchart's schema
* Add unit tests for ValidateAgainstSchema
* Remove nonessential test files
* Remove a misleading unit test
The TestReadSchema unit test was simply testing the ReadValues function,
which is already being validated in the TestReadValues unit test
* Update documentation to reflect changes to subchart schemas
6 years ago
Michelle Noorali
3dd1765491
Merge pull request #5631 from michelleN/test-run
...
add helm test run
6 years ago
Matthew Fisher
e2ccf13294
Merge pull request #5553 from bacongobbler/same-appversion-as-version
...
ref(create): app version should be 0.1.0
6 years ago
Michelle Noorali
ceab13e9a1
fix test command, move test to test run subcmd
...
Signed-off-by: Michelle Noorali <michellemolu@gmail.com>
6 years ago
Martin Hickey
b72e25cfb9
Change header "APP_VERSION" to "APP VERSION"
...
Update following review comment:
- https://github.com/helm/helm/pull/5538#pullrequestreview-221803355
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Martin Hickey
b600f6090e
Add app version to history table
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Matthew Fisher
5264ebd5aa
Merge pull request #5572 from ian-howell/fix/template-error-messages
...
fix(pkg/engine): Clean up template error messages
6 years ago
Matthew Fisher
d3f0ac9343
ref(create): app version should be 0.1.0
...
When creating a Helm chart for the first time, the assumption should be that the app version is also 0.1.0, implying this is for a new application.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Ian Howell
278594fb0f
fix(pkg/engine): Style changes on template errors
...
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
6 years ago
Ian Howell
92b86f6e74
fix(pkg/engine): Catch non-templating errors when rendering templates
...
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
6 years ago
Ian Howell
33b1ede570
fix(pkg/engine): Clean up template error messages
...
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
6 years ago
Abhilash Gnan
d40f3c63ea
fix ByDate sorter to use Time.Unix()
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
6 years ago
Adam Reese
e458a67f0c
ref(pkg/chart): add validation method to chart
...
Consolidate validation of Chart.yaml.
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Abhilash Gnan
f7e2a78374
fix test cases for list.AllNamespaces
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
6 years ago
Abhilash Gnan
f019ec0e8d
add superseded to list filter mask
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
6 years ago
Abhilash Gnan
416667a8e9
Remove redundant ByNameAsc enum value. Handled by default sorting
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
6 years ago
Abhilash Gnan
b9a39e46de
handle default list sort order through enum order
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
6 years ago
Abhilash Gnan
d3c85f97c2
fix sort list with options bug
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
6 years ago
Adam Reese
31819e4796
fix(pkg/chartutil): marshal capabilities VersionSet into slice
...
Marshal capabilities VersionSet into readable value.
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
87e789f01f
fix(pkg/chartutil): only include external objects in capabilities
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
fe06343b8f
Merge pull request #5512 from adamreese/v3/linter-fixes
...
ref(pkg/action): refactoring dup code and linter fixes
6 years ago
Adam Reese
295092cd7d
ref(pkg/action): refactoring dup code and linter fixes
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Matthew Fisher
bb179bdead
chore(dep): bump kubernetes to 1.14.0
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Matthew Fisher
0805a87140
ref(uninstall): purge release history by default
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Matthew Fisher
0b1caa14a7
Merge pull request #5489 from bacongobbler/list-move-namespaces-field
...
ref(list): move namespaces field closer to the name
6 years ago
Matthew Fisher
32712201ec
ref(list): move namespaces field closer to the name
...
Most users want to see the release name and the namespace it was deployed to,
as those are the unique identifiers where the release is stored. I also added
integration tests for `helm list` to better test the command output.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Adam Reese
779373a276
Merge pull request #5472 from adamreese/v3/template-name
...
fix(cmd/template): allow setting release name for template
6 years ago
Sunyk
223148dac9
Remove a trivial TODO comment
...
Signed-off-by: Sunyk <lentil1016@gmail.com>
6 years ago
Adam Reese
271e4cf111
fix(cmd/template): allow setting release name for template
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
14d8e97d2a
fix(*): resolve new govet issues
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Matthew Fisher
8f37ab48ac
Merge pull request #5455 from bacongobbler/fix-list
...
fix(install): fix issue where chart metadata is not being saved on `helm install`
6 years ago
Matthew Fisher
5c2f235b6c
fix(install): fix issue where chart metadata is not being saved on `helm install`
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Adam Reese
895e9192d4
feat(*): use vanity import helm.sh/helm
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Matthew Fisher
017790d0e3
ref(action): remove ParseShowOutputFormat
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Matthew Fisher
78bd46075b
fix(action): remove test.go
...
test.go is a duplicate of release_testing.go
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Matthew Fisher
f8ed917830
test(cmd): refactor release_testing_test.go
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Matthew Fisher
f185103b60
ref(action): move AddFlags functions back to cmd
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Matthew Fisher
2b775d693d
ref(action): remove io.Writers, return string instead
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Matthew Fisher
6bb9264e89
fix(helm): fix `helm status` output formatting
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Matthew Fisher
2571dbf82f
ref: remove pkg/helm, pkg/hapi, pkg/tiller
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Adam Reese
21d3a40f3b
feat(tests): replace gometalinter with golangci-lint
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
849f27d11f
ref(pkg/engine): make template specific functions private
...
Make template specific functions private to ensure they not misused and
make unit tests simpler. We may export the template helpers later if
needed.
This lays the foundation for the new chart pipeline.
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
d841a1b1d9
fix(engine): make template rendering thread safe
...
See https://github.com/helm/helm/pull/4828
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Matthew Fisher
2a82e6cbe6
docs: s,kubernetes/helm,helm/helm,g ( #5404 )
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Adam Reese
a1a7d3e824
ref(pkg/helm): refactor out `ReleaseStatus`
...
The `ReleaseStatus()` client call returns the same information as
`ReleaseContent()`
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Martin Hickey
ef4d2a6e65
Update after review
...
Review comment:
- https://github.com/helm/helm/pull/5295#pullrequestreview-203519813
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Martin Hickey
abdaf3ce1b
Add chart type
...
The chart type is added to differentiaite between an application chart
and a library chart. Library charts can be used as dependencies but are
not installable.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Adam Reese
e51a9b90c9
Merge pull request #5284 from adamreese/v3/make-format
...
feat(Makefile): add formatting target
6 years ago
Martin Hickey
45fb4b1c44
Fix linter warnings
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6 years ago
Adam Reese
f791421fab
feat(Makefile): add formatting target
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Josh Dolitsky
16b59bfe5b
Helm 3: fix "latest" tag bug ( #5279 )
...
* add extra ref parsing, validation
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* add fix for missing locator
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* add repo and tag fields for clarity
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* small refector
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
6 years ago
Josh Dolitsky
a32f8ebb37
Helm 3: initial registry support ( #5243 )
...
* initial registry support
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* fix dependency mess
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* add extra chart command output
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* sanitize registry path (windows fix)
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* store all sha256 blobs in same dir
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* switch to use chartutil.SaveDir
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* populate chart command long descriptions
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* remove test cache dir in teardown
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* add long description of chart export
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* clean up table rows code
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
6 years ago
Adam Reese
28d8c7b277
ref(*): remove references to chart 'engine'
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Matthew Fisher
95c865513f
fix appveyor builds ( #4934 )
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
6 years ago
Martin Hickey
86d8596763
Feature(Plugins): Enable platform specific commands ( #5176 )
...
* Add logic for platform specific commands to plugins
* Add plugins doc updated to incorporate platform specific commands
* Add condition for os match: If OS matches and there is no more specific match, the command
will be executed
6 years ago
Adam Reese
d94707db86
ref(*): remove helmVersion chart constraint
...
* Remove helmVersion constraint from charts
* Guard compile time set variables behind `internal/`
* Allow configuration of UserAgent for HTTPGetter
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Matt Butcher
f3bfae5ea7
fix: fix a number of style errors ( #5136 )
...
This fixes a dozen or so style errors, almost all of which were just missing comments.
I left several which are fixed in other outstanding PRs, or which belong to code that is about to be removed.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
6 years ago
Matt Butcher
425f7a6f6c
feat: add 'pkg/action' for list operations ( #5077 )
...
* feat: add pkg/action to encapsulate action logic
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* feat: replace client/server internals with action package
While we removed Tiller, we left the internal client/server architecture mostly intact. This replaces that architecture with the `pkg/action` package.
This implements the action package for list, but nothing else.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* feat: Add install and refactor some tests
This adds install to the action package, and then fixes up a lot of testing.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* fix: Move a bunch of sorters to the releaseutils package
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* fix: updated APIs and fixed a failed test
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* Use var for timestamper, instead of adding as a struct field
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
6 years ago
derkoe
6e1b45888a
feat(cmd/helm): re-add --history-max option to v3
...
Since there is no tiller anymore this option make most sense with the
'helm upgrade' commando.
Origininally this was added in PR #2636 implementing the feature #2081 .
Signed-off-by: Christian Koeberl <christian.koeberl@gmail.com>
6 years ago
Adam Reese
2b81eea1e2
ref(*): replace byte array with map for Release config
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
6fc8c9e079
ref(pkg/chartutil): simplify chart dependency unit tests
...
- simplify unit tests
- refactor typed errors
- unexport internal functions
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
825b15c763
Merge pull request #4972 from adamreese/ref/chart-dependencies
...
ref(pkg/chart): rename Requirements to Dependencies
6 years ago
Adam Reese
85aef0d3d7
ref(pkg/chart): rename Requirements to Dependencies
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
roc
79f88dfc5e
ref(url) update helm's github url ( #4962 )
...
https://github.com/kubernetes/helm -> https://github.com/helm/helm
https://github.com/kubernetes/charts -> https://github.com/helm/charts
Signed-off-by: Roc Chan <roc@imroc.io>
6 years ago
roc
212d326a34
ref(pkg/repo): rename RepoFile to File
...
To resolve the linter warning: name start with package name.
Signed-off-by: Roc <roc@imroc.io>
6 years ago
Adam Reese
9e1e26f01e
ref(pkg/chartutil): attempt to make requirements processing readable
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
f5b6ff2832
ref(pkg/chart): rename files to be consistent with types
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Matt Butcher
7061716406
ref: require name by default on 'helm install' ( #4858 )
...
This is described in the official Helm 3 proposal: https://github.com/helm/community/blob/master/helm-v3/000-helm-v3.md
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
6 years ago
Adam Reese
3b0ba0f71e
ref(tests): remove broken symlinks in testdata
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
b4ed1de6b8
ref(*): kubernetes v1.12 support
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Matt Butcher
9fda187647
fix(tests): set mock to generate UTC timestamps ( #4716 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
6 years ago
Adam Reese
3be0d81da7
ref(driver): refactor out function type errors
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
21259507bd
ref(*): rename requirements.lock to Chart.lock
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
f7a7a157ce
ref(*): merge requirement.yaml into Chart.yaml
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago
Adam Reese
516c53dae6
ref(chart): use map for chart.Values
...
Signed-off-by: Adam Reese <adam@reese.io>
6 years ago