Matt Butcher
809e2d999e
Merge pull request from GHSA-m54r-vrmv-hw33
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
055dd41cbe
Merge pull request from GHSA-jm56-5h66-w453
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
59d5b94d35
Merge pull request from GHSA-9vp5-m38w-j776
4 years ago
Matthew Fisher
aa5431ab71
Merge pull request #8751 from technosophos/fix/helm-create-overwrite
...
fixed bug that caused helm create to not overwrite modified files
4 years ago
Matthew Fisher
2a74204508
go fmt
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matthew Fisher
84de24edc9
Merge pull request #8752 from technosophos/fix/better-http-plugin-checks
...
improve the HTTP detection for tar archives
4 years ago
Matt Farina
7953adb06c
Merge branch 'master' into fix/helm-create-overwrite
4 years ago
Matt Butcher
e2da16f514
improve the HTTP detection for tar archives
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Farina
b5daf5a484
Merge pull request #8753 from technosophos/fix/dependency-status
...
handle case where dependency name collisions break dependency resolution
4 years ago
Matt Farina
11f75e420c
Merge pull request #8750 from technosophos/fix/helm-create-name
...
validate the name passed in during helm create
4 years ago
Matt Butcher
40b7800287
handle case where dependency name collisions break dependency resolution
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
106f1fb45c
fixed bug that caused helm create to not overwrite modified files
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
ed5fba5142
refactor the release name validation to be consistent across Helm
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
c4ef82be13
validate the name passed in during helm create
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matthew Fisher
55fbd985dd
Merge pull request #8707 from zhijianli88/cleanup-tempfiles
...
Cleanup tempfiles
4 years ago
Matthew Fisher
dafeb1541b
Merge pull request #8493 from yxxhero/fix-insecure-skip-tls-verify-flag-not-work-on-helm-install
...
fix insecure-skip-tls-verify flag does't work on helm install
4 years ago
Paul Brousseau
3192408415
Fixing typo in engine comments
...
Signed-off-by: Paul Brousseau <object88@gmail.com>
4 years ago
Li Zhijian
4258e8664e
Use T.cleanup() to cleanup cmdtest_temp file
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
d9ad9153c8
Use RemoveAll to remove a non-empty directory
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
cccc2867ea
mark NewTempServer as Deprecated
...
Please use NewTempServerWithCleanup instead
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
35c5268d9d
Use T.Cleanup() to cleanup temp dir helm-repotest
...
For backward compatibility, as suggested by @bacongobbler, we introduce
a new API NewTempServerWithCleanup
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
leigh capili
9429af8b39
Support impersonation via flags similar to kubectl --as="user"
...
Signed-off-by: leigh capili <leigh@null.net>
4 years ago
Li Zhijian
ba4c8029c2
Use T.cleanup() to cleanup helm-action-test
...
T.Cleanup() is introduced since go-1.14
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Martin Hickey
daa104d60e
Revert PR 8562
...
Revert of PR 8562 as the container version may not represent the
application version.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
4 years ago
Matt Farina
e454e6a910
Merge pull request #8682 from liuming-dev/remove-duplicate-variable-definition
...
Remove duplicate variable definition
4 years ago
Martin Hickey
2a9ef6d3b0
Merge pull request #8529 from lingsamuel/status-show-desc
...
feat: add flag `--show-desc` to display description for `helm status`
4 years ago
Ling Samuel
da6878dc0f
feat: status command display description
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
4 years ago
Liu Ming
317616482c
Remove duplicate variable definition
...
Variable values `helm.sh/resource-policy` and `keep` are duplicately
defined in resource_policy.go (`resourcePolicyAnno` `keepPolicy`) and
resource_policy.go (`ResourcePolicyAnno` `KeepPolicy`), remove the
varibales in resource_policy.go to keep the code clean.
Signed-off-by: Liu Ming <hit_oak_tree@126.com>
4 years ago
Matt Butcher
04fb35814f
Fixed a variable name collision caused by two PR merges ( #8681 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
70d03e5cef
Fix/8467 linter failing ( #8496 )
...
* add output to get debug info on linter failing
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* trap cases where the YAML indent is incorrect.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
96d9ab9663
fix name length check on lint ( #8543 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Zhou Hao
0669f40e81
cleanup tempfiles for load_test
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
4 years ago
Matt Farina
3fc88f2492
Fixing failing CI for windows
...
A fix introduced in #8631 caused a bug in Windows builds due to
a type difference between POSIX and Windows environments. This
change corrects that problem and provides a code comment to warn
others.
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matthew Fisher
0a28e5cbff
Merge pull request #8631 from mrueg/sem-fixes
...
pkg/*: Small linting fixes
4 years ago
Matt Farina
c7b5f5f88f
Merge pull request #8627 from mattfarina/fix-6418
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Manuel Rüger
4abcdc40ef
pkg/*: Small linting fixes
...
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
4 years ago
Matthew Fisher
0941e3e345
Merge pull request #8613 from tariq1890/if-optimise
...
optimise if condition in service ready logic
4 years ago
Matt Farina
11f658e223
Fixing linting of templates on Windows
...
When the engine stored templates in the map the keys were generated
based on path and not filepath. filepath was being used in the linter
when retrieving content from the keys. On Windows the keys ended up
being different.
This change is to use path joins to create the lookup key. Since the
name path was used in the code it needed to be changed in order to
import the package.
Tests already exist and were failing on windows. This got in because
CI is not run on Windows.
Closes #6418
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matthew Fisher
198f403688
Merge pull request #8590 from Foxboron/morten/fix-go1.15
...
release/mock: Ensure conversion from int to string yields a string
4 years ago
Tariq Ibrahim
b07b2589fb
optimise if condition in service ready logic
...
Signed-off-by: Tariq Ibrahim <tariq181290@gmail.com>
4 years ago
Matthew Fisher
bb33b9264f
Merge pull request #8507 from rajatjindal/fix-watch-timeout-error
...
fix watch error due to elb/proxy timeout
4 years ago
Martin Hickey
273d0364be
Merge pull request #8532 from dm3ch/labels-selector
...
Adding filtering of helm releases for configmap and secret backends during list command
4 years ago
Morten Linderud
83a5e620d0
release/mock: Ensure conversion from int to string yields a string
...
With the release of go 1.15, the test-suite doesn't pass as `go test` got
a new warning for improper `string(x)` usage.
https://golang.org/doc/go1.15#vet
$ make test-unit
# helm.sh/helm/v3/pkg/release
pkg/release/mock.go:56:27: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
[snip]
make: *** [Makefile:82: test-unit] Error 2
This patch changes ensures we are utilizing `fmt.Sprint` instead as
recommended.
Signed-off-by: Morten Linderud <morten@linderud.pw>
4 years ago
Martin Hickey
91094186eb
Merge pull request #8562 from andytom/chore/update_starter_chart
...
Update Common Lables template in starter chart
4 years ago
Thomas O'Donnell
4b1fa60d58
Update Common Lables template in starter chart
...
Have update the Common Labels template in the starter chart so that the
value for the `app.kubernetes.io/version` is set to the same value as
the image tag used in the deployment.
Signed-off-by: Thomas O'Donnell <andy.tom@gmail.com>
4 years ago
Martin Hickey
621c2020c6
Merge pull request #8505 from jiayushe/master
...
Avoid hardcoded container port in default notes
4 years ago
Martin Hickey
a5047b2f6c
Merge pull request #8438 from donggangcj/feature/support-jsonpath
...
feature(show): support jsonpath output for `helm show value`
4 years ago
yxxhero
0674d93609
add helm v4 todo comments for FindChartInAuthAndTLSRepoURL.
...
Signed-off-by: yxxhero <aiopsclub@163.com>
4 years ago
Dong Gang
df4708a9de
polish the error handler
...
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
4 years ago
Dmitry Chepurovskiy
266c74f390
Move selector filtering after latest release version filtering
...
Signed-off-by: Dmitry Chepurovskiy <dm3ch@dm3ch.net>
4 years ago