Matt Farina
806d59750a
Merge pull request #30902 from brandtkeller/30890_prov_mediatype_allow
...
fix(client): allow layer selection permissive
7 months ago
Scott Rigby
e37962522c
Merge pull request #30887 from scottrigby/v3-remove-registry-login-url
...
Fix 3.18.0 regression: registry login with scheme
7 months ago
Brandt Keller
a18a52e898
fix(client): skipnode utilization for PreCopy
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
7 months ago
Brandt Keller
b07ab77da3
fix(client): layers now returns manifest - remove duplicate from descriptors
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
7 months ago
Brandt Keller
c225c124ac
fix(client): return nil on non-allowed media types
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
7 months ago
Scott Rigby
c0f3ace52d
Fix 3.18.0 regression: registry login with scheme
...
Helm 3.18.0 released an upgrade of ORAS from v1 to v2.
ORAS v2 correctly does not accept http/https scheme for registry login, while
ORAS v1 previously did. Even if v1 should not have, we want to preserve
backwards compatibility for Helm 3 users who pass the scheme.
This will be removed in Helm 4, where registry login will not accept http/https
scheme.
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Robert Sirchia
f147277a59
Merge pull request #30885 from helm/revert-13534-dev-v3-12987
...
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
7 months ago
Benoit Tigeot
dce60adb51
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
7 months ago
Benoit Tigeot
cda0865d64
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
7 months ago
Benoit Tigeot
5d9d9a0fb8
Wait for Helm v4 before raising when platformCommand and Command are set
...
same for `PlatformHooks` and `hooks`.
When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.
See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270
Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
7 months ago
Matt Farina
c5249c1f8d
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
...
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
7 months ago
Feng Cao
afefca8b2d
chore: update generalization warning message
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
8 months ago
Feng Cao
eb5b6d5047
fix: move warning to top of block
...
Emit the warning first to ensure it's always logged. This clarifies that any following errors are due to using a local chart instead of a remote repository.
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
8 months ago
Feng Cao
6b5c94475d
fix: replace fmt warning with slog
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
8 months ago
Feng Cao
247bf7c2e0
fix: add warning when ignore repo flag
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
8 months ago
George Jenkins
b4e06a11d2
Merge pull request #30658 from helm/gjenkins/backport_12912
...
[v3 backport] feat: add httproute from gateway-api to create chart template
8 months ago
George Jenkins
a69eaf6098
Merge pull request #30764 from nvanthao/backport-30673
...
v3 backport: Process all hook deletions on failure
8 months ago
Robert Sirchia
94044595c7
bump version to v3.18.0
...
(cherry picked from commit 74c3d1dc0de0335f941362c80447871e7d6bc78e)
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
8 months ago
Terry Howe
cdd7c105a6
docs: Note about http fallback for OCI registries
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
Scott Rigby
e4bc4a31b9
Merge pull request #30768 from banjoh/em/fix-take-ownership
...
v3 backport - fix --take-ownership
8 months ago
Benoit Tigeot
087fa18276
Bump toml
...
Looking at the [toml diff](https://github.com/BurntSushi/toml/compare/v1.4.0...v1.5.0 ). I think it's safe to change the test here.
For main: https://github.com/helm/helm/pull/30775
Closes: https://github.com/helm/helm/pull/30683
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Evans Mungai
0906fe7f6b
Add install test for TakeOwnership flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
9 months ago
Patrick Seidensal
4ee3a19e9a
Fix --take-ownership
...
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.
This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.
By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.
Fixes #30622
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
9 months ago
Gerard Nguyen
0a800e84b0
backport #30673 to dev-v3
...
Signed-off-by: Gerard Nguyen <gerard@replicated.com>
9 months ago
Matt Farina
3ce10e4f81
Unarchiving fix
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 7cc4dcf94ee410c8e0d64f3e726dda199c24ccb2)
9 months ago
Benoit Tigeot
422c58e4a2
Fix typo
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
5e7f12d4c3
Report as debug log, the time spent waiting for resources
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Terry Howe
1435ec7c77
Update pkg/registry/fallback.go
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
10 months ago
Terry Howe
674e882c88
automatic fallback to http
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
10 months ago
Terry Howe
c188441757
chore(oci): upgrade to ORAS v2
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
10 months ago
Henrik Gerdes
bd1b67b082
feat: add httproute from gateway-api to create chart template
...
Adds the HTTPRoute from https://gateway-api.sigs.k8s.io/reference/spec/ to the example getting started chart.
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
Scott Rigby
bcb83e465f
Fix cherry-pick helm.sh/helm/v4 -> helm.sh/helm/v3
...
Signed-off-by: Scott Rigby <scott@r6by.com>
10 months ago
Chris Berry
2aa90b8f26
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
10 months ago
Chris Berry
5739197faa
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
10 months ago
Chris Berry
b8e13878fc
Add HookOutputFunc and generic yaml unmarshaller
...
Signed-off-by: Chris Berry <bez625@gmail.com>
10 months ago
Scott Rigby
97b0e11871
clarify fix error message
...
Signed-off-by: Scott Rigby <scott@r6by.com>
10 months ago
Scott Rigby
2f79afb0a3
fix err check
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
10 months ago
Scott Rigby
c77f4ec6c4
remove comments about previous functionality
...
Signed-off-by: Scott Rigby <scott@r6by.com>
10 months ago
Scott Rigby
3cd6afe845
add short circuit return
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
10 months ago
Chris Berry
5367001f4f
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
10 months ago
Chris Berry
3c445158d8
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
10 months ago
Chris Berry
4cb639ed4e
Fix lint
...
Signed-off-by: Chris Berry <bez625@gmail.com>
10 months ago
Chris
20f859c9ff
Tidy up imports
...
Signed-off-by: Chris <bez625@gmail.com>
10 months ago
Chris Berry
ca90972b3d
Add hook annotations to output pod logs to client on success and fail
...
Signed-off-by: Chris Berry <bez625@gmail.com>
10 months ago
Matt Farina
e2c7986f30
Merge pull request #13534 from althmoha/dev-v3-12987
...
fix (helm) : toToml` renders int as float [ backport to v3 ]
11 months ago
George Jenkins
80f87ab636
Merge pull request #13654 from ryanhockstad/subchart-null
...
[backport] bugfix: Override subcharts with null values
11 months ago
Matt Farina
9aff8bdaa0
Merge pull request #13644 from mattfarina/backport-13583
...
fix: check group for resource info match (v3 backport)
11 months ago
George Jenkins
6ed9d2f2d5
Merge pull request #13592 from stevehipwell/add-plugin-platform-hooks-v3
...
feat: Add multi-platform plugin hook support [v3 backport]
12 months ago
Jiasheng Zhu
2ebce786ba
fix: check group for resource info match
...
Closes : #13582
Signed-off-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com>
(cherry picked from commit f5d488122b )
12 months ago
Ryan Hockstad
326c1e3f67
add test for nullifying nested global value
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
12 months ago