f8ab189515
Merge pull request #6582 from jonasrutishauser/fix/hooks_output
...
Use same output format for hooks as for manifest
5 years ago
9ea75a9f59
Use same output format for hooks as for manifest
...
Signed-off-by: Jonas Rutishauser <jonas.rutishauser@alumni.ethz.ch>
5 years ago
2d5faff6a1
Create file locking directory if it does not exist ( #6555 )
...
* Create file locking directory if it does not exist
As Helm v3 uses lazy creation for configuration then
directories and files are not created until required.
File locking when doing repo add was introduced in
v2 and ported to v3 in #6492 . It locks on the config
directory where the repo file resides and therefore
needs the directory to be created if it doesn't exist.
This fix adds the directory if need be,
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Add unit test
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
5 years ago
07c950fc41
Merge pull request #6571 from cgetzen/cg/dev-v3/kube_create_goroutine
...
v3: Performance: Batch kube API operations
5 years ago
bb9426c4e2
fix(pkg/lint): fix lint silently ignoring non existing packaged charts
...
Closes #6428
Signed-off-by: Karuppiah Natarajan <karuppiah7890@gmail.com>
5 years ago
d2cafdc063
modify resources to match helm3
...
Signed-off-by: Charlie Getzen <charlie.getzen@procore.com>
5 years ago
ce4ca05d0a
use WaitGroup instead of channels and counters
...
Signed-off-by: Charlie Getzen <charlie.getzen@procore.com>
5 years ago
3799d0024c
fix(cmd): Fix all the outputs
...
There were two different methods and varying ways to output the status of a release.
This standardizes all of the outputs, but requires a breaking change. Output will
not perfectly match previous v3 output, and we had to break the printing function
in the `action` package, but now things are much more standardized.
Fixes #6238
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
5 years ago
410ec5319f
Merge pull request #6579 from cagataygurturk/fix-makefile
...
Fixed Makefile with the new package name
5 years ago
5fa57aa905
Add v3 to missing line
...
Signed-off-by: Cagatay Gurturk <info@cagataygurturk.com>
5 years ago
7066ac2f58
Fixed Makefile with the new package name
...
Signed-off-by: Cagatay Gurturk <info@cagataygurturk.com>
5 years ago
b02080dc2c
fix(downloader): bypass index cache when repository URL defined
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
5 years ago
223c859867
fix(create): convert tabs to spaces on help output
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
5 years ago
9510713d21
fix(chartutil): port over enhancements to `helm create` from Helm 2
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
5 years ago
ea0f59d69f
Merge pull request #6576 from mattfarina/fix-go-modules
...
Fixing the ability to build v3
5 years ago
0c551a02c0
Merge pull request #6574 from mattfarina/cruft-cleanup
...
Removing some duplicate go module stuff not needed
5 years ago
cc51efda47
Fixing the ability to build v3
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
a1a8825cdc
Removing some duplicate go module stuff not needed
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
6f0235f659
Merge pull request #5498 from mattfarina/go-mod
...
Migrating dependency management to go modules
5 years ago
9bc7934f35
Updating the module for v3 as the major version
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
967f4fed42
Update dependencies
...
* Kubernetes updated to 1.16.1
* SemVer and Sprig updated to latest releases that leverage go
modules
* Tests and checks updated. These already landed in v2 via PR 6457
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
25bbd88639
Add check on empty list
...
Signed-off-by: Charlie Getzen <charlie.getzen@procore.com>
5 years ago
4c39d2b63f
batch perform function by resource kind (Deployment, Pod, etc)
...
Signed-off-by: Charlie Getzen <charlie.getzen@procore.com>
5 years ago
f7a05ba018
Use a goroutine when interacting with kube api
...
Signed-off-by: Charlie Getzen <charlie.getzen@procore.com>
5 years ago
f18c078618
Reducing the circleci footprint
...
* Removed the parallelism as it was running the same tests 3 times
* Removed caching as the time to cache/restore is about the same
as without caching
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
e247d30503
Merge pull request #6563 from VilledeMontreal/fix/historyOutputFlag
...
v3: fix(cmd) have history use global output flag
5 years ago
e3137d106a
Migrating dependency management to go modules
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
cb86db7ff5
fix(cmd) have history use global output flag
...
Also, it seems that for helm v3, the description of flags all start
with a lowercase, so this commit also does that for the output flag.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
5 years ago
5c592dcca6
Merge pull request #6541 from BhaveshSethi/feature/add-version-to-helm-list
...
Feature/add version to helm list
5 years ago
319045d351
Merge pull request #6547 from SimonAlling/processDependencyConditions
...
ref(pkg/chartutil): Simplify processDependencyConditions
5 years ago
3cc0240d8d
Merge pull request #6549 from perher/no-wait-paused-v3
...
Skip waiting for paused deployments
5 years ago
c1fc24c84e
Merge pull request #6386 from VilledeMontreal/fix/testrunnocluster
...
Check connectivity to cluster for helm test run
5 years ago
337f52c566
fix(pkg/action): fix conditional dependencies not working with reuse values
...
Closes #6530
Signed-off-by: Karuppiah Natarajan <karuppiah7890@gmail.com>
5 years ago
43bb10cd24
ref(pkg/chartutil): Dry up file and path names ( #6554 )
...
Signed-off-by: Simon Alling <alling.simon@gmail.com>
5 years ago
11d5a269a7
Merge pull request #6542 from thomastaylor312/fix/atomic_delete
...
fix(action): Protects against current resource conflicts
5 years ago
6ccb2897d9
PR fixes
...
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
5 years ago
f5e977b8ed
Skip waiting for paused deployments
...
Signed-off-by: Per Hermansson <perher1@gmail.com>
5 years ago
a40debd42b
ref(pkg/chartutil): Simplify processDependencyConditions
...
Before this commit, `r.Enabled` was modified if and only if a boolean
was found in the for loop, and in that case, it was assigned the value
of said boolean, just in a more complicated way.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
5 years ago
36f3a4b326
fix(action): Protects against current resource conflicts
...
Currently, if using the --atomic flag or deleting a release that failed due to an already existing
resource, Helm will deleting those resources that aren't managed by it. This PR fixes the issue
by checking for pre-existing resources during install and upgrade. This is done as a validation
step so the release will not even be started if resources currently exist. This PR is inspired by
@xchapter7x's work in #3477 .
This also fixes a small bug in upgrade where deletes fail if the resource was already deletes
Fixes #6407
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
5 years ago
37f7cc0851
Merge pull request #4917 from derkoe/dev-v3-fix-requirement-condition
...
fix(pkg/chartutil): conditions for alias and umrella charts (#3734 )
5 years ago
0c43fc9175
go formatted - (gofmt)
...
Signed-off-by: Bhavesh Sethi <bhaveshsethi1611@gmail.com>
5 years ago
951a5d1b9c
update test files to account for added field
...
Signed-off-by: Bhavesh Sethi <bhaveshsethi1611@gmail.com>
5 years ago
40962b1be7
add appVersion field to output
...
Signed-off-by: Bhavesh Sethi <bhaveshsethi1611@gmail.com>
5 years ago
0ca3840714
Merge pull request #6444 from mumoshu/fix-no-hooks-flag
...
fix(v3): `helm template` output should include hooks by default
5 years ago
26dacf84aa
feat(cmd): Port child NOTES.txt rendering to Helm 3 ( #6512 )
...
* Port Helm 2 PR 4088 to Helm 3
Not a direct port as is but refactored for Helm 3.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Update unit test to test string retunred for different order
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
5 years ago
db15a6f898
Create charts directory for scaffold chart ( #6516 )
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
5 years ago
5c18e1b89f
fix(helm3): `helm template` output should include hooks by default
...
This fixes `helm template [--no-hooks]` to work like proposed in #6443
Manually tested with running `helm template` against `stable/mysql` chart with helm 2, helm 3.0.0-beta.3, and helm 3 after this fix.
The manual test report follows. Assume `helmv3` is 3.0.0-beta.3 and `helmv3-nohooksfix` is the binary build from this PR.
```
$ helmv3 fetch stable/mysql
$ helmv3 template mysql-1.3.1.tgz > helm-template-mysql-helm-3.yaml
$ helmv3-nohooksfix template mysql-1.3.1.tgz > helm-template-mysql-helm-3-with-fix.yaml
$ helmv3-nohooksfix template --no-hooks mysql-1.3.1.tgz > helm-template-mysql-helm-3-with-fix-nohooks-enabled.yaml
```
The example below shows that this fix changes `helm template` to output hooks by default:
```
$ diff --unified helm-template-mysql-helm-3{,-with-fix}.yaml
--- helm-template-mysql-helm-3.yaml 2019-09-17 22:21:38.000000000 +0900
+++ helm-template-mysql-helm-3-with-fix.yaml 2019-09-17 22:21:53.000000000 +0900
@@ -13,10 +13,10 @@
type: Opaque
data:
- mysql-root-password: "VGtybWh5N3JnWA=="
+ mysql-root-password: "aGpHN2VEbnhvVA=="
- mysql-password: "OTNQSXdNVURBYw=="
+ mysql-password: "UmpwQkVuMHpoQQ=="
---
# Source: mysql/templates/tests/test-configmap.yaml
apiVersion: v1
@@ -167,3 +167,48 @@
claimName: RELEASE-NAME-mysql
# - name: extras
# emptyDir: {}
+---
+# Source: mysql/templates/tests/test.yaml
+apiVersion: v1
+kind: Pod
+metadata:
+ name: RELEASE-NAME-mysql-test
+ namespace: default
+ labels:
+ app: RELEASE-NAME-mysql
+ chart: "mysql-1.3.1"
+ heritage: "Helm"
+ release: "RELEASE-NAME"
+ annotations:
+ "helm.sh/hook": test-success
+spec:
+ initContainers:
+ - name: test-framework
+ image: "dduportal/bats:0.4.0"
+ command:
+ - "bash"
+ - "-c"
+ - |
+ set -ex
+ # copy bats to tools dir
+ cp -R /usr/local/libexec/ /tools/bats/
+ volumeMounts:
+ - mountPath: /tools
+ name: tools
+ containers:
+ - name: RELEASE-NAME-test
+ image: "mysql:5.7.14"
+ command: ["/tools/bats/bats", "-t", "/tests/run.sh"]
+ volumeMounts:
+ - mountPath: /tests
+ name: tests
+ readOnly: true
+ - mountPath: /tools
+ name: tools
+ volumes:
+ - name: tests
+ configMap:
+ name: RELEASE-NAME-mysql-test
+ - name: tools
+ emptyDir: {}
+ restartPolicy: Never
```
The example below shows that `helm template --no-hooks` can be used for excluding hooks:
```
$ diff --unified helm-template-mysql-helm-3{,-with-fix-nohooks-enabled}.yaml
--- helm-template-mysql-helm-3.yaml 2019-09-17 22:21:38.000000000 +0900
+++ helm-template-mysql-helm-3-with-fix-nohooks-enabled.yaml 2019-09-17 22:22:03.000000000 +0900
@@ -13,10 +13,10 @@
type: Opaque
data:
- mysql-root-password: "VGtybWh5N3JnWA=="
+ mysql-root-password: "Zk1LYUd6OWgzaQ=="
- mysql-password: "OTNQSXdNVURBYw=="
+ mysql-password: "OTZPZU9hdlFORg=="
---
# Source: mysql/templates/tests/test-configmap.yaml
apiVersion: v1
```
Fixes #6443
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
5 years ago
3fa4465eec
Merge pull request #6502 from VilledeMontreal/feat-v3/compRenamedBin
...
v3: Support auto-complete of a renamed helm binary
5 years ago
c225b60307
Avoid string concatenation
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
5 years ago
15d277360e
Merge pull request #6504 from thomastaylor312/feat/output
...
feat(*): Ports all output functionality from v2
5 years ago
Taylor Thomas
Jonas Rutishauser
Martin Hickey
Karuppiah Natarajan
Charlie Getzen
Matt Farina
Cagatay Gurturk
Matthew Fisher
Marc Khouzam
Simon Alling
Per Hermansson
Simon Alling
Bhavesh Sethi
Yusuke Kuoka