The toTOML doc comment said "returns empty string on marshal error"
but the implementation actually returns err.Error(). Fix the comment
to match the real behavior. Also mention mustToToml as the strict
alternative.
Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>
Add `mustToToml` that panics on marshal error, consistent with
`mustToYaml` and `mustToJson`. This makes it possible for chart authors
to get a hard failure when TOML serialization fails, rather than having
to inspect the output manually.
`toToml` behavior is unchanged in this commit.
Closes#31430
Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>
Remove pre-Go modules import path comments from pkg/kube test files
(ready_test.go, resource_test.go, statuswait_test.go) for consistency
with the rest of the package.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Import path comments (e.g. `// import "helm.sh/helm/v4/pkg/kube"`) are
a pre-Go modules convention no longer needed in module-aware builds.
Some files in pkg/kube had these comments while others did not, causing
inconsistency that triggered downstream Kythe indexing errors.
Remove the import comments from all affected files to make the package
declaration consistent across the directory.
Fixes#31846
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
The import comment in pkg/kube/statuswait.go still referenced
helm.sh/helm/v3/pkg/kube while all other files in the package
correctly reference helm.sh/helm/v4/pkg/kube. This mismatch
causes downstream processing errors (e.g. kythe) when vendoring
Helm.
Fixes#31846
Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
When a dependency declared an alias, the nested path entry in the
coalesced values snapshot (e.g. cvals["midChart"]["leafChart"]) was
built by an ancestor's CoalesceValues call that still used the
original chart name as the map key. As a result, the subchart's own
default values were coalesced under the original name only, leaving
the alias-keyed nested entry incomplete. Condition lookups that
navigated via the accumulated path therefore returned ErrNoValue
instead of the chart's default, causing disabled-by-default
dependencies to be incorrectly rendered.
Fix by coalescing the correctly-computed top-level entry
(cvals[alias], produced at the current level after alias renaming)
into the stale nested entry before recursing. The nested entry
retains priority so explicit ancestor overrides are preserved; only
missing defaults are filled in.
Signed-off-by: Julian Siebert <j.siebert@micromata.de>
Julian Siebert
George Jenkins
Anmol Virdi
Debasish Mohanty
Terry Howe
Ilya Kiselev
Matthieu MOREL
abhay1999
tsinglua
Matheus Pimenta
Travis Leeden
Mads Jensen
Julian Siebert
rohansood10