The binary of Helm to use for dynamic completion should be the same
as the actual Helm binary being used. For example, if PATH points
to a version of helm v3, but the user calls a binary named helm2 to
use a renamed v2 version, then dynamic completion should also use helm2.
If not, in this example, the dynamic completion will use the
information returned by helm v3.
This improvement is particularly useful for users that will run both
helm v2 and helm v3 at the same time.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
This cuts down on the number of duplicate json/yaml marshaling blocks and
simplifies how to add printing to a function by using simple "container" structs
that know how to massage the data
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
unit test adapted for output json or yaml in install_test.go and search_test.go.
docs modified for new flag helm_install.md, helm_repo_list.md, helm_search.md and helm_upgrade.md
Signed-off-by: Michael Schaefer <michael.schaefer@sew-eurodrive.de>
- Convert Tiller Deployment from extensions/v1betax to apps/v1
- Update installation unit tests
- Add support for helm init --upgrade
Signed-off-by: Jerome Brette <jbrette@gmail.com>
If starter template path is an absolute path, it shouldn't
be prefixed with c.home.Starters() but rather be used as is.
Signed-off-by: Tine Jozelj <tine.jozelj@tjo.space>
Signed-off-by: ds-ms <desattir@microsoft.com>
Using debug function instead
Signed-off-by: ds-ms <desattir@microsoft.com>
Removing [INFO] from the message
Turns out that removing the quotes from the associate array
'aliashash' is still required, but because it is needed for
completion of alias commands. For example
helm dep <TAB>
does not complete as expected (as if it was 'helm dependency')
if the quotes are not removed.
This is because although bash ignores quotes when using
associative arrays, zsh does not. So when looking for an alias
aliashash[dep]
will not match the entry
aliashash["dep"]
in zsh but will for bash. Therefore, removing the quotes fixes
things.
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
This reverts commit d2ab3f5062.
The reverted commit turned out to be a workaroud another problem.
The real fix is submitted in PR #5680
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
- Add ability to test for nested non-existent keys
- Add test cases for nested null values
- Minimalist fix for nested null key test cases
- Add missing metadata to integration test
Signed-off-by: Adam Eijdenberg <adam.eijdenberg@digital.gov.au>
PR #5072 followed by #5406 tweaked the handling of the associative
array 'aliashash' when in zsh. However, upon further investigation
the root of the problem was the 'aliashash' was not being declared
properly as it was declared within a method and therefore not
accessible to the rest of the completion script.
The previous commit of this PR makes the necessary change to properly
declare 'aliashash' which makes the previous tweak unecessary. This
commit removes the tweak.
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
This is a bug I ran into when working on Helm completion.
I was surprised that it didn't happen when I was using
kubectl, so I investigated and found a PR that fixed this
bug in kubectl:
https://github.com/kubernetes/kubernetes/pull/48553
I duplicated the code in this commit which:
Removes __helm_declare, which is safe to do since
`declare -F` is already replaced to `whence -w` by
__helm_convert_bash_to_zsh().
The problem was that calling "declare" from inside a function
scopes the declaration to that function only. So "declare"
should not be called through __helm_declare() but instead
directly.
To reproduce:
1- setup helm completion in zsh
2- helm --kubeconfig=$HOME/.kube/config statu<TAB>
you will get the error:
__helm_handle_flag:27: bad math expression: operand expected at end of string
Co-authored-by: Kazuki Suda <kazuki.suda@gmail.com>
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
Matthew Fisher
Marc Khouzam
Taylor Thomas
陈谭军
yuxiaobo
Michael Schaefer
Jerome Brette
Marc Khouzam
Anton
Martin Hickey
dzzg
Tine Jozelj
Oleg Sidorov
ds-ms
Matt Farina
Naseem
Xiang Dai
Adam Eijdenberg
dev-chulbuji
Tariq Ibrahim
Patrick Decat
Jon Huhn