Andrew Block
834a11db56
Added registryClient to resolver
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Scott Rigby
1fabbabae9
Fix Trim to TrimPrefix
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
a8df413c41
Update ORAS to v1.1.0-rc1
...
Now that https://github.com/oras-project/oras-go/pull/89 is merged and released
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
e3f2fb4235
Add OCI tag verions to the Dependency object before Resolve. TODO: fix HTTP HTTPS error for local registries
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Andrew Block
9a7c362dd1
Initial tag listing support
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Scott Rigby
39792b5ad0
Revert "It appears we never got to this block below. Quick rec by Farina. Untested if necessary"
...
This reverts commit f616a01808da3428c6191e5196f32ca72eb22254.
Removing for now until we know we need it.
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
3dc9930488
Revert "hack in progress"
...
This reverts commit c0be414e4b8d2928018504c010cb04b1b2450bf3.
Taking a different approach, but keep this work in git history for now until we
know the new approach works.
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
16453c372c
It appears we never got to this block below. Quick rec by Farina. Untested if necessary
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
042e13d0d1
Temp use Andy's fork PR branch
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
0d2f0116ea
hack in progress
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
3072ce42d9
Merge pull request #10536 from zonggen/issue-10156
...
registry: change default registry config from `registry.json` to `registry/config.json`
3 years ago
Allen Bai
e3897ad6b1
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
...
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.
Ref:
- https://github.com/helm/helm/pull/10536#issuecomment-1010144075
- https://github.com/oras-project/oras-go/pull/92
Signed-off-by: Allen Bai <abai@redhat.com>
3 years ago
Allen Bai
e08a9270be
HELM_REGISTRY_CONFIG: change default file of registry config to config.json
...
Changes default registry config file from `registry.json` to
`config.json`. This aligns with the `config.json` that is widely used in docker.
Closes: https://github.com/helm/helm/issues/10156
Related: https://github.com/helm/helm/issues/10122
Signed-off-by: Allen Bai <abai@redhat.com>
3 years ago
Scott Rigby
46aa53ad22
Merge pull request #10521 from scottrigby/adopt-underscore-convention-for-semver-build-metadata
...
For OCI, convert + to _ before pull, and + to _ before push
3 years ago
Josh Wolf
fed0d31bf5
ensure consistency in registry client Push/Pull function signatures. ensure message is only printed when tags contain a replaced character
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
3 years ago
Scott Rigby
157ac85ab7
Fix typo. Thanks buildbot. Also comments at 80 chars
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Josh Wolf
fb0eeebf66
add oci reference validation and tag scoped (+) replacement to registry client Push/Pull
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
3 years ago
Martin Hickey
292368a64d
Merge pull request #10209 from yxxhero/fix_sa_issue
...
Add more debug msg when helm upgrade
3 years ago
yxxhero
f82896b0b5
add more debug msg when helm upgrade
...
Signed-off-by: yxxhero <aiopsclub@163.com>
3 years ago
Matt Farina
ea5d7af200
Merge pull request #10535 from mattfarina/fix-10534
...
Fixing issue where OCI handling early causes a bad message
3 years ago
Matt Farina
d02f13c1bf
Merge pull request #10424 from davidxia/patch1
...
docs: Clarify use of --set-file
3 years ago
Matt Farina
ee73a0263c
Fixing issue where OCI handling early causes a bad message
...
Note, there is OCI handling later in the funtion that should
handle the situation instead.
Closes #10534
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Scott Rigby
8424bc2b60
Update registry underscore message with semver note for extra clarity
...
Add newline to registry underscore message
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
4aacbc44e0
Move plus/underscore change to inside Client. Compare original ref for strict mode
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Martin Hickey
39ca699ca7
Merge pull request #9119 from ErmakovDmitriy/master
...
Added flag --list-repo
3 years ago
Bridget Kromhout
a30a8481b8
Adding Joe Julian as triage maintainer
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
3 years ago
Matt Farina
d9ffe37d37
Merge pull request #9536 from mengjiao-liu/add-install-validate
...
validate release name during install
3 years ago
Scott Rigby
472eb6f096
For OCI, convert + to _ before pull, and + to _ before push
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Teo Klestrup Röijezon
94779dc99f
fix(helm): ignore file-not-found error for `helm repo list -o json`
...
Currently, `helm repo list -o json` returns (either `[]` or an english
"no repositories" error message, depending on whether
`$HELM_CONFIG_HOME/repositories.yaml` exists). This PR aligns the two cases
so that it always returns `[]`.
Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
3 years ago
Marc Khouzam
b8d3535991
feat(comp): Allow fuzzy matching during completion
...
We had made the assumption that when doing shell completion, we only
needed choices that had for *prefix* what the user had typed.
However, the zsh and fish shells have a more advanced matching system
which first matches on prefix, but if no match is found, then does
more advanced matching attempts, such as sub-strings; fish even matches
on descriptions of completions.
For example,
helm status nginx<tab>
would match releases such as
ingress-nginx
ingress-nginx-release
as long as no release had a prefix of "nginx".
Such fuzzy matching can make completion even more useful for users in
cases where identical prefixes are common.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
3 years ago
Matt Farina
66fb403804
Merge pull request #10490 from helm/dependabot/go_modules/github.com/docker/docker-20.10.12incompatible
...
chore(deps): bump github.com/docker/docker from 20.10.11+incompatible to 20.10.12+incompatible
3 years ago
mengjiao.liu
160da867d0
validate release name during install
...
Signed-off-by: mengjiao.liu <mengjiao.liu@daocloud.io>
3 years ago
Matthew Fisher
d3dbd65997
Merge pull request #10504 from jayonlau/clean_up
...
Clean up extra spaces
3 years ago
jayonlau
55bb6c307a
lean up extra spaces
...
Although these errors are not important, they affect the code specification.
Signed-off-by: jayonlau <jayonlau@gmail.com>
3 years ago
dependabot[bot]
babbb67f89
chore(deps): bump github.com/docker/docker
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 20.10.11+incompatible to 20.10.12+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/docker/docker/compare/v20.10.11...v20.10.12 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
dependabot[bot]
d417878a69
chore(deps): bump github.com/spf13/cobra from 1.2.1 to 1.3.0
...
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra ) from 1.2.1 to 1.3.0.
- [Release notes](https://github.com/spf13/cobra/releases )
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md )
- [Commits](https://github.com/spf13/cobra/compare/v1.2.1...v1.3.0 )
---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
Matt Farina
47c2fd78a2
Merge pull request #10488 from mattfarina/bump-k8s-0.23.1
...
Updating Kubernetes packages to those from 1.23.1
3 years ago
Kay Yan
141f2dd501
Fix typo
...
Unset the env var before func return in Unit Test
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
3 years ago
Matt Farina
5c698e9fa7
Updating Kubernetes packages to those from 1.23.1
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
3 years ago
Matt Farina
ca4e926009
Merge pull request #10470 from bridgetkromhout/prydonius-emeritus
...
Moving prydonius to emeritus
3 years ago
Neven Miculinic
5059ae843e
Fix install memory/goroutine leak
...
Signed-off-by: Neven Miculinic <neven.miculinic@gmail.com>
3 years ago
Bridget Kromhout
ad1110eaba
Moving prydonius to emeritus
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
3 years ago
root
679e14cd21
add legal name check
...
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
3 years ago
Andrew Block
797a8cd524
Honor --dependency-update flag in upgrade command
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Simon Alling
dd5db7bc40
Remove AssertGoldenBytes test helper
...
The test suite is thereby simplified somewhat.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
3 years ago
Simon Alling
0f15b01dfb
Remove runTestActionCmd and use runTestCmd instead
...
`runTestCmd` is identical to `runTestActionCmd` except that it
* runs the command multiple times if the `repeat` property is greater
than zero,
* calls its storage `storage` instead of `store`,
* fails if the `Create` method returns an error, and
* logs a "running cmd" message.
This is most easily demonstrated by copying the functions to their own
files and diffing the files with this command:
git diff --no-index --ignore-space-change --color-words=. runTestActionCmd.go runTestCmd.go
Also, `runTestCmd` is used 32 times; `runTestActionCmd` only 1.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
3 years ago
Matt Farina
8ca401398d
Merge pull request #10440 from jkmw/fix/10439
...
Fix memory leak in upgrade action
3 years ago
Jerome Küttner
9a492f8240
Channel should remain open if there is still a routine that wants to write into it
...
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 years ago
Jerome Küttner
ad3d2cc8ef
Fix memory leak in upgrade action
...
fixes helm/helm#10439
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 years ago
Matt Farina
0e6e936ab8
Merge pull request #10410 from helm/dependabot/go_modules/github.com/Masterminds/squirrel-1.5.2
...
chore(deps): bump github.com/Masterminds/squirrel from 1.5.1 to 1.5.2
3 years ago