Benoit Tigeot
70fc5f97e2
Code review
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
Benoit Tigeot
9f1c8a26f0
Fix linting issue
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
Michelle Fernandez Bieber
6bb5bcc212
Update pkg/action/hooks.go
...
Co-authored-by: Marco Lecheler <marco@task.media>
Signed-off-by: Michelle Fernandez Bieber <37021266+mfbieber@users.noreply.github.com>
1 month ago
Michelle Fernandez Bieber
d9301441f4
added check for nil shutdown
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
1 month ago
Michelle Fernandez Bieber
7a61ebf013
cleaned up empty line
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
1 month ago
Michelle Fernandez Bieber
10714772be
updated comment and made defer of shutdown function return errors as before and not the possible shutdown error
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
1 month ago
Michelle Fernandez Bieber
7a557580e1
added shutdown hook that is executed after the logs have been retrieved
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
1 month ago
Robert Sirchia
722482b77d
Merge pull request #31561 from atombrella/feature/nilness_cleanup
...
Remove two redundant if-checks.
1 month ago
Mads Jensen
380abe2b16
Remove two redundant if-checks.
...
These were found with the nilness checker.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
1 month ago
Matt Farina
936cd328ac
Fix kube client logging
...
The kube client logging is based on the actionConfig logging. This
is setup to use slog.Default() before the logging flags are parsed
and logging is setup.
newRootCmdWithConfig changes the logging but it wasn't picked up
for actionConfig or the kube client. This change updates the logging
to include any changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
Matt Farina
61d289c119
Merge pull request #31518 from gjenkins8/gjenkins/fix_update_create
...
fix: Use server-side apply for object create during update
1 month ago
Matt Farina
698fcd2290
Merge pull request #31515 from gjenkins8/gjenkins/copy_adopted
...
fix: Copy adopted resource info
1 month ago
Matt Farina
df6aafeeee
Merge pull request #31462 from mattfarina/load-archive
...
Adding a LoadArchive to common loader
1 month ago
Matt Farina
63858b383f
Merge pull request #31535 from mattfarina/bump-4.1
...
bump version to 4.1
1 month ago
Robert Sirchia
eb3da36e2e
Merge pull request #31530 from shuv0id/improve-debug-logging
...
fix: add missing context to debug logs
1 month ago
George Jenkins
63dcb5c74c
Merge pull request #31464 from benoittgt/fix-test
...
Properly test error messages on pull command's test
1 month ago
Matt Farina
63e060fb05
bump version to 4.1
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
shuv0id
2dc5864f44
fix: add missing context to debug logs
...
Adds chart name to dependency logs, namespace to resource waiting logs,
and confirmation message when all resources are ready.
Addresses #31520
Signed-off-by: shuv0id <110290476+shuv0id@users.noreply.github.com>
1 month ago
George Jenkins
f8a49f1852
fixup test
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
George Jenkins
a9cdc78116
logs
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
George Jenkins
b1a976073f
fix
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
Robert Sirchia
a75fcc2948
Merge pull request #31478 from promalert/main
...
refactor: use strings.Builder to improve performance
1 month ago
George Jenkins
18616e6ce9
fix: Use server-side apply for object create during update
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
Scott Rigby
ebd5f53fc3
Merge pull request #31421 from benoittgt/improve-doc-wait-strategy
...
Unify --wait strategy inputs, clarify defaults and docs; avoid SDK timeout footgun
1 month ago
George Jenkins
855ebb6884
Copy adopted resource info
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
Scott Rigby
b740071279
Merge pull request #31342 from TerryHowe/chore-remove-mitchellh-dependency-3
...
chore: replace github.com/mitchellh/copystructure
2 months ago
Scott Rigby
e7ac8fe3b8
Merge pull request #30984 from fm1ck3y/bug/index-concurrency
...
feat(concurrency): allow concurrent dependency build with atomic file write
2 months ago
Scott Rigby
d57fb45648
Merge pull request #31469 from saimanojk1/issue-31454
...
Convert pkg/cmd/load_plugins.go to slog
2 months ago
promalert
d8c4040336
refactor: use strings.Builder to improve performance
...
Signed-off-by: promalert <promalert@outlook.com>
2 months ago
Scott Rigby
0ee89d2d4e
Merge pull request #31418 from tisonkun/typo
...
chore: fix typo of public field
2 months ago
Benoit Tigeot
02312a1cf2
Update pkg/cmd/flags.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
277c140c87
Error strategy list match help
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
5f6fa437b2
Prevent surprising failure with SDK when timeout is not set
...
While testing SDK features for v4. I was surprised with the error:
"reporter failed to start: event funnel closed: context deadline exceeded"
This occurs when no timeout is set:
```
upgradeClient := action.NewUpgrade(actionConfig)
upgradeClient.WaitStrategy = kube.StatusWatcherStrategy
// When Timeout is zero, the status wait uses a context with zero timeout which
// immediately expires causing "context deadline exceeded" errors.
upgradeClient.Timeout = 2 * time.Minute
```
With this patch it will work without specifying.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
52a282832f
Do not change the default waiting strategy when --wait is not set
...
It is too much a breaking change for a new RC of beta V4.
See comment: https://github.com/helm/helm/pull/31421#discussion_r2465121438
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
11128659aa
Provide more help for SDK user when setting up WaitStrategy
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
8535e9f4ab
Avoid confusion between `--wait` (watcher) and no --wait (hookOnly)
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
1836f37f4d
The default is not HookOnlyStrategy but WaitStrategy
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
a5e110fccd
Make wait strategy selection more obvious
...
It is not clear enough that you need to set --wait=false for a hook only
strategy.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
e8b0cff45a
Update pkg/cmd/flags.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
95e1ee1089
Increase documentation of --wait flag
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
5cbd9b3035
While testing SDK features for v4. I was surprised with the error:
...
> "reporter failed to start: event funnel closed: context deadline exceeded"
It happens when you forget to set a minimal timeout:
```go
upgradeClient := action.NewUpgrade(actionConfig)
upgradeClient.WaitStrategy = kube.StatusWatcherStrategy
// When Timeout is zero, the status wait uses a context with zero timeout which
// immediately expires causing "context deadline exceeded" errors.
upgradeClient.Timeout = 2 * time.Minute
```
Also maybe it might be worth documenting this more clearly. Initial [PR](https://github.com/helm/helm/pull/13604 ) say:
> I have not written any docs, I assume that can be done when we are closer to Helm 4, a lot of it is covered by linking to - https://github.com/kubernetes-sigs/cli-utils/blob/master/pkg/kstatus/README.md
Related:
- https://github.com/helm/helm/pull/31411#issuecomment-3443925663
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
saimanojk1
6de83c5f60
Convert pkg/cmd/load_plugins.go to slog
...
Signed-off-by: saimanojk1 <saimanojk1@hotmail.com>
2 months ago
George Jenkins
cdb48b88fb
Merge pull request #31240 from benoittgt/fix-31170-URN
...
jsonschema: warn and ignore unresolved URN $ref to match v3.18.4
2 months ago
tison
4576a81a00
for remaining local variable case inconsistency
...
Signed-off-by: tison <wander4096@gmail.com>
2 months ago
Benoit Tigeot
ed6cf0e8a1
Properly test error messages on pull command's test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Matt Farina
0f5eda74c1
Adding a LoadArchive to common loader
...
LoadArchive is in the individual loaders for the chart versions.
It is used by SDK users to load a stream rather than a file on
the filesystem. Adding to support SDK users like Flux.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 months ago
George Jenkins
384a3f0ff8
Merge pull request #31385 from porridge/test-unknown-policy
...
test: protect unknown hook delete policies
2 months ago
tison
90d01915f9
for all other similar cases
...
Signed-off-by: tison <wander4096@gmail.com>
2 months ago
Scott Rigby
99cd196435
Merge pull request #31435 from matheuscscp/cancel-health-checks
...
Introduce a context for canceling wait operations
2 months ago
Matheus Pimenta
efc1702657
Introduce a context for canceling wait operations
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 months ago