Normally zsh arrays start at index 1 but when emulating other shells
this may change. During completion, we run the command
emulate -L sh
which affects the indexing of zsh arrays to make it start at 0.
Consequently, when replacing FUNCNAME by funcstack, we should not
change the index.
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
Cobra provides some out-of-the-box debugging for bash completion.
To use it, one must set the variable BASH_COMP_DEBUG_FILE to
some file where the debug output will be written. Many of the
debug printouts indicate the current method name; they do so
by using bash's ${FUNCNAME[0]} variable. This variable is
different in zsh. To obtain the current method name in zsh
we must use ${funcstack[1]}.
This commit adds the proper sed modification to convert from
bash to zsh.
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
Update to the latest Sprig version, which is a reversion of some of
the functions added in 2.18.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
Correct some words spelling for reading more easily.
Signed-off-by: Nguyen Quang Huy <huynq0911@gmail.com>
Co-Authored-By: Nguyen Van Trung <trungnvfet@outlook.com>
Although it is spelling mistakes, it might make an affects
while reading.
Co-Authored-By: Dao Cong Tien tiendc@vn.fujitsu.com
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
Changes as per PR https://github.com/helm/helm/pull/5271
- make imagePullSecrets be an array
- move imagePullSecrets to 'root' level of Values
Signed-off-by: Don Bowman <db@donbowman.ca>
Describe detail step-by-step of using github to contribute to
helm project.
Co-Authored-By: Dao Cong Tien tiendc@vn.fujitsu.com
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
This commit aims to add '/usr/bin/env bash' as a shebang line
to indicates scripts use bash shell for interpreting.
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
When Helm is packaging up the bundles it generates the checksums
but does not display them. Having them here will aide in the
generation of release notes and provide another source
listing them.
Signed-off-by: Matt Farina <matt@mattfarina.com>
That the match is based on version is implicit. Making it explicit
because I had to think when I saw it.
Signed-off-by: Matt Farina <matt@mattfarina.com>
* ref: Update Sprig to 2.18.0
This fixes a problem with Go 1.11 and also adds some new functions.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* Added the glide.lock file.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* fix: Update gRPC to get better TLS connection handling
To avoid backward compatibility breakers, we have been pinned to a very
old version of gRPC. But it appears that there have been some very
significant network fixes since then. Looking closely at #3480, it
appears that some of this fixes may be directly related to solving that
bug.
Note that this regenerates a few of the Go proto files, so the binary
wire format may be broken. That means this MUST be held to a minor
version, not a patch release.
To test:
- Build both client and server
- Install Tiller into your cluster
- Perform a number of Helm-Tiller interactions (`helm version`, `helm
list`)
Closes#3480
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* Switched to latest protobuf
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
tariqibrahim
Marc Khouzam
Luis Davim
Joe Lanford
Matt Butcher
Matthew Fisher
Martin Hickey
Patrick Decat
Marc Khouzam
anton
Jacob LeGrone
Don Bowman
Nguyen Van Duc
Nguyen Quang Huy
Vu Cong Tuan
Nguyen Hai Truong
hnwolf
Nguyen Hai Truong
Matt Farina
Miroslav Spousta
Marc Jansen
Alex
Nguyen Van Trung
liaoj
lIuDuI