Martin Hickey
6ca989e777
Merge pull request #8913 from cvila84/fork-lint-bug
...
do not check YAML if nothing was parsed
4 years ago
Marc Khouzam
e16d26717b
fix(helm): flag descriptions start with lowercase
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
4 years ago
Martin Hickey
9c97dc8fa2
Merge pull request #8933 from wawa0210/fix-helm-package-escape-invalid-version
...
Fix invalid semver version number of the helm package command will escape
4 years ago
zh168654
bfc575dec2
add waitwithjobs instead of changing wait api
...
Signed-off-by: zh168654 <zhangye.168@163.com>
4 years ago
zh168654
957d2a2bf9
add wait-for-jobs flag
...
Signed-off-by: zh168654 <zhangye.168@163.com>
4 years ago
zhangye15
bd03e1b5c7
fix style conformance
...
Signed-off-by: zhangye15 <zhangye15@baidu.com>
4 years ago
zhangye15
c96dc48f21
fix test-style error
...
Signed-off-by: zhangye15 <zhangye15@baidu.com>
4 years ago
zh168654
8d498d58e7
add test cases
...
Signed-off-by: zh168654 <zhangye.168@163.com>
4 years ago
zh168654
5825112a8b
helm upgrade with --wait support jobs in manifest to be completed
...
Signed-off-by: zh168654 <zhangye15@baidu.com>
4 years ago
Aayush Joglekar
babc8c9a70
Add remaining tests in TestDependentChartAliases
...
Signed-off-by: Aayush Joglekar <aayushjog@gmail.com>
4 years ago
Martin Hickey
9aa0fbee6c
Merge pull request #8879 from hickeyma/fix/incorrect-lint-msg
...
fix(lint): Lint error message for valid names
4 years ago
Chris Wells
2a7a98ae5a
feat: Allow helm test to run a subset of tests
...
Signed-off-by: Chris Wells <chriswells0@users.noreply.github.com>
4 years ago
wawa0210
2c19838295
Fix that the invalid version number of the helm package command will escape
...
Signed-off-by: wawa0210 <xiaozhang0210@hotmail.com>
4 years ago
Du Zheng
87040536fb
Improve the console output for resource policy keep to align with helm2.
...
Signed-off-by: Du Zheng <zsuzhengdu@gmail.com>
4 years ago
Matt Farina
43b0ef5f20
Merge pull request #8855 from janario/fix/reusabe-kube-client
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
af2d3021f4
Merge pull request #8952 from mattfarina/fix-8940
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
c0d3877231
Merge pull request #8915 from zheng1/master
...
Bugfix: panic when chart contains requirements.lock
4 years ago
Zhengyi Lai
9cc00eea24
Add test case for LoadFiles
...
Signed-off-by: Zhengyi Lai <zheng1@yunify.com>
4 years ago
Matt Farina
882db2543c
Fixes Error: could not find protocol handler for
...
A previous update to automate finding charts in repos when update
was run did not take into account the case for no repo being
specified. This fixes that situation.
Closes #8940
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Lehel Gyuro
27807e1bb5
[ #7696 ] Avoid crash in chart loader on unexpected file sequence
...
Make sure, that chart metadata is initialized by the time the processing
of the chart is started.
Signed-off-by: Lehel Gyuro <lehel@freemail.hu>
4 years ago
Christophe VILA
8a4c0bc7b1
added test for https://github.com/helm/helm/pull/8913 related to https://github.com/helm/helm/issues/8621
...
Signed-off-by: Christophe VILA <christophe.vila@thalesgroup.com>
4 years ago
Lehel Gyuro
8abb44f218
[ #7696 ] Avoid crash in chart loader on unexpected file sequence
...
Make sure, that chart metadata is initialized by the time the processing
of the chart is started.
Signed-off-by: Lehel Gyuro <lehel@freemail.hu>
4 years ago
Martin Hickey
b83632e757
Update err message to use the regex pattern directly
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
4 years ago
Martin Hickey
5785dd6d49
Fix the lint error message for valid names
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
4 years ago
Christophe VILA
f736af95eb
do not check YAML if nothing was parsed
...
Signed-off-by: Christophe VILA <christophe.vila@thalesgroup.com>
4 years ago
Matt Farina
ce4fa95868
bump version to v3.4.0
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 7090a89efc
)
4 years ago
Matt Farina
75b7aeaeeb
Merge pull request #7024 from jan25/issue-6972
...
v3: Prettify Updated time in helm list
4 years ago
Matt Butcher
fe2d7f7792
this rewrites a whole bunch of old repo URLs to the new repo URL ( #8902 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
5f3e560029
improved user-facing error messages to explain the underlying problem ( #8731 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Martin Hickey
8667aa4f98
Merge pull request #8874 from consideRatio/pr/helm-create-template-indentation
...
helm create: make generated YAML indentation more consistent
4 years ago
Matthew Fisher
e73af10d0b
Merge pull request #8696 from f0rmiga/patch-1
...
fix: boilerplate template indentation
4 years ago
Erik Sundell
1d9767fea2
helm create: make generated YAML indentation more consistent
...
Signed-off-by: Erik Sundell <erik@sundellopensource.se>
4 years ago
Janario Oliveira
cf3870a57f
Adjusted import
...
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
4 years ago
Janario Oliveira
10a29d1662
Reuse kube-client
...
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
4 years ago
Matt Farina
6297c021cb
Merge pull request #8795 from mattfarina/feat-8767
...
Adding annotation to index.yaml file
4 years ago
Mikuláš Dítě
6aa54eacc5
feat(install): add requested version to error
...
Signed-off-by: Mikuláš Dítě <dite@mangoweb.cz>
4 years ago
Matt Farina
593fec6868
Merge pull request #8807 from mattfarina/feat-8806
...
Adding support for k8s 1.19
4 years ago
zouyu
a167b3fc87
Fix wrong function's name in comment
...
Signed-off-by: zouyu <zouy.fnst@cn.fujitsu.com>
4 years ago
Matt Farina
b7c38c879a
Adding support for k8s 1.19
...
Closes #8806
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Abhilash Gnan
3ca46f3b23
remove redudant time func
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
4 years ago
Abhilash Gnan
c5e9732a9f
rename to time format flag
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
4 years ago
Abhilash Gnan
f61332f379
add time-format flag to list command
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
4 years ago
Matt Farina
4c121c3085
Adding annotation to index.yaml file
...
Chart.yaml files have an annotation field that allow a chart to
have custom information similar to the way Kubernetes annotations
work.
In an index.yaml file each chart version can have annotations in
a similar manner to the Chart.yaml file. It is derived from the
same underlying struct.
These enable extension points where people can add their own info.
One thing missing is the ability to extend the top level of an
index file. This change adds annotations to the top level of an
index.yaml file. This would provide top level support for vendors
to extent index.yaml files.
Closes #8767
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matthew Fisher
b0fdb5461f
Merge pull request #8244 from carlpett/report-findcharturl-error
...
Report what cause finding chart to fail
4 years ago
Sebastian Sdorra
467bd49bb0
support passing signing passphrase from file or stdin ( #8394 )
...
Signed-off-by: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
4 years ago
Matthew Fisher
f19acbdc94
fix: allow serverInfo field on index files
...
A recent change merged into Helm fixes a number of security issues related to parsing malformed index files. Unfortunately, it also broke the ability for users to load index files from chartmuseum, which adds a "server info" field to add additional metadata.
This commit adds that field so that index files from chartmuseum can be validated. Since Helm does not use this field for anything, the information is discarded and unused.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matthew Fisher
6eeec4a002
switched to stricter YAML parsing on plugin metadata files
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matt Butcher
809e2d999e
Merge pull request from GHSA-m54r-vrmv-hw33
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
055dd41cbe
Merge pull request from GHSA-jm56-5h66-w453
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
59d5b94d35
Merge pull request from GHSA-9vp5-m38w-j776
4 years ago
Matthew Fisher
aa5431ab71
Merge pull request #8751 from technosophos/fix/helm-create-overwrite
...
fixed bug that caused helm create to not overwrite modified files
4 years ago
Matthew Fisher
2a74204508
go fmt
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matthew Fisher
84de24edc9
Merge pull request #8752 from technosophos/fix/better-http-plugin-checks
...
improve the HTTP detection for tar archives
4 years ago
Matt Farina
7953adb06c
Merge branch 'master' into fix/helm-create-overwrite
4 years ago
Matt Butcher
e2da16f514
improve the HTTP detection for tar archives
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Farina
b5daf5a484
Merge pull request #8753 from technosophos/fix/dependency-status
...
handle case where dependency name collisions break dependency resolution
4 years ago
Matt Farina
11f75e420c
Merge pull request #8750 from technosophos/fix/helm-create-name
...
validate the name passed in during helm create
4 years ago
Matt Butcher
40b7800287
handle case where dependency name collisions break dependency resolution
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
106f1fb45c
fixed bug that caused helm create to not overwrite modified files
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
ed5fba5142
refactor the release name validation to be consistent across Helm
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Thulio Ferraz Assis
b4bb73d8ce
fix: if not .Values.autoscaling.enabled indent
...
Signed-off-by: Thulio Ferraz Assis <thulio.assis@suse.com>
4 years ago
Matt Butcher
c4ef82be13
validate the name passed in during helm create
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matthew Fisher
55fbd985dd
Merge pull request #8707 from zhijianli88/cleanup-tempfiles
...
Cleanup tempfiles
4 years ago
Matthew Fisher
dafeb1541b
Merge pull request #8493 from yxxhero/fix-insecure-skip-tls-verify-flag-not-work-on-helm-install
...
fix insecure-skip-tls-verify flag does't work on helm install
4 years ago
Paul Brousseau
3192408415
Fixing typo in engine comments
...
Signed-off-by: Paul Brousseau <object88@gmail.com>
4 years ago
Li Zhijian
4258e8664e
Use T.cleanup() to cleanup cmdtest_temp file
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
d9ad9153c8
Use RemoveAll to remove a non-empty directory
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
cccc2867ea
mark NewTempServer as Deprecated
...
Please use NewTempServerWithCleanup instead
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
35c5268d9d
Use T.Cleanup() to cleanup temp dir helm-repotest
...
For backward compatibility, as suggested by @bacongobbler, we introduce
a new API NewTempServerWithCleanup
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
leigh capili
9429af8b39
Support impersonation via flags similar to kubectl --as="user"
...
Signed-off-by: leigh capili <leigh@null.net>
4 years ago
Li Zhijian
ba4c8029c2
Use T.cleanup() to cleanup helm-action-test
...
T.Cleanup() is introduced since go-1.14
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Thulio Ferraz Assis
6766017d38
fix: with .Values.podAnnotations indent template
...
Signed-off-by: Thulio Ferraz Assis <thulio.assis@suse.com>
4 years ago
Martin Hickey
daa104d60e
Revert PR 8562
...
Revert of PR 8562 as the container version may not represent the
application version.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
4 years ago
Matt Farina
e454e6a910
Merge pull request #8682 from liuming-dev/remove-duplicate-variable-definition
...
Remove duplicate variable definition
4 years ago
Martin Hickey
2a9ef6d3b0
Merge pull request #8529 from lingsamuel/status-show-desc
...
feat: add flag `--show-desc` to display description for `helm status`
4 years ago
Ling Samuel
da6878dc0f
feat: status command display description
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
4 years ago
Liu Ming
317616482c
Remove duplicate variable definition
...
Variable values `helm.sh/resource-policy` and `keep` are duplicately
defined in resource_policy.go (`resourcePolicyAnno` `keepPolicy`) and
resource_policy.go (`ResourcePolicyAnno` `KeepPolicy`), remove the
varibales in resource_policy.go to keep the code clean.
Signed-off-by: Liu Ming <hit_oak_tree@126.com>
4 years ago
Matt Butcher
04fb35814f
Fixed a variable name collision caused by two PR merges ( #8681 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
70d03e5cef
Fix/8467 linter failing ( #8496 )
...
* add output to get debug info on linter failing
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* trap cases where the YAML indent is incorrect.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
96d9ab9663
fix name length check on lint ( #8543 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Zhou Hao
0669f40e81
cleanup tempfiles for load_test
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
4 years ago
Matt Farina
3fc88f2492
Fixing failing CI for windows
...
A fix introduced in #8631 caused a bug in Windows builds due to
a type difference between POSIX and Windows environments. This
change corrects that problem and provides a code comment to warn
others.
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matthew Fisher
0a28e5cbff
Merge pull request #8631 from mrueg/sem-fixes
...
pkg/*: Small linting fixes
4 years ago
Matt Farina
c7b5f5f88f
Merge pull request #8627 from mattfarina/fix-6418
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Manuel Rüger
4abcdc40ef
pkg/*: Small linting fixes
...
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
4 years ago
Matthew Fisher
0941e3e345
Merge pull request #8613 from tariq1890/if-optimise
...
optimise if condition in service ready logic
4 years ago
Matt Farina
11f658e223
Fixing linting of templates on Windows
...
When the engine stored templates in the map the keys were generated
based on path and not filepath. filepath was being used in the linter
when retrieving content from the keys. On Windows the keys ended up
being different.
This change is to use path joins to create the lookup key. Since the
name path was used in the code it needed to be changed in order to
import the package.
Tests already exist and were failing on windows. This got in because
CI is not run on Windows.
Closes #6418
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matthew Fisher
198f403688
Merge pull request #8590 from Foxboron/morten/fix-go1.15
...
release/mock: Ensure conversion from int to string yields a string
4 years ago
Tariq Ibrahim
b07b2589fb
optimise if condition in service ready logic
...
Signed-off-by: Tariq Ibrahim <tariq181290@gmail.com>
4 years ago
Matthew Fisher
bb33b9264f
Merge pull request #8507 from rajatjindal/fix-watch-timeout-error
...
fix watch error due to elb/proxy timeout
4 years ago
Martin Hickey
273d0364be
Merge pull request #8532 from dm3ch/labels-selector
...
Adding filtering of helm releases for configmap and secret backends during list command
4 years ago
Morten Linderud
83a5e620d0
release/mock: Ensure conversion from int to string yields a string
...
With the release of go 1.15, the test-suite doesn't pass as `go test` got
a new warning for improper `string(x)` usage.
https://golang.org/doc/go1.15#vet
$ make test-unit
# helm.sh/helm/v3/pkg/release
pkg/release/mock.go:56:27: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
[snip]
make: *** [Makefile:82: test-unit] Error 2
This patch changes ensures we are utilizing `fmt.Sprint` instead as
recommended.
Signed-off-by: Morten Linderud <morten@linderud.pw>
4 years ago
Martin Hickey
91094186eb
Merge pull request #8562 from andytom/chore/update_starter_chart
...
Update Common Lables template in starter chart
4 years ago
Thomas O'Donnell
4b1fa60d58
Update Common Lables template in starter chart
...
Have update the Common Labels template in the starter chart so that the
value for the `app.kubernetes.io/version` is set to the same value as
the image tag used in the deployment.
Signed-off-by: Thomas O'Donnell <andy.tom@gmail.com>
4 years ago
Martin Hickey
621c2020c6
Merge pull request #8505 from jiayushe/master
...
Avoid hardcoded container port in default notes
5 years ago
Martin Hickey
a5047b2f6c
Merge pull request #8438 from donggangcj/feature/support-jsonpath
...
feature(show): support jsonpath output for `helm show value`
5 years ago
yxxhero
0674d93609
add helm v4 todo comments for FindChartInAuthAndTLSRepoURL.
...
Signed-off-by: yxxhero <aiopsclub@163.com>
5 years ago
Dong Gang
df4708a9de
polish the error handler
...
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
5 years ago
Dmitry Chepurovskiy
266c74f390
Move selector filtering after latest release version filtering
...
Signed-off-by: Dmitry Chepurovskiy <dm3ch@dm3ch.net>
5 years ago
Dmitry Chepurovskiy
2ea8f805b9
Added testing for list action with selector
...
Signed-off-by: Dmitry Chepurovskiy <dm3ch@dm3ch.net>
5 years ago