Chris Berry
b8e13878fc
Add HookOutputFunc and generic yaml unmarshaller
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Scott Rigby
97b0e11871
clarify fix error message
...
Signed-off-by: Scott Rigby <scott@r6by.com>
1 year ago
Scott Rigby
2f79afb0a3
fix err check
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
1 year ago
Scott Rigby
c77f4ec6c4
remove comments about previous functionality
...
Signed-off-by: Scott Rigby <scott@r6by.com>
1 year ago
Scott Rigby
3cd6afe845
add short circuit return
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
1 year ago
Chris Berry
5367001f4f
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Chris Berry
3c445158d8
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Chris Berry
4cb639ed4e
Fix lint
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Chris
20f859c9ff
Tidy up imports
...
Signed-off-by: Chris <bez625@gmail.com>
1 year ago
Chris Berry
ca90972b3d
Add hook annotations to output pod logs to client on success and fail
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Matt Farina
e2c7986f30
Merge pull request #13534 from althmoha/dev-v3-12987
...
fix (helm) : toToml` renders int as float [ backport to v3 ]
2 years ago
George Jenkins
80f87ab636
Merge pull request #13654 from ryanhockstad/subchart-null
...
[backport] bugfix: Override subcharts with null values
2 years ago
Matt Farina
9aff8bdaa0
Merge pull request #13644 from mattfarina/backport-13583
...
fix: check group for resource info match (v3 backport)
2 years ago
George Jenkins
6ed9d2f2d5
Merge pull request #13592 from stevehipwell/add-plugin-platform-hooks-v3
...
feat: Add multi-platform plugin hook support [v3 backport]
2 years ago
Jiasheng Zhu
2ebce786ba
fix: check group for resource info match
...
Closes : #13582
Signed-off-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com>
(cherry picked from commit f5d488122b )
2 years ago
Ryan Hockstad
326c1e3f67
add test for nullifying nested global value
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
2 years ago
Matt Farina
fba9d08dce
Ensuring the file paths are clean prior to passing to securejoin
...
securejoin v0.4.0 made a possibly breaking change. Only clean paths
are safe to pass to SecureJoin or they could return an error or
have the wrong path. The details are in the release notes for v0.4.0.
This change ensures the paths are clean prior to passing to SecureJoin.
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 35a9ead998 )
2 years ago
Matt Farina
d6db69ed66
bump version to v3.17.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 301108edc7 )
2 years ago
Ryan Hockstad
ef2eb55283
Add test case for removing an entire object
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
2 years ago
Scott Rigby
60fcce18d1
Tests for bugfix: Override subcharts with null values #12879
...
- Add consistency for null test in given values, parent chart, subchart, and
sub-sub-chart
- Remove bar null test to keep consistent with boat=null at top level
Signed-off-by: Scott Rigby <scott@r6by.com>
2 years ago
Andrew Block
83dddb1839
feat: Added multi-platform plugin hook support to v3
...
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
2 years ago
Terry Howe
949b2e6040
fix: make ORAS reference private
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit d2b94f6200 )
2 years ago
Terry Howe
aba95b9cb4
fix: issue with helm template and oci chart
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit aca7e8d775 )
2 years ago
Terry Howe
c3e5217d85
feat: allow installation by OCI digest
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit ad9fb68fa3 )
2 years ago
Matt Farina
9ade3b502a
Merge pull request #13574 from gjenkins8/v3_13343
...
Add annotations and dependencies to get metadata output [v3 backport]
2 years ago
Matt Farina
4f0b63483e
Merge pull request #13575 from gjenkins8/v3_13232
...
ref(create): don't render empty resource fields [v3 backport]
2 years ago
Matt Farina
391a90752d
Merge pull request #13512 from gjenkins8/shadow_oras_remoteclient_type
...
fix: Shadow ORAS remote.Client interface [v3 backport]
2 years ago
Matt Farina
9f620b857a
Update to Go 1.23
...
Multiple changes were made to pass linting. Some Go built-in names
are being used for variables (e.g., min). This happens in the Go
source itself including the Go standard library and is not always
a bad practice.
To handle allowing some built-in names to be used the linter config
is updated to allow (via opt-in) some names to pass. This allows us
to still check for re-use of Go built-in names and opt-in to any
new uses.
There were also several cases where a value was checked for nil
before checking its length when this is already handled by len()
or the types default value. These were cleaned up.
The license validation was updated because it was checking everything
in the .git directory including all remote content that was local.
The previous vendor directory was from a time prior to Go modules
when Helm handled dependencies differently. It was no longer needed.
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 5727f56a96 )
2 years ago
dnskr
ba180a3b6a
ref(create): don't render empty resource fields
...
Signed-off-by: Denis Krivenko <dnskrv88@gmail.com>
Signed-off-by: dnskr <dnskrv88@gmail.com>
2 years ago
Niladri Halder
7321579092
Add annotations and dependencies to get metadata output
...
The output of helm get metadata includes a subset of the fields contained in
the chart.Metadata struct. This change adds the values of the annotations field
and the dependencies field to the output.
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
2 years ago
Althaf M
0a6834fdf0
This commit fixes the issue where the yaml.Unmarshaller converts all int values into float64, this passes in option to decoder,
...
which enables conversion of int into .
Signed-off-by: Althaf M <althafm@outlook.com>
2 years ago
George Jenkins
c40cf00a06
Shadow ORAS remote.Client interface
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Matt Farina
3fe0bbdd44
Merge pull request #13480 from rynowak/rynowak/override-authorizer
...
Make the authorizer and registry authorizer configurable
2 years ago
Matt Farina
41b6273682
Merge pull request #13483 from banjoh/em/password-to-oci-registries-v3
...
fix(helm): pass down username/password CLI parameters to OCI registry clients (v3 backport)
2 years ago
Ryan Nowak
3c2ab91263
Make the authorizer and registry authorizer configurable
...
Fixes : #12584
This change makes the authorizer and registryAuthorizer of the registry client configurable via options. This allows Go SDK users to override the authentication behavior of the client.
This PR makes both the authorizer and registryAuthorizer configurable because depending on the exact scenario that may be needed. The default registryAuthorizer only supports a specific implementation of the authorizer.
Signed-off-by: Ryan Nowak <nowakra@gmail.com>
2 years ago
Evans Mungai
7a22dd28d1
Rename CAFile to CaFile for consistency
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 years ago
Matt Farina
2aba8a1fcd
Merge pull request #13424 from wangjingcun/main
...
fix: fix label name
2 years ago
wangjingcun
e4062e7e00
fix: fix label name
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
2 years ago
Taylor Jasko
6f2f7d4781
Updating subchart load error to be more descriptive
...
In the event some malformed folders/files make its way into the
`charts/` directory meant for subcharts, it is possible one may see an
error message like the below:
```
Error: error unpacking foo in app: Chart.yaml file is missing
```
This error is not very descriptive, as it doesn't reference where on
disk `Chart.yaml` is missing. In the event this happens, this error is
being updated to include that `Chart.yaml` is missing for the `foo`
subchart.
Without this updated error messaging, one would need to look into Helm's
codebase to troubleshoot what exactly is wrong.
Signed-off-by: Taylor Jasko <taylor@taylorjasko.com>
2 years ago
Robert Sirchia
106e2f98e3
Merge pull request #13418 from alex-kattathra-johnson/issue-13417
...
Add tests to `helm/pkg/kube/client_test.go` to cover `wait.go`
2 years ago
Alex Johnson
9fd943b481
Add tests to `helm/pkg/kube/client_test.go` to cover `wait.go`
...
Signed-off-by: Alex Johnson <alex.kattathra.johnson@gmail.com>
2 years ago
Zach Burgess
0cc78c6ac3
Fix typo in pkg/lint/rules/chartfile_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
2 years ago
Suleiman Dibirov
f4f4a6b81f
fix(hooks): correct hooks delete order
...
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
2 years ago
Tianle Xu
a51ea6ec73
Allow tests to run on loong64
...
Signed-off-by: Tianle Xu <xtl@xtlsoft.top>
2 years ago
Andrew Block
717529a7e5
Merge pull request #13376 from helm/fix_oci_push_timestamp
...
fix: Use chart archive modifed time for OCI push
2 years ago
Robert Sirchia
5ae91e11ae
Merge pull request #13034 from mattclegg/issue-9507
...
ISSUE-9507: ADD `application/gzip,application/octet-stream` accept header
2 years ago
George Jenkins
85499b2fdc
Merge pull request #13400 from wangjingcun/main
...
chore: fix some function names in comment
2 years ago
wangjingcun
de9e138ec1
chore: fix some function names in comment
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
2 years ago
Robert Sirchia
7e6b34d7dd
removing duplicate empty test
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Robert Sirchia
16a4e37f20
fixing unit test as per Matt
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Evans Mungai
bdaa93b969
Ensure test fails without causing panic
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 years ago
Evans Mungai
3c4d0bb061
Fix failing tests
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 years ago
Evans Mungai
323f88950a
Merge remote-tracking branch 'origin/main' into em/password-to-oci-registries
2 years ago
Robert Sirchia
a205af755e
adding more unit test
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Robert Sirchia
999b85145a
adding test coverage for ready.go
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Matt Farina
8f59c8e807
Merge pull request #9713 from andreaskaris/issue9710
...
fix(helm): Retry Conflict error for createResource, deleteResource
2 years ago
Andreas Karis
79a1f2c801
fix(helm): Retry Conflict error for createResource, deleteResource
...
kubernetes might at any time throw 409 Conflict Error codes. Clients
are supposed to retry when this happens. As an example, see
kubernetes/issues/67761 where such an issues might happen when the
cluster manipulates a projects's ResourceQuotas.
Catch such Conflict Errors on createResource and deleteResource and
retry before giving up. Due to the more complex logic and focus on
kubernetes/issues/67761, this patch purposefully omits possibly
needed changes to updateResource and instead defers them to another
patch if required in the future.
Closes issue #9710
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
2 years ago
Jon Olsson
ca584648ee
minor spelling fix
...
Signed-off-by: Jon Olsson <jon.olsson@sequitor.se>
2 years ago
Matt Farina
54be5511e6
Merge pull request #12788 from vtrenton/main
...
changed Itoa to Sprintf to allow int64 value preventing 2038 overflow
2 years ago
Luis Davim
ab3c589809
chore: Make retryingRoundTripper type public
...
Make retryingRoundTripper type public to allow being used in other
projects
fixes : #13052
Signed-off-by: Luis Davim <luis.davim@gmail.com>
2 years ago
Trent V.
f9183a522a
Merge branch 'helm:main' into main
2 years ago
Trent V
4ede1c9c37
Merge branch 'helm:main' into main
2 years ago
George Jenkins
f5fcae8356
verbs
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
02ef83fe28
fix: Use chart archive modifed time for OCI push
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Matt Farina
145d12f82f
Merge pull request #13177 from bb-Ricardo/main
...
Improves handling of Helm index with broken helm chart versions #13176
2 years ago
ricardo.bartels@telekom.de
cdbef2b7d1
Revering change unrelated to issue #13176
...
Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de>
2 years ago
Matt Farina
2da76a06e7
Merge pull request #13345 from AdamKorcz/fuzzzzz2
...
add chart fuzz tests
2 years ago
Matt Farina
7ad309791c
Merge pull request #13344 from AdamKorcz/fuzzzz1
...
add strvals fuzzer from cncf-fuzzing
2 years ago
Matt Farina
eecb848dcb
Merge pull request #13301 from NathanBaulch/typos
...
Fix typos
2 years ago
Matt Farina
d45439f2e9
Merge pull request #11923 from Bhargav-InfraCloud/helm-create-deprication-tests
...
test(create): Add test to check deprecated `apiVersion`s in resource templates created by `helm create`
2 years ago
Adam Korczynski
b203cc17c8
add strvals fuzzer from cncf-fuzzing
...
Signed-off-by: Adam Korczynski <adam@adalogics.com>
2 years ago
Adam Korczynski
e432f39ea7
add chart fuzz tests
...
Signed-off-by: Adam Korczynski <adam@adalogics.com>
2 years ago
Nathan Baulch
ef85fa7f2d
Grammar fixes
...
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
2 years ago
Nathan Baulch
ff9dd262e3
Fix typos
...
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
2 years ago
Matt Farina
b7c29d776f
Merge pull request #13329 from chenrui333/fix-test-chart
...
fix: fix testchart lint errors
2 years ago
Rui Chen
ddead08eb8
fix: fix testchart lint errors
...
Signed-off-by: Rui Chen <rui@chenrui.dev>
2 years ago
Fred Heinecke
30ce031d77
Merge branch 'main' into feat/add-toyamlpretty-1
2 years ago
Joe Julian
ff4877e696
Merge pull request #13224 from sttts/sttts-fix-apiext-registration
...
kube/client: add to global client-go scheme in init func
2 years ago
Joe Julian
1c73ea44ad
Merge remote-tracking branch 'upstream/main' into feat/toml-parsing
...
Signed-off-by: Joe Julian <me@joejulian.name>
2 years ago
Matt Farina
c81bd8912e
Revert "Improve helm dependency update performance"
...
The change in #11726 caused a regression where `helm dependency udpate`
stopped working. The format of the internal representation of the data
changed causing errors of "non-absolute URLs should be in form of
repo_name/path_to_chart". See #13324 for more details.
Since this change is in released Helm and it's a regression, reverting
the original change was the fastest and safest route to deliver a
fix as quickly as possible.
Closes #13324
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Matt Farina
d644da6205
bump version to v3.16.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 0d439e1a09 )
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Matt Farina
36ae5168bd
Merge pull request #13256 from robertsirc/issue-13229
...
Updating the inline documentation.
2 years ago
Andrew Block
a6f5844fb4
Merge pull request #13231 from dnskr/helm-create-drop-old-kubernetes-support
...
ref(create): drop old Kubernetes versions support in Ingress template
2 years ago
Joe Julian
333754479b
Merge pull request #11726 from Nordix/fixDepUpPerformance
...
Improve helm dependency update performance
2 years ago
Robert Sirchia
b92cc927d1
fixing changes as per requested.
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Robert Sirchia
b98952fb01
Merge branch 'helm:main' into issue-13229
2 years ago
Matt Farina
109dbe7c18
Merge pull request #13172 from maorfr/repository-cache-help-fix
...
fix repository-cache flag help description from file to directory
2 years ago
Robert Sirchia
e72978edcf
Updating the inline documentation.
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Scott Rigby
8a26add23f
Fix linting error for pr 12876
...
golangci-lint passed when last commit was made on #12876 , but has since failed.
This is probably because the linter has since updated.
I ran locally with the same version of golangci-lint we run in GH Actions, and
this is the only error now (an additional linting error in
pkg/action/package.go since #12876 has already been fixed.
```sh
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.58.1
./bin/golangci-lint run pkg/action/...
./bin/golangci-lint run ./...
```
we should be good now.
Signed-off-by: Scott Rigby <scott@r6by.com>
2 years ago
Matt Farina
c261d0655c
Merge pull request #12876 from manno/sdk-ignore-missing-annotations
...
Allow install, update action to adopt existing resources (sdk only)
2 years ago
Scott Rigby
f0442777bb
Merge pull request #12743 from anessi/feat/skip-schema-validation
...
feat(helm): add --skip-schema-validation flag to helm 'install', 'uprade' and 'lint'
2 years ago
dnskr
f9ba3c568b
ref(create): drop old Kubernetes versions support in Ingress template
...
Signed-off-by: Denis Krivenko <dnskrv88@gmail.com>
Signed-off-by: dnskr <dnskrv88@gmail.com>
2 years ago
Evans Mungai
0687961da4
Revert CAFile rename breaking change
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 years ago
MichaelMorris
9e5f465499
Merge branch 'helm:main' into fixDepUpPerformance
...
Signed-off-by: MichaelMorris <michael.morris@est.tech>
2 years ago
Dr. Stefan Schimanski
b9bdeca93b
kube/client: add to global client-go scheme in init func
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2 years ago
ricardo.bartels@telekom.de
af13b0d8dc
adds tests for handling of Helm index with broken chart versions #13176
...
Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de>
2 years ago
ricardo.bartels@telekom.de
154b477554
improves handling of Helm index with broken helm chart versions #13176
...
Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de>
2 years ago
Maor Friedman
84cbb2c59b
fix repository-cache flag help description from file to directory
...
Signed-off-by: Maor Friedman <mafriedm@redhat.com>
2 years ago
Joe Julian
4278ada158
Merge pull request #13085 from alex-kattathra-johnson/issue-12961
...
Fix race condition in TestInstallRelease_Wait_Interrupted test
2 years ago
Joe Julian
15e36139c1
Merge pull request #13130 from idsulik/issue-13127
...
fix: update error handling in Configuration.Init method, add tests for the method
2 years ago