Matt Farina
f895948ae2
Fixing issue with non-existant .Template when using tpl function
...
This is a regression accidently introduced in #9957 .
A delete call had been used on the Template key of vals. This caused
a condition where Template was not available when rendering via tpl.
The delete happened after ExecuteTemplate so the issue is surpsising.
It may possibly be a race condition. Existing tests did not catch it.
I tried to create a test that directly tested the issue and was
unable to replicate the error seen with real charts. This leads me
to believe it is a race condition in the underlying Go template
package.
The delete call was not there before #9957 . It should be safe to
remove and keep that information.
Closes #10082
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Matt Farina
ac80a5eec9
Merge branch 'main' into feat/subcharts-scope
3 years ago
Matt Farina
2de6f9d424
Merge pull request #9993 from Ka0o0/make-isroot-available-to-template
...
Make Chart's IsRoot available to templates
3 years ago
Kai Takac
8fcaf7b85c
Add Chart IsRoot test
...
Signed-off-by: Kai Takac <kai.takac@gmail.com>
3 years ago
Kai Takac
06ae6f933a
Make Chart's IsRoot available to templates
...
Signed-off-by: Kai Takac <kai.takac@gmail.com>
3 years ago
Cory Snider
79df3926f6
fix(engine): parse fail messages with newlines
...
The templating engine handles errors originating from the `required` and
`fail` template functions specially, cleaning up the error messages to
be more presentable to users. Go's text/template package unfortunately
does not make this straightforward to implement. Despite
template.ExecError implementing Unwrap, the error value returned from
the template function cannot be retrieved using errors.As. The wrapped
error in ExecError is a pre-formatted error string with the template
function's error string interpolated in with the original error value
erased. Helm works around this limitation by delimiting the
template-supplied message and extracting the message out of the
ExecError string with a regex.
Fix the parsing of `required` and `fail` error messages containing
newlines by setting the regex flag to make `.` match newline characters.
Signed-off-by: Cory Snider <csnider@mirantis.com>
3 years ago
Valentin Flaux
3daaea0a1c
feat(pkg/engine): expose subcharts scope in parent
...
Expose the scope (.Values, .Charts, .Releases etc.) of subcharts to the parent scope.
Signed-off-by: Valentin Flaux <vflaux@oui.sncf>
3 years ago
Martin Hickey
dffc2a30c7
Merge pull request #9035 from wizbit/fail-message
...
Fail message is now the same as the required message.
3 years ago
Martin Hickey
699ea6dcef
Merge pull request #9066 from scaat/fix-specification
...
[FIX]Unified go specification
3 years ago
Josh Soref
2bf8fdf45d
chore: Spelling ( #9410 )
...
* spelling: annotate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: asserts
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: behavior
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: binary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: contain
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: copied
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dependency
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: depending
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: deprecated
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: doesn't
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: donot
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: github
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: inputting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: iteration
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: jabberwocky
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: kubernetes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: length
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mismatch
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multiple
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: nonexistent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: outputs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: panicking
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: plugins
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: parsing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: porthos
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: regular
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: resource
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repositories
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: something
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: strict
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: string
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unknown
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
3 years ago
Marcus Speight
7a663a56c2
Fixed Test
...
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
Signed-off-by: Marcus Speight <marcus@pmconnect.co.uk>
4 years ago
Marcus Speight
8aa42824f9
Added test for lint mode
...
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
4 years ago
Scaat Feng
1852694a65
[FIX]comment should start with whitespace
...
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
4 years ago
Marcus Speight
7a0739a863
Fail message is now the same as the required message.
...
Fixed #8973 Helm function 'fail' should not fail when doing 'helm lint'
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
4 years ago
Paul Brousseau
3192408415
Fixing typo in engine comments
...
Signed-off-by: Paul Brousseau <object88@gmail.com>
4 years ago
Matt Farina
dbd001e532
Removing tiller language
...
Since Tiller is no longer part of Helm v3, internal documentation
language about Tiller can be removed
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Butcher
bb47286f09
fix linting error with lookup function ( #7969 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Andre Sencioles
d0726e07ab
Parse reference templates in predictable order ( #7702 )
...
* Parse reference templates in predictable order
Fix issue #7701
Signed-off-by: Andre Sencioles <asenci@gmail.com>
* Add test case for issue #7701 regression
Signed-off-by: Andre Sencioles <asenci@gmail.com>
* gofmt
Signed-off-by: Andre Sencioles <asenci@gmail.com>
4 years ago
Matt Farina
3b8521c1f0
Updating sprig and semver to newer versions
...
Note, there is an issue with a dependency of sprig changing
behavior. A test has been added with a description to catch if a
behavior breaking change of mergo is used.
See https://github.com/imdario/mergo/issues/139 for the mergo
issue and sprig for further details on handling this in the
future.
Closes #7533
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Adam Reese
c2da4fd53d
ref(*): kubernetes v1.18 ( #7831 )
...
Upgrade Kubernetes libraries to v0.18.0
Add new lazy load KubernetesClientSet to avoid missing kubeconfig error
In kubernetes v1.18 kubeconfig validation was added. Minikube and Kind
both remove kubeconfig when stopping clusters. This causes and error
when running any helm commands because we initialize the client before
executing the command.
Signed-off-by: Adam Reese <adam@reese.io>
4 years ago
Tuan
97c68adc4d
Add fromYamlArray and fromJsonArray template helpers ( #7712 )
...
Signed-off-by: Tuan Nguyen <nmtuan.dev@gmail.com>
4 years ago
Daniel Cheng
206d4a9053
add test for template recursion
...
Signed-off-by: Daniel Cheng <dcheng@us.ibm.com>
5 years ago
Daniel Cheng
8528548441
fix recursion count in templates
...
Signed-off-by: Daniel Cheng <dcheng@us.ibm.com>
5 years ago
Jon Huhn
43e6285995
Fix engine.newFiles doc comment
...
Signed-off-by: Jon Huhn <huhnjon@gmail.com>
5 years ago
Matthew Fisher
1b1d6bba9c
fix(lookup_func): do not return error when object is not found
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
5 years ago
Matthew Fisher
9c680e604b
Merge pull request #7443 from zwwhdls/fix7439
...
allow limited recursion in templates
5 years ago
zwwhdls
16a85f7570
fix test-style
...
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
5 years ago
zwwhdls
4eda4fa06d
allow limited recursion in templates
...
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
5 years ago
Matthew Fisher
e84b61b2db
Merge pull request #6752 from raffaelespazzoli/lookup
...
Lookup template function
5 years ago
Josh Soref
02ad2b1187
Spelling ( #7258 )
...
* spelling: constraint
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: cryptographic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dependency
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: doesnot
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: don't
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unexpected
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dreadnought
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: default
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: envvars
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: evaluates
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: execute
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: extractor
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: frobnitz
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: generated
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: implementation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: jabba
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: keywords
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: kubernetes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: override
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: package
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: parsable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: progress
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: recursively
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: release
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: cache
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: representing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: serializer
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: subchart
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: utilities
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
5 years ago
raffaelespazzoli
fa643cfa31
fixed golint
...
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
5 years ago
raffaelespazzoli
a62ba04962
additional fixes based on @thomastaylor312 comment
...
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
5 years ago
raffaelespazzoli
0bb4eaace7
addressing some feedback from @thomastaylor312
...
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
5 years ago
raffaelespazzoli
e98cd621f0
added rest client passed with action configuration
...
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
5 years ago
raffaelespazzoli
b3495c7353
added license header
...
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
5 years ago
raffaelespazzoli
02ce01b241
fixed circle ci issues
...
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
5 years ago
raffaelespazzoli
30d245a0e3
added check on namespaced resource
...
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
5 years ago
raffaelespazzoli
d564d4bf2d
first lookup template function implementation
...
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
5 years ago
海的澜色
750b870aed
fix stack overflow error ( #7114 )
...
* fixed #7111
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
* update error message
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
* add test case
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
* fix lint error
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
5 years ago
KUOKA Yusuke
4c351c7248
fix(v3): fix type error while merging map loaded with `fromYaml` template func ( #6630 )
...
Fixes #6626
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
5 years ago
Matt Farina
9bc7934f35
Updating the module for v3 as the major version
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
Matt Farina
967f4fed42
Update dependencies
...
* Kubernetes updated to 1.16.1
* SemVer and Sprig updated to latest releases that leverage go
modules
* Tests and checks updated. These already landed in v2 via PR 6457
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
Adam Reese
4fcc876786
ref(pkg/engine): cleanup of development `hack`
...
This was left in from some of the chart builder work. I forgot to
remove it.
Signed-off-by: Adam Reese <adam@reese.io>
5 years ago
Martin Hickey
5906b9dfee
Fix style conformance issue
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
5 years ago
Ian Howell
c92e3351f7
Switch to a more unique delimiter for template execution errors
...
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
5 years ago
Ian Howell
31b940a61d
fix(engine): Fix eating too many colons during template execution
...
This fixes #6044 , in which error parsing is greedily eating too many
colons, preventing users from using colons in their warning messages to
the `required` function
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
5 years ago
Thomas O'Donnell
213f714604
Stop Lint from breaking when using required
...
Have updated the required filter so that it doesn't break when linting a
chart. This work is based off #4221 and #4748 which didn't make it into
the v3 branch.
Signed-off-by: Thomas O'Donnell <andy.tom@gmail.com>
5 years ago
Adam Reese
b49db9e6e6
ref(pkg/chartutil): break up chartutil into logical files
...
Signed-off-by: Adam Reese <adam@reese.io>
5 years ago
Matthew Fisher
757eb88d6c
Merge pull request #5441 from hickeyma/update-lib-charts
...
feat(*): Add capability for application charts to be used as library charts
5 years ago
Josh Dolitsky
a12a396aab
Helm 3: registry login/logout ( #5597 )
...
* login/logout placeholders
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* use latest oras
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* use docker auth system
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* working login+push
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* working on tests
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* fix typo in htpasswd
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* rename credsfile to config.json
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* add flags for username/password
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* disable logout test broken on linux
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* upgrade to oras 0.4.0
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* re-enable logout test
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* panic for uncaught errors
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
* move login/logout to new registry subcommand
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
5 years ago